QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 00:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(frontend): comprehensive TypeScript quality improvements (#37625)

Browse Source 
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Evan Rusackas
2026-02-06 16:16:57 -05:00
committed by GitHub
parent e9ae212c1c
commit fc5506e466
441 changed files with 14136 additions and 9956 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
superset-frontend/plugins/plugin-chart-pivot-table/src/PivotTableChart.tsx
View File

@@ -16,7 +16,11 @@
* specific language governing permissions and limitations
* under the License.
*/
import { useCallback, useMemo } from 'react';
import {
useCallback,
useMemo,
type MouseEvent as ReactMouseEvent,
} from 'react';
import { MinusSquareOutlined, PlusSquareOutlined } from '@ant-design/icons';
import { t } from '@apache-superset/core';
import {
@@ -501,7 +505,7 @@ export default function PivotTableChart(props: PivotTableProps) {
const toggleFilter = useCallback(
(
e: MouseEvent,
e: ReactMouseEvent,
value: string,
filters: FilterType,
pivotData: Record<string, any>,
@@ -598,10 +602,10 @@ export default function PivotTableChart(props: PivotTableProps) {
const handleContextMenu = useCallback(
(
e: MouseEvent,
colKey: (string | number | boolean)[] | undefined,
rowKey: (string | number | boolean)[] | undefined,
dataPoint: { [key: string]: string },
e: ReactMouseEvent,
colKey?: string[],
rowKey?: string[],
dataPoint?: { [key: string]: string },
) => {
if (onContextMenu) {
e.preventDefault();
@@ -611,7 +615,7 @@ export default function PivotTableChart(props: PivotTableProps) {
colKey.forEach((val, i) => {
const col = cols[i];
const formatter = dateFormatters[col];
const formattedVal = formatter?.(val as number) || String(val);
const formattedVal = formatter?.(Number(val)) || String(val);
if (i > 0) {
drillToDetailFilters.push({
col,
@@ -627,7 +631,7 @@ export default function PivotTableChart(props: PivotTableProps) {
rowKey.forEach((val, i) => {
const col = rows[i];
const formatter = dateFormatters[col];
const formattedVal = formatter?.(val as number) || String(val);
const formattedVal = formatter?.(Number(val)) || String(val);
drillToDetailFilters.push({
col,
op: '==',
@@ -639,7 +643,9 @@ export default function PivotTableChart(props: PivotTableProps) {
}
onContextMenu(e.clientX, e.clientY, {
drillToDetail: drillToDetailFilters,
crossFilter: getCrossFilterDataMask(dataPoint),
crossFilter: dataPoint
? getCrossFilterDataMask(dataPoint)
: undefined,
drillBy: dataPoint && {
filters: [
{