From fc73474d53dac92a4fe46b794ca94ca0c619e99b Mon Sep 17 00:00:00 2001
From: Evan Rusackas <evan@rusackas.com>
Date: Mon, 23 Feb 2026 10:51:10 -0800
Subject: [PATCH] fix(ci): fix ruff E501 and requirements ordering for pyodps

Split long log message string in db_engine_specs/__init__.py to stay
within the 88-character line limit. Move pyodps==0.12.2 to its proper
alphabetical position in requirements/base.txt and remove the manually
appended entry from the end of both requirements files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 requirements/base.txt                | 8 ++++++--
 requirements/development.txt         | 1 -
 superset/db_engine_specs/__init__.py | 3 ++-
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/requirements/base.txt b/requirements/base.txt
index fe38a393d39..5deb2f9a74a 100644
--- a/requirements/base.txt
+++ b/requirements/base.txt
@@ -292,7 +292,9 @@ prison==0.2.1
 prompt-toolkit==3.0.51
     # via click-repl
 pyarrow==16.1.0
-    # via apache-superset (pyproject.toml)
+    # via
+    #   apache-superset (pyproject.toml)
+    #   pyodps
 pyasn1==0.6.2
     # via
     #   pyasn1-modules
@@ -319,6 +321,8 @@ pyjwt==2.10.1
     #   redis
 pynacl==1.6.2
     # via paramiko
+pyodps==0.12.2
+    # via -r requirements/base.in
 pyopenssl==25.3.0
     # via shillelagh
 pyparsing==3.2.3
@@ -355,6 +359,7 @@ referencing==0.36.2
     #   jsonschema-specifications
 requests==2.32.4
     # via
+    #   pyodps
     #   requests-cache
     #   shillelagh
 requests-cache==1.2.1
@@ -485,4 +490,3 @@ xlsxwriter==3.0.9
     #   pandas
 zstandard==0.23.0
     # via flask-compress
-pyodps==0.12.2
diff --git a/requirements/development.txt b/requirements/development.txt
index 7005eabf7f1..e0a2b801182 100644
--- a/requirements/development.txt
+++ b/requirements/development.txt
@@ -1157,4 +1157,3 @@ zstandard==0.23.0
     # via
     #   -c requirements/base-constraint.txt
     #   flask-compress
-pyodps==0.12.2
diff --git a/superset/db_engine_specs/__init__.py b/superset/db_engine_specs/__init__.py
index 6c8ac54d3cd..ca72453f488 100644
--- a/superset/db_engine_specs/__init__.py
+++ b/superset/db_engine_specs/__init__.py
@@ -84,7 +84,8 @@ def load_engine_specs() -> list[type[BaseEngineSpec]]:
         # Validate that the engine spec is a proper subclass of BaseEngineSpec
         if not is_engine_spec(engine_spec):
             logger.warning(
-                "Skipping invalid DB engine spec %s: not a valid BaseEngineSpec subclass",
+                "Skipping invalid DB engine spec %s: "
+                "not a valid BaseEngineSpec subclass",
                 ep.name,
             )
             continue