Eslint error cleanup (#10657)

* moving two console errors to logger errors

* nixing unused map index

* nixing unused param

* linting

* changing an alert to a toast

* fixing tests

* lint fix

* one letter change, just to see if iti gets CI to pass this test.

superset-frontend/src/components/Button/index.tsx

@@ -114,14 +114,12 @@ export default function Button(props: ButtonProps) {
           {props.children}
         </SupersetButton>
         <ul className="dropdown-menu">
-          {dropdownItems.map(
-            (dropdownItem: DropdownItemProps, index1: number) => (
-              <MenuItem key={`${dropdownItem.label}`} href={dropdownItem.url}>
-                <i className={`fa ${dropdownItem.icon}`} />
-                &nbsp; {dropdownItem.label}
-              </MenuItem>
-            ),
-          )}
+          {dropdownItems.map((dropdownItem: DropdownItemProps) => (
+            <MenuItem key={`${dropdownItem.label}`} href={dropdownItem.url}>
+              <i className={`fa ${dropdownItem.icon}`} />
+              &nbsp; {dropdownItem.label}
+            </MenuItem>
+          ))}
         </ul>
       </div>
     );