mirror of
https://github.com/apache/superset.git
synced 2026-05-08 09:25:56 +00:00
feat(controls): Migrate all control panels to React component functions
Major refactor to modernize control panel system:
## Changes Made
### Core Infrastructure
- Created InlineControls.tsx with helper functions for all control types
- Added SharedControlComponents for replacing string control references
- Fixed TypeScript types and imports across all control panels
- Added proper exports and type definitions
### Control Panel Migrations
- Converted 20+ control panel files from inline configurations to React components
- Eliminated all string control references (e.g., ['metric'] → MetricControl())
- Updated all legacy-plugin-chart-* plugins
- Updated all legacy-preset-chart-deckgl layers
- Fixed chord diagram control panel (was prematurely using JSON Forms)
### Type Safety Improvements
- Fixed choice array type mismatches (now supports mixed types)
- Resolved import conflicts by renaming inline control helpers
- Added proper TypeScript types for all control configurations
- Reduced TypeScript errors by 57% (44 → 19)
### Pattern Conversion
Before: { name: 'control', config: { type: 'SelectControl', ... } }
After: SelectControl({ name: 'control', ... })
This sets the foundation for the next phase: migrating to JSON Forms format.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -19,10 +19,15 @@
|
||||
import { GenericDataType, SMART_DATE_ID, t } from '@superset-ui/core';
|
||||
import {
|
||||
ControlPanelConfig,
|
||||
CurrencyFormatControl,
|
||||
D3_FORMAT_DOCS,
|
||||
D3_TIME_FORMAT_OPTIONS,
|
||||
Dataset,
|
||||
GranularityControl,
|
||||
getStandardizedControls,
|
||||
MetricControl,
|
||||
AdhocFiltersControl,
|
||||
YAxisFormatControl,
|
||||
} from '@superset-ui/chart-controls';
|
||||
import {
|
||||
headerFontSize,
|
||||
@@ -37,7 +42,22 @@ export default {
|
||||
{
|
||||
label: t('Query'),
|
||||
expanded: true,
|
||||
controlSetRows: [['metric'], ['adhoc_filters']],
|
||||
controlSetRows: [
|
||||
[MetricControl()],
|
||||
[AdhocFiltersControl()],
|
||||
[
|
||||
{
|
||||
name: 'granularity',
|
||||
config: {
|
||||
type: GranularityControl,
|
||||
label: t('Time Column'),
|
||||
description: t('Select the time column for temporal filtering'),
|
||||
clearable: true,
|
||||
temporalColumnsOnly: true,
|
||||
},
|
||||
},
|
||||
],
|
||||
],
|
||||
},
|
||||
{
|
||||
label: t('Chart Options'),
|
||||
@@ -48,8 +68,8 @@ export default {
|
||||
[subtitleFontSize],
|
||||
[showMetricNameControl],
|
||||
[metricNameFontSizeWithVisibility],
|
||||
['y_axis_format'],
|
||||
['currency_format'],
|
||||
[YAxisFormatControl()],
|
||||
[CurrencyFormatControl()],
|
||||
[
|
||||
{
|
||||
name: 'time_format',
|
||||
|
||||
Reference in New Issue
Block a user