mirror of
https://github.com/apache/superset.git
synced 2026-04-19 08:04:53 +00:00
feat(mcp): Add support for AG Grid Interactive Table (ag-grid-table) viz_type (#37191)
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -54,6 +54,59 @@ class TestTableChartConfig:
|
||||
)
|
||||
assert len(config.columns) == 2
|
||||
|
||||
def test_default_viz_type_is_table(self) -> None:
|
||||
"""Test that default viz_type is 'table'."""
|
||||
config = TableChartConfig(
|
||||
chart_type="table",
|
||||
columns=[ColumnRef(name="product")],
|
||||
)
|
||||
assert config.viz_type == "table"
|
||||
|
||||
def test_ag_grid_table_viz_type_accepted(self) -> None:
|
||||
"""Test that viz_type='ag-grid-table' is accepted for AG Grid table."""
|
||||
config = TableChartConfig(
|
||||
chart_type="table",
|
||||
viz_type="ag-grid-table",
|
||||
columns=[
|
||||
ColumnRef(name="product_line"),
|
||||
ColumnRef(name="sales", aggregate="SUM", label="Total Sales"),
|
||||
],
|
||||
)
|
||||
assert config.viz_type == "ag-grid-table"
|
||||
assert len(config.columns) == 2
|
||||
|
||||
def test_ag_grid_table_with_all_options(self) -> None:
|
||||
"""Test AG Grid table with filters and sorting."""
|
||||
from superset.mcp_service.chart.schemas import FilterConfig
|
||||
|
||||
config = TableChartConfig(
|
||||
chart_type="table",
|
||||
viz_type="ag-grid-table",
|
||||
columns=[
|
||||
ColumnRef(name="product_line"),
|
||||
ColumnRef(name="quantity", aggregate="SUM", label="Total Quantity"),
|
||||
ColumnRef(name="sales", aggregate="SUM", label="Total Sales"),
|
||||
],
|
||||
filters=[FilterConfig(column="status", op="=", value="active")],
|
||||
sort_by=["product_line"],
|
||||
)
|
||||
assert config.viz_type == "ag-grid-table"
|
||||
assert len(config.columns) == 3
|
||||
assert config.filters is not None
|
||||
assert len(config.filters) == 1
|
||||
assert config.sort_by == ["product_line"]
|
||||
|
||||
def test_invalid_viz_type_rejected(self) -> None:
|
||||
"""Test that invalid viz_type values are rejected."""
|
||||
from pydantic import ValidationError
|
||||
|
||||
with pytest.raises(ValidationError):
|
||||
TableChartConfig(
|
||||
chart_type="table",
|
||||
viz_type="invalid-type",
|
||||
columns=[ColumnRef(name="product")],
|
||||
)
|
||||
|
||||
|
||||
class TestXYChartConfig:
|
||||
"""Test XYChartConfig validation."""
|
||||
|
||||
@@ -152,6 +152,58 @@ class TestMapTableConfig:
|
||||
result = map_table_config(config)
|
||||
assert result["order_by_cols"] == ["product", "revenue"]
|
||||
|
||||
def test_map_table_config_ag_grid_table(self) -> None:
|
||||
"""Test table config mapping with AG Grid Interactive Table viz_type"""
|
||||
config = TableChartConfig(
|
||||
chart_type="table",
|
||||
viz_type="ag-grid-table",
|
||||
columns=[
|
||||
ColumnRef(name="product_line"),
|
||||
ColumnRef(name="sales", aggregate="SUM", label="Total Sales"),
|
||||
],
|
||||
)
|
||||
|
||||
result = map_table_config(config)
|
||||
|
||||
# AG Grid tables use 'ag-grid-table' viz_type
|
||||
assert result["viz_type"] == "ag-grid-table"
|
||||
assert result["query_mode"] == "aggregate"
|
||||
assert len(result["metrics"]) == 1
|
||||
assert result["metrics"][0]["aggregate"] == "SUM"
|
||||
# Non-aggregated columns should be in groupby
|
||||
assert "groupby" in result
|
||||
assert "product_line" in result["groupby"]
|
||||
|
||||
def test_map_table_config_ag_grid_raw_mode(self) -> None:
|
||||
"""Test AG Grid table with raw columns (no aggregates)"""
|
||||
config = TableChartConfig(
|
||||
chart_type="table",
|
||||
viz_type="ag-grid-table",
|
||||
columns=[
|
||||
ColumnRef(name="product_line"),
|
||||
ColumnRef(name="category"),
|
||||
ColumnRef(name="region"),
|
||||
],
|
||||
)
|
||||
|
||||
result = map_table_config(config)
|
||||
|
||||
assert result["viz_type"] == "ag-grid-table"
|
||||
assert result["query_mode"] == "raw"
|
||||
assert result["all_columns"] == ["product_line", "category", "region"]
|
||||
assert "metrics" not in result
|
||||
|
||||
def test_map_table_config_default_viz_type(self) -> None:
|
||||
"""Test that default viz_type is 'table' not 'ag-grid-table'"""
|
||||
config = TableChartConfig(
|
||||
chart_type="table",
|
||||
columns=[ColumnRef(name="product")],
|
||||
)
|
||||
|
||||
result = map_table_config(config)
|
||||
|
||||
assert result["viz_type"] == "table"
|
||||
|
||||
|
||||
class TestMapXYConfig:
|
||||
"""Test map_xy_config function"""
|
||||
|
||||
Reference in New Issue
Block a user