QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-07-18 20:55:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sqllab): reflect query history deletion without page refresh (#41019)

Browse Source 
Co-authored-by: Evan Rusackas <evan@rusackas.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Jean Massucatto
2026-07-07 13:40:33 -03:00
committed by GitHub
parent 5f27f88e73
commit fe7d9b4724
3 changed files with 104 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
superset-frontend/src/SqlLab/actions/sqlLab.ts
View File

@@ -48,6 +48,8 @@ import getInitialState from '../reducers/getInitialState';
import { rehydratePersistedState } from '../utils/reduxStateToLocalStorageHelper';
import { PREVIEW_QUERY_LIMIT } from '../constants';
import { EMPTY_STATE_QE_ID } from '../hooks/useQueryEditor';
import { queryHistoryApi } from '../../hooks/apiResources/queries';
import type { AppDispatch as RootDispatch } from '../../views/store';
// Type definitions for SqlLab actions
export interface Query {
@@ -985,7 +987,7 @@ export function removeAllOtherQueryEditors(
}
export function removeQuery(query: Query): SqlLabThunkAction<Promise<unknown>> {
return function (dispatch: AppDispatch) {
return function (dispatch: RootDispatch) {
const queryEditorId = query.sqlEditorId ?? query.id;
const sync = isFeatureEnabled(FeatureFlag.SqllabBackendPersistence)
? SupersetClient.delete({
@@ -996,7 +998,26 @@ export function removeQuery(query: Query): SqlLabThunkAction<Promise<unknown>> {
: Promise.resolve();
return sync
.then(() => dispatch({ type: REMOVE_QUERY, query }))
.then(() => {
dispatch({ type: REMOVE_QUERY, query });
dispatch(
queryHistoryApi.util.updateQueryData(
'editorQueries',
{ editorId: queryEditorId },
draft => {
// The infinite-scroll merge can leave duplicate entries for the
// same id (offset shifts between page fetches), so drop them all.
const remaining = draft.result.filter(
({ id }) => id !== query.id,
);
if (remaining.length !== draft.result.length) {
draft.result = remaining;
draft.count = Math.max(0, draft.count - 1);
}
},
),
);
})
.catch(() =>
dispatch(
addDangerToast(