QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 00:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(sqllab): Add timeout on fetching query results (#29959)

Browse Source
This commit is contained in:
JUST.in DO IT
2024-09-12 09:41:28 -07:00
committed by GitHub
parent 23467bd7e4
commit ff3b86b5ff
7 changed files with 70 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
superset-frontend/src/SqlLab/actions/sqlLab.js
View File

@@ -294,21 +294,25 @@ export function requestQueryResults(query) {
return { type: REQUEST_QUERY_RESULTS, query };
}
export function fetchQueryResults(query, displayLimit) {
return function (dispatch) {
export function fetchQueryResults(query, displayLimit, timeoutInMs) {
return function (dispatch, getState) {
const { SQLLAB_QUERY_RESULT_TIMEOUT } = getState().common?.conf ?? {};
dispatch(requestQueryResults(query));
const queryParams = rison.encode({
key: query.resultsKey,
rows: displayLimit || null,
});
const timeout = timeoutInMs ?? SQLLAB_QUERY_RESULT_TIMEOUT;
const controller = new AbortController();
return SupersetClient.get({
endpoint: `/api/v1/sqllab/results/?q=${queryParams}`,
parseMethod: 'json-bigint',
...(timeout && { timeout, signal: controller.signal }),
})
.then(({ json }) => dispatch(querySuccess(query, json)))
.catch(response =>
.catch(response => {
controller.abort();
getClientErrorObject(response).then(error => {
const message =
error.error ||
@@ -318,8 +322,8 @@ export function fetchQueryResults(query, displayLimit) {
return dispatch(
queryFailed(query, message, error.link, error.errors),
);
}),
);
});
});
};
}