QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

[chart] fix, bulk delete endpoint and error message (#9330)

Browse Source
This commit is contained in:
ʈᵃᵢ
2020-03-19 11:26:55 -07:00
committed by GitHub
parent 46598830e9
commit ff703cf01b
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
superset-frontend/src/views/chartList/ChartList.tsx
View File

@@ -280,11 +280,9 @@ class ChartList extends React.PureComponent<Props, State> {
); );
}; };
handleBulkDashboardDelete = (charts: Chart[]) => { handleBulkChartDelete = (charts: Chart[]) => {
SupersetClient.delete({ SupersetClient.delete({
endpoint: `/api/v1/dashboard/?q=!(${charts endpoint: `/api/v1/chart/?q=!(${charts.map(({ id }) => id).join(',')})`,
.map(({ id }) => id)
.join(',')})`,
}).then( }).then(
({ json = {} }) => { ({ json = {} }) => {
const { lastFetchDataConfig } = this.state; const { lastFetchDataConfig } = this.state;
@@ -296,7 +294,7 @@ class ChartList extends React.PureComponent<Props, State> {
(err: any) => { (err: any) => {
console.error(err); console.error(err);
this.props.addDangerToast( this.props.addDangerToast(
t('There was an issue deleting the selected dashboards'), t('There was an issue deleting the selected charts'),
); );
}, },
); );
@@ -408,7 +406,7 @@ class ChartList extends React.PureComponent<Props, State> {
description={t( description={t(
'Are you sure you want to delete the selected charts?', 'Are you sure you want to delete the selected charts?',
)} )}
onConfirm={this.handleBulkDashboardDelete} onConfirm={this.handleBulkChartDelete}
> >
{confirmDelete => { {confirmDelete => {
const bulkActions = []; const bulkActions = [];