Beto Dealmeida
1c0b141e2d
feat: allow assets to be managed externally ( #18093 )
...
* feat: allow assets to be managed externally
* Use server_default
2022-01-24 11:03:01 -08:00
Geido
83e49fc9ee
feat: Certify Charts and Dashboards ( #17335 )
...
* Certify charts
* Format
* Certify dashboards
* Format
* Refactor card certification
* Clear details when certified by empty
* Show certification in detail page
* Add RTL tests
* Test charts api
* Enhance integration tests
* Lint
* Fix dashboards count
* Format
* Handle empty value
* Handle empty slice
* Downgrade migration
* Indent
* Use alter
* Fix revision
* Fix revision
2021-11-24 13:42:52 +02:00
ofekisr
8a6ecd3b97
refactor(QueryContext): add QueryContextFactory ( #17495 )
2021-11-21 14:35:46 +02:00
Kamil Gabryjelski
fa51b3234e
fix(dashboard): Return columns and verbose_map for groupby values of Pivot Table v2 [ID-7] ( #17287 )
...
* fix(dashboard): Return columns and verbose_map for groupby values of Pivot Table v2
* Refactor
* Fix test and lint
* Fix test
* Refactor
* Fix lint
2021-11-05 16:05:48 +01:00
John Bodley
fb4650a6eb
chore(pylint): Remove top-level disable ( #16589 )
...
* chore(pylint): Remove top-level disable
* Update examples.py
* Update command.py
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-09-15 09:30:23 -07:00
Yongjie Zhao
ad60c0c4ad
fix: remove useless-suppression for pylint ( #16696 )
2021-09-14 13:27:21 +08:00
AAfghahi
c66f278b42
feat: Backend Validation for Creation Method ( #16375 )
...
* backend creation method validation
* added tests
* Update superset/reports/dao.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset/reports/dao.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update tests/integration_tests/reports/api_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update tests/integration_tests/reports/api_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset/reports/dao.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset/reports/dao.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset/reports/commands/create.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset/reports/commands/exceptions.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* revisions
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
2021-09-08 16:35:18 -07:00
Beto Dealmeida
359383b578
feat: Add Aurora Data API engine spec ( #16535 )
...
* feat: Add Aurora Data API engine spec
* Fix lint
2021-09-04 08:40:14 -07:00
Beto Dealmeida
62d8ab7f9c
fix: create example DB if needed ( #16451 )
...
* fix: create example DB if needed
* fix lint
2021-08-27 07:19:37 -07:00
Ville Brofeldt
18be181946
fix(explore): update overwrite button on perm change ( #16437 )
...
* fix(explore): update overwrite on perm change
* remove redundant user_id prop
* fix types
* fix user type
* fix tests
* fix lint
2021-08-26 06:24:33 +03:00
John Bodley
bc4b6f0a6c
fix(pylint): Fix master ( #16405 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-08-24 05:20:52 +12:00
Phillip Kelley-Dotson
f0e3b68cc2
fix: ensure that users viewing chart does not automatically save edit data ( #16077 )
...
* add last_change_at migration
* add last_saved_by db migration
* finish rest of api migration
* run precommit
* fix name
* run precommitt
* remove unused mods
* merge migrations
* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset/migrations/versions/f6196627326f_update_chart_permissions.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* fix test
* precommit
* remove print
* fix test
* change test
* test commit
* test 2
* test 3
* third time the charm
* fix put req
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
2021-08-10 10:29:49 -06:00
John Bodley
c0615c55df
fix: Ensure table uniqueness on update ( #15909 )
...
* fix: Ensure table uniqueness on update
* Update models.py
* Update slice.py
* Update datasource_tests.py
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-08-03 07:45:55 +12:00
Beto Dealmeida
2d61f15153
feat: send post-processed data in reports ( #15953 )
...
* feat: send post-processed data in reports
* Fix tests and lint
* Use enums
* Limit Slack message to 4k chars
2021-07-30 09:37:16 -07:00
Beto Dealmeida
2ce676d20d
feat: call screenshot to store query_context ( #15846 )
...
* feat: call screenshot to store query_context
* Add unit test
* Move updateQueryContext to ExploreChartPanel
* Add error handling
* Fix code
* Fix logic
2021-07-27 14:02:27 -07:00
Beto Dealmeida
9a79a5775b
feat: store query context when saving charts ( #15824 )
...
* WIP
* Add migration
* Fix tests
2021-07-21 13:54:39 -07:00
John Bodley
ab4e3b9bf9
chore: Enforce Mypy for non-tests ( #15757 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-07-22 06:46:43 +12:00
Amit Miran
62a8f2e193
chore(python-testing): move memoized tests to unit tests ( #15507 )
...
* chore: move memoized test into a separated file
create integration test workflow
* chore: create unit test workflow to run purely pytest
* fix: bad reference
* fix: remove pip requirements bc there aren't any yet
* temp: install unit dependencies directly
* fix: --rootdir=
* fix: try to run only unit test
* chore: decouple memoized as separated module
* fix: bring back dependencies bc superset top-level module is coupled to flask and others so no reason no to do it
* fix: reference
* fix: pre-commit
* fix: pylint
2021-07-12 10:00:18 +03:00
Erik Ritter
a816655715
fix: dashboard datasources filter None ( #14471 )
2021-05-04 15:34:38 -07:00
Sam Faber-Manning
11260b3117
chore: add stack trace to all calls of logger.error ( #14382 )
2021-04-30 09:22:05 -07:00
Ben Reinhart
2a1235c0c2
fix: Cleanup serialization and hashing code ( #14317 )
2021-04-26 14:04:40 -07:00
Ville Brofeldt
2f6d1ff4cd
chore: remove SIP-38 feature flag ( #12894 )
2021-02-03 09:41:44 +02:00
Jesse Yang
55c8f9ba60
feat(explore): allow opening charts with missing dataset ( #12705 )
2021-01-25 15:09:03 -08:00
Beto Dealmeida
2f4f87795d
feat: add a command to import charts ( #11743 )
...
* ImportChartsCommand
* Fix type
2020-11-20 14:20:13 -08:00
Daniel Vaz Gaspar
12cb27f5cb
feat: new reports models api ( #11606 )
...
* feat: new report schedule models
* lint and unique constraint
* support sqlite
* fix sqlite
* add audit mixin and minor fixes
* feat(api): alerts and reports REST API
* feat: new report schedule models
* lint and unique constraint
* support sqlite
* fix sqlite
* add audit mixin and minor fixes
* feat(api): alerts and reports REST API
* draft working version
* add tests
* test
* black
* remove copy pasta
* solve dashboard object representation being used on cache
* tests and custom filter
* fix PUT has PATCH on active field
* create feature flag
* fix lint
* address comments
2020-11-12 13:21:01 -08:00
Beto Dealmeida
4a070cfceb
chore: consolidate dashboard import logic ( #11529 )
...
* Consolidate dash import logic
* Fix lint
* Remove Slice.import_obj
* Remove unused import
* Fix log
2020-11-11 14:50:18 -08:00
Beto Dealmeida
f2b8d6aef8
chore: rename ImportMixin to ImportExportMixin ( #11460 )
...
* Add UUID to saved_query
* Reuse function from previous migration
* Point to new head
* feat: add backend to export saved queries using new format
* Rename ImportMixin to ImportExportMixin
2020-10-30 09:11:56 -07:00
ʈᵃᵢ
233e67a854
fix: add schema name to datasource field in chart list ( #11278 )
2020-10-15 14:12:21 -07:00
Beto Dealmeida
9785667a0d
feat: add UUID column to ImportMixin ( #11098 )
...
* Add UUID column to ImportMixin
* Fix default value
* Fix lint
* Fix order of downgrade
* Add logging when downgrade fails
* Migrate position_json to contain UUIDs, and add schedule tables
* Save UUID when adding charts to dashboard
* Fix heads
* Rename migration file
* Fix dashboard serialization
* Fix migration script with Postgres
* Fix unique contraint name
* Handle UUID when exporting dashboard
* Fix Dataset PUT
* Add UUID JSON serialization
* Fix tests
* Simplify logic
* Try binary=True
2020-10-07 09:00:55 -07:00
Kasia Kucharczyk
63d0e801ad
chore: updated lint rules in models module ( #11036 )
...
* Removed disabled pylint rule `unused_import` from `dashboards.py` in `models` module. Added missing break in too long line. Formatting.
* Changed `datasource_access_request.py` in models` module: removed disabled pylint rule `unused_import`, removed `no-member` disabled rules which aren't needed. Formatting
* Changed `slice.py` in models` module: removed disabled pylint rule `unused_import`, changed unused arguments to private and removed disabled rule `unused-argument`
2020-09-24 13:49:00 -07:00
Ville Brofeldt
363abfa1a5
fix: remove unnecessary exception when exploring non-legacy viz plugins ( #10538 )
...
* fix: remove unnecessary exception when exploring non-legacy viz plugins
* lint
2020-08-07 08:41:39 +03:00
Erik Ritter
fd2d1c58c5
Revert "chore: Cleanup database sessions ( #10427 )" ( #10537 )
...
This reverts commit 7645fc85c3 .
2020-08-06 15:33:48 -07:00
John Bodley
7645fc85c3
chore: Cleanup database sessions ( #10427 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-07-30 23:07:56 -07:00
Daniel Vaz Gaspar
2fd37b18e3
fix(api): fixes perf on charts and introduces sorting by database on datasets ( #10392 )
2020-07-23 11:19:05 -07:00
Erik Ritter
5fa4680447
feat: update timeout error UX ( #10274 )
2020-07-20 15:32:17 -07:00
Maxime Beauchemin
318e5347bc
feat: Alerts! allowing users to set SQL-based email alerts with screenshots ( #9944 )
...
* feat: add support for alerts
* Add ModelViews
* First pass at adding scheduled Alert support
* Fix syntax errors
* Add log_retention and database to model
* Improving screenshots
* Still refactoring screenshots
* Pass down thumb_size properly
* Progress on screenshot endpoint
* Add alerts.last_eval_dttm and alert query logic
* Getting ready to split compute_screenshot and screenshot/{SHA}
* split the endpoints
* Improving alerting loop
* empty methods
* Add CLI command 'superset alert' that runs a sched loop
* Getting things to work
* email delivery
* A working email\!
* Add feature flag
* Add some description_columns to AlertModelView
* Little tweaks
* Use database.get_df, eval cells for truthiness
* Migrate thumbnail/screenshot functions to use new arg pattern
* Addressing PR feedback
* Update alerts DB migration down_revision
* Resolve _deliver_email arg conflict
* Make mypy happy
* Make isort happy
* Make pylint happy
Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com >
2020-07-06 13:12:27 -07:00
John Bodley
91517a56a3
style(mypy): Spit-and-polish pass ( #10001 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-07 08:53:46 -07:00
John Bodley
e789a35558
[mypy] Enforcing typing for superset.models ( #9883 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-05-22 20:31:21 -07:00
Daniel Vaz Gaspar
61ebb9bbc4
fix: chart datasource explore URL showing datasource name for druid ( #9839 )
2020-05-21 10:45:47 +01:00
Daniel Vaz Gaspar
48ef619618
perf(charts): improve performance on GET list ( #9619 )
2020-04-30 17:15:48 +01:00
Daniel Vaz Gaspar
d81f720502
[thumbnails] API and celery task for dashboards and charts ( #8947 )
2020-04-15 09:40:14 +01:00
Ville Brofeldt
9447381549
deprecate groupby controls in query_obj ( #9366 )
...
* Deprecate groupby from query_obj
* Fix query_object bug
* Fix histogram
* Remove groupby from legacy druid connector and fix first batch of unit tests
* Deprecate some unnecessary tests + fix a few others
* Address comments
* hide SIP-38 changes behind feature flag
* Break out further SIP-38 related tests
* Reslove test errors
* Add feature flag to QueryContext
* Resolve tests and bad rebase
* Backport recent changes from viz.py and fix broken DeckGL charts
* Fix bad rebase
* backport #9522 and address comments
2020-04-14 12:06:10 +03:00
Ville Brofeldt
980dd2fd41
pylint: accept specific 2 character names by default ( #9460 )
...
* lint: accept 2 letter names by default
* Address review comments
* Remove e and d from good-names
2020-04-08 20:32:26 +03:00
John Bodley
19da9042ff
[cache] Cleaning up viz/cache logic ( #9375 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-03-26 09:22:06 -07:00
ʈᵃᵢ
89109a16c6
[chart] fix, datasource link in listview ( #9247 )
2020-03-07 14:46:17 -08:00
Craig Rueda
607cfd1f29
Moving away from using the root logger everywhere ( #9099 )
...
* Moving away from using the root logger everywhere
* self.logger -> logger
2020-02-07 23:38:48 -08:00
ʈᵃᵢ
e5f5eed425
[chart] new, list view (react) ( #8999 )
...
* [charts] new, list view (react)
* DRY up template rendering
* fix i18n
* lint package.json
2020-02-05 12:42:42 -08:00
David Aaron Suddjian
d4d7134bf8
[explore] Modal to edit chart properties ( #9051 )
...
* chart edit modal
* remove commented code
* remove unused prop
* address PR feedback
* small tweak
2020-02-04 17:38:51 +00:00
David Aaron Suddjian
016f202423
Refactor Dashboard and Slice models ( #8820 )
...
* refactor dashboard and slice models
* appease various linters
* remove shortcuts & import indirection
* appease mypy
* fix bad imports
* lint
* address various issues
* ignore type issue
* remove unused imports
* lint
2019-12-18 11:40:45 -08:00