QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-15 22:25:15 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,179 Commits 424 Branches 541 Tags
02ef9ca4cd60d0d05f0afd2cebc1cabb83dfd4df
Commit Graph

66 Commits

Author SHA1 Message Date
Evan Rusackas
76b4a14d30 chore(config): Migrating ENABLE_JAVASCRIPT_CONTROLS from app config to a feature flag (#19113) 
* first pass migrating config to ff

* nixing a console log from testing

* adding an entry to `UPDATING.md`

* linting ✨

* Adding ENABLE_JAVASCRIPT_CONTROLS to FEATURE_FLAGS.md

* no longer in need of state!

* Turning the flag back off

* linting... le sigh

* and more linting...
 2022-03-14 08:54:02 -06:00
John Bodley
26486d01c1 chore: Remove legacy SIP-15 interim logic/flags (#18936) 
* chore: Remove legacy SIP-15 logic

* Update ab9a9d86e695_deprecate_time_range_endpoints.py

* Update UPDATING.md

* Update UPDATING.md

* Update UPDATING.md

Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2022-03-04 09:15:36 +13:00
David Aaron Suddjian
da3bc48803 feat: On window focus, redirect to login if the user has been logged out (#18773) 
* /me api

* test it

* watch for window activation and check auth

* simplify

* more comment

* making ci happy

* mypy should ignore tests
 2022-02-24 10:09:41 -08:00
Michael S. Molina
4b61c76742 fix: Explore long URL problem (#18181) 
* fix: Explore long URL problem

* Fixes lint problems

* Fixes default value

* Removes duplicated test

* Fixes share menu items

* Fixes tests

* Debounces form_data updates

* Rewrites debounce function

* Moves history update outside the functional component

* Mocks lodash function in tests

* Fixes Cypress test

* Fixes Cypress test #2
 2022-01-28 17:42:16 -03:00
Craig Rueda
ac76defc05 chore(datasets): Sanitizing /save response (#17579) 2021-11-29 20:07:06 -08:00
ofekisr
c520eb79b0 refactor: sqllab: move sqllab ralated enumns and utils to more logical place (#16843) 
* refactor move QueryStatus to common

* refactor move apply_display_max_row_limit to sqllab package

* refactor move limiting_factor to sqllab package

* fix pylint issues
 2021-09-26 21:15:57 +03:00
Rob DiCiuccio
4e380db3fd fix: Support Jinja template functions in global async queries (#16412) 
* Support Jinja template functions in async queries

* Pylint

* Add tests for async tasks

* Remove redundant has_request_context check
 2021-09-03 14:33:29 +03:00
John Bodley
be7065faf8 chore(pylint): Reenable raise-missing-from check (#16266) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-08-17 10:26:10 +12:00
John Bodley
24b43beff9 chore(pylint): Bump Pylint to 2.9.6 (#16146) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-08-14 10:32:28 +12:00
aspedrosa
e5540b79ec fix: no roles being returned for anonymous user (#15585) 2021-07-27 12:22:39 -06:00
cccs-jc
f652908a70 fix: renamed sqllab filters to _filters (#14971) 2021-06-03 21:22:50 +03:00
cccs-jc
eef489c667 feat: add support for filters in sqlLab (#14765) 2021-06-01 21:23:51 +03:00
Ville Brofeldt
66a4c94a1e fix(chart-data): handle url_params in csv export and native filters (#14526) 2021-05-07 21:07:44 +03:00
Erik Ritter
a816655715 fix: dashboard datasources filter None (#14471) 2021-05-04 15:34:38 -07:00
Daniel Vaz Gaspar
b4e527a8c4 fix: bootstrap data permissions (#14348) 2021-04-30 12:02:01 -06:00
Ville Brofeldt
2f6d1ff4cd chore: remove SIP-38 feature flag (#12894) 2021-02-03 09:41:44 +02:00
Rob DiCiuccio
d7cbd53fce fix(async queries): Remove "force" param on cached data retrieval (#12103) 
* Async queries: remove force cache param on data retrieval

* Assert equal query_object cache keys

* Decouple etag_cache from permission checks

* Fix query_context test

* Use marshmallow EnumField for validation
 2021-01-27 10:16:57 -08:00
Jesse Yang
55c8f9ba60 feat(explore): allow opening charts with missing dataset (#12705) 2021-01-25 15:09:03 -08:00
Duy Nguyen Hoang
77da4ada99 fix: error while parsing invalid json form_data (#12586) 
* Fix error while parsing invalid json form_data

* Refine error returned
 2021-01-19 16:15:16 +00:00
Kasia Kucharczyk
ad63823d6f fix: Added message flash when chart with missing dataset is accessed. (#12468) 2021-01-18 22:42:03 -08:00
Rob DiCiuccio
4d329071a1 feat(SIP-39): Async query support for charts (#11499) 
* Generate JWT in Flask app

* Refactor chart data API query logic, add JWT validation and async worker

* Add redis stream implementation, refactoring

* Add chart data cache endpoint, refactor QueryContext caching

* Typing, linting, refactoring

* pytest fixes and openapi schema update

* Enforce caching be configured for async query init

* Async query processing for explore_json endpoint

* Add /api/v1/async_event endpoint

* Async frontend for dashboards [WIP]

* Chart async error message support, refactoring

* Abstract asyncEvent middleware

* Async chart loading for Explore

* Pylint fixes

* asyncEvent middleware -> TypeScript, JS linting

* Chart data API: enforce forced_cache, add tests

* Add tests for explore_json endpoints

* Add test for chart data cache enpoint (no login)

* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag

* Add tests for tasks/async_queries and address PR comments

* Bypass non-JSON result formats for async queries

* Add tests for redux middleware

* Remove debug statement

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Skip force_cached if no queryObj

* SunburstViz: don't modify self.form_data

* Fix failing annotation test

* Resolve merge/lint issues

* Reduce polling delay

* Fix new getClientErrorObject reference

* Fix flakey unit tests

* /api/v1/async_event: increment redis stream ID, add tests

* PR feedback: refactoring, configuration

* Fixup: remove debugging

* Fix typescript errors due to redux upgrade

* Update UPDATING.md

* Fix failing py tests

* asyncEvent_spec.js -> asyncEvent_spec.ts

* Refactor flakey Python 3.7 mock assertions

* Fix another shared state issue in Py tests

* Use 'sub' claim in JWT for user_id

* Refactor async middleware config

* Fixup: restore FeatureFlag boolean type

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
 2020-12-10 20:21:56 -08:00
Maxime Beauchemin
c360413fc2 style(menu): clean up right menu - leaving only "Settings" (#11227) 
* style(menu): clean up right menu - leaving only settings

* bring pre-commit back

* fix frontend tests

* pre-commit

* re-introduce subtle '+'
 2020-10-20 21:33:28 -07:00
Ville Brofeldt
e647286393 chore(sql-lab): catch PyArrow deserialization error (#11201) 2020-10-12 10:16:00 +03:00
Grace Guo
a10e86ab31 fix: revert eTag cache feature for dashboard (#11203) 
* revert #11137

* revert #10963
 2020-10-08 12:15:08 -07:00
Ville Brofeldt
1fa8bf7d7b fix(viz): downgrade exception for missing viz/datasource (#11173) 
* fix(viz): downgrade exception for missing datasource

* add translations
 2020-10-07 15:16:51 +03:00
Grace Guo
6633409a15 feat: enable ETag header for dashboard GET requests (#10963) 
* feat: add etag for dashboard load requests

* fix review comments
 2020-09-29 10:57:16 -07:00
John Bodley
1ee87cc4d1 fix: dashboard extra filters (#10692) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-09-02 16:03:25 -07:00
Ville Brofeldt
58b075bc17 fix(jinja): extract form_data from json body (#10684) 
* fix(jinja): extract form_data from json body

* add test

* disable test for presto
 2020-08-28 21:26:07 +03:00
Erik Ritter
fd2d1c58c5 Revert "chore: Cleanup database sessions (#10427)" (#10537) 
This reverts commit 7645fc85c3.
 2020-08-06 15:33:48 -07:00
John Bodley
7645fc85c3 chore: Cleanup database sessions (#10427) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-07-30 23:07:56 -07:00
John Bodley
aefef9ca55 chore(security): Updating assert logic (#10034) 
* chore(security): Updating assert logic

* Deprecating rejected_tables

Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-06-23 20:49:39 -07:00
Will Barrett
8e23d4f369 chore: Upgrade pylint to 2.5.3 and fix most new rules (#10101) 
* Bump pylint version to 2.5.3

* Add a global disable for the most common new pylint error

* Fix a bunch of files containing very few errors

* More pylint tweakage, low-hanging fruit

* More easy stuff...

* Fix more erroring files

* Fix the last couple of errors, clean pylint!

* Black

* Fix mypy issue in connectors/druid/models.py
 2020-06-18 14:03:42 -07:00
Will Barrett
01aede0652 refactor: Break up superset/views/core.py (#10078) 
* Remove unreferenced function from views/core.py

* Remove excess constants from views/core.py

* Extract CssTemplate-related views to their own file from core.py

* Remove duplicate constant declaration and make the constant less racist

* Move free-floating functions in views/core.py to views/utils.py

* Move AccessRequestsModelView out of views/core.py into its own module

* Move health checks and KV ModelView out of core.py and into their own modules

* Move R model view to its own module

* Move after-request header setting to views/base.py from views/core.py

* black

* mypy

* isort

* Fix reference to imported app

* pylint

* Fix some imports

* Add some missing view imports

* Fix a missing import
 2020-06-17 13:42:13 -07:00
John Bodley
91517a56a3 style(mypy): Spit-and-polish pass (#10001) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-06-07 08:53:46 -07:00
John Bodley
63e0188f45 style(mypy): Enforcing typing for superset.views (#9939) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-06-05 08:44:11 -07:00
John Bodley
1001c6d5f4 Revert "[caching] Using request context rather than globals" (#9969) 
This reverts commit 90cd3889ac.

Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-06-02 16:03:33 -07:00
John Bodley
04e3a4a72d [caching] Using request context rather than globals (#9715) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-05-11 15:55:05 -07:00
John Bodley
7f89f12c4a [debug] Debugging caching issue (#9665) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-04-29 12:16:47 -07:00
Ville Brofeldt
9447381549 deprecate groupby controls in query_obj (#9366) 
* Deprecate groupby from query_obj

* Fix query_object bug

* Fix histogram

* Remove groupby from legacy druid connector and fix first batch of unit tests

* Deprecate some unnecessary tests + fix a few others

* Address comments

* hide SIP-38 changes behind feature flag

* Break out further SIP-38 related tests

* Reslove test errors

* Add feature flag to QueryContext

* Resolve tests and bad rebase

* Backport recent changes from viz.py and fix broken DeckGL charts

* Fix bad rebase

* backport #9522 and address comments
 2020-04-14 12:06:10 +03:00
John Bodley
19da9042ff [cache] Cleaning up viz/cache logic (#9375) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-03-26 09:22:06 -07:00
John Bodley
43f0221304 [sip-15] Fixing typo in docstring (#9377) 2020-03-25 10:00:41 -07:00
Grace Guo
adebd40d30 [cache warm_up] warm_up slice with dashboard default_filters (#9311) 
* [cache warm_up] warm_up slice with dashboard default_filters

* update Celery warmup tasks

* fix code review comments

* add try catch and type checking for parsed dash metadata

* extra code review fix
 2020-03-18 08:21:10 -07:00
ʈᵃᵢ
7b97764dbc [dashboard] New, list view (react) (#8845) 
* adds dashboard listview component

* use new api

* use json over rison

* lint

* adds seperate dashboard list view

* edit and delete actions

* fix lint ignore

* fix common_bootstrap_payload is now a function

* fix license

* fix pylint

* isort

* fix tests

* lint

* lint ts

* fix js tests

* fix double import from bad rebase

* fix indent error

* lookup permissions

* generic permission lookup

* get tslint to pass

* adds js specs

* lint

* fix rebase

* lint

* lint again

* fix type errors preventing build

* adds more specs

* fix tslint error

* fix null check

* remove unecessary code

* use translations provided by api

* more translations

* linting

* fix spec

* i18n

* fix register order
 2020-01-16 00:48:55 -05:00
David Aaron Suddjian
016f202423 Refactor Dashboard and Slice models (#8820) 
* refactor dashboard and slice models

* appease various linters

* remove shortcuts & import indirection

* appease mypy

* fix bad imports

* lint

* address various issues

* ignore type issue

* remove unused imports

* lint
 2019-12-18 11:40:45 -08:00
Will Barrett
60914fa76a re-enable Pylint on a number of view files (#8773) 
* re-enable pylint for superset/views/tags.py

* Re-enable pylint for superset/views/dashboard.py

* Re-enable pylint for superset/views/sql_lab.py

* Re-enable pylint for superset/views/datasource.py

* Re-enable pylint for superset/views/utils.py

* Re-enable pylint for superset/views/log/__init__.py

* pylint fix

* Improve naming
 2019-12-11 09:49:19 -08:00
John Bodley
1e3d833b02 [sip-15] Fixing time range endpoints from dashboards (#8513) 2019-11-06 09:15:58 -08:00
John Bodley
5dba2f4b56 [SIP-15] Adding grace period (#8490) 2019-11-04 12:00:41 -08:00
John Bodley
eb150eba1f [sip-15] Fix time range endpoints encoding (#8481) 2019-10-31 07:11:48 -07:00
Will Barrett
e4ca44e95f Use config[] not config.get() (#8454) 
* Typo fix in CONTRIBUTING.md

* Alter references to config.get('FOO') to use preferred config['FOO']

* Set missing configuration constants in superset/config.py

* Misc. CI fixes

* Add type annotation for FEATURE_FLATGS
 2019-10-30 16:19:16 -07:00
John Bodley
8b74745f9e [SIP-15] Adding initial framework (#8398) 
* [sip-15] Adding initial framework

* [toast] Addressing etr2460's comments

* [fix] Addressing etr2460's comments
 2019-10-28 14:23:12 -07:00