Commit Graph

428 Commits

Author SHA1 Message Date
Lily Kuang
27268169e4 fix: cache key with guest token rls (#19110)
* add guest rls clause to cache key

* lint

* pylint

* add app back
2022-03-10 13:49:47 -08:00
John Bodley
26486d01c1 chore: Remove legacy SIP-15 interim logic/flags (#18936)
* chore: Remove legacy SIP-15 logic

* Update ab9a9d86e695_deprecate_time_range_endpoints.py

* Update UPDATING.md

* Update UPDATING.md

* Update UPDATING.md

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-03-04 09:15:36 +13:00
serenajiang
760dab9abd feat(TimeTableViz): sort by first metric (#18896) 2022-02-28 10:26:24 -08:00
Kamil Gabryjelski
830f2e71d3 feat(explore): Allow using time formatter on temporal columns in data table (#18569)
* feat(explore): Allow using time formatter on temporal columns in data table

* Fix data table loading

* Return colnames and coltypes from results request

* Fix types

* Fix tests

* Fix copy button

* Fix df is none

* Fix test

* Address comments

* Move useTimeFormattedColumns out of useTableColumns

* Make reducer more readable
2022-02-09 10:29:11 +01:00
Kamil Gabryjelski
b5b6ceb1b3 fix(explore): don't apply time range filter to Samples table (#17711) 2021-12-10 11:40:11 -07:00
Ville Brofeldt
3a42071e0f chore(sql): clean up invalid filter clause exception types (#17702)
* chore(sql): clean up invalid filter clause exception types

* fix lint

* rename exception
2021-12-09 17:49:32 +02:00
ofekisr
8a6ecd3b97 refactor(QueryContext): add QueryContextFactory (#17495) 2021-11-21 14:35:46 +02:00
Ville Brofeldt
e2a429b0c8 feat(explore): adhoc column expressions [ID-3] (#17379)
* add support for adhoc columns to api and sqla model

* fix some types

* fix duplicates in column names

* fix more lint

* fix schema and dedup

* clean up some logic

* first pass at fixing viz.py

* Add frontend support for adhoc columns

* Add title edit

* Fix showing custom title

* Use column name as default value in sql editor

* fix: Adds a loading message when needed in the Select component (#16531)

* fix(tests): make parquet select deterministic with order by (#16570)

* bump emotion to help with cache clobbering (#16559)

* fix: Support Jinja template functions in global async queries (#16412)

* Support Jinja template functions in async queries

* Pylint

* Add tests for async tasks

* Remove redundant has_request_context check

* fix: impersonate user label/tooltip (#16573)

* docs: update for small typos (#16568)

* feat: Add Aurora Data API engine spec (#16535)

* feat: Add Aurora Data API engine spec

* Fix lint

* refactor: sql_json view endpoint: encapsulate ctas parameters (#16548)

* refactor sql_json view endpoint: encapsulate ctas parameters

* fix failed tests

* fix failed tests and ci issues

* refactor sql_json view endpoint: separate concern into ad hod method (#16595)

* feat: Experimental cross-filter plugins (#16594)

* fix:fix get permission function

* feat: add cross filter chart in charts gallery under FF

* chore(deps): bump superset-ui to 0.18.2 (#16601)

* update type guard references

* fix imports

* update series_columns schema

* Add changes that got lost in rebase

* Use current columns name or expression as sql editor init value

* add integration test and do minor fixes

* Bump superset-ui

* fix linting issue

* bump superset-ui to 0.18.22

* resolve merge conflict

* lint

* fix select filter infinite loop

* bump superset-ui to 0.18.23

* Fix auto setting column popover title

* Enable adhoc columns only if UX_BETA enabled

* put back removed test

* Move popover height and width to constants

* Refactor big ternary expression

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: joeADSP <75027008+joeADSP@users.noreply.github.com>
Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
2021-11-15 12:50:08 +02:00
John Bodley
675ffaf8df revert: Partial revert of 17236 (#17383)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-10 20:32:35 -08:00
John Bodley
1c12167d8d fix: Revert default series sort-by metric and enforce non-xor with series limit (#17236)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-03 13:59:38 -07:00
Ville Brofeldt
d7834f17e3 fix(filter-indicator): show filters handled by jinja as applied (#17140) 2021-10-18 19:28:05 +02:00
ofekisr
c520eb79b0 refactor: sqllab: move sqllab ralated enumns and utils to more logical place (#16843)
* refactor move QueryStatus to common

* refactor move apply_display_max_row_limit to sqllab package

* refactor move limiting_factor to sqllab package

* fix pylint issues
2021-09-26 21:15:57 +03:00
Ville Brofeldt
4e3d4f6daf feat: add global max row limit (#16683)
* feat: add global max limit

* fix lint and tests

* leave SAMPLES_ROW_LIMIT unchanged

* fix sample rowcount test

* replace max global limit with existing sql max row limit

* fix test

* make max_limit optional in util

* improve comments
2021-09-16 19:33:41 +03:00
John Bodley
fb4650a6eb chore(pylint): Remove top-level disable (#16589)
* chore(pylint): Remove top-level disable

* Update examples.py

* Update command.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-09-15 09:30:23 -07:00
John Bodley
1669947bcd chore(pylint): Reenable too-many-lines check (#16287)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-09-13 13:22:19 -07:00
天河
bb014b5131 fix: fix assignment in FilterBoxViz (#16662)
* Fixing assignment.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Adding unit test for FilterBoxViz.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Reformatting with black.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Revert format change in other test.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Reformatting with the same black version with pre-commit config.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>
2021-09-10 15:10:55 +03:00
AAfghahi
631ad02a76 fix: copy to Clipboard order (#16299)
* copy to Clipboard order

* centralized copyToClipboard

* fixed table order

* fixed tests

* added colnames to all viz types

* added colnames to all viz types

* added colnames to all viz types
2021-08-24 14:47:09 -07:00
John Bodley
7e4c940314 chore(pylint): Enable useless-suppression check (#16388)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-08-24 03:58:41 +12:00
Ville Brofeldt
36abc51f90 fix(dashboard): unset empty time filter indicator (#16272) 2021-08-16 19:32:05 +03:00
Ville Brofeldt
63ace7b288 feat(cross-filters): add support for temporal filters (#16139)
* feat(cross-filters): add support for temporal filters

* fix test

* make filter optional

* remove mocks

* fix more tests

* remove unnecessary optionality

* fix even more tests

* bump superset-ui

* add isExtra to schema

* address comments

* fix presto test
2021-08-10 17:18:46 +01:00
Jesse Yang
490890de23 fix(dashboard): 500 error caused by data_for_slices API (#16053) 2021-08-03 19:01:39 -07:00
Yongjie Zhao
61e6b7017b fix: nvd3 bar chart sortby metric (#15318) 2021-06-30 19:36:05 +08:00
Yongjie Zhao
b3616d23a4 fix: follow up pr-15343 (#15355) 2021-06-24 16:38:25 +08:00
Yongjie Zhao
fae4531f1e fix: missing orderby in query on the nvd3 timeseries chart (#15343) 2021-06-24 16:01:38 +08:00
Ville Brofeldt
822eb2e27e feat(sql): add jinja support to metrics and expressions (#15247)
* feat(sql): add jinja support to metrics and expressions

* add test
2021-06-19 08:29:04 +03:00
Yongjie Zhao
9729ffd7a1 fix: reindex when combine metric in legacy pivot table (#14708) 2021-05-20 11:14:30 -07:00
Ville Brofeldt
37276e1af9 fix(viz): apply uniform sorting to all nvd3 timeseries charts (#14539) 2021-05-10 15:43:21 +03:00
Sam Faber-Manning
11260b3117 chore: add stack trace to all calls of logger.error (#14382) 2021-04-30 09:22:05 -07:00
Ben Reinhart
e7f5100833 fix: Fix unintended cache misses with async queries (#14291)
* bug: Fix unintended cache misses with async queries

* Ensure sort order

* Ensure columns are sorted

* Update failing tests
2021-04-28 12:14:55 -07:00
Ville Brofeldt
d7fc2031b1 feat(filter-box): sort by metric on backend (#14340) 2021-04-26 21:06:19 +03:00
Ville Brofeldt
fe21de3fc4 fix(viz): time shift read-only error (#14191) 2021-04-16 16:48:06 +03:00
Jesse Yang
fe08b698f5 docs: update outdated country map tools instructions (#14027)
also add actionable error for country map vis
2021-04-09 15:15:17 -07:00
Erik Ritter
ceb88926ff fix: Check for permissions in FilterBox (#13859) 2021-03-31 10:34:48 -07:00
Ben Reinhart
55ba47ec2e fix(#13734): Properly escape special characters in CSV output (#13735)
* fix: Escape csv content during downloads

* Reuse CsvResponse object

* Use correct mimetype for csv responses

* Ensure that headers are also escaped

* Update escaping logic
2021-03-26 15:22:00 -07:00
Jesse Yang
bd1d6acb0c fix(query): order by adhoc metrics should trigger group by (#13434)
* fix(query): properly select adhoc metrics in orderby

* Throw error when sql is empty

* Allow `metrics` to be None

* Always use alias in orderby for metrics

* Bump table chart version and migrate histogram to typescript

* Fix Histogram without groupby

* Fix Presto birth names test

* Raw records mode should not aggregate
2021-03-16 21:00:03 -07:00
Jesse Yang
49eeab6f55 fix(explore): make sure sort by metric is not duplicated (#13473) 2021-03-07 21:13:54 -08:00
Mayur
8b38d63b7d changes added (#13431) 2021-03-03 13:52:54 +02:00
Ville Brofeldt
70e12ed27d chore: bump pyarrow and pandas (#12882)
* bump pyarrow and pandas

* remove df copy
2021-03-02 19:44:53 +02:00
Rob Spielman
e37c2bf8fd fixing chart keys in MultiLineViz (#12937) 2021-02-23 10:40:23 +02:00
Victor Malai
b5379bc8c5 fix(viz): calendar heatmap granularity (#13233)
* fix: add time granularity to heatmap query

* fix: add time granularity to heatmap query

* Add aggregation for druid

* Fix lint

* Fix lint

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
2021-02-22 16:17:36 +02:00
Victor Malai
e8d50356a2 Add sort by for dist bar chart (#13049) 2021-02-22 08:36:57 +02:00
Victor Malai
73ce2f1ea7 feat: Add sort by metric for charts with multiple metrics (#13057)
* feat: Add sort by metric for pivot-table

* feat(legacy-plugin-chart-parallel-coordinates): subject Add sort by metric

* feat(legacy-plugin-chart-rose-chart): subject Add sort by metric

* feat(legacy-plugin-chart-partition): subject Add sort by metric

* feat(legacy-plugin-chart-paired-t-test): subject Add sort by metric

* feat(legacy-plugin-chart-treemap): subject Add sort by metric

* feat(legacy-plugin-chart-nvd3-area): subject Add sort by metric

* Fix lint

* feat(plugin-chart-horizon): Add sort by & Add no default sorting if checkbox is not selected
2021-02-21 21:59:45 -08:00
michellethomas
91db008d72 fix: accept null groupby in form data for timeseries table viz (#13086)
* Allowing timeseries table groupby to be null in form data

* Check truthiness for is_group_by

Co-authored-by: michelle_thomas <michelle.thomas@airbnb.com>
2021-02-17 13:45:39 -08:00
Ville Brofeldt
d8c32b8097 fix(chart-data-api): support numeric temporal columns (#13138) 2021-02-16 09:51:22 +02:00
Victor Malai
24ebf10976 feat: add sort_by_metric for charts with single metric (#13058) 2021-02-15 02:59:50 -08:00
Duy Nguyen Hoang
32f2c45f93 fix(explore): preserve metric column order in bar chart (#12417)
* fix: Preserve Column Order in Bar chart

* Update tests/viz_tests.py to use f-strings style

Co-authored-by: Duy Nguyen <duy.nguyenhoang@global-fashion-group.com>
2021-01-28 10:39:00 +02:00
Beto Dealmeida
5a3c5b1f54 fix: samples should not be timeseries (#12796) 2021-01-28 10:12:30 +02:00
Grace Guo
48f37ca1db fix: Prevent dashboard with filter_values template cause incompatible indicator (#12742)
* fix: Prevent dashboard using filter_values to add incompatible indicator

* fix review comments

* fix review comments

* add extra fix per comments
2021-01-27 10:28:17 -08:00
Rob DiCiuccio
d7cbd53fce fix(async queries): Remove "force" param on cached data retrieval (#12103)
* Async queries: remove force cache param on data retrieval

* Assert equal query_object cache keys

* Decouple etag_cache from permission checks

* Fix query_context test

* Use marshmallow EnumField for validation
2021-01-27 10:16:57 -08:00
Ville Brofeldt
ede879022c fix(multiline): return all chart data on initial request (#12660)
* fix(multiline): return chart data on data request

* bump package

* optimize chart retrieval and fix chart form_data
2021-01-23 15:01:50 +08:00