QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 15:44:57 +00:00
Code Issues Packages Projects Releases Wiki Activity
12,864 Commits 448 Branches 542 Tags
0706bcfe2a08f3fb2a8a79d3ca9be928f58a2eba
Commit Graph

28 Commits

Author SHA1 Message Date
Elizabeth Thompson
6f6cb1839e fix: add back database lookup from sip 68 revert (#22129) 2022-11-15 11:57:03 -08:00
Elizabeth Thompson
86d52fcbc4 chore: remove shadow write of new sip 68 dataset models (#21986) 2022-11-14 09:55:53 -08:00
Hugh A. Miles II
bc435e08d0 fix: overwrite update override columns on PUT /dataset (#20862) 
* update override columns

* save

* fix overwrite with session.flush

* write test

* write test

* layup

* address concerns

* address concerns
 2022-07-29 21:51:35 -04:00
John Bodley
d327437462 refactor: Improve performance regression introduced in #20473 (#20810) 
* refactor: Improve performance regression introduced in #20473

* Update dao.py
 2022-07-26 17:47:15 -07:00
John Bodley
f0ca158989 fix: Refactor ownership checks and ensure consistency (#20499) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2022-07-07 11:04:27 -07:00
John Bodley
f29cde2269 refactor: Minor optimization for updating DatasetDAO columns and metrics (#20473) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2022-06-25 14:31:04 -07:00
Elizabeth Thompson
32bb1ce3ff feat!: pass datasource_type and datasource_id to form_data (#19981) 
* pass datasource_type and datasource_id to form_data

* add datasource_type to delete command

* add datasource_type to delete command

* fix old keys implementation

* add more tests
 2022-06-02 16:48:16 -07:00
Beto Dealmeida
8b6e582211 fix (dataset): DAO update (#19926) 2022-05-02 11:52:57 -07:00
Hugh A. Miles II
a1961cfc6f fix: Users being able to update datasets across DBs (#17348) 
* add database id back

* add condition to verify dataset is being changed

* Update superset/datasets/dao.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-11-10 19:45:48 -05:00
ofekisr
0d0c759cfe refactor: sql lab command: separate concerns into different modules (#16917) 
* chore move sql_execution_context to sqllab package

* add new helper methods into base Dao

* refactor separate get existing query concern from command

* refactor separate query access validation concern

* refactor separate get query's database concern from command

* refactor separate get query rendering concern from command

* refactor sqllab_execution_context

* refactor separate creating payload for view

* chore decouple command from superset app

* fix pylint issues

* fix failed tests

* fix pylint issues

* fix failed test

* fix failed black

* fix failed black

* fix failed test
 2021-10-03 11:15:46 +03:00
Hugh A. Miles II
331de0c4ae fix: Fix Uniqueness check before update for Sqllab Overwrites (#16859) 
* add condition to make sure columns are available before throwing

* fix

* remove database_id from history changed

* refactor update call to datasets

* cleanup

* oops

* prettier
 2021-09-29 13:38:29 -04:00
Ville Brofeldt
ac1d779a30 chore(ci): bump pylint to 2.10.2 (#16463) 2021-08-26 20:30:41 +03:00
John Bodley
32a5680510 chore: pylint reenable bad-option-value (#15775) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-07-22 04:34:08 +12:00
Sam Faber-Manning
11260b3117 chore: add stack trace to all calls of logger.error (#14382) 2021-04-30 09:22:05 -07:00
John Bodley
a3b41e2bac fix: Issue 13956 (#13980) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-04-09 15:21:58 +12:00
Daniel Vaz Gaspar
d1e93078f4 fix: delete dataset columns and metrics on the REST API (#13389) 
* feat: delete dataset columns and metrics on the REST API

* fix openapi spec

* change delete comparison to id

* delete columns and metrics on their namespace

* add missing licenses

* add failed test

* address comment
 2021-03-15 18:14:26 +00:00
Grace Guo
8da1900d8a feat: add hook for dataset health check (#11970) 
* feat: add hook for dataset health check

* add event log

* optimize datasource json data like certified data

* add unit test

* fix review comments

* extra code review comments
 2020-12-15 18:12:06 -08:00
Hugh A. Miles II
0689738e7c feat: Sqllab to Explore UX improvements api changes (#11836) 2020-11-30 09:23:11 -08:00
Daniel Vaz Gaspar
9e9dac68f7 feat(datasets): REST API bulk delete (#11237) 
* feat(datasets): REST API bulk delete

* doc HTTP 400
 2020-10-12 13:40:05 +01:00
Bogdan
03eebd3019 fix: fix table existence validation function (#11066) 
* Fix table existance validation function

* Drop left over table name index in mysql db

* Do not modify model

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-09-29 15:01:01 -07:00
ʈᵃᵢ
50852dfbbf chore: downgrade expected exception from error to info (#10994) 
* chore: reduce number of error logs

* info -> warning
 2020-09-23 12:05:44 +01:00
Lily Kuang
b9e0678752 feat: dataset api endpoint for charts and dashboards count (#10235) 
* create GET endpoint for charts and dashboards count associated to a dataset

* add test for chart and dashboard count dataset
 2020-07-06 16:25:57 -07:00
Will Barrett
8e23d4f369 chore: Upgrade pylint to 2.5.3 and fix most new rules (#10101) 
* Bump pylint version to 2.5.3

* Add a global disable for the most common new pylint error

* Fix a bunch of files containing very few errors

* More pylint tweakage, low-hanging fruit

* More easy stuff...

* Fix more erroring files

* Fix the last couple of errors, clean pylint!

* Black

* Fix mypy issue in connectors/druid/models.py
 2020-06-18 14:03:42 -07:00
John Bodley
91517a56a3 style(mypy): Spit-and-polish pass (#10001) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-06-07 08:53:46 -07:00
Ville Brofeldt
980dd2fd41 pylint: accept specific 2 character names by default (#9460) 
* lint: accept 2 letter names by default

* Address review comments

* Remove e and d from good-names
 2020-04-08 20:32:26 +03:00
Daniel Vaz Gaspar
4be827544e [datasets] Add strict type annotation (#9437) 
* [datasets] Add strict type annotation

* Fix refresh endpoint

* Improve logic on update
 2020-04-07 16:22:57 +01:00
Daniel Vaz Gaspar
ccb22dc976 [dataset] columns and metrics API (nested) (#9268) 
* [dataset] columns and metrics API (nested)

* [dataset] tests and validation

* [datasets] Fix, revert list field name to database_name
 2020-03-24 17:24:08 +00:00
Daniel Vaz Gaspar
52c59d6890 [datasets] new, API using command pattern (#9129) 
* [datasets] new, API using command pattern

* [datasets] tests and improvements

* [datasets] lint

* [database] address comments

* [datasets] lint

* [datasets] Address PR comments

* [dataset] Fix, dataset expects a Dict now

* [dataset] lint and optional commits

* [dataset] mypy

* [dataset] Fix, license and parent class

* [dataset] Make CRUD DAO raise exceptions
 2020-03-08 09:13:08 +00:00