Commit Graph

34 Commits

Author SHA1 Message Date
JUST.in DO IT
0c0d2b38a6 fix(sqllab): infinite running state on disconnect (#23669) 2023-04-18 12:26:29 -07:00
JUST.in DO IT
ca4dd26648 chore(sqllab): Remove schemaOptions from redux store (#23257) 2023-03-22 15:35:22 -06:00
Hugh A. Miles II
8fa77adf9a chore: Hugh/migrate estimate query cost to v1 (#23226)
Co-authored-by: Diego Medina <diegomedina24@gmail.com>
2023-03-17 18:02:25 -06:00
Zamar
001100ddf0 feat(db_engine_specs): big query cost estimation (#21325)
Co-authored-by: zamar roura <zamar.roura@cabify.es>
Co-authored-by: Zamar Roura <zamarfazal@gmail.com>
2023-01-09 08:56:19 +02:00
Ville Brofeldt
b6d39d194c feat(trino): support early cancellation of queries (#22498) 2022-12-24 06:31:46 +02:00
JUST.in DO IT
fb8231b50c fix(sqllab): wiped out unsaved changes by delayed actions (#21877) 2022-10-27 13:20:34 -07:00
Mayur
61319fd759 feat(sqllab): save query parameters in database (#21682) 2022-10-07 12:49:14 +05:30
JUST.in DO IT
8d1b7ecfde fix(sqllab): perf regression on #21532 refactor (#21632) 2022-10-03 11:00:53 +08:00
JUST.in DO IT
222f1e7ea8 fix(sqllab): invalid table metadata request (#21304) 2022-09-01 16:35:19 -07:00
JUST.in DO IT
f77b910e2c perf(sqllab): Rendering perf improvement using immutable state (#20877)
* perf(sqllab): Rendering perf improvement using immutable state

- keep queryEditors immutable during active state
- add unsavedQueryEditor to store all active changes
- refactor each component to subscribe the related unsaved editor state only

* revert ISaveableDatasource type cast

* missing trigger prop

* a default of an empty object and optional operator
2022-08-23 12:17:19 -03:00
Lyndsi Kay Williams
8a04536f9d feat(SqlLab): Change Save Dataset Button to Split Save Query Button IV (#20852)
* Moving entire split save btn PR

* Addressed review comments

* Remove arbitrary div from ErrorBoundary in Chart

* Added accidentally removed comment

* Fix act errors in SaveQuery tests

* Fix SaveDatasetActionButton test

* SaveDatasetModal test almost working

* SaveDatasetModal tests all passing

* Clean SaveDatasetModal test

* Fix create chart button and SaveDatasetModal text in SQL Lab

* Fix untitled dataset name on SaveDatasetModal in explore

* Fix styling on split save button
2022-08-01 14:36:34 -05:00
Diego Medina
115ab700df fix(sql lab): MultiSelector component render twice (#20706)
* fix(sql lab): MultiSelector component render twice

* filter null/undefined tables
2022-07-19 08:33:15 -03:00
Diego Medina
92057858c2 fix(sql lab): View result button is not showing consistently (#20164) 2022-06-02 22:53:59 -06:00
Michael S. Molina
834dcef993 chore: Moves date utils to utils folder (#20192) 2022-05-31 12:21:58 -03:00
Luis Casillas
1fa841ee29 Revert "fix(sql lab): display the 'View Results' button consistently in the history tab on sync mode (#19362)" (#19906)
This reverts commit 6d5d03e592.
2022-05-02 11:45:43 -06:00
Diego Medina
6d5d03e592 fix(sql lab): display the 'View Results' button consistently in the history tab on sync mode (#19362)
* fix(sql lab): display the 'View Results' button in the history tab when running sync queries

* pr comment
2022-04-13 10:20:32 -06:00
Diego Medina
4669b6ce11 fix: most Recently Selected Table Should Appear at the Top of the List on the Left Panel (#19258) 2022-03-21 15:58:23 -06:00
Diego Medina
bd76648e4e fix: show the total row count in the SQL Lab Query History tab when limited by DISPLAY_MAX_ROW (#19054) 2022-03-09 12:19:18 -07:00
AAfghahi
147dc5af71 fix(sql Lab tabs): Empty SQL Lab tabs (#18817)
* Empty SQL table message on zero tabs

* sql editor no editor tab bug fix

* Revert Error message

* empty state tab state

* added a unit test

* addressed reviews

* kasia feedback

Co-authored-by: Yahya Kayani <yahyakiani1@gmail.com>
2022-02-25 10:48:15 -08:00
Grace Guo
2199f65373 fix: sql lab refetch button (#16469)
* fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)

* fix: SQL Lab show "Refetch Results" button while fetching new query results

* fix comments

(cherry picked from commit 408d58f937)

* handle exception caused by invalid query id
2021-08-30 15:47:00 -07:00
Peter Kosztolanyi
02032ee8a4 feat: cancel db query on stop (#15403)
* feat: cancel db query on stop

* fix pylint

* Add unit tests

* Do not bind multiple times

* Stop only running queries

* Postgres to cancel only the required query

* Remove extra log

* Add docstring

* Better types, docstring and naming

* Use python3 format strings

* Update superset/sql_lab.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Add cancel_query_on_windows_unload option to database

* Return cancel_query as bool

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-07-13 12:09:22 -04:00
Grace Guo
5b2eb8d933 Revert "fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)" (#15301)
This reverts commit 408d58f937.
2021-06-22 11:08:29 -07:00
Grace Guo
408d58f937 fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)
* fix: SQL Lab show "Refetch Results" button while fetching new query results

* fix comments
2021-06-16 16:57:31 -07:00
AAfghahi
e507508b48 feat: Logic added to limiting factor column in Query model (#13521)
* Sqllab limit

* Add migration script

* Set default values

* initial push

* revisions

* Update superset/views/core.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* moving migration to separate PR

* with migration

* revisions

* Fix apply_limit_to_sql

* all but tests

* added unit tests

* revisions

* Update superset/sql_lab.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/sql_parse.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* fixed black issue

* Update superset/views/core.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* updated logic

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-04-30 15:15:18 -07:00
Beto Dealmeida
8d48d2e37b fix(sqllab): per-tab hide left bar (#13288)
* fix (sqllab): per-tab hide left bar

* Load state when switching tabs
2021-03-05 11:16:11 -08:00
Beto Dealmeida
ab3f4bd94b feat: add separate endpoint to fetch function names for autocomplete (#12840)
* WIP

* Add unit test for API

* Add spec

* Fix unit test

* Fix unit test

* Fix test

* Fix test

* Add period to error message
2021-02-02 18:01:01 -08:00
Beto Dealmeida
1d9d905497 fix: prevent race condition when canceling query (#11449) 2020-10-29 14:34:58 -07:00
Kamil Gabryjelski
ccfd293227 ESLint: no-restricted-syntax (#10889)
* Enable no-restricted syntax rule

* Fix webpack.config.js

* Remove unused function from utils/common.js

* Refactor triple nested for loop

* Fix loops in src/explore components

* Fix loops in SqlLab components

* Fix loops in AlteredSliceTag

* Fix loops in FilterableTable

* Add fixtures and uinit tests for findControlItem

* Add license
2020-09-18 09:05:57 -07:00
Kamil Gabryjelski
352e8a1afd Re-enable rule prefer-destructuring (only for objects) (#10867) 2020-09-14 10:11:20 -07:00
Jesse Yang
9a59bdda48 refactor: merge/upgrade superset-ui packages (#10790)
* refactor: merge/upgrade superset-ui packages

* Fix flaky big number test

* Fix Flaky AdhocFilters test
2020-09-09 13:18:55 -07:00
Erik Ritter
9a5195ab85 feat: support new errors payload in SQL Lab (#10243) 2020-07-06 09:49:32 -07:00
Erik Ritter
4281ad5486 chore: type ResultSet.tsx (#10226) 2020-07-02 10:12:31 -07:00
Evan Rusackas
1cdfb829d7 Eslint prefer-object-spread (#9466)
* The rule.

* The result
2020-04-03 17:05:16 -07:00
David Aaron Suddjian
2913063924 SIP-32: Moving frontend code to the base of the repo (#9098)
* move assets out, get webpack dev working

* update docs to reference superset-frontend

* draw the rest of the owl

* fix docs

* fix webpack script

* rats

* correct docs

* fix tox dox
2020-02-09 17:53:56 -08:00