Address /review-code findings — the previous round's hardening fixed
flake but a few assertions still gave weak signals:
- The chart-rendered selector matched a still-loading chart cell, since
Superset's `Loading` spinner itself renders an SVG. Exclude the spinner
via `:not(:has([data-test="loading-indicator"]))` and centralize the
selector as `EmbeddedPage.RENDERED_CHART_SELECTOR`.
- The "dashboard renders" test only proved iframe/header chrome, not the
dashboard. Add `waitForChartRendered()` so the test name matches what
it asserts.
- The `hideTitle` test passed for the wrong reason if the locator
drifted (`toBeHidden()` succeeds for absent elements). Add an explicit
`toHaveCount(0)` so the contrast against the baseline visibility check
in test 1 is load-bearing.
- `tokenCallCount` was a `>=1` check that any rendered dashboard would
satisfy. Tighten to `=== 1` to actually exercise the SDK's caching
contract.
- Drop the redundant `appUrl` shadow of `appServer.url`.
- Move `import os` to module top in the docker-light config; document
the strict `"true"`-only env-var truthiness convention.
Pre-commit clean (type-check, prettier, oxlint, ruff, mypy). Local
re-verification blocked by an unrelated worktree env issue (semantic
layers feature has incomplete state — the docker-compose-light stack
doesn't bind-mount superset-core/, so the image's stale copy lacks the
new submodule); CI on the chromium-embedded project will validate.
Changes are strictly stronger assertions and refactors so they cannot
turn a previously-passing test into a false positive.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Three additions to the lightweight local config so the embedded-dashboard
flow works against docker-compose-light without manually patching state:
- Read SUPERSET_FEATURE_<NAME> env vars into FEATURE_FLAGS so a docker
.env-local can toggle features without editing tracked config.
- Disable Talisman so /embedded/<uuid> doesn't serve X-Frame-Options:
SAMEORIGIN, which otherwise blocks cross-origin iframe embedding.
- Mirror Public to Gamma via PUBLIC_ROLE_LIKE so guest tokens can hit
/api/v1/me/roles/ (CI does this implicitly via load_test_users; the
light stack does not).
Required for the chromium-embedded Playwright project to run locally.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* remove depracted keys and associated methods
* remove api methods and tablemodel views
* remove deprecated api and unsued vars
* reremove schedules
* readd code
* fix pylint
* run black
* remove test
* core select start test
* add suggested changes
* fixed whitespace
* commit exclusion of package-lock from large file size precommit hook
* Converted all PNG files to JPG files to save space, stay under <500kb file size
* added link to release notes for 1.0
* chore: Adding pip-compile-multi et al
* Specify requirements.txt path for fossa
* [ci] Fixing CI
Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
* chore: bump pyhton dependencies
* bump flask-testing
* Add note to UPDATING and bump flask-testing in requirements-dev.txt
* fix old sqlparse test case that is fixed with sqlparse==0.3.1
* Fix migration and sqlparse set test
* downgrade alembic
* Downgrade sqlalchemy-utils
* pin sqlalchemy-utils due to regression in 0.36.5
* Refine comment in setup.py
* make cachelib an explicit requirement
* Splitting up some of the Docker build steps
* Adding dev target which includes requirements-extra / Updating docker configs to handle async query running
