Commit Graph

4035 Commits

Author SHA1 Message Date
Beto Dealmeida
705bad9792 fix: revert data endpoint name (#16162)
(cherry picked from commit 7b3fce7e81)
2021-08-11 09:33:23 -07:00
Elizabeth Thompson
86d079b31c add config to hide some user menu items (#16156)
(cherry picked from commit 5488a8a948)
2021-08-11 09:33:05 -07:00
Phillip Kelley-Dotson
7c5546586c fix: ensure that users viewing chart does not automatically save edit data (#16077)
* add last_change_at migration

* add last_saved_by db migration

* finish rest of api migration

* run precommit

* fix name

* run precommitt

* remove unused mods

* merge migrations

* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/migrations/versions/f6196627326f_update_chart_permissions.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* fix test

* precommit

* remove print

* fix test

* change test

* test commit

* test 2

* test 3

* third time the charm

* fix put req

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
(cherry picked from commit f0e3b68cc2)
2021-08-11 09:32:28 -07:00
Ville Brofeldt
9e21009db3 feat(cross-filters): add support for temporal filters (#16139)
* feat(cross-filters): add support for temporal filters

* fix test

* make filter optional

* remove mocks

* fix more tests

* remove unnecessary optionality

* fix even more tests

* bump superset-ui

* add isExtra to schema

* address comments

* fix presto test

(cherry picked from commit 63ace7b288)
2021-08-11 09:31:32 -07:00
Yongjie Zhao
79e4253230 fix: boolean type into SQL 'in' operator (#16107)
* fix: boolean type into SQL 'in' operator

* fix ut

* fix ut again

* update url

* remove blank line

(cherry picked from commit bb1d8fe4ef)
2021-08-11 09:31:14 -07:00
Maxime Beauchemin
f8f3b7abbb chore: add stats logging to thumbnail api (#16133)
(cherry picked from commit df50a47777)
2021-08-11 09:27:19 -07:00
David Aaron Suddjian
08e64048fa fix(explore): drag & drop column select component triggering onChange unnecessarily (#16073)
* fix(explore): avoid sync until after first render

* fix example

(cherry picked from commit e6292a89bb)
2021-08-11 09:25:57 -07:00
Beto Dealmeida
18f551580e fix: migrate_roles (#16098)
(cherry picked from commit 28c383af68)
2021-08-06 10:08:54 -07:00
Beto Dealmeida
d85875d962 fix: load tabbed dash only for tests (#16091)
(cherry picked from commit b72fd7b9f4)
2021-08-06 10:08:54 -07:00
Beto Dealmeida
a16605cf01 chore: simplify chart permissions (#16078)
(cherry picked from commit 1dbd1e9f02)
2021-08-06 10:08:54 -07:00
Ville Brofeldt
87fad13f89 feat(explore): add automatic conditional formatter to pivot table v2 (#16045)
(cherry picked from commit 7ef97a54e2)
2021-08-06 10:08:54 -07:00
Beto Dealmeida
69c5cd7922 feat: handle subtle bug with load-examples (#16052) 2021-08-03 12:44:44 -07:00
Beto Dealmeida
ec22acb786 fix: handle schemas_allowed_for_csv_upload serde (#16038)
* fix: handle schemas_allowed_for_csv_upload serde

* Add migration
2021-08-03 09:10:32 -07:00
Erik Ritter
7c059cda39 fix: make dataset update methods static instead of global (#16044) 2021-08-03 08:47:52 -07:00
Beto Dealmeida
7b15b7690d fix: DB exported with incorrect type (#16037)
* fix: DB exported with incorrect type

* Fix export as well
2021-08-03 08:35:48 -07:00
Hugh A. Miles II
4cb79e5017 fix: Fix long dashboards screenshot emails (#15954)
* create serialize json function

* create new setting for reports

* cleanup

* address comments

* up the attributes
2021-08-02 16:37:34 -04:00
John Bodley
41e8190575 chore: Use datetime.timedelta for defining durations in config (#16029)
* chore: use datetime.timedelta for defining durations

* Update config.py
2021-08-03 08:22:30 +12:00
John Bodley
c0615c55df fix: Ensure table uniqueness on update (#15909)
* fix: Ensure table uniqueness on update

* Update models.py

* Update slice.py

* Update datasource_tests.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-08-03 07:45:55 +12:00
Yongjie Zhao
3f57ea76db fix: missing mulitiple metrics on pivot operator (#16026)
* fix: missing mulitiple metrics on pivot operator

* code smell
2021-08-02 11:37:10 -07:00
Elizabeth Thompson
5031a67597 feat: Self subscribe reports (#16027)
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2021-08-02 09:12:09 -07:00
Ville Brofeldt
c77bf264d1 fix(native-filters): add support for versioned import/export (#16017)
* fix(native-filters): add support for versioned import/export

* fix lint

* address CR

* make query_context nullable
2021-08-02 16:10:57 +03:00
Yongjie Zhao
a786373fff feat: auto sync table columns when change dataset (#15887)
* feat: auto sync dataset metadata when change dataset

* diablo sync button when edit mode

* handle undefine schema

* fix py UT

* fix FE UT

* improve test coverage

* fix UT
2021-08-02 16:55:31 +08:00
Yongjie Zhao
c01d42fd98 fix: eliminate cartesian product columns in pivot operator (#15975)
* fix: eliminate cartesian product columns in pivot operator

* wip

* wip

* minor tip
2021-07-31 16:02:04 +08:00
Jesse Yang
b73d7baedf fix(dashboard): FilterBox JS error when datasets API is slow (#15993) 2021-07-30 22:06:29 -07:00
Beto Dealmeida
2d61f15153 feat: send post-processed data in reports (#15953)
* feat: send post-processed data in reports

* Fix tests and lint

* Use enums

* Limit Slack message to 4k chars
2021-07-30 09:37:16 -07:00
Beto Dealmeida
f4739f427e feat: post-processing for pivot table v2 (#15879)
* feat: add pivot v2 post-processing

* Fix lint
2021-07-29 11:05:56 -07:00
Beto Dealmeida
6afa840659 feat: send report data to Slack (#15806)
* feat: send data embedded in report email

* Change post-processing to use new endpoint

* Show TEXT option only to text-based vizs

* Fix test

* feat: send data embedded in report email

* feat: send report data to Slack

* Add unit test

* trigger tests
2021-07-29 10:13:28 -07:00
Michael S. Molina
7b0acc45de chore: Changes the main menu order as defined in SIP-34 (#15929) 2021-07-28 16:47:07 -03:00
Hugh A. Miles II
bfe7eb9a7b feat(dbc ui): Adding Google Sheets Dynamic Form (#15801)
* feat: Make Google Sheets Dyanmic (#15576)

* first draft

* second draft

* added tests

* first draft

* added table_catalog

* remove console.log

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* revisions

* save this for now

* working form

* save disable on public sheets

* refactor somethings

* saving this for now

* working edit

* add back query to schema

* working add

* fix styling

* fixing x

* fix linting

* prettier

* fix some type issues

* more lint fixes

* remove unused dependency

* fix linint

* fix validation

* pylint bypass

* pylint bypass

* fix this

* fix mypy

* yerp

* fix test

* fix test

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* wrap add sheets

* fix linting issues

* fix unit test

* ignore typing

* fix editting and paste issues

* remove query

* fix this

* fix test

* add test back

* fix error messaging

* update url messaging on error

* change error type

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* add errors for sheets with no name

* fix

* fix messaging for gsheets

* stop pylint

* update line

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: Arash <arash.afghahi@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-07-28 15:00:27 -04:00
John Bodley
671b8f2544 chore: Mypy fix **kwargs type (#15823)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-29 04:59:20 +12:00
Beto Dealmeida
3adf8e85cd feat: send data embedded in report email (#15805)
* feat: send data embedded in report email

* Prettify table

* Change post-processing to use new endpoint

* Show text option only for text viz

* Show TEXT option only to text-based vizs

* Fix test

* Add email test

* Add unit test
2021-07-28 09:43:04 -07:00
Yongjie Zhao
32d2aa0c40 feat: run extra query on QueryObject and add compare operator for post_processing (#15279)
* rebase master and resolve conflicts

* pylint to makefile

* fix crash when pivot operator

* fix comments

* add precision argument

* query test

* wip

* fix ut

* rename

* set time_offsets to cache key

wip

* refactor get_df_payload

wip

* extra query cache

* cache ut

* normalize df

* fix timeoffset

* fix ut

* make cache key logging sense

* resolve conflicts

* backend follow up iteration 1

wip

* rolling window type

* rebase master

* py lint and minor follow ups

* pylintrc
2021-07-28 22:34:39 +08:00
Yongjie Zhao
11b0249803 fix: remove unused time column when update dataset (#14969)
* fix: remove unused time column when update dataset

* fix lint

* set dttm to first datatime column
2021-07-28 21:40:16 +08:00
Elizabeth Thompson
ea49aa3d2d feat: add timezones to report cron (#15849)
* add timezones to report cron

* fix test
2021-07-27 18:28:24 -07:00
Beto Dealmeida
2ce676d20d feat: call screenshot to store query_context (#15846)
* feat: call screenshot to store query_context

* Add unit test

* Move updateQueryContext to ExploreChartPanel

* Add error handling

* Fix code

* Fix logic
2021-07-27 14:02:27 -07:00
aspedrosa
e5540b79ec fix: no roles being returned for anonymous user (#15585) 2021-07-27 12:22:39 -06:00
Kamil Gabryjelski
3f5237a3c1 feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set (#15864)
* feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set

* Lint fix

* Set autocomplete to True in example datasets

* Use "IN" as a default operator in dnd filters

* Default operator only if UX_BETA enabled
2021-07-27 17:40:10 +02:00
Beto Dealmeida
eeba326f8b chore: set UUID of examples DB (#15724) 2021-07-26 17:45:48 -07:00
chuancy
2d0056507b Incorrect translations (#15813) 2021-07-26 17:41:06 -06:00
Hugh A. Miles II
62550db385 fix: Update Query Context on Explore loading (#15865)
* create serialize json function

* saving for now

* saving for now

* lint

* cleanup

* fix network request

* update test

* Update tests/integration_tests/charts/api_tests.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-07-26 12:43:25 -07:00
Beto Dealmeida
2f95f81be7 feat: apply post processing to chart data (#15843)
* feat: apply post processing to chart data

* Fix tests and lint

* Fix lint

* trigger tests
2021-07-26 10:58:59 -07:00
John Bodley
6d3e19d857 fix(15403): Re-enable canceling query for Hive and Presto (#15878)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-26 08:04:56 -07:00
John Bodley
65728ea049 fix(15482): Propagate SupersetSecurityException error (#15874)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-24 10:19:49 +12:00
John Bodley
4ba17092fa fix: Ensure SupersetError.extra is always a dict (#15848)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-24 10:19:30 +12:00
Beto Dealmeida
f9b72505fb fix: revert DEFAULT_SQLLAB_LIMIT to default (#15869) 2021-07-23 11:38:42 -07:00
Elizabeth Thompson
c1eb9cec49 add timezone to report schedule (#15747) 2021-07-22 15:36:15 -07:00
Kamil Gabryjelski
5e1c469f42 feat(explore): default aggregate for string/numeric columns when creating metric (#15798)
* feat(explore): default aggregate for string/numeric columns when creating metric

* Fix for editing items with the same label

* Replace componentDidUpdate with getDerivedStateFromProps

* Wrap changes in feature flag
2021-07-22 18:23:10 +02:00
Beto Dealmeida
f6fe29db87 feat: use new API endpoint to build CSV reports (#15830)
* feat: add `GET /api/v1/chart/{chart_id}/data/?format{format}` API

* feat: use new API endpoint to build CSV reports
2021-07-21 17:50:56 -07:00
Beto Dealmeida
211319673f fix: publish the new example dashboards (#15803)
* fix: publish the new example dashboards

* Fix tests
2021-07-21 17:26:03 -07:00
Beto Dealmeida
f104fba61d feat: add GET /api/v1/chart/{chart_id}/data/?format{format} API (#15827)
* feat: add `GET /api/v1/chart/{chart_id}/data/?format{format}` API

* Fix test
2021-07-21 17:03:22 -07:00