Commit Graph

3315 Commits

Author SHA1 Message Date
Lily Kuang
2eb400a2fc chore: remove SIP_34_SAVED_QUERIES_UI feature flag (#11175) 2020-10-06 15:13:41 -07:00
Jesse Yang
38dccf9e12 fix: enable consistent etag across workers and force no-cache for dashboards (#11137)
* fix: enable consistent etag across workers

* Use CACHE_DEFAULT_TIMEOUT instead of 0

* Change timeout to 0 and set expires header even for no-cache

* Reduce number of if branches to appease Pylint

* Fix mypy error
2020-10-06 09:43:43 -07:00
John Bodley
5e0603f957 chore: Remove obsolete creating missing metric permissions (#11143) 2020-10-04 09:16:29 -07:00
Ville Brofeldt
662fb43350 fix(examples): missing expressions in birth_names (#11141)
* fix(examples): missing expressions in birth_names

* disable flaky tests
2020-10-02 23:47:38 +03:00
John Bodley
e90c63fc7b fix: Alembic migration 18532d70ab98 (#11136) 2020-10-02 09:12:03 +01:00
ʈᵃᵢ
017e5acd14 style(listview): dynamic card size and grid spacing (#11111) 2020-10-01 15:44:42 -07:00
Daniel Vaz Gaspar
4c85d33109 feat: custom favorite filter for dashboards, charts and saved queries (#11083)
* feat: custom favorite filter for dashboards

* lint and sort

* add favored for charts

* fix tests and lint

* more tests and saved query filter

* fix tests

* fix tests

* lint

* lint and fix conflict

* remove unnecessary prop

* separate tests
2020-10-01 15:08:40 -07:00
Elizabeth Thompson
33906c6895 fix: remove extra flash import (#11121)
* remove extra flash import

* remove yml from accepted file types
2020-10-01 14:09:30 -07:00
Daniel Vaz Gaspar
50d80405a9 fix: alembic migration error msg trying to delete constraint on tables (#11115)
* fix: alembic migration fails by deleting non existent constraint on tables

* Revert "fix: alembic migration fails by deleting non existent constraint on tables"

This reverts commit 3a359b0577.

* mantain migration but just for MySQL and add downgrade procedure

* skip the downgrade
2020-10-01 12:35:12 +01:00
Daniel Vaz Gaspar
fdb26f6131 feat: CRUD REST API for CSS Templates (#11114)
* feat: CSS Template CRUD API

* fix API docs

* fix copy pasta

* lint
2020-10-01 11:46:25 +01:00
Moriah Kreeger
e7a4265c30 feat: saved query list actions (#11109) 2020-09-30 18:18:34 -07:00
Lily Kuang
5b284e67eb feat: add created by chart CRUD view (#11067) 2020-09-30 13:53:04 -07:00
Kalyan
0bcc9d77a7 fix: Disabling timezone of dataframe before passing Prophet (#11107)
* fix: Disabling timezone of dataframe before passing Prophet 

While running forecasting with Druid. Prophet throws the following exception. This PR removes the timezone info. 
ValueError: Column ds has timezone specified, which is not supported. Remove timezone
https://github.com/apache/incubator-superset/issues/11106

@villebro

* Update pandas_postprocessing.py

* Update superset/utils/pandas_postprocessing.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-09-30 21:38:37 +03:00
Ville Brofeldt
ada66e30dd fix(chart-data-api): ignore missing filters (#11112) 2020-09-30 09:34:23 +01:00
Erik Ritter
fa5dab85c4 feat: more specific presto error messages (#11099) 2020-09-29 21:50:58 -07:00
Bogdan
94d4d55908 Fix alembic migration (#11110)
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-09-29 16:35:00 -07:00
Bogdan
03eebd3019 fix: fix table existence validation function (#11066)
* Fix table existance validation function

* Drop left over table name index in mysql db

* Do not modify model

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-09-29 15:01:01 -07:00
Moriah Kreeger
b8d616a9d2 feat: saved query list view + sort/filters (#11005) 2020-09-29 13:39:10 -07:00
John Bodley
4ccba3072d chore: Remove Obsolete WARNING_MSG from config (#10972) 2020-09-29 12:33:02 -07:00
Grace Guo
6633409a15 feat: enable ETag header for dashboard GET requests (#10963)
* feat: add etag for dashboard load requests

* fix review comments
2020-09-29 10:57:16 -07:00
Kasia Kucharczyk
89bf76553e Updated lint in schedules.py in tasks: unused_import, ungrouped_import and changed argument name to remove unused-argument (#11045) 2020-09-29 08:10:46 -07:00
Daniel Vaz Gaspar
5d08a426d3 fix(api): unable to delete virtual dataset, wrong permission name (#11019)
* fix(api): unable to delete virtual dataset because of wrong permission name

* Still delete the dataset even when no permission was found

* migration script to fix possible existing faulty permissions on the db

* black

* fix db migration and one more test

* add more comments to the migration script

* freeze a partial schema of the model on the migration step

* fix mig script

* Update superset/migrations/versions/3fbbc6e8d654_fix_data_access_permissions_for_virtual_.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-09-29 12:33:07 +01:00
Ville Brofeldt
80e395559d fix: echarts timeseries groupby (#11103)
* fix: echarts timeseries groupby

* address review comment
2020-09-29 14:25:38 +03:00
Kasia Kucharczyk
3a08fd04f3 chore: pylint fixes in files in project's root (#11064)
* Pylint rule: not necesary unused-import in extensions.py. Autofomatted

* Pylint rule: not necesary unused-import in jinja_context.py. Autofomatted

* Pylint rule: not necesary no-value-for-parameter in stats_logger.py. Autofomatted

* Pylint rule: not necesary no-member in viz.py

* Pylint rule: not necesary no-member in viz_sip38.py
2020-09-28 14:32:45 -07:00
Kasia Kucharczyk
690e27e5fd chore: updated utils with pylint rules (#11062)
* Updated pylint in cache.py in utils: unecessary bad-whitespace. Autoformatting

* Updated pylint in core.py in utils: E0202.

* Updated pylint in logging_configurator.py in utils: disable=no-member. Formatting

* Updated pylint in machine_auth.py in utils: unused-import

* Updated pylint in screenshots.py in utils: unused-import and import-error

* Updated pylint in webdriver.py in utils: unused-import
2020-09-28 14:32:06 -07:00
ʈᵃᵢ
1dc05d4c12 feat(charts): modify custom api filter to include more fields (#11054) 2020-09-28 10:18:34 -07:00
Erik Ritter
0f7e90f1f7 feat: improve presto query perf (#11069) 2020-09-28 08:52:00 -07:00
Lily Kuang
ea105bc23b feat: add "created by" to dashboard CRUD view (#11030) 2020-09-24 14:33:55 -07:00
Kasia Kucharczyk
92dd257ef4 Changed tags.py and helpers.py in models module: removed disabled pylint rule unused_import, changed unused arguments to private and removed disabled rule unused-argument. Removed redundant rules. (#11037) 2020-09-24 13:50:09 -07:00
Kasia Kucharczyk
63d0e801ad chore: updated lint rules in models module (#11036)
* Removed disabled pylint rule `unused_import` from `dashboards.py` in `models` module. Added missing break in too long line. Formatting.

* Changed `datasource_access_request.py` in models` module: removed disabled pylint rule `unused_import`, removed `no-member` disabled rules which aren't needed. Formatting

* Changed `slice.py` in models` module: removed disabled pylint rule `unused_import`, changed unused arguments to private and removed disabled rule `unused-argument`
2020-09-24 13:49:00 -07:00
Kasia Kucharczyk
eba1aa8a53 Enabled argument-differ for bulk_delete (#11039) 2020-09-24 13:47:00 -07:00
Kasia Kucharczyk
7ca4192fe6 Enabled no-self-use pylint rule in security. Formatter (#11041) 2020-09-24 13:46:21 -07:00
Kasia Kucharczyk
8bc05bda6f Changed variable name from capitals to lowercase and changed lint rule (#11044) 2020-09-24 13:45:19 -07:00
ʈᵃᵢ
eded51b2f8 feat(saved_queries): add custom api filter for all string & text fields (#11031) 2020-09-24 11:05:25 -07:00
Bogdan
b2fdf12f62 Support jinja templates (#11008)
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-09-24 10:29:44 -07:00
Ville Brofeldt
6181994084 chore: bump pandas to latest stable version (#11018)
* chore: bump pandas to latest stable version

* fix nest_values
2020-09-24 13:11:10 +03:00
Kasia Kucharczyk
af1e8e8839 fix: enable several pylint rules partially in db_engines_specs module (#11000)
* Enabled mssql

* Enabling pylint rules in `mysql.py` from `db_engine_specs`:
- added variable to shorten line and enable `line-too-long`
- `import-error` seems not prompting anymore
- specified exception instead broad-except

* Refactored too long line in `oracle.py` from `db_engine_specs`. Enabled too-long-line pylint rule.

* Changed fstring into string `pinot.py` to reenable `f-string-without-interpolation` rule.

* Enabled `unused-import` rule and changed line to adjust to correct number of characters in `db_engine_specs/postgres.py`.

* Enabled unused-import pylint check in `db_engine_specs/presto.py`

* Enabled unused-import pylint check in `db_engine_specs/snowflake.py`

* Enabled unused-import pylint check in `db_engine_specs/sqlite.py`
2020-09-23 10:47:56 -07:00
Kasia Kucharczyk
fb6f14c469 fix: pylint checks in connectors/sqla/models.py (#10974)
* Removed unused pylint rule `too-many-instance-attributes` from SqlaTable class.

* Removed unecessary rule: `bad-whitespace` from `get_sqla_query` method

* Disabling too-many-instance-attributes since it fails on CI
2020-09-23 10:47:12 -07:00
Kasia Kucharczyk
bade279883 fix: reenable pylint rule unused-import in charts and connectors modules (#11014)
* Removed disabled pylint rule `unused_import` from `dao.py` in `charts` module

* Removed disabled pylint rule `unused_import` from `connector_registry.py` in `connectors` module
2020-09-23 10:46:44 -07:00
Kasia Kucharczyk
26fcc08906 Enabled pylint rules in db_engines module: (#11016)
- `unused_import` and `import_error` - not promting anymore
- changed unused param to private and removed `unused_argument`
2020-09-23 10:45:26 -07:00
Kasia Kucharczyk
a26f29e7c8 fix: changes a pylint check in dashboard module (#10978)
* Removed not needed disabled pylint rules from `set_dash_metadata`:
- `disable=too-many-locals`,
- `too-many-branches`,
- `too-many-statements`

* Changed broad exception to KeyError.

* Reverted broad_exception in get_col_type in utils
2020-09-23 10:26:22 -07:00
Daniel Vaz Gaspar
ba009b7c09 fix: query search low privileged user search access denied (#11017) 2020-09-23 14:16:24 +01:00
ʈᵃᵢ
50852dfbbf chore: downgrade expected exception from error to info (#10994)
* chore: reduce number of error logs

* info -> warning
2020-09-23 12:05:44 +01:00
ʈᵃᵢ
0d1f6119a6 feat(listview): feature flag config to set default viewing mode (#10986) 2020-09-22 18:01:19 -07:00
Kasia Kucharczyk
a6f258747b fix: enable pylint rules in db_engine_specs module (#10998)
* Athena.py: cretaed variable for too long line, removed disabled pylint rule.

* Enabled `line-too-long` in `drill.py`. Added variable for too long string.

* Reformatted hana.py:
- changed return statement into two lines to keep line lenght limit

* Enabling pylint rule in hive.py:
- `no-name-in-module` for pyhive in several places
- `line-too-long` and adding new lines
- `unused-import` is not invalid anymore

* Enabled `line-too-long` in `kylin.py`. Added variable for too long string.

* Enabled `unused_import` in `base.py` from db_engine_specs module.

* Enabled `unused_import` in `bigquery.py` from db_engine_specs module.

* Enabled `unused_import` in `druid.py` from db_engine_specs module.

* fix: athena datetime string converting
2020-09-22 13:44:45 -07:00
Ville Brofeldt
a9eab33d64 feat: add ECharts Pie chart (#10966)
* feat: introduce echarts pie chart

* lint

* remove viz.py shim

* remove tests

* fix cypress test

* fix test
2020-09-22 19:27:40 +03:00
Beto Dealmeida
0554c8918e Enable subqueries in gsheetsdb (#10991) 2020-09-22 08:51:29 -07:00
Karthikeyan Singaravelan
95ba8e1fb7 fix: deprecation warnings due to invalid escape sequences. (#10710)
* fix: Fix deprecation warnings due to invalid escape sequences.

* fix: Fix black related errors.
2020-09-22 16:03:58 +01:00
Ville Brofeldt
bd140e018a fix(presto): default unknown types to string type (#10753)
* fix(presto): default unknown types to string type

* lint
2020-09-22 13:16:54 +03:00
Ville Brofeldt
448a41a4e7 feat(row-level-security): add base filter type and filter grouping (#10946)
* feat(row-level-security): add filter type and group key

* simplify tests and add custom list widget

* address comments

* use enum value to ensure case sensitive value is used
2020-09-22 08:54:10 +03:00