Commit Graph

100 Commits

Author SHA1 Message Date
Ville Brofeldt
b954f8f560 feat(welcome): make examples tab customizable (#22302) 2022-12-21 09:28:41 +02:00
Lyndsi Kay Williams
ba65f66897 fix: Change downloadAsImage to use Superset theme (#22011) 2022-11-02 21:24:10 -05:00
Yongjie Zhao
429f246f7a refactor: clean up codes (#22002) 2022-11-03 00:16:10 +08:00
Ville Brofeldt
dc7399540b chore: bubble up more db error messages (#21982) 2022-11-01 07:54:27 +02:00
Eric Briscoe
d1807db041 fix: Adds logging for SPA route navigation with React router (#21960) 2022-10-28 13:00:45 -07:00
Kamil Gabryjelski
406e44bba1 perf(dashboard): Virtualization POC (#21438) 2022-10-11 15:06:00 +02:00
JUST.in DO IT
2d70ef670e feat(sqllab): Make LeftBar width resizable (#21300) 2022-09-01 21:26:20 -07:00
Kamil Gabryjelski
076af6003a fix(explore): Incorrect conversion from simple bool filter to custom sql (#21293) 2022-09-01 17:06:42 +02:00
JUST.in DO IT
4e23d62d4f fix(sqllab): missing zero values while copy-to-clipboard (#21153) 2022-08-26 14:28:48 -07:00
Lyndsi Kay Williams
d42cf4e4c9 fix: Columns not passing properly from SQL Lab to Explore (#20975)
* debugging columns

* Clean up code

* Fix test
2022-08-04 14:59:50 -04:00
Lyndsi Kay Williams
8a04536f9d feat(SqlLab): Change Save Dataset Button to Split Save Query Button IV (#20852)
* Moving entire split save btn PR

* Addressed review comments

* Remove arbitrary div from ErrorBoundary in Chart

* Added accidentally removed comment

* Fix act errors in SaveQuery tests

* Fix SaveDatasetActionButton test

* SaveDatasetModal test almost working

* SaveDatasetModal tests all passing

* Clean SaveDatasetModal test

* Fix create chart button and SaveDatasetModal text in SQL Lab

* Fix untitled dataset name on SaveDatasetModal in explore

* Fix styling on split save button
2022-08-01 14:36:34 -05:00
Kamil Gabryjelski
6ec164e6a9 feat: Use SPA navigation from datasets list to Explore (#20890)
* feat: Use SPA navigation from datasets list to Explore

* fix lint

* Fix lint

* Fix type

* Make external links work without protocols

* add comment
2022-08-01 16:45:07 +02:00
Hugh A. Miles II
0d8889dc9c fix: Save dataset + chart when Chart source is Query (#20880)
* feat: save dataset savemodal

* fix lint

* add comments

* enable chart power query

* clean up

* added test

* fix overwrite

* add proper error messaging for save datasetModal

* lint

* fix ts lint

* fix

* Disables Save button while network call is in progress, removing second Chart saved toast message

* change naming

* err

* Update superset-frontend/src/explore/components/SaveModal.tsx

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

* Update SaveModal.tsx

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-07-29 17:30:28 -04:00
Kamil Gabryjelski
0945d4a2f4 feat: Pass dashboard context to explore through local storage (#20743)
* feat: Pass dashboard context to explore through local storage

* Remove console log

* Remove unused local storage keys

* Fix lint

* Fix link

* Fix UT

* fix lint

* fix prettier

* Fix bug

* Fix bug with some sample dashboards

* Roll back unnecessary change

* style fix

* Add comments

* Fix lint

* Address code review comments

* Fix
2022-07-25 16:44:43 +02:00
Just[in]Do it!
1debacaaca feat(dashboard): Make FilterBar width resizable (#20778)
* Add Resizable panel in DashboardBuilder to adjust the width for FiltersPanel
* store the adjusted width for individual dashboard in localStorage to memorize the state
* migrate DashboardBuilder test code by testing-library and jest
2022-07-20 09:56:55 -07:00
Cody Leff
84d4302628 fix(explore): Fix chart standalone URL for report/thumbnail generation (#20673)
* Update explore URLs.

* More URL fixes.

* Make frontend accept true/false query params case-insensitively.

* Fix URL mistake.

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-07-19 13:53:55 -03:00
Hugh A. Miles II
e5e8867394 feat: Visualize SqlLab.Query model data in Explore 📈 (#20281) 2022-07-15 19:34:02 -04:00
Michael S. Molina
662bab1e6d feat: Renders Explore in SPA (#20572)
* feat: Renders Explore in SPA

* Adds permalink support

* Replaces navigation from Welcome page

* Fix initializing feature flags

* Remove redundant import

* Adds saveSlice workaround

* Fixes paths

* Fixes lint error

* Fixes tests

* Fix url to explore from Datasets view

* Fix explore page height

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-07-05 16:58:09 -03:00
Phillip Kelley-Dotson
9da7c1f7b8 feat: hack db connection modal ctabtns (#20017)
* add flow for dbconnmodal to datasetmodal

* fix bug

* second part

* fix dataset to sql lab

* fix lint

* more lint

* add key value

* fix type

* add new styling

* remove undefined from types
2022-07-05 08:56:12 -07:00
Jesse Yang
cadd259788 feat: save active tabs in dashboard permalink (#19983) 2022-06-29 09:43:52 -07:00
Diego Medina
c5d3678a31 fix: Unable to download the Dashboard as image in case there's an image added through Markdown (#20362)
* fix: Unable to download the Dashboard as image in case there's an image added through Markdown

* licence
2022-06-30 00:22:49 +08:00
Kamil Gabryjelski
c7f1c7d5bd chore: Restructure explore redux state (#20448)
* chore: Restructure explore redux state

* fixes

* fix tests

* add new tests

* Fix type

* Address comments

* Fix bug

* Fix import

* Add new test

* Move unsaved chart id to a constant

* Add todo
2022-06-24 15:26:07 +02:00
Michael S. Molina
d6f9fb5af1 chore: Removes unused vars (#20194)
* chore: Removes unused vars

* Fixes lint

* Disables no-unused-vars for the operators
2022-06-15 11:01:45 -03:00
Michael S. Molina
cb2ffa530f chore: Removes no-use-before-define warnings (#20298) 2022-06-13 07:44:34 -03:00
Diego Medina
0e38c686c6 fix: Support the Clipboard API in modern browsers (#20058)
* fix: Support the Clipboard API in modern browsers

* fix tests

* PR comment

* Improvements
2022-06-03 19:34:00 +08:00
Michael S. Molina
834dcef993 chore: Moves date utils to utils folder (#20192) 2022-05-31 12:21:58 -03:00
Ville Brofeldt
e766f8cb57 fix(explore): handle null control sections (#20142)
* fix(explore): handle null control sections

* fix type and add null to test fixture
2022-05-20 19:07:53 +03:00
Ville Brofeldt
0bcc21bc45 chore(data-table): make formatted dttm the default (#20140)
fix test
2022-05-20 15:39:10 +03:00
Jesse Yang
7b88ec7e25 refactor(ReportModal): simplify state reducer and improve error handling (#19942) 2022-05-05 10:06:40 -07:00
Ville Brofeldt
e061955fd0 fix(dashboard): copy permalink to dashboard chart (#19772)
* fix(dashboard): copy permalink to dashboard chart

* lint

* address comments
2022-04-19 22:34:41 +03:00
Kamil Gabryjelski
6f4480a06c feat(explore): Replace overlay with alert banner when chart controls change (#19696)
* Rename explore alert

* Rename refreshOverlayVisible to chartIsStale

* Implement banners

* Add tests

* Add clickable text to empty state

* Fix viz type switching

* styling changes

* Fixes after rebasing

* Code review fixes

* Fix bug

* Fix redundant refreshing
2022-04-19 14:57:06 +02:00
Ville Brofeldt
b7ecb14230 fix(dashboard): fix default filter bar visibility + add docs (#18741)
* fix(dashboard): fix default filter tab visibility + add tests

* fix types

* lint

* rename docs + add double bang to length
2022-03-23 08:55:03 +02:00
Ville Brofeldt
b7a0559aaf feat: add permalink to dashboard and explore (#19078)
* rename key_value to temporary_cache

* add migration

* create new key_value package

* add commands

* lots of new stuff

* fix schema reference

* remove redundant filter state from bootstrap data

* add missing license headers

* fix pylint

* fix dashboard permalink access

* use valid json mocks for filter state tests

* fix temporary cache tests

* add anchors to dashboard state

* lint

* fix util test

* fix url shortlink button tests

* remove legacy shortner

* remove unused imports

* fix js tests

* fix test

* add native filter state to anchor link

* add UPDATING.md section

* address comments

* address comments

* lint

* fix test

* add utils tests + other test stubs

* add key_value integration tests

* add filter box state to permalink state

* fully support persisting url parameters

* lint, add redirects and a few integration tests

* fix test + clean up trailing comma

* fix anchor bug

* change value to LargeBinary to support persisting binary values

* fix urlParams type and simplify urlencode

* lint

* add optional entry expiration

* fix incorrect chart id + add test
2022-03-17 01:15:52 +02:00
Grace Guo
d539fc217a fix(time-series table): display null values in time-series table and sortable (#19024)
* fix: display null values in time-series table and sortable

* add unit test

* fix unit test

* Add sortNumericValues with different nan treatment

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2022-03-08 17:03:49 -08:00
Jesse Yang
c75f233109 feat(select): sort exact and startsWith match to first (#18856) 2022-03-08 07:08:40 -08:00
Kamil Gabryjelski
9d5c0505cf feat(native-filters): Re-arrange controls in FilterBar (#18784)
* feat(native-filters): Re-arrange controls in FilterBar

* Typo fix

* Add tests

* Fix tests

* Address PR reviews

* Add 1px bottom padding to icon

* Fix test

* Tiny refactor

* Change buttons background

* Add hover state to Clear all button

* Fix Clear All button logic so it clears all selections

* Remove redundant useEffect

* Set zindex higher than loading icon

* Fix scrolling issue
2022-02-22 17:45:53 +01:00
simcha90
bcad1acec2 feat: Dynamic dashboard component (#17208)
* fix:fix get permission function

* feat: dynamic loading of dashboard components

* fix: revert image

* fix: fix py

* fix: fix py

* fix: pass state to dynamic component

* lint: add typing

* lint: fix lint

* lint: fix lint

* refactor: re-run pipeline

* fix: fix CR notes

* fix: fix CR notes

* move types and interfaces to core

* reorder exports

* rename Scope and Target

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2022-02-09 17:44:40 +02:00
Kamil Gabryjelski
830f2e71d3 feat(explore): Allow using time formatter on temporal columns in data table (#18569)
* feat(explore): Allow using time formatter on temporal columns in data table

* Fix data table loading

* Return colnames and coltypes from results request

* Fix types

* Fix tests

* Fix copy button

* Fix df is none

* Fix test

* Address comments

* Move useTimeFormattedColumns out of useTableColumns

* Make reducer more readable
2022-02-09 10:29:11 +01:00
Yongjie Zhao
20b4ae1ef9 fix: null value and empty string in filter (#18171) 2022-01-27 22:58:06 +08:00
Phillip Kelley-Dotson
cfd851aa13 fix: replace datamask with key from new key value api (#17680)
* afirst stage to ccheck to get initial datamask

* clean up code and update typescript

* remove consoles

* fix ts and update copy dashboard url

* use key when one doesn't exists

* lint clean up

* fix errors

* add suggested changes

* remove line

* add tests and add changes for copydashboard

* fix lint

* fix lint

* fix lint

* Update superset-frontend/src/dashboard/components/Header/index.jsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* add timeout

* fix test

* fix test, add qs to cypress and add suggestions

* add suggestions

* fix lint

* more suggested changes for backwards comapat

* fix lint

* cleanup naming and add qs parse to tests

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* more changes and fix lint

* remove nativefiler param

* fix path

* remove con

* simplify logic

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-12-21 09:08:48 -08:00
Erik Ritter
5b0aa27f2b feat: Persist SQL Lab autocomplete setting across tabs and visits (#17708) 2021-12-20 15:53:48 -08:00
Erik Ritter
6edc183c5f chore: Refactor localstorage into typesafe version (#17832) 2021-12-20 13:58:59 -08:00
Geido
12bd1fcde5 fix: Save properties after applying changes in Dashboard (#17570)
* Refactor PropertiesModal

* Update json_metadata fully

* Clean up

* Verify values

* Catch changed to metadata

* Always updated dashboard info on update

* Avoid unnecessary fetches

* Formt

* Fix copy dashboards

* Fixes onUpdate onCopy handlers

* Pylint

* Update tests

* Clean up

* Handle data on show

* Change Save to Apply

* Update Cypress save test

* Update Cypress edit prop test

* Update PropertiesModal test

* Fix duplicate request with cross filters

* Improve code style

* Fix typo

* Lint
2021-12-09 10:03:07 -07:00
Yongjie Zhao
9070b6b19c refactor(monorepo): stage 1 (#17427)
* skip geojson in pre-commit

update prettier

* update package.json

update package.json

u package

pkg

pkg2

* lint main repo 2

lint main repo

lint

* lintrc

lintrc 2

lintrc2

lintrc 3

lintrc

* fix import

* refresh lock file

* fix break line make @ts-ignore invalid

* update rat-excludes

rat-excludes

update rat-excludes

* update eslintrc.js

* lint lint lint
2021-11-17 15:31:36 +08:00
Geido
59a6502efe fix: Color consistency (#17089)
* Update label colors on the fly

* Clean up

* Improve getFormDataWithExtraFilters

* Improve code structure

* Remove labelColors from formData

* Exclude label_colors from URL

* Refactor color scheme implementation

* Clean up

* Refactor and simplify

* Fix lint

* Remove unnecessary ColorMapControl

* Lint

* Give json color scheme precedence

* Add label_colors prop in metadata

* Separate owners and dashboard meta requests

* Remove label_colors control

* bump superset-ui 0.18.19

* Fix end of file

* Update tests

* Fix lint

* Update Cypress

* Update setColorScheme method

* Use Antd modal body
2021-11-03 19:22:38 +02:00
Erik Ritter
80a459f43b feat: support disabling domain sharding with a query param (#17177) 2021-10-21 12:49:59 -07:00
Kamil Gabryjelski
860e481a97 fix(explore): timestamp format when copy datatable to clipboard (#17166)
* fix(explore): timestamp format when copy datatable to clipboard

* Fix test

* Fix test

* Use translation for aria label

* Memoize stringified cells

* Fix test
2021-10-21 16:05:14 +02:00
simcha90
37944e18d6 feat(Filter-sets): connect to api (#17055)
* fix:fix get permission function

* feat: filtersets new

* feat: connect filter sets to api

* lint: fix lint

* doc: add comment
2021-10-17 09:56:54 +03:00
Michael S. Molina
05632b9804 chore: Moves the stylesheets folder to the assets folder (#16880)
* chore: Moves the stylesheets folder to the assets folder

* Changes {src} to src
2021-09-30 09:28:38 -03:00
Michael S. Molina
9b17e86b44 chore: Moves messageToasts to the components folder (#14431)
* chore: Moves messageToasts to the components folder

* Rebases
2021-09-22 07:44:54 -03:00