Yongjie Zhao
9729ffd7a1
fix: reindex when combine metric in legacy pivot table ( #14708 )
2021-05-20 11:14:30 -07:00
Ville Brofeldt
37276e1af9
fix(viz): apply uniform sorting to all nvd3 timeseries charts ( #14539 )
2021-05-10 15:43:21 +03:00
Sam Faber-Manning
11260b3117
chore: add stack trace to all calls of logger.error ( #14382 )
2021-04-30 09:22:05 -07:00
Ben Reinhart
e7f5100833
fix: Fix unintended cache misses with async queries ( #14291 )
...
* bug: Fix unintended cache misses with async queries
* Ensure sort order
* Ensure columns are sorted
* Update failing tests
2021-04-28 12:14:55 -07:00
Ville Brofeldt
d7fc2031b1
feat(filter-box): sort by metric on backend ( #14340 )
2021-04-26 21:06:19 +03:00
Ville Brofeldt
fe21de3fc4
fix(viz): time shift read-only error ( #14191 )
2021-04-16 16:48:06 +03:00
Jesse Yang
fe08b698f5
docs: update outdated country map tools instructions ( #14027 )
...
also add actionable error for country map vis
2021-04-09 15:15:17 -07:00
Erik Ritter
ceb88926ff
fix: Check for permissions in FilterBox ( #13859 )
2021-03-31 10:34:48 -07:00
Ben Reinhart
55ba47ec2e
fix( #13734 ): Properly escape special characters in CSV output ( #13735 )
...
* fix: Escape csv content during downloads
* Reuse CsvResponse object
* Use correct mimetype for csv responses
* Ensure that headers are also escaped
* Update escaping logic
2021-03-26 15:22:00 -07:00
Jesse Yang
bd1d6acb0c
fix(query): order by adhoc metrics should trigger group by ( #13434 )
...
* fix(query): properly select adhoc metrics in orderby
* Throw error when sql is empty
* Allow `metrics` to be None
* Always use alias in orderby for metrics
* Bump table chart version and migrate histogram to typescript
* Fix Histogram without groupby
* Fix Presto birth names test
* Raw records mode should not aggregate
2021-03-16 21:00:03 -07:00
Jesse Yang
49eeab6f55
fix(explore): make sure sort by metric is not duplicated ( #13473 )
2021-03-07 21:13:54 -08:00
Mayur
8b38d63b7d
changes added ( #13431 )
2021-03-03 13:52:54 +02:00
Ville Brofeldt
70e12ed27d
chore: bump pyarrow and pandas ( #12882 )
...
* bump pyarrow and pandas
* remove df copy
2021-03-02 19:44:53 +02:00
Rob Spielman
e37c2bf8fd
fixing chart keys in MultiLineViz ( #12937 )
2021-02-23 10:40:23 +02:00
Victor Malai
b5379bc8c5
fix(viz): calendar heatmap granularity ( #13233 )
...
* fix: add time granularity to heatmap query
* fix: add time granularity to heatmap query
* Add aggregation for druid
* Fix lint
* Fix lint
Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local >
2021-02-22 16:17:36 +02:00
Victor Malai
e8d50356a2
Add sort by for dist bar chart ( #13049 )
2021-02-22 08:36:57 +02:00
Victor Malai
73ce2f1ea7
feat: Add sort by metric for charts with multiple metrics ( #13057 )
...
* feat: Add sort by metric for pivot-table
* feat(legacy-plugin-chart-parallel-coordinates): subject Add sort by metric
* feat(legacy-plugin-chart-rose-chart): subject Add sort by metric
* feat(legacy-plugin-chart-partition): subject Add sort by metric
* feat(legacy-plugin-chart-paired-t-test): subject Add sort by metric
* feat(legacy-plugin-chart-treemap): subject Add sort by metric
* feat(legacy-plugin-chart-nvd3-area): subject Add sort by metric
* Fix lint
* feat(plugin-chart-horizon): Add sort by & Add no default sorting if checkbox is not selected
2021-02-21 21:59:45 -08:00
michellethomas
91db008d72
fix: accept null groupby in form data for timeseries table viz ( #13086 )
...
* Allowing timeseries table groupby to be null in form data
* Check truthiness for is_group_by
Co-authored-by: michelle_thomas <michelle.thomas@airbnb.com >
2021-02-17 13:45:39 -08:00
Ville Brofeldt
d8c32b8097
fix(chart-data-api): support numeric temporal columns ( #13138 )
2021-02-16 09:51:22 +02:00
Victor Malai
24ebf10976
feat: add sort_by_metric for charts with single metric ( #13058 )
2021-02-15 02:59:50 -08:00
Duy Nguyen Hoang
32f2c45f93
fix(explore): preserve metric column order in bar chart ( #12417 )
...
* fix: Preserve Column Order in Bar chart
* Update tests/viz_tests.py to use f-strings style
Co-authored-by: Duy Nguyen <duy.nguyenhoang@global-fashion-group.com >
2021-01-28 10:39:00 +02:00
Beto Dealmeida
5a3c5b1f54
fix: samples should not be timeseries ( #12796 )
2021-01-28 10:12:30 +02:00
Grace Guo
48f37ca1db
fix: Prevent dashboard with filter_values template cause incompatible indicator ( #12742 )
...
* fix: Prevent dashboard using filter_values to add incompatible indicator
* fix review comments
* fix review comments
* add extra fix per comments
2021-01-27 10:28:17 -08:00
Rob DiCiuccio
d7cbd53fce
fix(async queries): Remove "force" param on cached data retrieval ( #12103 )
...
* Async queries: remove force cache param on data retrieval
* Assert equal query_object cache keys
* Decouple etag_cache from permission checks
* Fix query_context test
* Use marshmallow EnumField for validation
2021-01-27 10:16:57 -08:00
Ville Brofeldt
ede879022c
fix(multiline): return all chart data on initial request ( #12660 )
...
* fix(multiline): return chart data on data request
* bump package
* optimize chart retrieval and fix chart form_data
2021-01-23 15:01:50 +08:00
Karol Kostrzewa
f2b802978d
fix: bar chart data order ( #12665 )
...
* fix bar chart order
* fix test_explore_json_dist_bar_order
* fix quotes
2021-01-22 12:38:33 +02:00
bryanck
5504762458
add order by for bar charts ( #12661 )
...
Co-authored-by: Bryan Keller <bkeller@netflix.com >
2021-01-22 09:00:58 +02:00
Yongjie Zhao
9b0e6d0cc0
refactor: from superset.utils.core break down date_parser ( #12408 )
2021-01-11 14:16:42 -08:00
Ville Brofeldt
8afc4c4a44
fix(explore): bump superset-ui to 0.16.3 and fix DeckGL bug ( #12242 )
2021-01-04 22:01:09 -08:00
David Aaron Suddjian
b5dd0f32cc
feat: Dynamically imported viz plugins ( #10288 )
...
* first attempts at dynamic plugin loading
* dynamic import working for explore
* memoize appropriately
* add a backend for dynamic plugins
* hack at getting dynamic plugins working with dashboards
* more work on making it work, + feature flag
* lint
* actions to fix explore state when plugins load
* handle dynamic control panel, functionify ExploreViewContainer
* fix: rearrange migrations branch
* fix: name and key as strings with length 50
* bundle url length 2000
* bundle url to text
for some reason not supported on my sql
* fix: too long varchart
* fix: pre-commit typing
* fix: licenses
* fix: add slice container was not initing feature flags
* fix: undo linting issue
* fix: adjust down revision again
* fix: adjust down revision again
* isort
* pylint
* god damn linters
* remove unnecessary(?) loading message
* only log non-standard errors
* testing
* python is terrible
* see above commit message
* fix imports in DynamicPluginProvider
* fix
* shift migration forward
* lint
* fix form data calculations to handle missing control config
* temp commit - waiting for superset-ui changes and crud fixes
* remove unnecessary todo
* use new superset-ui shared module function
* fetch the plugins instead of hardcoding the test one
* migration sort
* remove duplicated import statement
* format
* try moving the import 🙄
* copy
* fix frontend tests
* safe access
* comment out dead code
* isort
* disable pylint on necessary lines
* use @superset-ui/logging instead of console
* remove temp code
* rearrange some code
* try triggering mouseover in cypress before click
* use loading spinner instead of text
* trying to fix cypress
* attempt cypress fix
* customize permissions
* update package lock
* only admins can write to plugins by default
* better copy
* disable flaky tests
* use makeApi
* flaky tests
* cleanup code
* flaaaakkkyyyyyy
* dry
Co-authored-by: amitNielsen <amit.miran@nielsen.com >
2020-12-19 07:06:11 -08:00
Ville Brofeldt
821b01737d
fix(viz): remove orderby from sample request ( #12055 )
2020-12-15 12:54:32 +02:00
Rob DiCiuccio
4d329071a1
feat(SIP-39): Async query support for charts ( #11499 )
...
* Generate JWT in Flask app
* Refactor chart data API query logic, add JWT validation and async worker
* Add redis stream implementation, refactoring
* Add chart data cache endpoint, refactor QueryContext caching
* Typing, linting, refactoring
* pytest fixes and openapi schema update
* Enforce caching be configured for async query init
* Async query processing for explore_json endpoint
* Add /api/v1/async_event endpoint
* Async frontend for dashboards [WIP]
* Chart async error message support, refactoring
* Abstract asyncEvent middleware
* Async chart loading for Explore
* Pylint fixes
* asyncEvent middleware -> TypeScript, JS linting
* Chart data API: enforce forced_cache, add tests
* Add tests for explore_json endpoints
* Add test for chart data cache enpoint (no login)
* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag
* Add tests for tasks/async_queries and address PR comments
* Bypass non-JSON result formats for async queries
* Add tests for redux middleware
* Remove debug statement
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
* Skip force_cached if no queryObj
* SunburstViz: don't modify self.form_data
* Fix failing annotation test
* Resolve merge/lint issues
* Reduce polling delay
* Fix new getClientErrorObject reference
* Fix flakey unit tests
* /api/v1/async_event: increment redis stream ID, add tests
* PR feedback: refactoring, configuration
* Fixup: remove debugging
* Fix typescript errors due to redux upgrade
* Update UPDATING.md
* Fix failing py tests
* asyncEvent_spec.js -> asyncEvent_spec.ts
* Refactor flakey Python 3.7 mock assertions
* Fix another shared state issue in Py tests
* Use 'sub' claim in JWT for user_id
* Refactor async middleware config
* Fixup: restore FeatureFlag boolean type
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
2020-12-10 20:21:56 -08:00
Victor Malai
05258ebc6c
fix(event-flow-viz): handle null metadata selection ( #11885 )
...
* Initialize object with empty array if is multiselect, fix 500 BE error
* modify data coming
2020-12-08 08:53:26 +02:00
Ville Brofeldt
327a2817d3
feat: add event and interval annotation support to chart data ep ( #11665 )
...
* feat: add event and interval annotation support to chart data ep
* add tests + refactor fixtures
* use chart dao
2020-12-04 14:40:31 +02:00
Ville Brofeldt
38f67a44ca
fix: mutating input df in viz.py ( #11795 )
2020-11-25 12:55:00 +02:00
Jesse Yang
4cfcaebb61
feat: rename TABLE_NAMES_CACHE_CONFIG to DATA_CACHE_CONFIG ( #11509 )
...
* feat: rename TABLE_NAMES_CACHE_CONFIG to DATA_CACHE_CONFIG
The corresponding cache will now also cache the query results.
* Slice use DATA_CACHE_CONFIG CACHE_DEFAULT_TIMEOUT
* Add test for default cache timeout
* rename FAR_FUTURE to ONE_YEAR_IN_SECS
2020-11-13 22:35:10 -08:00
Ville Brofeldt
2718909314
feat: add ECharts BoxPlot chart ( #11199 )
...
* feat: add ECharts BoxPlot chart
* lint
* fix cypress tests
* lint
* remove viz.py shim
* bump plugin package
* skip non-legacy plugin cypress dashboard tests
* fix cypress tests
* disable cypress tests for non-leagcy charts
* fix bad rebase
* use midpoint interpolation for quartile calculation
* bump packages and add support for no groupby
* whitespace
* whitespace
* linting
* fix tests
* xit mathjs load test
* bump mathjs to 8.0.1
* disable cypress filter test for v1 charts
2020-11-12 10:01:04 +02:00
Jesse Yang
339d0d73bc
feat(sankey-viz): allow sort by metric and bump superset-ui packages ( #11626 )
2020-11-10 15:58:00 -08:00
Ville Brofeldt
600a6fa92a
chore(rls): move to feature flag and disable related view ( #11575 )
...
* chore(rls): move to feature flag and disable related view
* rename feature flag
2020-11-05 12:19:48 +02:00
David Aaron Suddjian
18658f45be
feat(dashboards): Filter status indicators ( #10936 )
...
* Initial commit of new filters badge.
* refactor applied/rejected filters code
* finished filter indicators
* filter badge tested
* unnecessary imports
* formatting and types
* fixes
* license
* code quality tweaks
* state management for showing focused filter scope
* clean up filter key extraction code
* remove unnecessary styles
* temp css to demonstrate highlighting
* fix focused filter logic
* no more color badges
* new toys for highlighting dash components (#11144 )
* tweak style for the filter chart when filter is focused
* style: Filters p0 css2 (#11151 )
* nixing background tweak
* src paths
* another quick theme color
* src paths, adjusting pill icon color, changing icons, showing applied/busted counts
* linting stuff
* fixing and tweaking tests
* show filter indicator when filters are not active
* chart title bar cleanup
* open the right panel when popover opens
* unused import
* fix EditableTitle tests
* margin on dashboard header
* show the chart dropdown menu
* fix blur filter breaking dropdowns
* style tweak - no pointer events when irrelevant charts are blurred
* fix box shadow on filter highlight
* it's an array
* attempt fixing e2e
* style: filters p0 icon churn (#11215 )
* new filters icon
* icon styling
* bigger icons in list views
* better sizing of table actions and favStars
* more icon sizing...
* fixing more button size jankiness
* linting
* Filters performance (#11255 )
* fixing time filter "ok" button
* making unset filter menu collapsible
* sort alphabetically
* fix highlighting when removing items
* try a flex layout (for browser render perf)
* more specific transitioning
* temp: comment out some code as a test
* temp: comment out more code
* temp: remove possibly expensive computations from ChartHolder
* Revert "temp: comment out some code as a test"
This reverts commit 309b880e9064c88b2cba37ce0214f0c3972ba486#11325 )
* fix: use dashboard id for stable cache key (#11293 )
* fix: button translations missing (#11187 )
* button translations missing
* blank space before text
* feat: update time_compare description and choices (#11294 )
* feat: update time_compare description and choices
* Update sections.jsx
* fix(extra-filters): add logic for identifying applied extra filters
* lint
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com >
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com >
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com >
* address design feedback
* slight tweak to panel logic, keep panels open that user has opened
* rearrange code to be more graceful
* fix: bump superset-ui/core (#11385 )
* use is_dttm instead of is_temporal
* types, names
* only show unset filter panel if there are unset filters
* fix highlighting the filter control
* fix filterbox layout
* translations
* fix cypress
* actually add the test attribute
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* formatting
* add link comment to hack
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* stop importing lodash
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* skip broken test
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* adjust colors of titles
* linting
* no indicators when chart is loading
* support all time fields
* fix lock file
Co-authored-by: Natalie Ruhe <natalie@preset.io >
Co-authored-by: Evan Rusackas <evan@preset.io >
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com >
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com >
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com >
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com >
2020-10-28 15:46:24 -07:00
Erik Ritter
16f7b2b525
fix: improve time compare range error ( #11252 )
2020-10-13 16:00:39 -07:00
Maxime Beauchemin
ae87b0c767
fix: questioning a few lines that force an ORDER clause ( #11153 )
...
* draft: questioning a few lines that force an ORDER clause
* sorting by main metric DESC by default
2020-10-12 14:53:37 -07:00
Ville Brofeldt
1fa8bf7d7b
fix(viz): downgrade exception for missing viz/datasource ( #11173 )
...
* fix(viz): downgrade exception for missing datasource
* add translations
2020-10-07 15:16:51 +03:00
Kasia Kucharczyk
3a08fd04f3
chore: pylint fixes in files in project's root ( #11064 )
...
* Pylint rule: not necesary unused-import in extensions.py. Autofomatted
* Pylint rule: not necesary unused-import in jinja_context.py. Autofomatted
* Pylint rule: not necesary no-value-for-parameter in stats_logger.py. Autofomatted
* Pylint rule: not necesary no-member in viz.py
* Pylint rule: not necesary no-member in viz_sip38.py
2020-09-28 14:32:45 -07:00
Ville Brofeldt
6181994084
chore: bump pandas to latest stable version ( #11018 )
...
* chore: bump pandas to latest stable version
* fix nest_values
2020-09-24 13:11:10 +03:00
Ville Brofeldt
a9eab33d64
feat: add ECharts Pie chart ( #10966 )
...
* feat: introduce echarts pie chart
* lint
* remove viz.py shim
* remove tests
* fix cypress test
* fix test
2020-09-22 19:27:40 +03:00
Ville Brofeldt
70c6764780
fix: pivot table timestamp grouping ( #10774 )
...
* fix: pivot table timestamp grouping
* address comments
2020-09-03 19:49:54 +03:00
Bogdan
4572ebb600
chore: log cache keys to the logs ( #10678 )
...
* Log cache keys to the logs
* Add tests
* Use separate table for the cache keys
* Add migration for the cache lookup table
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com >
2020-09-01 09:41:25 -07:00
Ville Brofeldt
dd0bc472e3
refactor(database): use SupersetResultSet on SqlaTable.get_df() ( #10707 )
...
* refactor(database): use SupersetResultSet on SqlaTable.get_df()
* lint
* change cypress test
2020-08-28 21:12:03 +03:00
Maxime Beauchemin
82dda473b1
fix: dedup groupby in viz.py while preserving order ( #10633 )
2020-08-21 08:02:02 +03:00
