Commit Graph

262 Commits

Author SHA1 Message Date
Erik Ritter
343d3f8f7a fix: Disable filtering on wide result sets (#18021) 2022-01-13 10:11:18 -08:00
Lyndsi Kay Williams
f6b9393999 Tooltip no longer dancing (#17931) 2022-01-10 16:54:38 -06:00
Michael S. Molina
647bbf1ea1 chore: Moves spec files to the src folder - iteration 10 (#17902)
* chore: Moves spec files to the src folder - iteration 10

* Fixes test

* Fixes lint problem

* Uses styledMount in test
2022-01-07 15:24:15 -03:00
Hugh A. Miles II
9e69940171 feat: Update query states to use spinner vs. progress bar (#17804)
* lit

* remove reference for progress bar

* update to loading

* update switch out spinner for loading when progress hits 100

* update test
2022-01-05 10:43:42 -08:00
Erik Ritter
5b0aa27f2b feat: Persist SQL Lab autocomplete setting across tabs and visits (#17708) 2021-12-20 15:53:48 -08:00
Daman Arora
c6ba9bf9db chore: migrate EstimateQueryCostButton component from jsx to tsx (#17603)
* migrate EstimateQueryCostButton component from jsx to tsx

* re-format spaces using prettier

* Update superset-frontend/src/SqlLab/components/EstimateQueryCostButton/index.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

* remove extra onClick and make disabled prop optional

* restore & rename event handler onClick to onClickHandler

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
2021-12-01 09:28:52 -08:00
Holger Bruch
6604a6ab28 chore(translations): Add missing i18n (#17525)
* Add *.ts to babel.cfg

* Add missing i18n calls

* Update pot file

* Fix lint issues and review comment

* Incorparate review feedback

* Fix missing or non-extractable i18n calls

* Update pot file

* Fix syntax error in CommonParameters.tsx

* Fix introduced issues
2021-11-27 14:50:33 +02:00
Ville Brofeldt
5d1c9078ad chore(translations): fix translation literals (#17501)
* chore(translations): fix translation literals

* fix table name types and translations

* fix lint

* join concat'd messages
2021-11-23 10:06:09 +02:00
Corbin Robb
8e1619b105 fix(sqllab): Have table name tooltip only show when name is truncated (#17386)
* Add conditional to table name tooltip to only show when overflowing

* Remove uneccessary state and useEffect, a little clean up and slight refactoring

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-11-19 09:34:28 -08:00
Daniel Vaz Gaspar
69f9ee8f5e fix: feature flags typing (#15254)
* fix: feature flags typing

* fix tests

* add note in UPDATING.md

* fix frontend

* also move SCHEDULED_QUERIES to top level

* fix test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-11-19 15:56:16 +00:00
Yongjie Zhao
9070b6b19c refactor(monorepo): stage 1 (#17427)
* skip geojson in pre-commit

update prettier

* update package.json

update package.json

u package

pkg

pkg2

* lint main repo 2

lint main repo

lint

* lintrc

lintrc 2

lintrc2

lintrc 3

lintrc

* fix import

* refresh lock file

* fix break line make @ts-ignore invalid

* update rat-excludes

rat-excludes

update rat-excludes

* update eslintrc.js

* lint lint lint
2021-11-17 15:31:36 +08:00
Hugh A. Miles II
a1961cfc6f fix: Users being able to update datasets across DBs (#17348)
* add database id back

* add condition to verify dataset is being changed

* Update superset/datasets/dao.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-11-10 19:45:48 -05:00
Lyndsi Kay Williams
1beda796f2 fix(sqllab): Query limit dropdown number breaks to separate lines (#17382)
* Limit break fixed

* Used white-space: nowrap instead of width: max-content
2021-11-10 10:58:03 -08:00
Erik Ritter
f05a32eeb9 fix: Remove horizontal scroll navigation from SQL Lab (#17356) 2021-11-05 11:12:30 -07:00
AAfghahi
5948a9fd02 fix(AlertReportModal): Text Area Change (#17176)
* Text Area Change

* added unique key to component

* tests passing

* changed css

* data flow and naming convention
2021-10-29 15:30:20 -07:00
Michael S. Molina
4c96ae76e3 chore: Breaks the dataViewCommon folder into TableCollection and Pagination (#17132) 2021-10-25 08:47:24 -03:00
Evan Rusackas
ac509611b6 chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor (#16999)
* chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor

* putting the background back in, but using the theme.

* should be no need for this import anymore.
2021-10-07 09:46:37 +02:00
Hugh A. Miles II
40861b3db3 fix: check if owners are actually being updated in PUT /datasets/<id> (#16941)
* check if owners are actually being updated

* move logic to FE

* fix

* fix
2021-10-06 11:26:02 -07:00
Michael S. Molina
1ab36c94f3 chore: Moves spec files to the src folder - iteration 7 (#16943) 2021-10-04 10:56:49 -03:00
Michael S. Molina
05632b9804 chore: Moves the stylesheets folder to the assets folder (#16880)
* chore: Moves the stylesheets folder to the assets folder

* Changes {src} to src
2021-09-30 09:28:38 -03:00
Hugh A. Miles II
331de0c4ae fix: Fix Uniqueness check before update for Sqllab Overwrites (#16859)
* add condition to make sure columns are available before throwing

* fix

* remove database_id from history changed

* refactor update call to datasets

* cleanup

* oops

* prettier
2021-09-29 13:38:29 -04:00
Michael S. Molina
9b17e86b44 chore: Moves messageToasts to the components folder (#14431)
* chore: Moves messageToasts to the components folder

* Rebases
2021-09-22 07:44:54 -03:00
Michael S. Molina
596e1cdf9b refactor: Changes the DatabaseSelector and TableSelector to use the new Select component (#16483) 2021-09-22 07:43:46 -03:00
Elizabeth Thompson
d375538671 only fetch db function when db exists in sql lab (#16754) 2021-09-21 09:40:02 -07:00
Elizabeth Thompson
f032cc254c fix shared query (#16753) 2021-09-21 09:38:23 -07:00
Elizabeth Thompson
519baa6f00 fix: params in sql lab are jumpy in the ace editor (#16536)
* fix jumpy params

* remove cypress tests
2021-09-07 09:38:45 -07:00
Grace Guo
2199f65373 fix: sql lab refetch button (#16469)
* fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)

* fix: SQL Lab show "Refetch Results" button while fetching new query results

* fix comments

(cherry picked from commit 408d58f937)

* handle exception caused by invalid query id
2021-08-30 15:47:00 -07:00
AAfghahi
ee2eccdb67 fix: queryEditor bug (#16452)
* queryEditor bug

* update tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-08-26 15:20:02 -07:00
AAfghahi
631ad02a76 fix: copy to Clipboard order (#16299)
* copy to Clipboard order

* centralized copyToClipboard

* fixed table order

* fixed tests

* added colnames to all viz types

* added colnames to all viz types

* added colnames to all viz types
2021-08-24 14:47:09 -07:00
Hugh A. Miles II
11a2d4dfdd fix: Remove grey bar for TableElement component when metadata is empty (#16054)
* create serialize json function

* remove grey space with no metadata

* remove console log
2021-08-04 17:07:20 -04:00
serenajiang
c37c56c2e4 Revert "fix: Select a query from History and Run (#15891)" (#15992)
This reverts commit 8c7e09e500.
2021-07-30 15:24:07 -07:00
Grace Guo
8c7e09e500 fix: Select a query from History and Run (#15891)
* fix: Run query picked from History

* remove sql from component local state
2021-07-27 13:24:48 -07:00
Beto Dealmeida
d908dd6689 chore: better copy for SQL dialog (#15714) 2021-07-15 12:20:47 -07:00
Beto Dealmeida
b489cffb57 fix: no lazy translation on SupersetError (#15669)
* fix: no lazy translation on SupersetError

* Small fixes
2021-07-14 16:54:11 -07:00
Phillip Kelley-Dotson
1483e04381 refactor: icon to icons for Querytable, datasource test, and copyclipboard story (#15665)
* initial commit

* fix theme

* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-07-13 14:24:59 -07:00
Peter Kosztolanyi
02032ee8a4 feat: cancel db query on stop (#15403)
* feat: cancel db query on stop

* fix pylint

* Add unit tests

* Do not bind multiple times

* Stop only running queries

* Postgres to cancel only the required query

* Remove extra log

* Add docstring

* Better types, docstring and naming

* Use python3 format strings

* Update superset/sql_lab.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Add cancel_query_on_windows_unload option to database

* Return cancel_query as bool

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-07-13 12:09:22 -04:00
Phillip Kelley-Dotson
d8a15e60b9 refactor: icon to icons for sqllab (#15593)
* initial commit

* rid of theme

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-07-12 10:24:16 -07:00
Beto Dealmeida
cbc4aa8dc1 feat: extra table metadata for Google Sheets (#14775)
* feat: GSheets extra table metadata

* Bump version
2021-07-01 19:27:26 -07:00
Grace Guo
5b2eb8d933 Revert "fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)" (#15301)
This reverts commit 408d58f937.
2021-06-22 11:08:29 -07:00
Grace Guo
408d58f937 fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)
* fix: SQL Lab show "Refetch Results" button while fetching new query results

* fix comments
2021-06-16 16:57:31 -07:00
Phillip Kelley-Dotson
ca89292faa refactor: refactor Icon to Icons in sqlEditor component (#14463)
* add triangle-down

* lint fix

* add suggestions
2021-06-16 14:14:36 -06:00
Beto Dealmeida
d625f5f111 feat: show rich error messages on past failed queries (#15158)
* feat: store SIP-40 error payload with queries

* Set errors in query on load
2021-06-16 12:58:14 -07:00
Corbin Robb
b179863e25 refactor: Convert TableElement to TypeScript (#14978)
* Convert TableElement to typescript

* Change type names to better match naming conventions in other files

* Fix import order and update tests on TableElement

* Remove defaultProps

* Destructure the props

* Use Rest and Spread syntax to condense props destructuring

* Fix TypeScript errors and add comment to explain antd props and types weirdness

* Remove comment, add consistency with other files, and use method chaining to make more concise

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-06-15 13:29:45 -07:00
AAfghahi
2d3f552b51 adding fetching to query status (#15064) 2021-06-09 16:11:49 -07:00
AAfghahi
7f4e036433 fix: adding additional configs and colors for queryHistory (#14995)
* added additional configs and colors for queryHistory

* added condition to status icon

* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx

* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx
2021-06-07 14:10:28 -04:00
Corbin Robb
004a6d9e54 refactor: Convert TableElement.jsx component from class to functional with hooks (#14830)
* Change TableElement from a class component to a functional component

* Replace class state checks in TableElement_spec.jsx with checks testing elements they change

* Refactor small bit of logic to use optional chaining

* Add optional chaining to some logic

* Fix IconTooltip and add IconTooltip to the collapse button

* Fix custom icon using IconToolTip so it better matches the original

* Update collapse/expand icon to use Icons component instead of importing from antdesign directly

* Fix eslint errors

* Clean up some code for readability

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-06-03 16:04:56 -07:00
cccs-jc
f652908a70 fix: renamed sqllab filters to _filters (#14971) 2021-06-03 21:22:50 +03:00
AAfghahi
53505c2acb additional safeguard (#14953) 2021-06-02 12:02:22 -07:00
AAfghahi
eced510708 fix: Query History cosmetic issues (#14885)
* easiest fix

* Query History Cosmetic Issues

* added revisions

* beto revisions
2021-06-01 14:53:12 -04:00
cccs-jc
eef489c667 feat: add support for filters in sqlLab (#14765) 2021-06-01 21:23:51 +03:00