Commit Graph

82 Commits

Author SHA1 Message Date
Hugh A. Miles II
30c6ec07ef fix: Allow users to update database in Dataset Edit Modal (#17265)
* add condition to fix save

* remove console.log

(cherry picked from commit d0bad96b1a)
2021-11-22 11:53:45 -08:00
Geido
23313fdb1f fix(Explore): Undefined owners (#17167)
* Reconcile owners data

* Fix on save

(cherry picked from commit f580f6bcba)
2021-10-27 13:38:55 -07:00
Hugh A. Miles II
c03771dc6d fix: Owners selection in dataset edit UX (#17063)
* boilerplate

* update owner select component

* this is working

* update onchange

* refactorig

* you need to useMemo or things break

* update test

* prettier

* move logic into bootstrap data endpoint

* address concerns

* oops

* oops

* fix test

(cherry picked from commit 959fd763a8)
2021-10-27 13:38:54 -07:00
Geido
3f0756f637 chore: Select component refactoring - SelectControl - Iteration 5 (#16510)
* Refactor Select DatasourceEditor

* Fire onChange with allowNewOptions

* Clean up

* Refactor Select in AnnotationLayer

* Handle on clear

* Update tests

* Refactor Select in SpatialControl

* Show search

* Refactor Select in FilterBox

* Remove search where unnecessary

* Update SelectControl - WIP

* Refactor Controls

* Update SelectControl tests

* Clean up

* Test allowNewOptions false

* Use SelectControl AnnotationLayer

* Use SelectControl SpatialControl

* Clean up

* Render custom label

* Show search

* Implement filterOption

* Improve filterOption

* Update Cypress

* Update Cypress table test

* Use value for defaultValue

* Merge with latest changes

* Reconcile with latest Select changes

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Revert changes to test

* Call onPopoverClear when v value is undefined

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-10-04 18:24:41 +03:00
Phillip Kelley-Dotson
a198dbb19b feat: add certifiedby & certification details fields to the edit dataset columns fields (#16454)
* add migration

* add backend and frontend for certified

* update migration with batch

* fix integration test and update Updating.md

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* change method name

* add tooltip info

* add mixin

* merge heads

* address comments

* fix select label styles

* add extra field

* fix test?

* add extra field to put schema

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
2021-09-22 15:09:30 -07:00
Michael S. Molina
9b17e86b44 chore: Moves messageToasts to the components folder (#14431)
* chore: Moves messageToasts to the components folder

* Rebases
2021-09-22 07:44:54 -03:00
Michael S. Molina
596e1cdf9b refactor: Changes the DatabaseSelector and TableSelector to use the new Select component (#16483) 2021-09-22 07:43:46 -03:00
Ville Brofeldt
1d5100daa2 fix(dataset): retain is_dttm if set on metadata sync (#16776) 2021-09-22 10:13:49 +03:00
Erik Ritter
8adc31d14c Revert "chore: Changes the DatabaseSelector to use the new Select component (#16334)" (#16478)
This reverts commit c768941f2f.
2021-08-26 22:28:04 -03:00
Michael S. Molina
c768941f2f chore: Changes the DatabaseSelector to use the new Select component (#16334) 2021-08-23 15:41:03 -03:00
Phillip Kelley-Dotson
c5081991fc initial commit (#16380) 2021-08-20 16:59:53 -06:00
Ville Brofeldt
575ee24a99 fix: call external metadata endpoint with correct rison object (#16369) 2021-08-20 11:43:57 +03:00
Yongjie Zhao
6cd15d54a0 refactor: external metadata fetch API (#16193)
* refactor: external metadata api

* fix comments

* fix ut

* fix fe lint

* fix UT

* fix UT
2021-08-13 20:56:42 +08:00
Elizabeth Thompson
628169a171 feat: change query predicate to text (#16160)
* change query predicate to text

* make input multiline

* remove value that is too long for the downgrade

* keep logging lint rule
2021-08-10 17:52:01 -07:00
Yongjie Zhao
bb1d8fe4ef fix: boolean type into SQL 'in' operator (#16107)
* fix: boolean type into SQL 'in' operator

* fix ut

* fix ut again

* update url

* remove blank line
2021-08-10 19:21:46 +08:00
Yongjie Zhao
3bbcc30d69 fix: virtual dataset wont work (#16132) 2021-08-07 20:43:12 +08:00
Yongjie Zhao
430ebe18aa fix: sync columns in explore page (#16042) 2021-08-03 09:49:08 -07:00
Geido
475f9cdc35 fix: Sort Metrics by ID DESC (order of creation) in the Datasource Editor (#15971)
* Sort metrics by ID

* Fix undefined metrics
2021-08-02 11:16:01 +02:00
Yongjie Zhao
a786373fff feat: auto sync table columns when change dataset (#15887)
* feat: auto sync dataset metadata when change dataset

* diablo sync button when edit mode

* handle undefine schema

* fix py UT

* fix FE UT

* improve test coverage

* fix UT
2021-08-02 16:55:31 +08:00
stellalc7
324ecb31fc fix: three button styles to tertiary (#15978)
* changed margin right on warning icon to 8px

* fixed to grid units from pixels

* Changed three buttons styles to tertiary
2021-07-31 10:25:55 +08:00
Andrew Bastian
ee8b1ed15a chore: update dataset count badge and tash icon sizing (#15608)
* update trash icon size

* changed badge icon `height` to `16px` (using `gridUnits` and centered text inside via `line-height`

* changed badge icon `height` to `16px` (using `gridUnits`), centered text inside via `line-height`, alignedItems inside div w/flex
2021-07-09 07:33:25 -07:00
Phillip Kelley-Dotson
e1ceb7f7cc refactor: Icon to icons for certifiedIcon (#15306)
* initial commit

* updated css

* fix lint
2021-06-23 14:49:17 -06:00
Phillip Kelley-Dotson
c211f7df8e refactor: icon to icons in DatasourceEditor (#15240)
* intial commit

* lint

* fix test

* fix lint

* remove console.

* Removing pixel placement override.

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-06-22 15:07:09 -07:00
Phillip Kelley-Dotson
e2abf59534 feat(Explore): add sort to edit dataset modal (#14872)
* inital commit

* refac

* fix ui issues and sort

* fix lint

* add suggestions

* lint

* add suggestions

* add enum

* add enum to inter
2021-06-14 15:20:22 -07:00
Elizabeth Thompson
0c470feaef move metric parsing to state instantiation (#15069) 2021-06-09 14:54:25 -07:00
Elizabeth Thompson
21aa3daae3 display all metric results in editor (#15031) 2021-06-07 19:12:56 -07:00
Yongjie Zhao
e6bc7c99e7 feat: add type_generic and is_dttm to table metadata (#14863) 2021-06-03 08:20:47 +08:00
David Aaron Suddjian
152b0d0575 fix(explore): checkbox form control formatting (#14701)
* fix(explore): add inline option for the field that only gets used in one place

* typescriptify

* unnecessary component wrapping
2021-05-19 14:04:09 -07:00
Evan Rusackas
ad699e8b48 fix: don't show busted label for unknown data types (#14585) 2021-05-12 23:16:54 -07:00
Michael S. Molina
331eb10fb9 refactor: Bootstrap to AntD - Form - iteration 4 (#14546) 2021-05-12 23:01:43 -07:00
Michael S. Molina
a52ff13b5d chore: Moves Card to the components folder (#14139) 2021-04-29 11:51:41 -07:00
Michael S. Molina
d0be1ff79e chore: Moves Tabs to the components folder (#14136) 2021-04-27 00:15:21 -07:00
Michael S. Molina
d1b458c4c5 chore: Moves Radio to the components folder (#14133) 2021-04-20 08:48:10 -07:00
Bruno Motta
95ed8735f1 chore: well component to card component(Updating PR #12200) (#14033)
* replace Well componenet with Card component

* Fix lint errors

* Fix lint

* Addressing comments

* Addressing comments

* Fix lint errors

* Exporting Card from index.tsx and adding storybook variants

* Fix some refactoring

* Fix errors

* solving conflicts and lint errors

* Update superset-frontend/src/common/components/Card.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/Card.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Nikola Gigic <nik.gigic@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 15:06:44 -07:00
AAfghahi
f19f2c3ac8 fix: Floating Menu in SQL Left Bar (#13858)
* floating table git issue

* made changes

* floating table git issue

* made changes

* long table names

* floating table git issue

* made changes

* floating table git issue

* made changes

* long table names

* floating table git issue

* made changes

* floating table git issue

* made changes

* long table names

* table values

* aligned

* active key

* changed to customStyle

* update dropdown styles

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-04-05 15:54:28 -07:00
Michael S. Molina
9d6832dc27 test: Adds tests and storybook to CertifiedIcon component (#13457) 2021-03-30 14:31:35 -07:00
Erik Ritter
64785c20bd feat: add warning metadata to tables and metrics (#13606) 2021-03-17 21:27:34 -07:00
Geido
d1f6245bcd test: Tests, dedicated directory and Storybook for the Badge component (#13513)
* Move to dir and add storybook

* Add tests

* Remove no-restricted-imports
2021-03-10 12:29:59 -08:00
Michael S. Molina
42ab57850d Migrate Bootstrap Alert to AntD (#12101) (#12122) 2021-02-21 20:50:18 -08:00
AAfghahi
69b0ed663d fix: added text and changed margins (#12923) 2021-02-08 17:26:55 -05:00
Michael S. Molina
5a79a7d993 Migrates Radio component from Bootstrap to AntD. (#12738) 2021-02-02 11:26:26 -08:00
Michael S. Molina
c781ab8adf Migrates Button component from Bootstrap to AntD (#12832) 2021-02-01 15:13:10 -08:00
Michael S. Molina
fc20e8b594 Apply capitalization guidelines - iteration 4 (#12343) (#12450) 2021-01-22 10:11:38 -08:00
Geido
3444d654ed fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals (#12598) 2021-01-21 10:34:41 -08:00
Jesse Yang
9acf48fd1e chore: upgrade eslint, babel, and prettier (#12393) 2021-01-10 17:26:35 -08:00
Michael S. Molina
8682c6fc1c refactor: Fix anchor-is-valid lint warnings (#12010)
* Fix anchor-is-valid lint warnings

* Change IconTooltip to use named exports
2020-12-21 23:58:05 -08:00
Rob DiCiuccio
4d329071a1 feat(SIP-39): Async query support for charts (#11499)
* Generate JWT in Flask app

* Refactor chart data API query logic, add JWT validation and async worker

* Add redis stream implementation, refactoring

* Add chart data cache endpoint, refactor QueryContext caching

* Typing, linting, refactoring

* pytest fixes and openapi schema update

* Enforce caching be configured for async query init

* Async query processing for explore_json endpoint

* Add /api/v1/async_event endpoint

* Async frontend for dashboards [WIP]

* Chart async error message support, refactoring

* Abstract asyncEvent middleware

* Async chart loading for Explore

* Pylint fixes

* asyncEvent middleware -> TypeScript, JS linting

* Chart data API: enforce forced_cache, add tests

* Add tests for explore_json endpoints

* Add test for chart data cache enpoint (no login)

* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag

* Add tests for tasks/async_queries and address PR comments

* Bypass non-JSON result formats for async queries

* Add tests for redux middleware

* Remove debug statement

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Skip force_cached if no queryObj

* SunburstViz: don't modify self.form_data

* Fix failing annotation test

* Resolve merge/lint issues

* Reduce polling delay

* Fix new getClientErrorObject reference

* Fix flakey unit tests

* /api/v1/async_event: increment redis stream ID, add tests

* PR feedback: refactoring, configuration

* Fixup: remove debugging

* Fix typescript errors due to redux upgrade

* Update UPDATING.md

* Fix failing py tests

* asyncEvent_spec.js -> asyncEvent_spec.ts

* Refactor flakey Python 3.7 mock assertions

* Fix another shared state issue in Py tests

* Use 'sub' claim in JWT for user_id

* Refactor async middleware config

* Fixup: restore FeatureFlag boolean type

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-12-10 20:21:56 -08:00
Geido
2c323426d1 refactor: Move Badge to Antdesign (#11899)
* Move Badge to Antdesign

* Export enhanced badge only

* Center number in badge
2020-12-04 17:06:54 -08:00
Evan Rusackas
38b720b0a7 style: eslint curly rule (#11913)
* style: eslint curly rule

* curly for ts
2020-12-03 10:20:05 -08:00
Grace Guo
61064b9634 add fix for extra comments for #11781 (#11902) 2020-12-02 18:13:42 -08:00