QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-04 15:19:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
6,259 Commits 538 Branches 545 Tags
38bb6f3f207cdafdd0bf86dbe9da900c2787c708
Commit Graph

498 Commits

Author SHA1 Message Date
Maxime Beauchemin
150c8e36b1 fix: always fetch database list on bootstrap payload (#11934) 
There was this weird bug happening only when `SQLLAB_BACKEND_PERSISTENCE
= False` where if no database had been selected, there would be some
issue.

This makes sure that the store is populated consistently with the list
of database connections regardless of `SQLLAB_BACKEND_PERSISTENCE`. It
also uses the DAO to fetch database and will apply the RBAC-related
filters if any, the same way that the API does.
 2020-12-09 09:36:18 -08:00
Erik Ritter
fa68288d61 fix: make sure we log the logs (#11939) 2020-12-04 16:50:16 -08:00
Will Barrett
1842c56209 Capture error when celery back-end does not support forgetting tasks (#10770) 2020-12-02 09:47:02 -08:00
ʈᵃᵢ
ffa32cde14 chore: remove SIP_34_QUERY_SEARCH_UI feature flag (#11863) 2020-12-01 09:29:16 -08:00
Maxime Beauchemin
0504cf1a00 chore: improve analytics (#11714) 
* chore: improve analytics

* lint

* log more events, add note in UPDATING.md

* handling base class

* more events\!

* get ref through

* right before @expose

* fix context

* touchups
 2020-11-25 08:45:02 -08:00
auxten
ac0dd3fa32 fix: attachment filename error in sqllab with i18n (#11762) 
* Fix attachment filename error in sqllab

* Fix line too long lint

* Fix black lint
 2020-11-25 13:05:30 +02:00
Erik Ritter
c0224aa928 feat: add certification info to table selector (#11785) 2020-11-24 12:13:52 -08:00
Hugh A. Miles II
1ef3a02e7a feat: Add user info to sqllab via bootstrap data (#11760) 2020-11-19 18:32:51 -08:00
Jesse Yang
4cfcaebb61 feat: rename TABLE_NAMES_CACHE_CONFIG to DATA_CACHE_CONFIG (#11509) 
* feat: rename TABLE_NAMES_CACHE_CONFIG to DATA_CACHE_CONFIG

The corresponding cache will now also cache the query results.

* Slice use DATA_CACHE_CONFIG CACHE_DEFAULT_TIMEOUT

* Add test for default cache timeout

* rename FAR_FUTURE to ONE_YEAR_IN_SECS
 2020-11-13 22:35:10 -08:00
ʈᵃᵢ
432e5ab460 feat: Query History CRUD list view (#11574) 2020-11-12 11:55:13 -10:00
Beto Dealmeida
4a070cfceb chore: consolidate dashboard import logic (#11529) 
* Consolidate dash import logic

* Fix lint

* Remove Slice.import_obj

* Remove unused import

* Fix log
 2020-11-11 14:50:18 -08:00
Grace Guo
b9284d3a3c fix(dashboard): use server-side lastModifiedTime for co-edit check (#11614) 
* fix: [dashboard][co-edit] Round client-side lastModifiedTime

* another try: server-side returns last_updated_time in save_dash response
 2020-11-09 13:30:40 -08:00
Jesse Yang
29554a9f02 fix: show recent visited dashboards and charts in recent_activity (#11481) 2020-10-30 11:59:08 -07:00
Grace Guo
b1263ad568 Revert "fix: change chart title by clicking (#11335)" (#11497) 
This reverts commit 1f04db79f7.
 2020-10-29 15:13:29 -07:00
David Aaron Suddjian
18658f45be feat(dashboards): Filter status indicators (#10936) 
* Initial commit of new filters badge.

* refactor applied/rejected filters code

* finished filter indicators

* filter badge tested

* unnecessary imports

* formatting and types

* fixes

* license

* code quality tweaks

* state management for showing focused filter scope

* clean up filter key extraction code

* remove unnecessary styles

* temp css to demonstrate highlighting

* fix focused filter logic

* no more color badges

* new toys for highlighting dash components (#11144)

* tweak style for the filter chart when filter is focused

* style: Filters p0 css2 (#11151)

* nixing background tweak

* src paths

* another quick theme color

* src paths, adjusting pill icon color, changing icons, showing applied/busted counts

* linting stuff

* fixing and tweaking tests

* show filter indicator when filters are not active

* chart title bar cleanup

* open the right panel when popover opens

* unused import

* fix EditableTitle tests

* margin on dashboard header

* show the chart dropdown menu

* fix blur filter breaking dropdowns

* style tweak - no pointer events when irrelevant charts are blurred

* fix box shadow on filter highlight

* it's an array

* attempt fixing e2e

* style: filters p0 icon churn (#11215)

* new filters icon

* icon styling

* bigger icons in list views

* better sizing of table actions and favStars

* more icon sizing...

* fixing more button size jankiness

* linting

* Filters performance (#11255)

* fixing time filter "ok" button

* making unset filter menu collapsible

* sort alphabetically

* fix highlighting when removing items

* try a flex layout (for browser render perf)

* more specific transitioning

* temp: comment out some code as a test

* temp: comment out more code

* temp: remove possibly expensive computations from ChartHolder

* Revert "temp: comment out some code as a test"

This reverts commit 309b880e90.

* Revert "temp: comment out more code"

This reverts commit 64c88b2cba.

* Revert "temp: remove possibly expensive computations from ChartHolder"

This reverts commit 37ce0214f0.

* experiment: upgrade react-select to v3

* Revert "experiment: upgrade react-select to v3"

This reverts commit c3972ba486.

* fix the damn problem

* remove code used for testing purposes

* awful hack to avoid adding a class to a container

* approaching infinity... and not beyond!

* fix ref forwarding

* add theme to tests as necessary

* fix(extra-filters): add logic for identifying applied extra filters (#11325)

* fix: use dashboard id for stable cache key (#11293)

* fix: button translations missing (#11187)

* button translations missing

* blank space before text

* feat: update time_compare description and choices (#11294)

* feat: update time_compare description and choices

* Update sections.jsx

* fix(extra-filters): add logic for identifying applied extra filters

* lint

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

* address design feedback

* slight tweak to panel logic, keep panels open that user has opened

* rearrange code to be more graceful

* fix: bump superset-ui/core (#11385)

* use is_dttm instead of is_temporal

* types, names

* only show unset filter panel if there are unset filters

* fix highlighting the filter control

* fix filterbox layout

* translations

* fix cypress

* actually add the test attribute

* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* formatting

* add link comment to hack

* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* stop importing lodash

* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* skip broken test

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* adjust colors of titles

* linting

* no indicators when chart is loading

* support all time fields

* fix lock file

Co-authored-by: Natalie Ruhe <natalie@preset.io>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
 2020-10-28 15:46:24 -07:00
John Bodley
8ee6493233 chore: Update testconn logic (#11315) 
* chore: Update testconn logic

* [databases] Address @dpgaspar's comments

Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-10-27 09:15:05 +00:00
Daniel Vaz Gaspar
144b279aa2 feat: saved queries with execution info (#11391) 
* feat: add rows and last_run info to saved queries

* feat: add rows to saved query

* refactor and tests

* lint

* fix tests
 2020-10-26 11:20:07 -07:00
Lily Kuang
1f04db79f7 fix: change chart title by clicking (#11335) 2020-10-22 18:33:13 -07:00
Maxime Beauchemin
f6436b7652 fix: 'Save Chart' modal's dashboard dropdown isn't sticky (#11338) 
It appears that the logic that makes the dashboard selection sticky
in the 'Save Chart' modal (explore) was broken at some time.

While working on a dashboard, it's nice if this modal can remember the
dashboard selection.
 2020-10-21 17:30:19 -07:00
Jesse Yang
634676d467 refactor: use contextmanager for event_logger decorators (#11222) 2020-10-14 10:44:06 -07:00
Jesse Yang
2c649ac20f perf: cache dashboard bootstrap data (#11234) 2020-10-13 18:43:06 -07:00
John Bodley
51fec1ab16 fix: Ensure consistent naming for testconn (#11246) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-10-13 09:53:03 -07:00
Grace Guo
4f4367edf3 feat: prevent co-edit dashboard collision (#11220) 
* feat: prevent co-edit dashboard collision

* fix comments
 2020-10-12 17:58:32 -07:00
Erik Ritter
6cf698cc6a chore: deprecate REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD (#11244) 2020-10-12 17:31:56 -07:00
Ville Brofeldt
e647286393 chore(sql-lab): catch PyArrow deserialization error (#11201) 2020-10-12 10:16:00 +03:00
John Bodley
513bf10a38 chore: Leverage SQLALchemy ping rather than explicit SELECT 1 for testconn (#11223) 2020-10-11 12:44:15 -07:00
Grace Guo
a10e86ab31 fix: revert eTag cache feature for dashboard (#11203) 
* revert #11137

* revert #10963
 2020-10-08 12:15:08 -07:00
Beto Dealmeida
9785667a0d feat: add UUID column to ImportMixin (#11098) 
* Add UUID column to ImportMixin

* Fix default value

* Fix lint

* Fix order of downgrade

* Add logging when downgrade fails

* Migrate position_json to contain UUIDs, and add schedule tables

* Save UUID when adding charts to dashboard

* Fix heads

* Rename migration file

* Fix dashboard serialization

* Fix migration script with Postgres

* Fix unique contraint name

* Handle UUID when exporting dashboard

* Fix Dataset PUT

* Add UUID JSON serialization

* Fix tests

* Simplify logic

* Try binary=True
 2020-10-07 09:00:55 -07:00
Jesse Yang
38dccf9e12 fix: enable consistent etag across workers and force no-cache for dashboards (#11137) 
* fix: enable consistent etag across workers

* Use CACHE_DEFAULT_TIMEOUT instead of 0

* Change timeout to 0 and set expires header even for no-cache

* Reduce number of if branches to appease Pylint

* Fix mypy error
 2020-10-06 09:43:43 -07:00
Grace Guo
6633409a15 feat: enable ETag header for dashboard GET requests (#10963) 
* feat: add etag for dashboard load requests

* fix review comments
 2020-09-29 10:57:16 -07:00
Daniel Vaz Gaspar
5d08a426d3 fix(api): unable to delete virtual dataset, wrong permission name (#11019) 
* fix(api): unable to delete virtual dataset because of wrong permission name

* Still delete the dataset even when no permission was found

* migration script to fix possible existing faulty permissions on the db

* black

* fix db migration and one more test

* add more comments to the migration script

* freeze a partial schema of the model on the migration step

* fix mig script

* Update superset/migrations/versions/3fbbc6e8d654_fix_data_access_permissions_for_virtual_.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
 2020-09-29 12:33:07 +01:00
Daniel Vaz Gaspar
ba009b7c09 fix: query search low privileged user search access denied (#11017) 2020-09-23 14:16:24 +01:00
Jesse Yang
1f31e0eb38 feat: server side dashboard css for less repaint (#10850) 2020-09-13 21:32:43 -07:00
Grace Guo
c2216e029d Revert "chore: add logging for "dashboard" action (#10744)" (#10822) 
This reverts commit e0ad9935c1.
 2020-09-09 14:44:07 -07:00
Lily Kuang
8a3ac70c06 feat(databases): test connection api (#10723) 
* test connection api on databases

* update test connection tests

* update database api test and open api description

* moved test connection to commands

* update error message

* fix isort

* fix mypy

* fix black

* fix mypy pre commit
 2020-09-09 13:37:48 -07:00
Daniel Vaz Gaspar
77a3167412 feat(database): POST, PUT, DELETE API endpoints (#10741) 
* feat(database): POST, PUT, DELETE API endpoints

* post tests

* more tests

* lint

* lint

* debug ci

* fix test

* fix test

* fix test

* fix test

* fix test

* fix test

* cleanup

* handle db connection failures

* lint

* skip hive and presto for connection fail test

* fix typo
 2020-09-02 09:58:08 -07:00
Grace Guo
e0ad9935c1 chore: add logging for "dashboard" action (#10744) 2020-09-01 20:14:22 -07:00
Daniel Vaz Gaspar
3e374dab07 fix: change public role like gamma procedure (#10674) 
* fix: change public role like gamma procedure

* lint and updating UPDATING with breaking change

* fix updating text

* add test and support PUBLIC_ROLE_LIKE_GAMMA

* fix, cleanup tests

* fix, new test

* fix, public default

* Update superset/config.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* add simple public welcome page

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
 2020-08-28 10:49:10 +01:00
John Bodley
502f4db6f9 feature: Adding extra_filters to warm_up_cache (#10675) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-08-25 15:19:34 -07:00
ʈᵃᵢ
7301a363c1 feat: setup react page with submenu for datasources listview (#10642) 2020-08-20 11:42:17 -07:00
Grace Guo
3bc79191c4 refactor: remove slice level label_colors from dashboard init load (#10603) 2020-08-18 18:10:06 -07:00
Ville Brofeldt
08358d623b fix: handle query exceptions gracefully (#10548) 
* fix: handle query exceptions gracefully

* add more recasts

* add test

* disable test for presto

* switch to SQLA error
 2020-08-07 17:37:40 +03:00
Erik Ritter
fd2d1c58c5 Revert "chore: Cleanup database sessions (#10427)" (#10537) 
This reverts commit 7645fc85c3.
 2020-08-06 15:33:48 -07:00
Daniel Vaz Gaspar
749581d534 fix(log): don't log exceptions on test connection (#10522) 
* fix(log): don't log exceptions on test connection

* fix lint
 2020-08-06 07:58:22 +01:00
John Bodley
7645fc85c3 chore: Cleanup database sessions (#10427) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-07-30 23:07:56 -07:00
Daniel Vaz Gaspar
671461d0d0 feat(api): database schemas migration to new API (#10436) 
* fix(log): log crashes if expired or not authenticated

* fix lint and rison

* add tests

* more tests

* perm fix

* fix test not found

* JS lint

* fix Jest test
 2020-07-29 09:33:15 +01:00
Daniel Vaz Gaspar
0aad9c6f48 fix(log): log endpoint authentication (#10435) 
* fix(log): log crashes if expired or not authenticated

* add auth to log endpoint
 2020-07-29 09:32:10 +01:00
Maxime Beauchemin
ea53916730 feat: SIP-34 explore save modal (#10355) 
* feat: SIP-34 explore save modal

* using a const for the session storage key

* backend changes

* minor tweaks

* more tweaks

* radio cosmetics

* styles

* fix tests

* CreatableSelect\!

* Fix cypress & lint

* fix unit

* lint
 2020-07-23 00:26:29 -07:00
Erik Ritter
5fa4680447 feat: update timeout error UX (#10274) 2020-07-20 15:32:17 -07:00
John Bodley
4e4ccd48d6 chore: Releasing SQL Lab Celery results (#10279) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-07-10 09:53:57 -07:00