QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity
6,561 Commits 490 Branches 544 Tags
3a962f81f60dca55e7a12a7d32ae42e4e6d5369a
Commit Graph

379 Commits

Author SHA1 Message Date
Duy Nguyen Hoang
368691383b fix(explore): preserve metric column order in bar chart (#12417) 
* fix: Preserve Column Order in Bar chart

* Update tests/viz_tests.py to use f-strings style

Co-authored-by: Duy Nguyen <duy.nguyenhoang@global-fashion-group.com>
 2021-01-29 11:38:51 +02:00
Rob DiCiuccio
73523e2822 fix(async queries): Remove "force" param on cached data retrieval (#12103) 
* Async queries: remove force cache param on data retrieval

* Assert equal query_object cache keys

* Decouple etag_cache from permission checks

* Fix query_context test

* Use marshmallow EnumField for validation
 2021-01-29 11:37:29 +02:00
Ville Brofeldt
0686a1c347 fix(multiline): return all chart data on initial request (#12660) 
* fix(multiline): return chart data on data request

* bump package

* optimize chart retrieval and fix chart form_data
 2021-01-25 15:04:15 +02:00
Yongjie Zhao
35c15b8b3a refactor: from superset.utils.core break down date_parser (#12408) 2021-01-13 19:00:54 +02:00
Ville Brofeldt
8afc4c4a44 fix(explore): bump superset-ui to 0.16.3 and fix DeckGL bug (#12242) 2021-01-04 22:01:09 -08:00
David Aaron Suddjian
b5dd0f32cc feat: Dynamically imported viz plugins (#10288) 
* first attempts at dynamic plugin loading

* dynamic import working for explore

* memoize appropriately

* add a backend for dynamic plugins

* hack at getting dynamic plugins working with dashboards

* more work on making it work, + feature flag

* lint

* actions to fix explore state when plugins load

* handle dynamic control panel, functionify ExploreViewContainer

* fix: rearrange migrations branch

* fix: name and key as strings with length 50

* bundle url length 2000

* bundle url to text
for some reason not supported on my sql

* fix: too long varchart

* fix: pre-commit typing

* fix: licenses

* fix: add slice container was not initing feature flags

* fix: undo linting issue

* fix: adjust down revision again

* fix: adjust down revision again

* isort

* pylint

* god damn linters

* remove unnecessary(?) loading message

* only log non-standard errors

* testing

* python is terrible

* see above commit message

* fix imports in DynamicPluginProvider

* fix

* shift migration forward

* lint

* fix form data calculations to handle missing control config

* temp commit - waiting for superset-ui changes and crud fixes

* remove unnecessary todo

* use new superset-ui shared module function

* fetch the plugins instead of hardcoding the test one

* migration sort

* remove duplicated import statement

* format

* try moving the import 🙄

* copy

* fix frontend tests

* safe access

* comment out dead code

* isort

* disable pylint on necessary lines

* use @superset-ui/logging instead of console

* remove temp code

* rearrange some code

* try triggering mouseover in cypress before click

* use loading spinner instead of text

* trying to fix cypress

* attempt cypress fix

* customize permissions

* update package lock

* only admins can write to plugins by default

* better copy

* disable flaky tests

* use makeApi

* flaky tests

* cleanup code

* flaaaakkkyyyyyy

* dry

Co-authored-by: amitNielsen <amit.miran@nielsen.com>
 2020-12-19 07:06:11 -08:00
Ville Brofeldt
821b01737d fix(viz): remove orderby from sample request (#12055) 2020-12-15 12:54:32 +02:00
Rob DiCiuccio
4d329071a1 feat(SIP-39): Async query support for charts (#11499) 
* Generate JWT in Flask app

* Refactor chart data API query logic, add JWT validation and async worker

* Add redis stream implementation, refactoring

* Add chart data cache endpoint, refactor QueryContext caching

* Typing, linting, refactoring

* pytest fixes and openapi schema update

* Enforce caching be configured for async query init

* Async query processing for explore_json endpoint

* Add /api/v1/async_event endpoint

* Async frontend for dashboards [WIP]

* Chart async error message support, refactoring

* Abstract asyncEvent middleware

* Async chart loading for Explore

* Pylint fixes

* asyncEvent middleware -> TypeScript, JS linting

* Chart data API: enforce forced_cache, add tests

* Add tests for explore_json endpoints

* Add test for chart data cache enpoint (no login)

* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag

* Add tests for tasks/async_queries and address PR comments

* Bypass non-JSON result formats for async queries

* Add tests for redux middleware

* Remove debug statement

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Skip force_cached if no queryObj

* SunburstViz: don't modify self.form_data

* Fix failing annotation test

* Resolve merge/lint issues

* Reduce polling delay

* Fix new getClientErrorObject reference

* Fix flakey unit tests

* /api/v1/async_event: increment redis stream ID, add tests

* PR feedback: refactoring, configuration

* Fixup: remove debugging

* Fix typescript errors due to redux upgrade

* Update UPDATING.md

* Fix failing py tests

* asyncEvent_spec.js -> asyncEvent_spec.ts

* Refactor flakey Python 3.7 mock assertions

* Fix another shared state issue in Py tests

* Use 'sub' claim in JWT for user_id

* Refactor async middleware config

* Fixup: restore FeatureFlag boolean type

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
 2020-12-10 20:21:56 -08:00
Victor Malai
05258ebc6c fix(event-flow-viz): handle null metadata selection (#11885) 
* Initialize object with empty array if is multiselect, fix 500 BE error

* modify data coming
 2020-12-08 08:53:26 +02:00
Ville Brofeldt
327a2817d3 feat: add event and interval annotation support to chart data ep (#11665) 
* feat: add event and interval annotation support to chart data ep

* add tests + refactor fixtures

* use chart dao
 2020-12-04 14:40:31 +02:00
Ville Brofeldt
38f67a44ca fix: mutating input df in viz.py (#11795) 2020-11-25 12:55:00 +02:00
Jesse Yang
4cfcaebb61 feat: rename TABLE_NAMES_CACHE_CONFIG to DATA_CACHE_CONFIG (#11509) 
* feat: rename TABLE_NAMES_CACHE_CONFIG to DATA_CACHE_CONFIG

The corresponding cache will now also cache the query results.

* Slice use DATA_CACHE_CONFIG CACHE_DEFAULT_TIMEOUT

* Add test for default cache timeout

* rename FAR_FUTURE to ONE_YEAR_IN_SECS
 2020-11-13 22:35:10 -08:00
Ville Brofeldt
2718909314 feat: add ECharts BoxPlot chart (#11199) 
* feat: add ECharts BoxPlot chart

* lint

* fix cypress tests

* lint

* remove viz.py shim

* bump plugin package

* skip non-legacy plugin cypress dashboard tests

* fix cypress tests

* disable cypress tests for non-leagcy charts

* fix bad rebase

* use midpoint interpolation for quartile calculation

* bump packages and add support for no groupby

* whitespace

* whitespace

* linting

* fix tests

* xit mathjs load test

* bump mathjs to 8.0.1

* disable cypress filter test for v1 charts
 2020-11-12 10:01:04 +02:00
Jesse Yang
339d0d73bc feat(sankey-viz): allow sort by metric and bump superset-ui packages (#11626) 2020-11-10 15:58:00 -08:00
Ville Brofeldt
600a6fa92a chore(rls): move to feature flag and disable related view (#11575) 
* chore(rls): move to feature flag and disable related view

* rename feature flag
 2020-11-05 12:19:48 +02:00
David Aaron Suddjian
18658f45be feat(dashboards): Filter status indicators (#10936) 
* Initial commit of new filters badge.

* refactor applied/rejected filters code

* finished filter indicators

* filter badge tested

* unnecessary imports

* formatting and types

* fixes

* license

* code quality tweaks

* state management for showing focused filter scope

* clean up filter key extraction code

* remove unnecessary styles

* temp css to demonstrate highlighting

* fix focused filter logic

* no more color badges

* new toys for highlighting dash components (#11144)

* tweak style for the filter chart when filter is focused

* style: Filters p0 css2 (#11151)

* nixing background tweak

* src paths

* another quick theme color

* src paths, adjusting pill icon color, changing icons, showing applied/busted counts

* linting stuff

* fixing and tweaking tests

* show filter indicator when filters are not active

* chart title bar cleanup

* open the right panel when popover opens

* unused import

* fix EditableTitle tests

* margin on dashboard header

* show the chart dropdown menu

* fix blur filter breaking dropdowns

* style tweak - no pointer events when irrelevant charts are blurred

* fix box shadow on filter highlight

* it's an array

* attempt fixing e2e

* style: filters p0 icon churn (#11215)

* new filters icon

* icon styling

* bigger icons in list views

* better sizing of table actions and favStars

* more icon sizing...

* fixing more button size jankiness

* linting

* Filters performance (#11255)

* fixing time filter "ok" button

* making unset filter menu collapsible

* sort alphabetically

* fix highlighting when removing items

* try a flex layout (for browser render perf)

* more specific transitioning

* temp: comment out some code as a test

* temp: comment out more code

* temp: remove possibly expensive computations from ChartHolder

* Revert "temp: comment out some code as a test"

This reverts commit 309b880e90.

* Revert "temp: comment out more code"

This reverts commit 64c88b2cba.

* Revert "temp: remove possibly expensive computations from ChartHolder"

This reverts commit 37ce0214f0.

* experiment: upgrade react-select to v3

* Revert "experiment: upgrade react-select to v3"

This reverts commit c3972ba486.

* fix the damn problem

* remove code used for testing purposes

* awful hack to avoid adding a class to a container

* approaching infinity... and not beyond!

* fix ref forwarding

* add theme to tests as necessary

* fix(extra-filters): add logic for identifying applied extra filters (#11325)

* fix: use dashboard id for stable cache key (#11293)

* fix: button translations missing (#11187)

* button translations missing

* blank space before text

* feat: update time_compare description and choices (#11294)

* feat: update time_compare description and choices

* Update sections.jsx

* fix(extra-filters): add logic for identifying applied extra filters

* lint

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

* address design feedback

* slight tweak to panel logic, keep panels open that user has opened

* rearrange code to be more graceful

* fix: bump superset-ui/core (#11385)

* use is_dttm instead of is_temporal

* types, names

* only show unset filter panel if there are unset filters

* fix highlighting the filter control

* fix filterbox layout

* translations

* fix cypress

* actually add the test attribute

* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* formatting

* add link comment to hack

* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* stop importing lodash

* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* skip broken test

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* adjust colors of titles

* linting

* no indicators when chart is loading

* support all time fields

* fix lock file

Co-authored-by: Natalie Ruhe <natalie@preset.io>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
 2020-10-28 15:46:24 -07:00
Erik Ritter
16f7b2b525 fix: improve time compare range error (#11252) 2020-10-13 16:00:39 -07:00
Maxime Beauchemin
ae87b0c767 fix: questioning a few lines that force an ORDER clause (#11153) 
* draft: questioning a few lines that force an ORDER clause

* sorting by main metric DESC by default
 2020-10-12 14:53:37 -07:00
Ville Brofeldt
1fa8bf7d7b fix(viz): downgrade exception for missing viz/datasource (#11173) 
* fix(viz): downgrade exception for missing datasource

* add translations
 2020-10-07 15:16:51 +03:00
Kasia Kucharczyk
3a08fd04f3 chore: pylint fixes in files in project's root (#11064) 
* Pylint rule: not necesary unused-import in extensions.py. Autofomatted

* Pylint rule: not necesary unused-import in jinja_context.py. Autofomatted

* Pylint rule: not necesary no-value-for-parameter in stats_logger.py. Autofomatted

* Pylint rule: not necesary no-member in viz.py

* Pylint rule: not necesary no-member in viz_sip38.py
 2020-09-28 14:32:45 -07:00
Ville Brofeldt
6181994084 chore: bump pandas to latest stable version (#11018) 
* chore: bump pandas to latest stable version

* fix nest_values
 2020-09-24 13:11:10 +03:00
Ville Brofeldt
a9eab33d64 feat: add ECharts Pie chart (#10966) 
* feat: introduce echarts pie chart

* lint

* remove viz.py shim

* remove tests

* fix cypress test

* fix test
 2020-09-22 19:27:40 +03:00
Ville Brofeldt
70c6764780 fix: pivot table timestamp grouping (#10774) 
* fix: pivot table timestamp grouping

* address comments
 2020-09-03 19:49:54 +03:00
Bogdan
4572ebb600 chore: log cache keys to the logs (#10678) 
* Log cache keys to the logs

* Add tests

* Use separate table for the cache keys

* Add migration for the cache lookup table

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-09-01 09:41:25 -07:00
Ville Brofeldt
dd0bc472e3 refactor(database): use SupersetResultSet on SqlaTable.get_df() (#10707) 
* refactor(database): use SupersetResultSet on SqlaTable.get_df()

* lint

* change cypress test
 2020-08-28 21:12:03 +03:00
Maxime Beauchemin
82dda473b1 fix: dedup groupby in viz.py while preserving order (#10633) 2020-08-21 08:02:02 +03:00
Ville Brofeldt
5136c5c16e feat(viz-plugins): add date formatting to pivot-table (#10637) 
* feat: make pivot table dates formattable

* Bump npm packages
 2020-08-19 23:55:59 +03:00
Grace Guo
ca9ca99510 refactor: [migration] convert iframe chart into dashboard markdown component (#10590) 
* refactor: [migration] convert iframe chart into dashboard markdown component

* remove 3 viz_types

* fix comments
 2020-08-16 14:43:30 -07:00
Ville Brofeldt
acb00f509c fix(chart-data-api): assert referenced columns are present in datasource (#10451) 
* fix(chart-data-api): assert requested columns are present in datasource

* add filter tests

* add column_names to AnnotationDatasource

* add assertion for simple metrics

* lint
 2020-08-14 20:58:24 +03:00
Ville Brofeldt
c0ebd7f434 fix: show error if rolling window returns empty df (#10572) 
* fix: show error if rolling window returns empty df

* add test
 2020-08-13 20:51:03 +03:00
Ville Brofeldt
08358d623b fix: handle query exceptions gracefully (#10548) 
* fix: handle query exceptions gracefully

* add more recasts

* add test

* disable test for presto

* switch to SQLA error
 2020-08-07 17:37:40 +03:00
Ville Brofeldt
363abfa1a5 fix: remove unnecessary exception when exploring non-legacy viz plugins (#10538) 
* fix: remove unnecessary exception when exploring non-legacy viz plugins

* lint
 2020-08-07 08:41:39 +03:00
Ville Brofeldt
96b9ba3364 ci: bump pre-commit py36 to py37 (#10541) 
* ci: bump pre-commit py36 to py37

* add 3rd party for py37

* lint

* yet more lint
 2020-08-07 06:54:22 +03:00
John Bodley
cda764fd4b chore: Adding pip-compile-multi et al. (#10499) 
* chore: Adding pip-compile-multi et al

* Specify requirements.txt path for fossa

* [ci] Fixing CI

Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
 2020-08-04 19:31:52 -07:00
Ville Brofeldt
9d9c34835a fix: support non-string groupbys for pie chart (#10493) 
* chore: add unit tests to pie chart

* refine logic for floats and nans and add more tests
 2020-07-31 11:19:21 +03:00
Ville Brofeldt
fc28c92f57 feat: support non-numeric columns in pivot table (#10389) 
* fix: support non-numeric columns in pivot table

* bump package and add unit tests

* mypy
 2020-07-28 10:40:53 +03:00
Ville Brofeldt
9a5d812ee6 fix: pie chart multiple groupbys (#10391) 2020-07-23 09:22:48 +03:00
bryanck
73797b8b64 check for empty dataframes before processing results (#10361) 
Co-authored-by: Bryan Keller <bkeller@netflix.com>
 2020-07-19 17:19:30 +03:00
Ville Brofeldt
ac85aebe4a chore: prefer allow/deny terminology (#10320) 
* chore: prefer allow/deny terminology

* fix tests

* add PR reference
 2020-07-15 19:22:46 +03:00
Maxime Beauchemin
318e5347bc feat: Alerts! allowing users to set SQL-based email alerts with screenshots (#9944) 
* feat: add support for alerts

* Add ModelViews

* First pass at adding scheduled Alert support

* Fix syntax errors

* Add log_retention and database to model

* Improving screenshots

* Still refactoring screenshots

* Pass down thumb_size properly

* Progress on screenshot endpoint

* Add alerts.last_eval_dttm and alert query logic

* Getting ready to split compute_screenshot and screenshot/{SHA}

* split the endpoints

* Improving alerting loop

* empty methods

* Add CLI command 'superset alert' that runs a sched loop

* Getting things to work

* email delivery

* A working email\!

* Add feature flag

* Add some description_columns to AlertModelView

* Little tweaks

* Use database.get_df, eval cells for truthiness

* Migrate thumbnail/screenshot functions to use new arg pattern

* Addressing PR feedback

* Update alerts DB migration down_revision

* Resolve _deliver_email arg conflict

* Make mypy happy

* Make isort happy

* Make pylint happy

Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
 2020-07-06 13:12:27 -07:00
John Bodley
cf60f664a4 fix: Remove double pickling for cached payloads (#10222) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-07-02 16:46:36 -07:00
Jesse Yang
9bdfa055ac feat(viz): add query mode switch to table chart (#10113) 
1, Replace table chart rendering from jquery.DataTables to react-table: apache-superset/superset-ui#623
2. Rearrange the control panel, replace GROUP BY and NOT GROUP BY with a "Query Mode" switch: apache-superset/superset-ui#609
 2020-06-28 21:37:04 -07:00
John Bodley
aefef9ca55 chore(security): Updating assert logic (#10034) 
* chore(security): Updating assert logic

* Deprecating rejected_tables

Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-06-23 20:49:39 -07:00
Erik Ritter
7504b1cf20 fix: caching on viz with relative time ranges and time compare (#10061) 2020-06-16 08:47:35 -07:00
Maxime Beauchemin
280ade826c fix: dashboard export raises schema issues (#10060) 
* fix: dashboard export raises schema issues

* Fix isort
 2020-06-15 21:43:05 -07:00
Ville Brofeldt
a3393c1bc4 fix: native annotations (#10037) 
* fix: native annotations

* Add test

* Add comment to test
 2020-06-12 21:53:26 +03:00
Ville Brofeldt
7cb38fe28b chore: remove markup from viz.py (#9997) 2020-06-10 07:49:09 +03:00
serenajiang
280b4dce00 fix(SankeyViz): enforce source/target order (#10003) 
* fix(SankeyViz): enforce source/target order

* address pr comments

* black

Co-authored-by: serena-jiang <serena.jiang@airbnb.com>
 2020-06-09 10:13:48 -07:00
John Bodley
91517a56a3 style(mypy): Spit-and-polish pass (#10001) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-06-07 08:53:46 -07:00
John Bodley
63e0188f45 style(mypy): Enforcing typing for superset.views (#9939) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-06-05 08:44:11 -07:00