Claude
471b4bafc4
fix(tests): resolve jest 30.4 + jsdom 26 compatibility issues
...
- Patch Object.defineProperties in jsDomWithFetchAPI.ts to make
window.location configurable, enabling jest.spyOn in tests with
jest-environment-jsdom 30 (which bundles jsdom 26)
- Update TableChart.test.tsx: jsdom 26 returns rgba(0,0,0,0) for
elements with no background, replacing empty string expectations
- Apply prettier formatting fixes to logger.test.ts and
RedirectWarning/utils.test.ts
Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-05-18 16:48:31 -05:00
Claude
421252b343
fix(tests): update test mocks for jsdom 30 window.location and CSS changes
...
jsdom 30 (shipped with jest-environment-jsdom 30) makes window.location
non-configurable, breaking the Object.defineProperty and delete patterns
used across 19 test files. Also introduces stricter CSS normalization
(rgba(x,y,z,1) -> rgb(x,y,z), alpha precision rounding, named colors to
rgb()) and stricter CSS font-shorthand parsing on SVG nodes.
Changes:
- Replace every Object.defineProperty(window, 'location', ...) and
delete window.location; window.location = ... with
jest.spyOn(window, 'location', 'get').mockReturnValue(...) plus
.mockRestore() for cleanup
- Use getter/setter objects on the mock return value for tests that write
to window.location.href or window.location.protocol
- Replace jest.spyOn(window, 'window', 'get') (also broken in jsdom 30)
with jest.spyOn(window, 'location', 'get') in getDashboardUrl tests
- TableChart: rgba(172,225,196,1) -> rgb(172,225,196);
rgba(172,225,196,0.812) -> rgba(172,225,196,0.81)
- DropdownContainer: 'background-color: red' -> 'background-color: rgb(255, 0, 0)'
- updateTextNode: fix CSS font shorthand order from
'italic 30px Lobster 700' (invalid) to 'italic 700 30px Lobster' (valid)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-05-18 08:19:24 -07:00
Jay Masiwal
cb74438865
fix(viz): correct table chart drill-to-detail temporal boundaries and null handling ( #39668 )
...
Co-authored-by: Samuelinto <samuel.mantilla@mail.utoronto.ca >
Co-authored-by: Amin Ghadersohi <amin.ghadersohi@gmail.com >
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-05-01 11:46:18 -04:00
Jean Massucatto
9c3c8dcc0b
fix(table): restore dropdown arrow visibility on paginated table page… ( #39305 )
2026-04-30 05:56:51 -07:00
Sam Firke
3395620b6e
fix(table chart): fix rerender bug that continuously cleared search box ( #39707 )
2026-04-28 08:40:56 -03:00
Maxime Beauchemin
c2d96e0dce
fix(table): fix cross-filter not clearing on second click in Interactive Table ( #39253 )
...
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-15 10:30:36 -07:00
Enzo Martellucci
aba7e6dae4
fix(table): cross-filtering breaks after renaming column labels via Custom SQL ( #38858 )
2026-04-10 06:02:18 +02:00
João Pedro Alves Barbosa
02ffb52f4a
fix(table): improve conditional formatting text contrast ( #38705 )
2026-03-22 18:59:15 -03:00
Michael S. Molina
357e35dc62
refactor(core): reorganize superset-core packages into feature-based structure ( #38448 )
2026-03-05 17:41:15 -03:00
Levis Mbote
c175346808
fix(table-charts): Prevent time grain from altering Raw Records in Tables + Interactive Tables ( #37561 )
2026-02-19 10:24:09 +01:00
SBIN2010
33441ccf3d
feat: add formatting column and formatting object to conditional formating table ( #35897 )
2026-02-19 02:07:15 +03:00
Michael S. Molina
19ec7b48a0
fix: Conditional formatting painting empty cells ( #37894 )
2026-02-12 10:22:00 -03:00
Đỗ Trọng Hải
563d9f1a3f
chore(lint): migrate Jest lint rules from eslint to oxlint ( #37787 )
...
Signed-off-by: hainenber <dotronghai96@gmail.com >
2026-02-08 16:44:42 +07:00
Nitish Agarwal
17d6f4ebc4
fix(table): align group headers correctly when filtering time compari… ( #37236 )
2026-01-21 12:50:18 -08:00
Luis Sánchez
c31224c891
fix(TableChart): render cell bars for columns with NULL values ( #36819 )
2025-12-31 17:51:35 +03:00
Mohammad Al-Qasem
4479614754
feat(table): Gradient Toggle ( #36280 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-12-04 12:31:44 -08:00
Edison Liem
eabb5bdf7d
feat(dashboard): implement boolean conditional formatting ( #36338 )
...
Co-authored-by: Morris <morrisho215215@gmail.com >
2025-12-04 09:53:49 -08:00
Kaito Watanabe
6e0960c3f5
feat: show search filtered total ( #36083 )
2025-12-01 22:29:23 +01:00
Joe Li
e7c54376e2
test(table): remove conditionals from TableChart tests ( #36149 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-11-21 13:28:16 -08:00
Joe Li
008c7c6517
fix(table-chart): fix missing table header IDs ( #35968 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-11-12 13:15:55 -08:00
SBIN2010
514d56d1ae
feat: conditional formatting improvements add flag toAllRow and toTextColor in tables ( #34762 )
2025-10-28 16:40:40 -07:00
SBIN2010
852adaa6cc
feat: conditional formatting improvements in tables ( #34330 )
2025-08-18 15:13:16 -07:00
JUST.in DO IT
8700a0b939
fix(table chart): render bigint value in a raw mode ( #34556 )
2025-08-05 13:11:28 -07:00
Maxime Beauchemin
dd129fa403
feat(theming): land Ant Design v5 overhaul — dynamic themes, real dark mode + massive styling refactor ( #31590 )
...
Co-authored-by: Enzo Martellucci <52219496+EnxDev@users.noreply.github.com >
Co-authored-by: Diego Pucci <diegopucci.me@gmail.com >
Co-authored-by: Mehmet Salih Yavuz <salih.yavuz@proton.me >
Co-authored-by: Geido <60598000+geido@users.noreply.github.com >
Co-authored-by: Alexandru Soare <37236580+alexandrusoare@users.noreply.github.com >
Co-authored-by: Damian Pendrak <dpendrak@gmail.com >
Co-authored-by: Pius Iniobong <67148161+payose@users.noreply.github.com >
Co-authored-by: Enzo Martellucci <enzomartellucci@gmail.com >
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com >
2025-06-20 13:38:58 -07:00
Levis Mbote
d75ff9e784
feat(charts): add subtitle option and metric customization controls ( #32975 )
2025-04-10 17:24:24 +02:00
Fardin Mustaque
7d77dc4fd2
fix: Time Comparison Feature Reverts Metric Labels to Metric Keys in Table Charts ( #32665 )
...
Co-authored-by: Fardin Mustaque <fardinmustaque@Fardins-Mac-mini.local >
2025-03-25 14:22:15 +02:00
Đỗ Trọng Hải
e9094659d3
refactor(frontend): migrate 6 tests from Enzyme to RTL ( #30151 )
...
Signed-off-by: hainenber <dotronghai96@gmail.com >
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com >
2024-09-13 15:02:03 -06:00
Ross Mabbett
dac69e2092
feat(explorer): Add configs and formatting to discrete comparison columns ( #29553 )
2024-07-25 18:43:56 -04:00
Đỗ Trọng Hải
0ca42a8e4d
chore: remove React 16.4's obsolete React imports ( #28571 )
...
Signed-off-by: hainenber <dotronghai96@gmail.com >
2024-06-05 08:13:24 -03:00
JUST.in DO IT
6f402991e5
fix(plugins): missing currency on small number format in table chart ( #27041 )
2024-02-08 15:24:24 -08:00
Arko
916f7bcbba
fix(table chart): Show Cell Bars correctly #25625 ( #25707 )
2023-11-06 08:36:21 -03:00
Kamil Gabryjelski
ea21e800a7
fix: Currency formatting in Table raw mode ( #25248 )
2023-09-11 16:48:39 +02:00
Kamil Gabryjelski
83ff4cd86a
feat: Implement currencies formatter for saved metrics ( #24517 )
2023-06-28 20:51:40 +02:00
JUST.in DO IT
5d910aa2e2
fix(plugin-chart-table): Invalid d3Formatter on String column ( #23515 )
2023-03-28 15:25:35 -07:00
Mayur
60bab4269f
fix(table-chart): don't color empty cells in table chart with color formatters ( #21501 )
2022-09-28 16:16:12 +08:00
Josh Soref
bebb10e495
chore(frontend-tests): Spelling ( #19853 )
...
* spelling: against
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: been
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: charts
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: clicking
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: columns
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: duplicate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: especially
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: extensions
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: fields
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: filter
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: for
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: label
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: labeled
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: nativefilter
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: registry
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: render
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: resizable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: response
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: successful
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: transform
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: unfortunately
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: until
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: virtual
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: wrapper
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com >
2022-04-26 10:35:01 -07:00
Erik Ritter
1e544ce531
fix: null dates in table chart ( #17974 )
2022-01-10 10:07:59 -08:00
Yongjie Zhao
3c41ff68a4
refactor(monorepo): move superset-ui to superset(stage 2) ( #17552 )
2021-11-30 08:29:57 +08:00