Commit Graph

27 Commits

Author SHA1 Message Date
Geido
48fd3c185c chore: Add docs to the Select component props (#17171)
* Add docs

* Add overall description

* Remove trailing space
2021-10-26 12:50:23 +03:00
Michael S. Molina
55be249870 fix: Order of Select items when unselecting (#17169)
* fix: Order of Select items when unselecting

* Adds a property comparator that supports strings and numbers

* Uses a named export for propertyComparator
2021-10-25 08:47:01 -03:00
Michael S. Molina
be211437de fix: Filtering db names while creating dataset is not working (#17023) 2021-10-07 16:23:51 -03:00
Geido
66b0877445 Strict undefined check SelectControl (#17008) 2021-10-07 17:22:52 +03:00
Geido
a782a62097 chore: Select component refactoring - SelectAsyncControl - Iteration 5 (#16609)
* Refactor Select

* Implement onError

* Separate async request

* Lint

* Allow clear

* Improve type

* Reconcile with Select latest changes

* Fix handleOnChange

* Clean up

* Add placeholder

* Accept null values

* Update superset-frontend/src/explore/components/controls/SelectAsyncControl/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Clean up

* Implement type guard

* Fix lint

* Catch error within loadOptions

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2021-10-07 14:20:32 +03:00
Michael S. Molina
86290cc0e5 chore: Improves the Select component to avoid additional queries when all values have been loaded (#16712)
* chore: Improves the Select component to avoid additional queries when all values have been loaded

* Handles the logic in handlePaginateFetch and removes the use effect
2021-09-15 15:39:58 -03:00
Michael S. Molina
adc3d24c21 fix: Ignore case and special keys when searching (#16706) 2021-09-15 07:33:43 -03:00
Geido
fecd4124fa fix: Select refactoring known issues (#16666)
* Clean up and reorganize effects

* Enhance optionFilterProps

* Render custom label

* Remove prop filtering

* Create options

* Create option from value in single mode

* Change to customLabel

* Show search by default

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Apply minor changes

* Fixes a bug that was failing CI

* Adds more tests to the component

* Apply customLabel in ColorSchemeControl

* Remove customLabel from rendered Option

* Hide No data when allowNewOptions

* Remove unnecessary prop from tests

* Adjust loading height

* Show no data with fetchOnlyOnSearch

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
2021-09-14 17:39:27 +03:00
Michael S. Molina
e9e6c5de8a chore: Writes the tests for the new Select component (#16638)
* chore: Writes the tests for the new Select component

* Uses array destructuring
2021-09-09 08:38:33 -03:00
Michael S. Molina
37c2020035 chore: Merges latest Select changes (#16587) 2021-09-07 10:41:55 -03:00
Michael S. Molina
02798a3517 fix: Adds a loading message when needed in the Select component (#16531) 2021-09-02 13:17:47 -03:00
Erik Ritter
8adc31d14c Revert "chore: Changes the DatabaseSelector to use the new Select component (#16334)" (#16478)
This reverts commit c768941f2f.
2021-08-26 22:28:04 -03:00
Ville Brofeldt
1c71eda70f fix(native-filters): handle null values in value filter (#16460)
* fix(native-filters): handle null values in value filter

* lint
2021-08-26 15:26:53 +03:00
Michael S. Molina
c768941f2f chore: Changes the DatabaseSelector to use the new Select component (#16334) 2021-08-23 15:41:03 -03:00
Michael S. Molina
0668eaad6a chore: Improves the flow to create a new chart (#16252)
* chore: Improves the flow to create a new chart

* Adds a comment about selector specificity
2021-08-16 11:56:47 -03:00
Michael S. Molina
e59f318ef9 chore: Changes the RefreshIntervalModal component to use the new select component (#16048) 2021-08-06 07:58:53 -03:00
Michael S. Molina
1917464d2b fix: Fix the Select unselect for object values (#16062) 2021-08-04 11:52:39 -03:00
Michael S. Molina
5be0a89625 fix: Charts sort by in edit mode gets cut off (#15896) 2021-07-26 16:38:38 -03:00
Michael S. Molina
9c81599d21 chore: Adds the tests that need to be coded for the Select component (#15885) 2021-07-25 21:01:48 +02:00
Michael S. Molina
e660de6936 chore: Adds lazy loading to the Select component (#15799) 2021-07-22 15:17:31 -03:00
Michael S. Molina
fdb40350bb chore: Changes the pagination API of the Select component (#15802) 2021-07-22 07:32:04 -03:00
Geido
314d49c13b Enhance Select (#15550) 2021-07-06 13:07:33 -03:00
Michael S. Molina
0b7e524f02 fix: Select item when allowNewOptions is true and the Enter is pressed (#15429) 2021-06-28 15:29:58 -03:00
Michael S. Molina
a7e103765a chore: Improves the Select component UI/UX - iteration 3 (#15363) 2021-06-25 11:01:39 -06:00
Michael S. Molina
fc1a62b78c chore: Improves the Select component UI/UX - iteration 2 (#15235) 2021-06-22 16:04:01 -03:00
Geido
d578ae9897 feat: Select component (Iteration 1) (#15121)
* Implement initial structure

* Add aria-label

* Rename files

* Refactor single mode new options

* Clean up

* Add select at every corner in storybook

* Clean up

* Add pagination

* Move selected options at the top

* Clean up

* Add license

* Refactor

* Improve pagination

* Fetch when allowNewOptions

* Clean up
2021-06-16 11:05:58 -06:00
Michael S. Molina
19c8a62254 chore: Moves OnPasteSelect tests to component's folder (#13338) 2021-03-01 12:54:18 -08:00