Commit Graph

740 Commits

Author SHA1 Message Date
Kamil Gabryjelski
b7759e6fd1 chore: Clean redundant dependency from useMemo dep array (#19732) 2022-04-15 14:56:34 +02:00
smileydev
c320c295dc fix(dnd&column): make to fix the blank state issue when only one column select (#19651) 2022-04-15 13:43:25 +02:00
Smart-Codi
ac2c66ccf6 fix: Line Chart Annotation Info Update (#19001)
* fix Line Chart Annotation Info Updage

* wrap annotation text with transation

* resolve comment
2022-04-14 10:46:32 -07:00
Kamil Gabryjelski
c8304a2821 feat(explore): Redesign of Run/Save buttons (#19558)
* feat(explore): Move save button to header, run button to bottom of control panel

* Make the tabs sticky

* Add error icon to Data tab

* Show message when creating chart and all controls are filled correctly

* Add tests and storybook

* Fix tests

* Disable save button when control have errors

* Fix types

* Apply code review comments

* Replace styled with css

* Remove unused import
2022-04-13 16:58:39 +02:00
Geido
7b0b029318 chore: Remove wrong usage of font-size in ExploreViewContainer (#19614)
* Remove hacky usage of font-size

* Update font
2022-04-12 16:10:58 +03:00
Ville Brofeldt
1ad82af058 fix(select): render when empty multiselect (#19612)
* fix(select): render when empty multiselect

* disable flaky test
2022-04-08 16:40:14 +03:00
Yongjie Zhao
761d5c4208 chore: cleanup as unknown conversion (#19587) 2022-04-08 17:32:29 +08:00
Stephen Liu
0e29871493 fix(explore): clean data when hidding control (#19039) 2022-04-06 20:25:32 +08:00
Kamil Gabryjelski
bb96029c9d fix(explore): Chart header icon paddings (#19534) 2022-04-06 06:50:16 +02:00
Geido
1521ab3b6f chore(Explore): Change text when saving a chart in a new dashboard (#19467)
* Change text when new dashboard

* Test buttons behavior
2022-04-05 22:05:05 +03:00
Geido
a59718b094 Remove Control less (#19415) 2022-04-05 20:05:09 +03:00
Kamil Gabryjelski
03d3eaacaf feat(explore): Move timer, row counter and cached pills to chart container (#19458)
* feat(explore): Move timer, row counter and cached pills to chart container

* Hide pills in standalone mode

* Take pills out of chart-container
2022-04-05 18:03:23 +02:00
Kamil Gabryjelski
602afbaa31 feat(explore): Move chart header to top of the page (#19529)
* Move chart header to top of the page

* Implement truncating and dynamic input

* fix typing

* Prevent cmd+z undoing changes when not in edit mode

* Fix tests, add missing types

* Show changed title in altered
2022-04-05 15:20:29 +02:00
Kamil Gabryjelski
1a1322d3d9 feat(explore): Move chart actions into dropdown (#19446)
* feat(explore): Move chart actions to a dropdown menu

* Fix tests and add some new ones

* Add background color to embed code button

* Fix cypress tests

* Move copy permalink to actions menu

* Remove unused function

* Move share by email above embed code

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test
2022-03-31 20:41:15 +02:00
Kamil Gabryjelski
a076ae6d99 feat(explore): UI changes in dataset panel on Explore page (#19394)
* feat(explore): Implement new design for dataset panel

* Fixes

* Replace drag handle in dashboard builder

* Add missing types

* Type fix

* Fix tests

* Fix non-dnd version

* Fix test

* Replace margin with height
2022-03-29 21:11:08 +02:00
Michael S. Molina
816a2c3e1e chore: Removes direct theme imports (#19368) 2022-03-29 10:15:07 -03:00
Beto Dealmeida
d304849b46 feat: disable edits on external assets (#19344)
* feat: disable edits on external assets

* Update tests
2022-03-28 16:32:57 -07:00
Michael S. Molina
65c204b288 fix: Null values on Explore filter (#19341) 2022-03-23 17:23:57 -04:00
smileydev
468c5ca29a fix(explore): make to convert null to N/A in view results (#19316)
* fix(explore): make to convert null to N/A in view results

* fix(explore): make to null formatter move before timeFormatter
2022-03-23 08:02:52 -06:00
Kamil Gabryjelski
a8a48af7fa chore: Make font-weights themable, fix font faces (#19236)
* fix(fonts): Import all necessary font packages

* Make html tags themable

* Set bold font weight to 600, add medium font weight to theme

* Replace hard coded font weights with theme variables

* Change some font weight light elements to normal

* Fix tests

* Fix bug in pivot table

* Address code review comments
2022-03-22 09:36:15 +01:00
Diego Medina
54f1b35161 chore: add missing keys to components inside lists (#19161) 2022-03-21 15:47:48 -06:00
Stephen Liu
dc575080d7 feat: improve color consistency (save all labels) (#19038) 2022-03-21 15:20:04 +08:00
smileydev
e7355b9610 fix(explore comma): make that the comma can be added by removing it from token separators… (#18926)
* make that the comma can be added by removing it from token separators in select component.

* fix(explore comma): add the allowTokenSeperators props into Select

* fix(explore comma): make to allow to customize the token separators in Select.

* fix(explore comma): make to add the unit test and story book.

* fix(explore comma): make to fix the lint

* fix(explore comma): make to fix the spell  & add tokenSeparatprs props to PickedSelectProps

* Update Select.tsx

* fix(explore comma): make to run lint fix
2022-03-18 11:39:26 -03:00
Diego Medina
0277ebc225 fix: Popovers in Explore not attached to the fields they are triggered by (#19139)
* fix: Popovers in Explore not attached to the fields they are triggered by

* fix

* PR comment

* remove unused import
2022-03-16 20:46:52 -06:00
Ville Brofeldt
b7a0559aaf feat: add permalink to dashboard and explore (#19078)
* rename key_value to temporary_cache

* add migration

* create new key_value package

* add commands

* lots of new stuff

* fix schema reference

* remove redundant filter state from bootstrap data

* add missing license headers

* fix pylint

* fix dashboard permalink access

* use valid json mocks for filter state tests

* fix temporary cache tests

* add anchors to dashboard state

* lint

* fix util test

* fix url shortlink button tests

* remove legacy shortner

* remove unused imports

* fix js tests

* fix test

* add native filter state to anchor link

* add UPDATING.md section

* address comments

* address comments

* lint

* fix test

* add utils tests + other test stubs

* add key_value integration tests

* add filter box state to permalink state

* fully support persisting url parameters

* lint, add redirects and a few integration tests

* fix test + clean up trailing comma

* fix anchor bug

* change value to LargeBinary to support persisting binary values

* fix urlParams type and simplify urlencode

* lint

* add optional entry expiration

* fix incorrect chart id + add test
2022-03-17 01:15:52 +02:00
David Aaron Suddjian
3d66912d89 fix: clean up chart metadata config (#19143)
* fix: clean up chart metadata config

* missed a spot

* missed another spot

* fix failing time-specific test

* can't call translation functions here

* Revert "fix failing time-specific test"

This reverts commit 3eeb8ab9cc.

* skip problematic test

* extra import
2022-03-16 09:59:56 -07:00
Jesse Yang
ae13d8313b feat(select): keep options order when in single mode (#19085) 2022-03-11 13:01:38 -08:00
Stephen Liu
7524e1e3c8 feat(viz-gallery): add 'feature' tag and fuzzy search weighting (#18662)
* feat(viz-gallery): add 'feature' tag and fuzzy search weighting

* add search weight

* Update superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* some improvements

* take metadata out

* use chartLabel enum to unify

* add test chart

* fix cache

* Resolving TS Lint issue

* Appeasing the linter

* Removing one example implementation

* Removing another example label implementation

* Removing the third example label implementation

Co-authored-by: Evan Rusackas <evan@preset.io>
2022-03-11 01:49:10 -07:00
Diego Medina
0e0beceac1 fix: Pivot Table Conditional Formatting Doesn't Show All Options (#19071)
* fix: Pivot Table Conditional Formatting Doesn't Show All Options

* PR comments

* PR comments
2022-03-09 15:04:04 -07:00
Kamil Gabryjelski
f9c7405e0e chore(explore): Set Drag&Drop feature flags to True by default (#19046)
* chore(explore): Set Drag&Drop feature flags to True by default

* fix tests
2022-03-08 18:50:51 +01:00
Jesse Yang
c75f233109 feat(select): sort exact and startsWith match to first (#18856) 2022-03-08 07:08:40 -08:00
Michael S. Molina
04a36d5c92 chore: Moves Chart to the components folder (#19029) 2022-03-08 08:57:29 -03:00
Michael S. Molina
329855170e refactor: Deletes the common/components folder (#18999) 2022-03-04 14:19:14 -03:00
Michael S. Molina
06e1e4285e feat: Adds support to multiple dependencies to the native filters (#18793)
* chore(native-filters): Remove cascading popovers from filter bar

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-03-04 13:06:10 -03:00
John Bodley
26486d01c1 chore: Remove legacy SIP-15 interim logic/flags (#18936)
* chore: Remove legacy SIP-15 logic

* Update ab9a9d86e695_deprecate_time_range_endpoints.py

* Update UPDATING.md

* Update UPDATING.md

* Update UPDATING.md

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-03-04 09:15:36 +13:00
Ville Brofeldt
bd63a1bd98 fix(chart): deprecate persisting url_params (#18960)
* fix(chart): deprecate peristing url_params

* remove duplicated backend logic

* use omitBy

* simplify omit
2022-03-02 07:44:36 +02:00
Michael S. Molina
fd4bd1edbc chore: Moves components out of the commons folder (#18931)
* refactor: Moves components out of the commons folder

* Fixes tests
2022-02-25 10:17:32 -03:00
Yongjie Zhao
4c16586067 fix(key-value): lost url_params after long-url feature (#18846) 2022-02-22 21:50:50 +08:00
Geido
535634310b Fix annotation cache (#18788) 2022-02-21 16:57:22 +02:00
Geido
cf8b57e80d fix(Explore): Fix cache timeout field not being saved and unit tests (#18738)
* fix cache timeout

* Add unit tests
2022-02-16 16:55:52 +02:00
Corbin Robb
c8df84985c fix(CRUD/listviews): Errors with rison and search strings using special characters (#18056)
* fix errors with rison and useQueryParams

* add test for encode/decode

* add rison link and make test case more readable

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2022-02-15 16:08:36 -06:00
Adam Dobrawy
8b3e27d68b refactor: migrate QueryAndSaveBtns to TypeScript and add stories (#18121)
* refactor: Migrate QueryAndSaveBtns to TS and stories

* fix: change typing notation in QueryAndSaveBtns
2022-02-15 17:04:48 +02:00
Michael S. Molina
48a80950de feat: Improve state key generation for dashboards and charts (#18576)
* feat: Improve state key generation for dashboards and charts
2022-02-14 17:09:06 -03:00
Kamil Gabryjelski
c1205b5279 feat(explore): Implement metrics and columns popovers empty states (#18681)
* feat(explore): Implement empty states for column and metrics popovers

* Fix test

* Change copy
2022-02-14 15:26:56 +01:00
Kamil Gabryjelski
42d97fb078 feat(explore): Implement data table empty states (#18679)
* feat(explore): Implement explore data table empty states

* Make empty state titles easier to translate
2022-02-14 13:06:31 +01:00
Adam Dobrawy
bd0b9f25e4 refactor: migrate SliderControl to TypeScript & added story (#18120)
* refactor: migrate SliderControl to TypeScript & added story

* fix: Set default onChange in SliderControl
2022-02-10 14:21:48 +01:00
Michael S. Molina
f03b4dbedb feat: Improves key expiration handling in Explore (#18624)
* feat: Improves key expiration handling in Explore

* Sets use_slice_data equals true

* Shows toast when recovering
2022-02-09 13:20:21 -03:00
Kamil Gabryjelski
830f2e71d3 feat(explore): Allow using time formatter on temporal columns in data table (#18569)
* feat(explore): Allow using time formatter on temporal columns in data table

* Fix data table loading

* Return colnames and coltypes from results request

* Fix types

* Fix tests

* Fix copy button

* Fix df is none

* Fix test

* Address comments

* Move useTimeFormattedColumns out of useTableColumns

* Make reducer more readable
2022-02-09 10:29:11 +01:00
Adam Dobrawy
fa8c81e1b1 chore: upgrade BoundsControl to TS (#18200)
* chore: upgrade BoundsControl to TS,FC, add storybook

* chore: improve React import reference consistency
2022-02-08 14:45:10 +02:00
Yongjie Zhao
aa21a963a6 feat: smart tooltip in datasourcepanel (#18080) 2022-02-07 22:48:23 +08:00