QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-11 04:15:33 +00:00
Code Issues Packages Projects Releases Wiki Activity
14,066 Commits 420 Branches 541 Tags
4e94fc4cff9e7dff2ddd7c176b647bdb19b9b1e2
Commit Graph

164 Commits

Author SHA1 Message Date
Rob Moore
4e94fc4cff fix(sqllab): reinstate "Force trino client async execution" (#25680) 2023-10-19 16:38:13 +03:00
Ville Brofeldt
e56e0de458 fix: revert fix(sqllab): Force trino client async execution (#24859) (#25541) 2023-10-13 11:58:20 +00:00
Rob Moore
cfda30c81a fix(sqllab): Force trino client async execution (#24859) 2023-09-06 14:20:26 -07:00
Hugh A. Miles II
d8496425e2 fix: DML failures in SQL Lab (#25190) 2023-09-06 09:41:36 -03:00
EugeneTorap
fc89718d48 chore: Update pylint to 2.17.4 (#24700) 
Co-authored-by: John Bodley <john.bodley@gmail.com>
 2023-07-24 17:13:49 -07:00
Santiago Cárdenas
e13b80aff1 fix(sql-lab): SQL Lab commit connection even if no CTA query is made (#19808) 
Co-authored-by: Santiago <s@inkremental.co>
 2023-06-07 16:35:23 -06:00
John Bodley
a4d5d7c6b9 chore(pre-commit): Add pyupgrade and pycln hooks (#24197) 2023-06-01 12:01:10 -07:00
Sebastian Liebscher
1583090623 chore(sqllab): remove deprecated PyArrow API (#24135) 2023-05-20 21:57:18 +03:00
John Bodley
0496779434 chore: Update QUERY_LOGGER and SQL_QUERY_MUTATOR signatures (#24029) 2023-05-19 06:42:19 -07:00
John Bodley
d583ca9ef5 chore: Embrace the walrus operator (#24127) 2023-05-19 00:37:13 -07:00
Artem Shumeiko
c839d0daf5 chore: Localization of superset pt. 2 (#22772) 2023-01-30 09:20:43 -07:00
Hugh A. Miles II
9c0d6c51f1 chore(ssh-tunnel): Refactor establishing raw connection with contextmanger (#22366) 2022-12-29 14:20:45 -05:00
Ville Brofeldt
b6d39d194c feat(trino): support early cancellation of queries (#22498) 2022-12-24 06:31:46 +02:00
Hugh A. Miles II
e23efefc46 feat: refactor all get_sqla_engine to use contextmanager in codebase (#21943) 2022-11-15 13:45:14 -05:00
Hugh A. Miles II
e6c44e02cb chore: stop logging "SyntaxError" as exceptions (#21787) 2022-10-13 11:58:02 -04:00
Jesse Yang
77db0651d8 feat(sql lab): display presto and trino tracking url (#20799) 2022-07-26 20:20:08 -07:00
Hugh A. Miles II
e5e8867394 feat: Visualize SqlLab.Query model data in Explore 📈 (#20281) 2022-07-15 19:34:02 -04:00
John Bodley
ad308fbde2 chore(rls): Remove passing global username (#20344) 
* chore(rls): Remove passing global username

* Update manager.py

* Update manager.py

* Update manager.py

* Update manager.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2022-07-05 10:51:24 -07:00
Diego Medina
92057858c2 fix(sql lab): View result button is not showing consistently (#20164) 2022-06-02 22:53:59 -06:00
Hugh A. Miles II
660af409a4 feat: Save column data into json_metadata for all Query executions (#20059) 
* add save_metadata function to QueryDAO

* use set_extra_json_key

* added test

* Update queries_test.py

* fix pylint

* add to session

* add to session

* refactor

* forgot the return
 2022-05-18 13:11:14 -04:00
John Bodley
449d08b25e fix: Refactor SQL username logic (#19914) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2022-05-12 21:03:05 -07:00
Beto Dealmeida
f2881e5bbd feat: RLS for SQL Lab (#19999) 
* feat: RLS for SQL Lab

* Small fixes

* Pass username to security manager

* Update docstrings

* Add tests

* Remove type from docstring
 2022-05-12 11:03:01 -07:00
Luis Casillas
1fa841ee29 Revert "fix(sql lab): display the 'View Results' button consistently in the history tab on sync mode (#19362)" (#19906) 
This reverts commit 6d5d03e592.
 2022-05-02 11:45:43 -06:00
Jesse Yang
231716cb50 perf: refactor SIP-68 db migrations with INSERT SELECT FROM (#19421) 2022-04-19 18:58:18 -07:00
Diego Medina
6d5d03e592 fix(sql lab): display the 'View Results' button consistently in the history tab on sync mode (#19362) 
* fix(sql lab): display the 'View Results' button in the history tab when running sync queries

* pr comment
 2022-04-13 10:20:32 -06:00
Elizabeth Thompson
d645579cdd chore!: update mutator to take kwargs (#19083) 
* update mutator to take kwargs

* update updating.md

* lint

* test that the database name is properly passed in to the mutator
 2022-03-18 16:01:27 -07:00
Sujith Kumar S
7e51b200b4 fix(mssql): support top syntax for limiting queries (#18746) 
* SQL-TOP Fix For Database Engines

MSSQL is not supporting LIMIT syntax in SQLs. For limiting the rows, MSSQL having a different keyword TOP. Added fixes for handling the TOP and LIMIT clauses based on the database engines.

* Teradata code for top clause handling removed from teradata.py

Teradata code for top clause handling removed from teradata.py file, since we added generic section in base engine for the same.

* Changes to handle CTE along with TOP in complex SQLs

Added changes to handle TOP command in CTEs, for DB Engines which are not supporting inline CTEs.

* Test cases for TOP unit testing in MSSQL

Added multiple unit test cases for MSSQL top command handling and also along with CTEs

* Corrected the select_keywords name key in basengine

Corrected the select_keywords name key in basengine

* Changes based on as per review.

made the required corrections based on code review to keep good code readability and code cleanliness.

* Review changes to correct lint and typo issues

Made the changes according to the review comments.

* fix linting errors

* fix teradata tests

* add coverage

* lint

* Code cleanliness

Moved the top/limit flag check from sql_lab to core.

* Changed for code cleanliness

Changes for keeping code cleanliness

* Corrected lint issue

Corrected lint issue.

* Code cleanliness

Code cleanliness

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
 2022-02-21 09:58:39 +02:00
Craig Rueda
6a63a21e06 chore: Bumping pyarrow / pandas (#17290) 
* Bumping pyarrow / pandas

* Appeasing the pylint gods

* Adjusting UPDATING.md

* Buping testing requirements
 2021-10-31 10:47:02 -07:00
Amit Miran
029ed90afb fix: preventing sql lab None limit value (#17155) 
* fix: preventing sql lab None limit value

* test: create a test for the fix

* pylint (#17172)

* add test (#17173)

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
 2021-10-20 23:43:14 +03:00
ofekisr
c520eb79b0 refactor: sqllab: move sqllab ralated enumns and utils to more logical place (#16843) 
* refactor move QueryStatus to common

* refactor move apply_display_max_row_limit to sqllab package

* refactor move limiting_factor to sqllab package

* fix pylint issues
 2021-09-26 21:15:57 +03:00
John Bodley
fb4650a6eb chore(pylint): Remove top-level disable (#16589) 
* chore(pylint): Remove top-level disable

* Update examples.py

* Update command.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-09-15 09:30:23 -07:00
Shaoqing Hu
d0f69f2e5c fix: pybabel extract fails (#16629) 
* fix pybabel extract fails

* fix black

* trigger GitHub actions
 2021-09-09 14:28:25 +03:00
John Bodley
be7065faf8 chore(pylint): Reenable raise-missing-from check (#16266) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-08-17 10:26:10 +12:00
John Bodley
6d3e19d857 fix(15403): Re-enable canceling query for Hive and Presto (#15878) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-07-26 08:04:56 -07:00
Peter Kosztolanyi
02032ee8a4 feat: cancel db query on stop (#15403) 
* feat: cancel db query on stop

* fix pylint

* Add unit tests

* Do not bind multiple times

* Stop only running queries

* Postgres to cancel only the required query

* Remove extra log

* Add docstring

* Better types, docstring and naming

* Use python3 format strings

* Update superset/sql_lab.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Add cancel_query_on_windows_unload option to database

* Return cancel_query as bool

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-07-13 12:09:22 -04:00
Beto Dealmeida
241ee32f56 feat: custom error SQL Lab timeout (#15342) 
* feat: custom error SQL Lab timeout

* Update test
 2021-06-24 08:02:49 -07:00
Beto Dealmeida
4b00c152cc feat: implement specific errors for SQL Lab (#15206) 
* RESULTS_BACKEND_NOT_CONFIGURED_ERROR

* DML_NOT_ALLOWED_ERROR

* INVALID_CxAS_QUERY_ERROR

* Fix lint

* Add more tests
 2021-06-23 07:58:20 -07:00
Beto Dealmeida
d625f5f111 feat: show rich error messages on past failed queries (#15158) 
* feat: store SIP-40 error payload with queries

* Set errors in query on load
 2021-06-16 12:58:14 -07:00
Ke Zhu
31da394676 Stop using deprecated task API (#15062) 2021-06-10 17:57:12 -06:00
Mikhail Kumachev
11eef251b2 feat: Add "is_select_query" method to base engine spec to make it possible to override it (#15013) 2021-06-07 17:32:33 -07:00
cccs-rc
f55882e756 fix: SQL Statement on QUERY_LOGGER prints none to log (#14358) 2021-05-06 17:50:19 +03:00
AAfghahi
e507508b48 feat: Logic added to limiting factor column in Query model (#13521) 
* Sqllab limit

* Add migration script

* Set default values

* initial push

* revisions

* Update superset/views/core.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* moving migration to separate PR

* with migration

* revisions

* Fix apply_limit_to_sql

* all but tests

* added unit tests

* revisions

* Update superset/sql_lab.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/sql_parse.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* fixed black issue

* Update superset/views/core.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* updated logic

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-04-30 15:15:18 -07:00
Sam Faber-Manning
11260b3117 chore: add stack trace to all calls of logger.error (#14382) 2021-04-30 09:22:05 -07:00
Lily Kuang
7980b767c0 feat: Implement Celery SoftTimeLimit handling (#13740) 
* log soft time limit error

* lint

* update test
 2021-04-12 13:18:17 -07:00
Beto Dealmeida
8bdd01e984 fix: don't close cursor before closing connection (#12821) 2021-01-28 14:32:00 -08:00
Beto Dealmeida
4255c22d01 feat: add decorator to guard public APIs (#12635) 
* feat: add decorator to guard public APIs

* Add unit tests

* Refactor to use unit tests

* Paramterize tests

* Remove decorator
 2021-01-22 13:06:14 -08:00
Beto Dealmeida
164db3e5a1 fix: CTAS on multiple statements (#12188) 
* WIP

* Add unit tests for sql_parse

* Add unit tests for sql_lab
 2021-01-04 09:22:35 -08:00
Beto Dealmeida
54bf70733f feat: run BQ queries as single statement (#11904) 
* feat: run BQ queries as single statement

* Update deps

* Fix lint

* Update superset/sql_lab.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
 2020-12-03 13:20:23 -08:00
Bogdan
0396c705d4 chore: Support SET & SHOW commands as read only SQL commands (#11868) 
* Support SET & SHOW commands as read only SQL commands

* Move is_readonly definition into the engine spec

* Rename & use super()

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-12-03 10:44:11 -08:00
Bogdan
ac2937a6c5 fix: use nullpool in the celery workers (#10819) 
* Use nullpool in the celery workers

* Address comments

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-09-10 13:29:57 -07:00