Commit Graph

75 Commits

Author SHA1 Message Date
Kamil Gabryjelski
4fd993c4e0 refactor: Replace react-bootstrap tabs with Antd tabs (#11090)
* Replace tabs in profile

* Replace tabs in SouthPane

* Replace tabs in TabbedSqlEditors

* Add typing for dropdown

* Add license

* Remove isSelected

* Fixes

* Add data-test

* Fix test

* Remove unnecessary style

* Remove unnecessary style

* Tests fix

* Tests fix

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Tabs.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Remove inModal prop

* Remove inModal from storybook

* Move inline style to styled component

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-10-02 13:07:52 -07:00
ʈᵃᵢ
7a72082d31 fix: Revert "Replace reactable with DataTable from superset-ui in QueryTable (#10981)" (#11125)
This reverts commit e93d92e8ac.
2020-10-01 10:06:22 -07:00
Moriah Kreeger
e7a4265c30 feat: saved query list actions (#11109) 2020-09-30 18:18:34 -07:00
Lily Kuang
e337355162 refactor: table selector on dataset editor (#10914)
Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
2020-09-28 11:16:03 -07:00
Kamil Gabryjelski
2fd8fca207 chore: Clean up some console warnings (#11061)
* Upgrade a few packages

* Update some prop types

* Update HTML

* Moar warning fixes

* Remove wrapper div
2020-09-28 09:43:21 -07:00
Grace Guo
f99753a800 Revert "ESLint: Re-enable rule default-props-match-prop-types (#10868)" (#11050)
This reverts commit 9f01a7fdf8.
2020-09-24 12:33:38 -07:00
Kamil Gabryjelski
e93d92e8ac Replace reactable with DataTable from superset-ui in QueryTable (#10981)
* Replace reactable with DataTable from superset-ui in QueryTable

* Fix tests

* Fix pagination

* Fix tests
2020-09-22 13:24:30 -07:00
Kamil Gabryjelski
9f01a7fdf8 ESLint: Re-enable rule default-props-match-prop-types (#10868)
* Re-enable rule default-props-match-prop-types

* Restore default props and remove isRequired

* Remove unused props
2020-09-22 13:17:41 -07:00
adam-stasiak-polidea
dc893fe1b3 chore: selectors refactor in SQLLab test suite (Cypress) (#10944)
* changed selectors for not skipped tests in sqllab suite

* linter fixes

* linter fixes
2020-09-21 15:49:44 -07:00
Kamil Gabryjelski
a8f5029cb1 ESLint: Remove ts-ignore comments (#10933)
* Upgrade json-bigint, add @types/json-bigint to deps

* Upgrade react-bootstrap-dialog

* Fix ts-ignore

* Fix ts-ignore

* Fix ts-ignore

* Upgrade react-syntax-highlighter, fix ts-ignore

* Fix ts-ignore

* Fix ts-ignore in styles.tsx

* Wrap Input in div to pass onPaste

* Change esm to cjs imports for highlighter to fix tests

* Add null checks
2020-09-21 15:47:33 -07:00
Kamil Gabryjelski
4835d3b0a2 ESLint: Re-enable rule no-access-state-in-setstate (#10870)
* Re-enable rule no-access-state-in-setstate

* Move accessing event values out of async functions
2020-09-20 23:48:23 -07:00
Kamil Gabryjelski
557a303cc5 ESLint: Enable rule no-named-as-default (#10879)
* Enable rule no-named-as-default

* Fix wrong import
2020-09-18 13:41:01 -07:00
Kamil Gabryjelski
ccfd293227 ESLint: no-restricted-syntax (#10889)
* Enable no-restricted syntax rule

* Fix webpack.config.js

* Remove unused function from utils/common.js

* Refactor triple nested for loop

* Fix loops in src/explore components

* Fix loops in SqlLab components

* Fix loops in AlteredSliceTag

* Fix loops in FilterableTable

* Add fixtures and uinit tests for findControlItem

* Add license
2020-09-18 09:05:57 -07:00
Kamil Gabryjelski
281305e0cf Enable anchor-has-content rule (#10908) 2020-09-16 13:27:52 -07:00
Jesse Yang
0129c4253d feat: move ace-editor and mathjs to async modules (#10837)
Follow up on #10831, move brace and mathjs to async modules so that the initial page load for dashboards most pages can be faster.
2020-09-15 14:12:06 -07:00
Kamil Gabryjelski
e28f3d6220 Re-enable rule line-between-class-members (#10862) 2020-09-14 15:41:32 -07:00
Kamil Gabryjelski
767044bfe5 ESLint: Re-enable rule control-has-associated-label (#10866)
* Re-enable rule control-has-associated-label

* Change aria-label message in DatasourceControl

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-09-14 13:00:39 -07:00
Kamil Gabryjelski
2d8f4e3aaf Re-enable rule no-else-return (#10861) 2020-09-14 13:00:07 -07:00
Kamil Gabryjelski
76275ec410 Enable rule no-plusplus (#10876) 2020-09-14 11:59:32 -07:00
Kamil Gabryjelski
d93b2b99b2 Re-enable rule sort-comp (#10872) 2020-09-14 10:45:05 -07:00
Kamil Gabryjelski
1908a94c7e ESLint: Re-enable rule no-restricted-globals (#10863)
* Re-enable rule no-restricted-globals

* Fix missing semicolons
2020-09-14 10:39:46 -07:00
Kamil Gabryjelski
906a629b33 Re-enable rule no-unused-state (#10871) 2020-09-14 10:31:16 -07:00
Kamil Gabryjelski
352e8a1afd Re-enable rule prefer-destructuring (only for objects) (#10867) 2020-09-14 10:11:20 -07:00
Maxime Beauchemin
6cb67017a5 style: white toolbar for SQL Lab (#10851) 2020-09-11 23:27:25 -07:00
Ville Brofeldt
8a9ae811d0 fix(sql-lab): relax column name restrictions (#10816) 2020-09-10 07:54:37 +03:00
Jesse Yang
9a59bdda48 refactor: merge/upgrade superset-ui packages (#10790)
* refactor: merge/upgrade superset-ui packages

* Fix flaky big number test

* Fix Flaky AdhocFilters test
2020-09-09 13:18:55 -07:00
Evan Rusackas
824cea24ba More Label touchups (margins) (#10722)
* labels with onClick don't need .pointer. No labels need `m-r-5`

* making Timer a proper Label

* a little linting

* addresing (helpful, thanks) comment
2020-09-02 23:13:58 -07:00
Evan Rusackas
9fe30ab71e style: Pass at propagating (and enhancing) Button component throughout Superset (#10649)
* getting rid of weird focus/active outline ring

* Buttons... buttons _everywhere_

* linting

* Nixing views/CRUD/dataset/Button component

* fixing 2 typing errors

* fixing more TS errors

* prefer src path for include

* one more real button, one less CSS class

* one more "button" to "Button"

* Published Status is now a proper clickable Label

* nixing the CRUD button again

* touching up stories, with SupersetButton story

* SIP-34 button colors

* adding polished package to mix colors

* updating button colors to match Superset theme

* abstracting away from bootstrap-specific props (might pivot libraries soon!)

* more abstraction from bsStyle/bsSize props

* exchanging styles for a prop

* linting

* restoring feature flag to stock

* using src alias

* last <button> replacement

* this classname would never be applied

* more linting action

* fixing unsupported bsSize 'medium', and cta typing error

* more cta action

* unnecessary styles

* errant bsSize prop

* cleanup

* tweaks to make new New button work

* Linting

* fixing a couple tests

* fixing theme based test failure

* margin tweak for NEW button

* another fixed test

* another fixed test

* fixing two more tests

* fixing last broken tests.

* always be linting

* Adding tertiary/dashed buttons

* cleaning up QueryAndSave buttons

* fixing "link" button styles

* fixing/updating link button styles

* cta buttons on Modal component

* linting.

* exporting button story knobs, making ALL knobs safe for export.

* capitalizing a file... no big whoop

* Basic button tests

* renaming button - temporarily

* renaming file to fix capitalization issue

* passing theme through to a difficult popover.

* fixin' a newly busted unit test

* lint fixin'

* oops, shouldn't have changed this prop!

* adding a dive() to themedShallow, and fixing a cypress/jest test

* addressing lint stuff

* touching up stories, with SupersetButton story

* SIP-34 button colors

* updating button colors to match Superset theme

* abstracting away from bootstrap-specific props (might pivot libraries soon!)

* linting

* restoring feature flag to stock

* cleanup

* Linting

* renaming button - temporarily

* renaming file to fix capitalization issue

* oops, shouldn't have changed this prop!

* adding a dive() to themedShallow, and fixing a cypress/jest test

* addressing lint stuff

* nixing new modal button

* Fixing another popover/button issue that should break cypress

* lint 

* passing classNames through to new button (should fix some tests)

* cleaning unused classes, making cypress tests use data attrs

* fixin' the test

* fixing another class-based test with data-test attr

* no longer passing theme as prop to buttons in popovers... themeprovider is better

* outline/border tweaks!
2020-08-28 17:34:28 -07:00
Evan Rusackas
844b471509 fix: removing unsupported modal sizes (#10625)
* fix: removing unsupported modal sizes

* linting!

* NOT specifying bsSize seems to have the same effect as (unsupported) "medium"

* supporting 'large' and 'small' over 'lg' and 'sm'
2020-08-18 14:33:39 -07:00
David Aaron Suddjian
83af9d12f8 fix(sqllab): Handle long table names in SQL Lab (#10518)
* widen the autocomplete menu for table names

* display the full table name in a tooltip

* license

* Update superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* src importing

* move autocomplete width css to main.less

* use html title attribute instead of tooltip

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-08-11 09:50:46 -07:00
Maxime Beauchemin
613dd12fbf fix: misaligned LimitControl buttons and port jsx->tsx (#10529)
* fix: misaligned LimitControl buttons and port jsx->tsx

* addressed comments
2020-08-10 15:35:39 -07:00
Maxime Beauchemin
0bad77f0fe chore: TypeScript <Label /> (#10494)
* chore: TypeScript <Label />

* rebase

* chore: TypeScript <Label />

* rebase

* A bunch o' test fixes. One more to go!

* helper for mountying Emotional components with Enzyme

* asf license

* fixed last test, some linting

* improve the storybook

* Adressing comments

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-08-06 22:33:07 -07:00
Maxime Beauchemin
edaf785815 fix(sqllab): button width isn't wide enough for 'Run Selection' (#10461) 2020-07-29 16:21:21 -07:00
Maxime Beauchemin
0483c26254 style(sqllab): fixed button width as label changes (#10404)
As the label change from RUN to STOP, the row of button shifts
left/right. This fixes the width so that it doesn't jitter.
2020-07-24 10:05:07 -07:00
Maxime Beauchemin
b438ba9ed5 chore: wiring ControlLabel to a new FormLabel (#10388)
* chore: wiring ControlLabel to a new FormLabel

Creating new simple <FormLabel /> component and wiring all <label>
and react-bootstrap.ControlLabel towards it.

FormLabel becomes a pivotal point that can be altered to point to AntD
when we're ready.

* lint

* ViewportControl

* addressing comments
2020-07-23 00:27:22 -07:00
Erik Ritter
5fa4680447 feat: update timeout error UX (#10274) 2020-07-20 15:32:17 -07:00
Erik Ritter
5984df3522 chore: enable no-static-element-interactions eslint rule (#10351) 2020-07-17 09:19:16 -07:00
Erik Ritter
09de805017 chore: enable no-unused-vars and prefer-template eslint rules (#10350) 2020-07-16 19:13:59 -07:00
ʈᵃᵢ
0eee6785a8 feat(listviews): SIP-34 Bulk Select (#10298) 2020-07-16 16:07:49 -07:00
Ville Brofeldt
611dd7a8f6 fix: make __time an ok column name in SQL Lab (#10336) 2020-07-16 10:34:50 +03:00
Grace Guo
2f147cfedc fix: add additional ui tweaks (#10275)
* fix: add additional ui tweaks

* use fa fa-close class for x icon

* use new svg icons
2020-07-15 14:05:30 -07:00
Erik Ritter
518dbd05b6 chore: add typing to more sqllab components (#10278) 2020-07-14 16:39:56 -07:00
Erik Ritter
80902bca50 chore: add typing to profile (#10282) 2020-07-14 16:39:37 -07:00
Maxime Beauchemin
11ae48062f fix: broken glyphicons used in react-json-schema (#10267)
I'm working on a talk for the Airflow Summit
"Advanced Apache Superset for Data Engineers" and showing the "Schedule
Query" feature that Beto contributed a while back (behind a feature flag).

I found that the glyphicons used in `react-json-schema` are broken and
came up with an easy fix.

Also other minor tweaks on the feature.
2020-07-14 15:40:39 -07:00
Grace Guo
6690963ec2 feat: minor reorder SQL Lab Tab controls (#10257) 2020-07-08 16:21:47 -07:00
Erik Ritter
9a5195ab85 feat: support new errors payload in SQL Lab (#10243) 2020-07-06 09:49:32 -07:00
Erik Ritter
4281ad5486 chore: type ResultSet.tsx (#10226) 2020-07-02 10:12:31 -07:00
Jason Davis
72fc581b15 added explore database for ctas/cvas (#10174)
Co-authored-by: Jason Davis <@dropbox.com>
2020-06-29 11:13:54 -07:00
Jason Davis
9de9e1c19d feat: Added configuration to SQL Lab results "Explore" button (#10164)
* added configuration to virtual table explore button

* added description to mixin

* fixed unit tests

Co-authored-by: Jason Davis <@dropbox.com>
2020-06-26 09:54:55 -07:00
Maxime Beauchemin
1781ebbaa4 fix: [search query view] edit link is broken (#10128)
* fix: [search query view] edit link is broken

* eslint + mypy

* rever app.py changes

* addressing comments

* use api/v1/query

* fix test
2020-06-25 12:20:10 -07:00