John Bodley
ed0d288ccd
chore(dao): Replace save/overwrite with create/update respectively ( #24467 )
2023-08-11 12:55:39 -07:00
EugeneTorap
fc89718d48
chore: Update pylint to 2.17.4 ( #24700 )
...
Co-authored-by: John Bodley <john.bodley@gmail.com >
2023-07-24 17:13:49 -07:00
Daniel Vaz Gaspar
cb9b865a53
fix: import database engine validation ( #24697 )
2023-07-20 13:08:07 +01:00
Hugh A. Miles II
d041648ad4
fix(ssh): Editting Database w/ SSH Tunneling ( #24552 )
2023-07-06 15:43:55 -04:00
John Bodley
7409289762
chore(dao): Condense delete/bulk-delete operations ( #24466 )
...
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com >
2023-07-06 09:21:08 -07:00
John Bodley
92e2ee9d07
chore(dao): Add generic type for better type checking ( #24465 )
2023-06-21 09:30:07 -07:00
John Bodley
3e76736874
chore(dao): Organize DAOs according to SIP-92 ( #24331 )
...
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com >
2023-06-18 18:32:32 -07:00
Rob Moore
6d9df432c1
fix(sqllab): Inefficient SqlaTable query ( #24343 ) ( #24344 )
2023-06-12 12:14:07 +03:00
John Bodley
a4d5d7c6b9
chore(pre-commit): Add pyupgrade and pycln hooks ( #24197 )
2023-06-01 12:01:10 -07:00
John Bodley
8b4222ff9e
chore: Refactor command exceptions ( #24117 )
2023-05-19 09:08:12 -07:00
John Bodley
d583ca9ef5
chore: Embrace the walrus operator ( #24127 )
2023-05-19 00:37:13 -07:00
Beto Dealmeida
f78798149a
fix: load examples as anon user ( #23600 )
2023-04-06 08:23:00 -07:00
Beto Dealmeida
ec6318b379
fix: permission checks on import ( #23200 )
2023-03-15 08:31:09 -07:00
Hugh A. Miles II
b820eb8235
chore: Update pre-commit packages ( #23173 )
2023-03-13 17:05:13 -06:00
Hugh A. Miles II
0a7016df2e
chore: Add statsd logger for ssh tunneling creation ( #23225 )
2023-02-28 11:21:40 -05:00
Antonio Rivero
3484e8ea7b
feat(ssh_tunnel): Import/Export Databases with SSHTunnel credentials ( #23099 )
2023-02-24 09:36:21 -08:00
Diego Medina
02cd75be8d
chore: Migrate /superset/tables/* to API v1 ( #22501 )
2023-02-01 12:45:57 +00:00
Antonio Rivero Martinez
d6a4a5da79
feat(ssh_tunnel): Add feature flag to SSH Tunnel API ( #22805 )
2023-01-26 16:53:36 -08:00
Hugh A. Miles II
2de19f1d66
feat: Add logging for ssh tunneling test_connection attempts ( #22625 )
2023-01-12 21:49:35 +00:00
Antonio Rivero Martinez
539936522f
feat(ssh_tunnel): SQLAlchemy Form UI ( #22513 )
...
Co-authored-by: hughhhh <hughmil3s@gmail.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
2023-01-11 19:29:52 +00:00
Hugh A. Miles II
ebaad10d6c
feat(ssh-tunnelling): Setup SSH Tunneling Commands for Database Connections ( #21912 )
...
Co-authored-by: Antonio Rivero Martinez <38889534+Antonio-RiveroMartnez@users.noreply.github.com >
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
2023-01-03 17:22:42 -05:00
EugeneTorap
394fb2f2d0
fix: slug is empty if filename is non-ASCII ( #22118 )
2022-11-16 10:53:30 -08:00
Hugh A. Miles II
e23efefc46
feat: refactor all get_sqla_engine to use contextmanager in codebase ( #21943 )
2022-11-15 13:45:14 -05:00
Antonio Rivero Martinez
203b289021
feat(bigquery): Custom message when Service Account doesnt have the correct Roles and Permissions ( #21838 )
2022-10-26 19:44:09 -04:00
Elizabeth Thompson
e98943e580
refactor: pass all properties to validate_parameters ( #21487 )
2022-10-03 17:48:54 -07:00
Beto Dealmeida
34a79add04
feat: filter parameters from DB API ( #21248 )
2022-09-02 11:50:04 -07:00
Daniel Vaz Gaspar
3f2e894af3
fix: dataset name change and permission change ( #21161 )
...
* fix: dataset name change and permission change
2022-08-31 18:11:03 +01:00
Beto Dealmeida
8772e2cdb3
fix: improve get_db_engine_spec_for_backend ( #21171 )
...
* fix: improve get_db_engine_spec_for_backend
* Fix tests
* Fix docs
* fix lint
* fix fallback
* Fix engine validation
* Fix test
2022-08-29 11:42:42 -07:00
Daniel Vaz Gaspar
bfd2a3d79f
fix: database permissions on update and delete (avoid orphaned perms) ( #20081 )
...
* fix: database permissions on update and delete (avoid orphaned perms)
* fix event transaction
* fix test
* fix lint
* update datasource access permissions
* add tests
* fix import
* fix tests
* update slice and dataset perms also
* fix lint
* fix tests
* fix lint
* fix lint
* add test for edge case, small refactor
* add test for edge case, small refactor
* improve code
* fix lint
2022-08-02 18:28:46 +01:00
John Bodley
f0ca158989
fix: Refactor ownership checks and ensure consistency ( #20499 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2022-07-07 11:04:27 -07:00
Phillip Kelley-Dotson
5111011de9
fix: dbmodal test connection error timeout ( #20068 )
...
* fix: check for connect on ping
* clean up merge
* fix merge
* precommit
2022-05-17 10:04:52 -07:00
John Bodley
449d08b25e
fix: Refactor SQL username logic ( #19914 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2022-05-12 21:03:05 -07:00
Daniel Vaz Gaspar
87a4379d0a
feat: deprecate /superset/validate_sql_json migrate to api v1 ( #19935 )
...
* feat: deprecate /superset/validate_sql_json migrate to api v1
* use new error handling
* migrate SQLLAb frontend and add tests
* debug test
* debug test
* fix frontend test on sqllab
* fix tests
* fix frontend test on sqllab
* fix tests
* fix tests
* fix tests
* fix tests
2022-05-10 21:25:39 +01:00
Craig Rueda
f64d654de3
chore(database): Creating helper make_url_safe to wrap potential errors ( #19526 )
...
* Creating helper make_url_safe to wrap potential errors
* Fixing imports
* Fixing imports again
* Adding comment
* Linting
* Fixing test
* Fixing test again...
* Fixing import
2022-04-05 11:17:30 -07:00
Ville Brofeldt
a619cb4ea9
chore: upgrade black ( #19410 )
2022-03-29 20:03:09 +03:00
Richard Whaling
202e34a259
feat: add duckdb as DataSource - Fixes #14563 ( #19317 )
...
* + duckdb support
needs the forked version of [duckdb-engine](https://github.com/alitrack/duckdb_engine )
* Update duckdb.py
update _time_grain_expressions
* removed superfluous get_all_datasource_names def in duckdb engine spec
* added exception handling for duckdb single-threaded RuntimeError
* fixed linter blips and other stylistic cleanup in duckdb.py
* one last round of linter tweaks in test_connection.py for duckdb support
Co-authored-by: Steven Lee <admin@alitrack.com >
Co-authored-by: Richard Whaling <richardwhaling@Richards-MacBook-Pro.local >
2022-03-24 15:07:57 +08:00
Beto Dealmeida
d01fdad1d8
feat: add export_related flag ( #19215 )
...
* feat: add export_related flag
* Fix lint
2022-03-16 16:03:06 -07:00
Elizabeth Thompson
c143b37128
chore: log multiple errors ( #14064 )
...
* log all errors from db create
* return unique set of errors
* sort set for exceptions list
* run black
2022-03-08 17:31:19 -08:00
Beto Dealmeida
51090c3f1b
feat: shorter timeout on test_connection ( #18001 )
...
* feat: shorter timeout on test_connection
* pip-compile-multi --no-upgrade
* Fix for SQLite
* Return 408
* Add test
2022-01-12 13:01:34 -08:00
Ville Brofeldt
5d1c9078ad
chore(translations): fix translation literals ( #17501 )
...
* chore(translations): fix translation literals
* fix table name types and translations
* fix lint
* join concat'd messages
2021-11-23 10:06:09 +02:00
Beto Dealmeida
cb34a22684
fix: import should accept old keys ( #17330 )
...
* fix: import should accept old keys
* Fix lint
* Preserve V1 schema
2021-11-03 11:25:30 -07:00
Shiva Raisinghani
ef3afbde82
refactor: Repeated boilerplate code between upload to database forms ( #16756 )
...
* abstract boilerplate code into class and rename csv to file
* add db migration
* fix some stuff
* more renaming of csv to file
* rename in translations
* update down revision
* update down revision
* bump chart version
* switch to alter column name approach in db migration
* fix db migration for MySQL
* db migration conflict
2021-10-25 13:53:06 +03:00
AAfghahi
376c685838
feat: adding logging to validation ( #16527 )
...
* adding logging to validation
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
2021-09-13 16:09:40 -07:00
Ville Brofeldt
ac1d779a30
chore(ci): bump pylint to 2.10.2 ( #16463 )
2021-08-26 20:30:41 +03:00
John Bodley
7e4c940314
chore(pylint): Enable useless-suppression check ( #16388 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-08-24 03:58:41 +12:00
John Bodley
be7065faf8
chore(pylint): Reenable raise-missing-from check ( #16266 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-08-17 10:26:10 +12:00
Beto Dealmeida
7b15b7690d
fix: DB exported with incorrect type ( #16037 )
...
* fix: DB exported with incorrect type
* Fix export as well
2021-08-03 08:35:48 -07:00
Hugh A. Miles II
bfe7eb9a7b
feat(dbc ui): Adding Google Sheets Dynamic Form ( #15801 )
...
* feat: Make Google Sheets Dyanmic (#15576 )
* first draft
* second draft
* added tests
* first draft
* added table_catalog
* remove console.log
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* revisions
* save this for now
* working form
* save disable on public sheets
* refactor somethings
* saving this for now
* working edit
* add back query to schema
* working add
* fix styling
* fixing x
* fix linting
* prettier
* fix some type issues
* more lint fixes
* remove unused dependency
* fix linint
* fix validation
* pylint bypass
* pylint bypass
* fix this
* fix mypy
* yerp
* fix test
* fix test
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* wrap add sheets
* fix linting issues
* fix unit test
* ignore typing
* fix editting and paste issues
* remove query
* fix this
* fix test
* add test back
* fix error messaging
* update url messaging on error
* change error type
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* add errors for sheets with no name
* fix
* fix messaging for gsheets
* stop pylint
* update line
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com >
Co-authored-by: Arash <arash.afghahi@gmail.com >
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
2021-07-28 15:00:27 -04:00
John Bodley
ab4e3b9bf9
chore: Enforce Mypy for non-tests ( #15757 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-07-22 06:46:43 +12:00
Hugh A. Miles II
d4480f5c9a
feat: Database Connection UI ( #14881 )
2021-07-01 14:40:27 -07:00
