Josh Soref
bebb10e495
chore(frontend-tests): Spelling ( #19853 )
...
* spelling: against
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: been
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: charts
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: clicking
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: columns
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: duplicate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: especially
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: extensions
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: fields
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: filter
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: for
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: label
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: labeled
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: nativefilter
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: registry
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: render
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: resizable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: response
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: successful
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: transform
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: unfortunately
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: until
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: virtual
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: wrapper
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com >
2022-04-26 10:35:01 -07:00
Ville Brofeldt
2ba484fe43
fix: login button does not render ( #19685 )
...
* fix: login button does not render
* add type guard
2022-04-13 16:04:04 +03:00
AAfghahi
4bf4d58423
fix: update Permissions for right nav ( #19051 )
...
* draft pr
* finished styling
* add filter
* added testing
* added tests
* added permissions tests
* Empty-Commit
* new test
* Update superset-frontend/src/views/components/MenuRight.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* revisions
* added to CRUD view
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
2022-04-11 16:50:59 -04:00
Yongjie Zhao
761d5c4208
chore: cleanup as unknown conversion ( #19587 )
2022-04-08 17:32:29 +08:00
Stephen Liu
dc575080d7
feat: improve color consistency (save all labels) ( #19038 )
2022-03-21 15:20:04 +08:00
Jesse Yang
ae13d8313b
feat(select): keep options order when in single mode ( #19085 )
2022-03-11 13:01:38 -08:00
Kamil Gabryjelski
3c1fb944c1
perf(dashboard): Improve performance of complex dashboards ( #19064 )
...
* perf(dashboard): Improve performance of filter indicators
* Improve perf of cross filters
* Rename old function
* Fix undefined
* fix type
* fix tests
* fix undefined
* Address code review comments
* Address code review comments
2022-03-09 22:39:58 +01:00
smileydev
6fe2431676
fix(nested-tab-available): make the another tabs into one tabs available ( #18877 )
...
* fix(nested-tab-available): make the another tabs into one tabs available
* fix(netsted-tab): remove code of disable nested tab
2022-03-03 13:22:49 -07:00
John Bodley
26486d01c1
chore: Remove legacy SIP-15 interim logic/flags ( #18936 )
...
* chore: Remove legacy SIP-15 logic
* Update ab9a9d86e695_deprecate_time_range_endpoints.py
* Update UPDATING.md
* Update UPDATING.md
* Update UPDATING.md
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2022-03-04 09:15:36 +13:00
David Aaron Suddjian
da3bc48803
feat: On window focus, redirect to login if the user has been logged out ( #18773 )
...
* /me api
* test it
* watch for window activation and check auth
* simplify
* more comment
* making ci happy
* mypy should ignore tests
2022-02-24 10:09:41 -08:00
simcha90
bcad1acec2
feat: Dynamic dashboard component ( #17208 )
...
* fix:fix get permission function
* feat: dynamic loading of dashboard components
* fix: revert image
* fix: fix py
* fix: fix py
* fix: pass state to dynamic component
* lint: add typing
* lint: fix lint
* lint: fix lint
* refactor: re-run pipeline
* fix: fix CR notes
* fix: fix CR notes
* move types and interfaces to core
* reorder exports
* rename Scope and Target
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com >
2022-02-09 17:44:40 +02:00
Michael S. Molina
bb7e979142
chore: Moves spec files to the src folder - iteration 9 ( #17901 )
2022-01-07 15:23:57 -03:00
Phillip Kelley-Dotson
cfd851aa13
fix: replace datamask with key from new key value api ( #17680 )
...
* afirst stage to ccheck to get initial datamask
* clean up code and update typescript
* remove consoles
* fix ts and update copy dashboard url
* use key when one doesn't exists
* lint clean up
* fix errors
* add suggested changes
* remove line
* add tests and add changes for copydashboard
* fix lint
* fix lint
* fix lint
* Update superset-frontend/src/dashboard/components/Header/index.jsx
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
* add timeout
* fix test
* fix test, add qs to cypress and add suggestions
* add suggestions
* fix lint
* more suggested changes for backwards comapat
* fix lint
* cleanup naming and add qs parse to tests
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
* more changes and fix lint
* remove nativefiler param
* fix path
* remove con
* simplify logic
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
2021-12-21 09:08:48 -08:00
Yongjie Zhao
9070b6b19c
refactor(monorepo): stage 1 ( #17427 )
...
* skip geojson in pre-commit
update prettier
* update package.json
update package.json
u package
pkg
pkg2
* lint main repo 2
lint main repo
lint
* lintrc
lintrc 2
lintrc2
lintrc 3
lintrc
* fix import
* refresh lock file
* fix break line make @ts-ignore invalid
* update rat-excludes
rat-excludes
update rat-excludes
* update eslintrc.js
* lint lint lint
2021-11-17 15:31:36 +08:00
Grace Guo
7d22c9ce17
feat(native_filter_migration): add transition mode ( #16992 )
...
* feat: [Migrate filter_box to filter component] add transition mode
* rebase and fix comments
* rebase and fix commnent -- patch 2
2021-11-09 09:55:25 -08:00
Geido
59a6502efe
fix: Color consistency ( #17089 )
...
* Update label colors on the fly
* Clean up
* Improve getFormDataWithExtraFilters
* Improve code structure
* Remove labelColors from formData
* Exclude label_colors from URL
* Refactor color scheme implementation
* Clean up
* Refactor and simplify
* Fix lint
* Remove unnecessary ColorMapControl
* Lint
* Give json color scheme precedence
* Add label_colors prop in metadata
* Separate owners and dashboard meta requests
* Remove label_colors control
* bump superset-ui 0.18.19
* Fix end of file
* Update tests
* Fix lint
* Update Cypress
* Update setColorScheme method
* Use Antd modal body
2021-11-03 19:22:38 +02:00
Geido
a2a457b7ef
fix(Dashboard): Sidepanel positioning ( #17200 )
...
* Refactor
* Adjust top offset
* Calculate padding chart list
* Check for standalone mode
* Rename standaloneMode
2021-11-02 19:28:16 +02:00
Geido
91199c30d8
Handle undefined ( #17183 )
2021-10-21 19:34:32 +03:00
Ville Brofeldt
a07c9d591b
fix(dashboard): recursive parent on dashboard components ( #16933 )
...
* fix(dashboard): don't add recursive parents on wrapper component
* add test
* refine logic and add new test
2021-10-01 08:13:38 -07:00
simcha90
668ae23f28
feat: Tabs in column ( #16593 )
...
* fix:fix get permission function
* feat: add tabs inside column
* lint: fix lint
* test: fix test
* test: fix tests
* test: fix tests
* fix: pass onChangeTab function through layout
2021-09-13 09:02:29 +03:00
Kamil Gabryjelski
788c0c3dae
fix(dashboard): label colors included in explore url ( #16621 )
2021-09-08 15:38:02 +02:00
Kamil Gabryjelski
f422f1ea49
perf(dashboard): decouple redux props from dashboard components ( #16421 )
...
* perf(dashboard): decouple redux props from dashboard components
* Lint fix
* Dont make copy of filters object
* Remove unnecessary exports
2021-08-26 21:54:11 +02:00
Kamil Gabryjelski
8ad495a572
perf(dashboard): reduce number of rerenders of Charts ( #16444 )
...
* perf(dashboard): reduce number of rerenders of Charts
* Remove static property
* Cleanup
2021-08-26 21:53:44 +02:00
Michael S. Molina
07f33998ac
fix: Multiple dashboard refresh triggers for the same session ( #16094 )
2021-08-10 09:12:28 -03:00
Hugh A. Miles II
4cb79e5017
fix: Fix long dashboards screenshot emails ( #15954 )
...
* create serialize json function
* create new setting for reports
* cleanup
* address comments
* up the attributes
2021-08-02 16:37:34 -04:00
Elizabeth Thompson
9c854ff1f1
bump typescript ( #15847 )
2021-07-22 16:30:25 -07:00
Kamil Gabryjelski
9ff2531cd0
fix(dashboard): Add resize handles to right and bottom of component ( #15778 )
...
* fix(dashboard): Add resize handles to right and bottom of component
* Fix test
2021-07-20 11:23:37 +02:00
Michael S. Molina
e6bbca3f61
chore: Preserve native filters selection after refresh ( #15583 )
2021-07-13 15:14:18 -03:00
Evan Rusackas
52ad779a27
fix: safe removal of tab with filters still scoped to a non-existing chart ( #15650 )
2021-07-12 23:43:53 -06:00
Ville Brofeldt
4630abb5a8
feat(native-filters): add support for preselect filters ( #15427 )
...
* feat(native-filters): add support for sharing preselected filters
* abc
* add serialization
2021-06-29 18:57:49 +03:00
David Aaron Suddjian
cf15fe0d03
fix(dashboard): custom css should be removed on unmount ( #15025 )
...
* fix(dashboard): custom css should be removed on unmount
* better comment
* remove unnecessary typecast
* move type to top level scope
2021-06-07 14:04:56 -07:00
simcha90
e43112c5f9
feat(native-filter): Hide native filters ( #14784 )
...
* fix:fix get permission function
* feat: support showFilters
* fix: fix CR notes
* fix: fix lint issues
2021-05-31 09:05:57 +03:00
David Aaron Suddjian
884ded0507
fix: roles undefined on public dashboards ( #14648 )
2021-05-14 14:28:47 -07:00
David Aaron Suddjian
f16c708fab
fix(dashboard): check edit permissions correctly on frontend ( #14626 )
...
* fix(dashboard): check edit permissions correctly on frontend
* fix types, appease linter
* handle nulls better
2021-05-14 12:18:38 -07:00
Michael S. Molina
9cb4a4602f
fix: Fixes top level tabs and automatic scroll ( #14624 )
2021-05-14 11:50:20 -07:00
Ville Brofeldt
66a4c94a1e
fix(chart-data): handle url_params in csv export and native filters ( #14526 )
2021-05-07 21:07:44 +03:00
simcha90
bbb1f2d757
perf(native-filters): avoid unnecessary reloading of charts ( #14408 )
...
* fix:fix get permission function
* refactor: filter default value
* refactor: update default value loading
* refactor: apply defaultValues
* lint: fix lint
* lint: fix lint
* test: fix test
* refactor: use extraFormData for reload charts
* test: fix tests
* test: fix tests
* test: fix tests
2021-05-03 14:56:41 +03:00
simcha90
03e4a5b6b7
fix(native-filters): Update filter saving ( #14370 )
...
* fix:fix get permission function
* fix: not reload charts after save filters
* fix: not reload charts after save filters
* fix: temp commit type
* lint: add typing
2021-04-27 11:20:04 +03:00
simcha90
8ef572a412
refactor(native-filters): update dataMask and ExtraFormData schema ( #13983 )
...
* refactor: updates usage of `ownFilters` to `ownState`
* refactor: update dataMask (final)
* lint: fix lint
* refactor: revert feat
* fix: fix missed chart configuration
* add filter set migration
* apply new changes
* fix migration revision
* update migration
* fix jest mock
* js lint
* fix test types
* update tests and types
* remove append_form_data from tests
* fix findExistingFilterSet tests
* add migration test
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com >
2021-04-15 17:43:29 +03:00
Jesse Yang
6755083e3a
fix(dashboard): incorrect perm for users with multiple roles ( #14148 )
2021-04-14 16:04:09 -07:00
simcha90
f453287a07
fix:fix get permission function ( #14099 )
2021-04-13 09:36:13 -07:00
Phillip Kelley-Dotson
4bb29b6f04
chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata ( #13306 )
...
* add hook for future async api calls
* test to see conflict
* add async middleware and update reducers
* working async dashboard load
* implement getcharts api
* add user permissions to explore and dashboard bootstrap data
* integrate api calls with getinitial state
* update namings
* accept an id or a slug in the dashboard charts api
* add permissions function
* fix merge
* update state
* get dashboard charts by id or slug
* fix undefined states
* variable names
* stop using some more bootstrap data
* fix metadata reference
* remove unused bootstrap from the template
* add errorboundry to dashboard
* refactoring, fixing
* update permissions
* add just roles
* id is supposed to be a string
* unused vars
* get datasources from api
* make onError optional
* use resource hooks, better error boundary
* add loading state for dashboardroute
* remove console
* add conditional
* more conditionals
* testing out a possible fix for cypress
* convert edit/standalone test to cypress
* remove bootstrappy assertions
* lint
* fix dashboard edit history issue
* rename stuff
* address recent native filters schema change
* remove unused getInitialState
* remove .only from test
* hooksy redux usage
* Revert "more conditionals"
This reverts commit 25c8ed61b477dea1915bevan@preset.io >
* import style
* comment
* cleaner dashboardInfo
* remove debug code
* use memo for getPermissions
* fix lint
* adjust name/location of DashboardPage
* move logic for REMOVE_SLICE_LEVEL_LABEL_COLORS to DAO
* stop using full_data()
* remove unused (and now useless) json=true query param
Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com >
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com >
Co-authored-by: Evan Rusackas <evan@preset.io >
2021-04-12 16:10:29 -07:00
Kamil Gabryjelski
bf22487e23
Make chart exclude itself from cross filtering ( #14046 )
2021-04-12 14:08:07 +03:00
Grace Guo
fa072cd74e
fix: dashboard filter scope bug ( #13695 )
...
* fix: dashboard filter scope bug
* fix comments
* fix function/variables name
2021-03-19 10:39:09 -07:00
simcha90
0e0c99b2fb
feat(cross-filters): Add scoping for cross filters ( #13625 )
...
* feat: cross filter modal
* refactor: add charts metadata
* refactor: add charts metadata
* feat: cross filters scoping
* fix: fix CR notes
* test: fix test
* lint: fix lint
2021-03-17 14:00:32 +02:00
simcha90
45972e9945
refactor(native-filters): Move filtersState to dataMask redux root ( #13437 )
2021-03-07 09:34:12 +02:00
simcha90
f19a830d9b
refactor(self-trigger): Split native filters state ( #13137 )
...
* feat: add cross filters
* refactor: fix CR notes
* lint: fix lint
* lint: fix lint
* feat: POC adding filters set feature
* chore: pre-commit
* refactor: under chage
* lint: fix TS
* fix: fix FF name
* refactor: move to behaviors
* lint: fix lint
* refactor: update state of native filters
* refactor: finish refactor nativeFilter state
* feat: split native filters state
* refactor: refactor Time filter to use new API
* refactor: refactor Time filter to use new API
* refactor: fix CR notes
* fix: fix update values in filter bar
* refactor: save filter sets in meta
* feat(filter-sets): save filters sets in metadata
* refactor: partially fix ts
* refactor: merge conflicts
* refactor: add behaviors property
* refactor: add behaviors property
* fix: undo py changes
* fix: under some changes
* refactor: synx with master
* fix: undo FF
* fix: undo FF
* lint: ts-ignore
* chore: update lock file
* refactor: update enum
* refactor: naming of enum
* test: fix test
* test: update mocks
Co-authored-by: amitmiran137 <amit.miran@nielsen.com >
2021-03-02 09:03:26 +02:00
Geido
409fc83ca9
chore: Tab title to be empty when creating a new tab ( #12773 )
...
* Remove unwanted package lock
* Edit on new and autofocus
* Update test
* Remove autofocus
2021-02-18 10:14:59 -08:00
simcha90
450215549f
fix: cross filter functionality ( #13178 )
2021-02-17 20:59:37 +02:00
simcha90
9c9becc3d5
fix: correct apply of native filter scopes ( #13165 )
2021-02-17 11:24:14 +02:00
