Commit Graph

454 Commits

Author SHA1 Message Date
Elizabeth Thompson
43b92b220f fix: dashboard edit/save errors (#10834)
* use conditional operator for lookup

* editing dashboard title should update after save

* uncomment test

* fix json metadata save

* json metadata color scheme should overwrite state

* test's functionality is no longer applicable

* add lastModifiedTime to DashboardInfo
2020-10-22 14:33:22 -07:00
Kamil Gabryjelski
30c71fd794 refactor: Replace react-bootstrap tabs with Antd tabs on Profile (#11211)
* Create styled Antd Tabs and Dropdown

* Replace Tabs in Profile view

* Change some hard coded variables to theme

* Lint fix
2020-10-22 14:19:37 -07:00
Kamil Gabryjelski
dc5e5a978b refactor: Replace usages of reactable in TableLoader (#11240)
* Refactor TableLoader to use react-bootstrap

* Remove unnecessary css classes

* Fix import

* Fix styling for no data

* Refactor TableLoader into functional component

* Convert TableLoader to typescript
2020-10-22 14:00:02 -07:00
Maxime Beauchemin
64b5aae6bc style: improve the "Create New Chart" screen's usability (#11383)
* style: make disabled buttons more readable

* making more of a CTA for VizControl
2020-10-22 10:16:58 -07:00
Daniel Vaz Gaspar
85e28dd04c perf(api): improve API info performance (#11346) 2020-10-22 08:55:13 +01:00
Moriah Kreeger
a2a614d760 feat: CSS Templates List Actions (#11271) 2020-10-21 20:32:59 -07:00
Kamil Gabryjelski
9dfe9aef39 Fix overflowing tabs (#11367) 2020-10-21 20:10:52 -07:00
Maxime Beauchemin
69046f08d4 style(sqllab): wrap text in monospace db-provided error messages (#11354) 2020-10-21 17:35:20 -07:00
Evan Rusackas
6fe7b4a202 feat: adding feature flags to escape/hide html in markdown (#11340)
* utilizing feature flag for html escapement

* use src alias

* Feature flag to allow hiding of HTML tags

* strips js attr

* better feature flag naming

* simplifying

* Adding comments to new feature flags

* shorter comment, because pylint,

* pedantic change to get black to format a file
2020-10-21 15:07:27 -07:00
ʈᵃᵢ
225c905bd5 fix(listview): hide actions column if no actions are allowed (#11337) 2020-10-21 09:27:48 -07:00
Evan Rusackas
cae54ac00e style: using correct + icon on New Query button (#11353)
* style: using correct + icon on New Query button

* non-meaningful whitespace removed.
2020-10-20 22:44:11 -07:00
Maxime Beauchemin
796a2a6924 fix: error around latest partition in BigQuery (#11274)
* fix: error around latest partition in BigQuery

* lint

* Going with a backend-first approach

* fix test

* add an extra test
2020-10-20 21:34:46 -07:00
Maxime Beauchemin
c360413fc2 style(menu): clean up right menu - leaving only "Settings" (#11227)
* style(menu): clean up right menu - leaving only settings

* bring pre-commit back

* fix frontend tests

* pre-commit

* re-introduce subtle '+'
2020-10-20 21:33:28 -07:00
Kamil Gabryjelski
3a0fcdacd3 Fix tabs switching in SouthPane (#11343) 2020-10-20 14:24:27 -07:00
Lily Kuang
6f3d4c131f feat: css template add/edit modal (#11296) 2020-10-20 12:15:39 -07:00
Lily Kuang
9f8d0e7a06 fix: update table_name and schema on dataset editor (#11218)
* fix dataset editor for updating table_name and schema

* update test

* remove table_name from restrict list

* fix pylint

* fix cypress test

* fix test
2020-10-20 09:38:57 -07:00
adam-stasiak-polidea
55ae259b13 chore: Dashboard cypress refactor (#11280)
* moved dashboard tests to use data-test attributes

* linter

* fix for unstable save test
2020-10-19 21:36:20 -07:00
Kamil Gabryjelski
9266f0a4a8 refactor: Replace usages of reactable in ChangeDatasourceModal (#11241)
* Refactor ChangeDatasourceModal to use react-table

* Fix import

* Moved columns declaration out of component scope
2020-10-19 20:44:21 -07:00
Kamil Gabryjelski
901a42b1df refactor: Replace usages of Popover from react-bootstrap with Antd (#11163)
* New popover component

* LimitControl

* Moar components migrated

* TimeSeriesColumnControl

* Hotkeys

* ColorPicker

* FilterBoxItemCOntrol

* AdhocFilterEditPopover

* AdhocMetric

* AnnotationLayerControl

* DateFilterControl

* Tests fix

* Fix linting issue

* Fix tests

* Bug fix

* Test fix

* Remove Antd global stylesheet

* Fix linting

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test
2020-10-19 20:42:33 -07:00
ʈᵃᵢ
4208ca76e0 refactor: replace AvatarIcon instances with FacePile (#11279) 2020-10-19 20:23:16 -07:00
Kamil Gabryjelski
735123d1f5 refactor: Refactor QueryTable to use react-table (#11216)
* Refactor QueryTable to use react-table

* Fix lodash import

* Fix tests

* Fix imports and QuerySearch styles

* Update superset-frontend/src/SqlLab/components/QuerySearch.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/SqlLab/components/QuerySearch.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Lint fix

* Refactored QueryTable into functional component

* Remove calculating content height

* Lint fix

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-10-18 22:32:13 -07:00
Kamil Gabryjelski
31e4a90440 Fix overflowing tab's styling in TabbedSqlEditors (#11303) 2020-10-16 14:23:21 -07:00
Grace Guo
8863c939ad fix: should update last_modified_time in client-side after save dash (#11305) 2020-10-16 10:54:35 -07:00
Yongjie Zhao
afee008a10 fix CTAS and CVAS buttons invisible (#11300) 2020-10-16 08:02:39 -07:00
Erik Ritter
9856f99620 feat: update time_compare description and choices (#11294)
* feat: update time_compare description and choices

* Update sections.jsx
2020-10-15 21:28:09 -07:00
rubenSastre
4f0a06dda5 fix: button translations missing (#11187)
* button translations missing

* blank space before text
2020-10-15 21:27:26 -07:00
Kamil Gabryjelski
9aef9c5764 fix: Fix styling in SqlLab when tabs overflow (#11287)
* Fix styling in SqlLab when tabs overflow

* Use theme variables
2020-10-15 08:38:13 -07:00
adam-stasiak-polidea
fc03549299 chore: Added data-test attributes for testing (#11254)
* Added data-test attributes for testing

* fixed incorrect naming change

* review changes
2020-10-14 16:12:01 -07:00
ʈᵃᵢ
a6224a2ed2 fix(query search): use new api to fetch users (#11260) 2020-10-14 13:52:48 -07:00
Erik Ritter
fc74b5d4a2 Revert "fix: keep placeholder in multivalue select when a value exists (#11181)" (#11270)
This reverts commit 31cc4155b7.
2020-10-14 12:58:58 -07:00
Kamil Gabryjelski
820fa473a7 refactor: Implement TableView component (#11217) 2020-10-14 11:15:34 -07:00
Ville Brofeldt
2a4ca9fa98 fix(crud): set default extra value (#11262) 2020-10-14 19:05:20 +03:00
Lily Kuang
cd7392e618 update dashboard edit modal (#11258) 2020-10-13 20:50:02 -07:00
Elizabeth Thompson
31cc4155b7 fix: keep placeholder in multivalue select when a value exists (#11181) 2020-10-13 13:45:31 -07:00
Grace Guo
88af85ac53 fix: show TIME COLUMN options in dashboard (#11210)
* fix: show TIME COLUMN options in dashboard

* add unit test
2020-10-12 21:43:30 -07:00
Grace Guo
4f4367edf3 feat: prevent co-edit dashboard collision (#11220)
* feat: prevent co-edit dashboard collision

* fix comments
2020-10-12 17:58:32 -07:00
Maxime Beauchemin
ae87b0c767 fix: questioning a few lines that force an ORDER clause (#11153)
* draft: questioning a few lines that force an ORDER clause

* sorting by main metric DESC by default
2020-10-12 14:53:37 -07:00
Lily Kuang
8e58730092 fix(dataset): update user list endpoint (#11221) 2020-10-12 17:11:00 +01:00
Kamil Gabryjelski
b071344531 refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab (#11212)
* Create styled Antd Tabs and Dropdown

* Replace Tabs in SqlLab
2020-10-09 23:11:25 -07:00
Moriah Kreeger
a6fc3d2384 feat: CSS Templates List (#11189) 2020-10-09 16:32:31 -07:00
ʈᵃᵢ
7b0dabd7aa style(listview): various changes to get closer to SIP-34 designs (#11101) 2020-10-09 13:06:26 -07:00
John Bodley
2a447ff466 Revert "refactor: Replace react-bootstrap tabs with Antd tabs (#11090)" (#11194)
This reverts commit 4fd993c4e0.

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-10-07 16:21:24 -07:00
Lily Kuang
a0713938b3 fixed undefined names error (#11180) 2020-10-06 22:11:16 -07:00
Moriah Kreeger
21c8d672a8 fix: save query modal/button styling + convert to ant-d modal (#11164) 2020-10-06 16:55:17 -07:00
Lily Kuang
2eb400a2fc chore: remove SIP_34_SAVED_QUERIES_UI feature flag (#11175) 2020-10-06 15:13:41 -07:00
Maxime Beauchemin
c8a5dec84d style(dashboard): minor improvements to chart context menu (#11170)
Bumping "Explore/edit chart" as the first option. Getting rid of the
old "edit chart properties" deprecated CRUD link
2020-10-06 12:55:13 -07:00
Maxime Beauchemin
f109f11ceb style: fix too light form labels in DatabaseModal + DRY css (#11056)
eventually should be moved away from bootstrap and onto a DRY
ControlLabel component in our design system.
2020-10-06 12:51:00 -07:00
Maxime Beauchemin
b2af0c0e22 style(sqllab): make database errors more clear and render as monospace (#11075)
* style(sqllab): make database errors more clear and render as monospace

In SQL Lab, when a database error message is returned, generally because
of a user error in the SQL, it's identified as an "Unexpected Error" and
some of the text formatting of the error message (\n, spaces, tabs, ...)
are lost as they are rendered in html.

This PR identifies the error as a "Database Error", and renders like
more like a <pre>, using a monospace font.

* fix the build

* addressing comments

* addressed comments

* lint + removing cruft

* addressing comments
2020-10-06 12:50:38 -07:00
Grace Guo
13963acefb fix: Fix Time Column dropdown for date filter (#11149) 2020-10-06 11:51:10 -07:00
Maxime Beauchemin
3d7b805755 chore: more 'datasource' -> 'dataset' renaming (#11055)
* chore: more 'datasource' -> 'dataset' renaming

* fix build

* explicitely setting disabled to false to avoid cypress confusion

* fix tests

* RAT
2020-10-05 20:04:17 -07:00