Rob DiCiuccio
c4effe1261
Log warning for failure to get table/view names from DB ( #11374 )
2020-10-21 20:09:24 -07:00
Maxime Beauchemin
796a2a6924
fix: error around latest partition in BigQuery ( #11274 )
...
* fix: error around latest partition in BigQuery
* lint
* Going with a backend-first approach
* fix test
* add an extra test
2020-10-20 21:34:46 -07:00
Jesse Yang
2c649ac20f
perf: cache dashboard bootstrap data ( #11234 )
2020-10-13 18:43:06 -07:00
Kasia Kucharczyk
cd77797802
Removed disabled linting redefined-outer-name. Url parameters are renamed where url was already defined in class attributes ( #10911 )
2020-09-16 20:22:46 -07:00
Yongjie Zhao
38edb69d95
Feat: Adding table comment and columns comment for SQLLab ( #10844 )
...
* Adding table comment and columns comment for backend
* fix mypy
* Fix CI
* adding wider catch
* use logger
* fix lint
2020-09-14 21:11:48 -07:00
Ville Brofeldt
dd0bc472e3
refactor(database): use SupersetResultSet on SqlaTable.get_df() ( #10707 )
...
* refactor(database): use SupersetResultSet on SqlaTable.get_df()
* lint
* change cypress test
2020-08-28 21:12:03 +03:00
Erik Ritter
b686004294
feat: add configuration for Presto cursor poll interval ( #10191 )
2020-06-30 08:56:22 -07:00
Jason Davis
72fc581b15
added explore database for ctas/cvas ( #10174 )
...
Co-authored-by: Jason Davis <@dropbox.com>
2020-06-29 11:13:54 -07:00
Jason Davis
9de9e1c19d
feat: Added configuration to SQL Lab results "Explore" button ( #10164 )
...
* added configuration to virtual table explore button
* added description to mixin
* fixed unit tests
Co-authored-by: Jason Davis <@dropbox.com>
2020-06-26 09:54:55 -07:00
John Bodley
37777f382f
fix(security): dbs/clusters perm ( #10130 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-24 10:06:25 -07:00
Bogdan
3db76c6fdc
Implement create view as functionality ( #9794 )
...
Implement create view as button in sqllab
Make CVAS configurable
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com >
2020-06-24 09:50:41 -07:00
Will Barrett
8e23d4f369
chore: Upgrade pylint to 2.5.3 and fix most new rules ( #10101 )
...
* Bump pylint version to 2.5.3
* Add a global disable for the most common new pylint error
* Fix a bunch of files containing very few errors
* More pylint tweakage, low-hanging fruit
* More easy stuff...
* Fix more erroring files
* Fix the last couple of errors, clean pylint!
* Black
* Fix mypy issue in connectors/druid/models.py
2020-06-18 14:03:42 -07:00
John Bodley
91517a56a3
style(mypy): Spit-and-polish pass ( #10001 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-07 08:53:46 -07:00
John Bodley
15f267d586
style(mypy): Fix memoize watch type ( #9970 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-02 16:02:07 -07:00
John Bodley
e789a35558
[mypy] Enforcing typing for superset.models ( #9883 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-05-22 20:31:21 -07:00
Bogdan
3e8e441bfc
feat: implement csv upload configuration func for the schema enforcement ( #9734 )
...
* Implement csv upload func for schema enforcement
Implement function controlled csv upload schema
Refactor + fix tests
Fixing hive as well
* Add explore_db to the extras
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com >
2020-05-21 13:49:53 -07:00
Bogdan
358bbe0c88
fix: Catch db_engine_spec.get_function_names exceptions ( #9691 )
...
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com >
2020-05-08 19:51:00 +01:00
Ville Brofeldt
980dd2fd41
pylint: accept specific 2 character names by default ( #9460 )
...
* lint: accept 2 letter names by default
* Address review comments
* Remove e and d from good-names
2020-04-08 20:32:26 +03:00
Jianchao Yang
801e2f1777
chore: bump black to 19.10b0 and mypy to 0.770 ( #9378 )
...
* Bump black to 19.10b0
* Upgrade mypy to 0.770
* Update how inline type is defined
2020-04-04 13:23:18 -07:00
Ville Brofeldt
499f9c8fca
feat: add SSL certificate validation for Druid ( #9396 )
...
* feat: add SSL certificate feature
* Address comments
* don't mutate extras
* Address comments and add polish
* Add further polish
2020-03-27 19:07:07 +02:00
Daniel Vaz Gaspar
8e4dcd0509
[log] Set detailed query info to log debug level ( #9167 )
2020-02-24 10:42:59 +00:00
Erik Ritter
3efdfc5345
Infer SQL_LAB QuerySource from referrer ( #9181 )
2020-02-20 13:38:47 -08:00
John Bodley
141570636e
[fix] SQL query source ( #9173 )
2020-02-20 11:15:12 -08:00
John Bodley
9f5f8e5d92
[mypy] Enforcing typing for db_engine_specs ( #9138 )
2020-02-17 23:08:11 -08:00
John Bodley
a7e433a512
[mypy] Disallowing implicit optional ( #9150 )
2020-02-16 22:34:15 -08:00
Craig Rueda
607cfd1f29
Moving away from using the root logger everywhere ( #9099 )
...
* Moving away from using the root logger everywhere
* self.logger -> logger
2020-02-07 23:38:48 -08:00
John Bodley
6cb4ce0e19
[fix] Issue with previously defined SQL configuration ( #9082 )
2020-02-04 13:37:01 -08:00
Erik Ritter
a4b8e0b9e4
[SQL Lab] Add function names to autocomplete ( #9012 )
2020-01-24 11:08:26 -08:00
Grace Guo
93bcace20f
Revert "Make select_star work with SQL Lab views ( #8598 )" ( #8930 )
...
This reverts commit 964e6db8
2020-01-06 12:04:36 -08:00
Ville Brofeldt
5b690f9411
chore: refactor, add typing and fix uncovered errors ( #8900 )
...
* Add type annotations and fix inconsistencies
* Address review comments
* Remove incorrect typing of jsonable obj
2019-12-31 09:26:23 +02:00
David Aaron Suddjian
016f202423
Refactor Dashboard and Slice models ( #8820 )
...
* refactor dashboard and slice models
* appease various linters
* remove shortcuts & import indirection
* appease mypy
* fix bad imports
* lint
* address various issues
* ignore type issue
* remove unused imports
* lint
2019-12-18 11:40:45 -08:00
David Aaron Suddjian
7a68cb7ca0
factor out datasource_access_request model ( #8809 )
2019-12-17 16:17:49 -08:00
Daniel Vaz Gaspar
2f2ac00a09
[dashboard] feat: REST API ( #8694 )
2019-12-16 21:10:33 +00:00
Will Barrett
ed54f6ec8d
Require the SQLAlchemy URI on the database model ( #8720 )
...
* Require the SQLAlchemy URI when creating a database
* Add migration to make dbs.sqlalchemy_uri not-nullable
* Fixes for black, isort, tests
* Alter migration to use current revision from master as downgrade target
* Update tests to support new db constraint
* black
2019-12-11 14:05:23 -08:00
Will Barrett
adf2cc2039
Re-enable pylint for some model files ( #8770 )
...
* Allow id as a valid name for pylint
* Re-enable pylint for superset/models/core.py
* re-enable pylint for superset/models/sql_lab.py
* re-enable pylint for superset/models/schedules.py
* re-enable pylint for superset/models/helpers.py
* re-enable pylint for superset/models/annotations.py
* re-enable pylint on superset/models/tags.py
* a couple more fixes after black formatting...
* Add another inline pylint disable
* Fix black
* Move to inline disables for 'id' attribute on models
* Fix lint disables after black reformatted them
2019-12-10 13:24:45 -08:00
Bogdan
003e98c231
Support schema permissions ( #8219 )
...
* Build support for schema access in Superset and SQLab
* Lint
* Test for old and new flask
* Black formatting
* Cleanup modified files
* Support schema permissions
* Add migration
* Make it work for slices as well
* TODO and remove unused field
* Apply schema access check to dashboards as well
Cleaner schema permissions check
Fetch schema permissions in 1 query
Bugfix
Better datasource check
Use security manager for permissions checks and remove dead code
Properly handle anon user
Add database permissions on the database updates
Fix schema filtering
Lint / flake changes
Increase cypress request timeout
Run black
Resolve multiple alembic heads
* Use set comprehensions
* Fixes for the pylint
2019-12-03 14:57:24 -08:00
Beto Dealmeida
606ac3255d
Migrate filter_immune_slice_fields ( #8718 )
2019-12-03 10:26:54 -08:00
Beto Dealmeida
964e6db800
Make select_star work with SQL Lab views ( #8598 )
...
* Make select_star work with SQL Lab views
* Fix mypy
2019-11-20 13:07:16 -08:00
serenajiang
9a29116d6b
[typing] superset/models/core.py ( #8284 )
2019-11-04 21:04:53 +02:00
Will Barrett
e4ca44e95f
Use config[] not config.get() ( #8454 )
...
* Typo fix in CONTRIBUTING.md
* Alter references to config.get('FOO') to use preferred config['FOO']
* Set missing configuration constants in superset/config.py
* Misc. CI fixes
* Add type annotation for FEATURE_FLATGS
2019-10-30 16:19:16 -07:00
Will Barrett
148cec4690
Add UI-only database configuration method for extended authorization scenarios ( #8448 )
...
* Add encrypted_extra to dbs
* WIP - UI-based BigQuery connection configuration
* Fix 500 bubbling to the surface when adding a database connection
* Add check for valid json
* black formatting:
* isort
* Incorporate PR feedback. Thanks all!
* black
* Typo fix in CONTRIBUTING.md
2019-10-28 15:49:40 +00:00
John Bodley
9fc37ea9f1
[ci] Deprecate flake8 ( #8409 )
...
* [ci] Deprecate flake8
* Addressing @villebro's comments
2019-10-18 14:44:27 -07:00
serenajiang
876d329474
[fix] make names non-nullable ( #8371 )
2019-10-15 16:51:04 -07:00
serenajiang
7e7ea3d9a0
Revert "[fix] make datasource names non-nullable ( #8332 )" ( #8363 )
...
This reverts commit 65a05ca47e .
2019-10-09 11:38:57 -07:00
serenajiang
65a05ca47e
[fix] make datasource names non-nullable ( #8332 )
2019-10-04 09:13:25 -07:00
Beto Dealmeida
12fb8e70cc
Show Presto views as views, not tables ( #8243 )
...
* WIP
* Implement views in Presto
* Clean up
* Fix CSS
* Fix unit tests
* Add types to database
* Fix circular import
2019-09-18 12:47:10 -07:00
Beto Dealmeida
8847e10529
Allow users to estimate query cost before executing it ( #8172 )
...
* WIP
* Basic functionality working
* Enable per DB
* Show error message
* Small improvements
* Fix lint
* Address comments
* Address comments
* Remove logging, fix exception
* Fix tests
* Bump FAB requirements
2019-09-17 09:09:40 -07:00
Beto Dealmeida
10f00cdde3
[fix] Isolate and improve performance on tagging system ( #7858 )
...
* Fix tag perf
* Add ASF header
* Make script idempotent
* Add CLI to sync tags
* Add missing file
* Merge heads
* Fix lint
* Remove script
2019-07-31 09:19:39 -07:00
Ville Brofeldt
07a76f83b1
[Bugfix] Remove prequery properties from query_obj ( #7896 )
...
* Create query_obj for every filter
* Deprecate is_prequery and prequeries from query_obj
* Fix tests
* Fix typos and remove redundant ; from sql
* Add typing to namedtuples and move all query str logic to one place
* Fix unit test
2019-07-23 22:13:58 +03:00
Maxim Sukharev
2221445f44
Fix incorrect datasource_name in dashboard export ( #7892 )
...
The bug was introduced in #7773
It uses filter by `cls.table_name == datasource_name`:
https://github.com/apache/incubator-superset/pull/7773/files#diff-a8dd5ec8d8decda2e3c5571d1ec0cdb6R740
But export puts `slc.datasource.name` into exported json:
https://github.com/apache/incubator-superset/pull/7773/files#diff-ceeb7eee8d573333109e0037299c9711L673
`slc.datasource.name` in case of `SqlaTable` is `"{}.{}".format(self.schema, self.table_name)`
2019-07-22 22:31:47 -07:00