Commit Graph

40 Commits

Author SHA1 Message Date
Beto Dealmeida
7a284bb9e8 fix: allow reports to update query_context (#16303) 2021-08-17 16:39:27 -07:00
Beto Dealmeida
7b3fce7e81 fix: revert data endpoint name (#16162) 2021-08-10 11:59:27 -07:00
Phillip Kelley-Dotson
f0e3b68cc2 fix: ensure that users viewing chart does not automatically save edit data (#16077)
* add last_change_at migration

* add last_saved_by db migration

* finish rest of api migration

* run precommit

* fix name

* run precommitt

* remove unused mods

* merge migrations

* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/migrations/versions/f6196627326f_update_chart_permissions.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* fix test

* precommit

* remove print

* fix test

* change test

* test commit

* test 2

* test 3

* third time the charm

* fix put req

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-08-10 10:29:49 -06:00
Elizabeth Thompson
5031a67597 feat: Self subscribe reports (#16027)
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2021-08-02 09:12:09 -07:00
Beto Dealmeida
2ce676d20d feat: call screenshot to store query_context (#15846)
* feat: call screenshot to store query_context

* Add unit test

* Move updateQueryContext to ExploreChartPanel

* Add error handling

* Fix code

* Fix logic
2021-07-27 14:02:27 -07:00
Kamil Gabryjelski
281d637674 Don't run query when control panel has errors (#14687) 2021-05-27 08:13:17 -07:00
Geido
a0881fb157 Add filter_box full height (#14657) 2021-05-19 00:13:16 -07:00
Cedric Gampert
74473e2ad1 fix: do not render favorite favStars and filters for anonymous user (#14120)
* fix: do not render favorite favStar and filter for anonymous user

* fix: prevent anonymous user to trigger the favstar view route

* fix: lint over previous commit

* fix: linter follow-up
2021-05-14 08:05:50 -07:00
Geido
e21beb76f1 fix: White space between Chart and Data panel in Explore (#14495)
* Adjust white space

* Adjust chart padding
2021-05-10 13:03:43 -07:00
simcha90
8ef572a412 refactor(native-filters): update dataMask and ExtraFormData schema (#13983)
* refactor: updates usage of `ownFilters` to `ownState`

* refactor: update dataMask (final)

* lint: fix lint

* refactor: revert feat

* fix: fix missed chart configuration

* add filter set migration

* apply new changes

* fix migration revision

* update migration

* fix jest mock

* js lint

* fix test types

* update tests and types

* remove append_form_data from tests

* fix findExistingFilterSet tests

* add migration test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-04-15 17:43:29 +03:00
simcha90
45972e9945 refactor(native-filters): Move filtersState to dataMask redux root (#13437) 2021-03-07 09:34:12 +02:00
David Aaron Suddjian
e11d0cbf44 refactor: Introduce api resource hooks, fetch owners for chart errors (#13218)
* refactor: introduce api resource hooks, fix error owners

* comment

* vestigial comment

* not a function

* clarification

* vestigial comment

* filter the api for a leaner response

* reorganize code, add resource hook catalog

* better names

* implement state management in redux

* Revert "implement state management in redux"

This reverts commit d64d50a99f.

* add tests for hooks
2021-02-25 14:41:35 -08:00
Kamil Gabryjelski
c1aacde304 fix(explore): Fix downloading as image charts which use Mapbox (#13181)
* Fix downloading as image charts which use Mapbox

* Remove unused prop

* Bump deckgl version
2021-02-20 19:45:03 +02:00
Kamil Gabryjelski
da478531b2 Fix chart panel overflowing (#13154) 2021-02-17 09:37:35 +08:00
Kamil Gabryjelski
d0b00bc08f fix: Fix switching viz type to and from Filter box (#13094)
* Fix switching viz_type to and from filter_box

* Remove RESET_FIELDS action

* Restore removed log

* Refactor reducer logic
2021-02-15 08:05:40 -08:00
simcha90
c5781cde60 feat(style): hide dashboard header by url parameter (#12918)
* feat(native-filters): hide dashboard header bu url parameter

* lint: fix lint

* test: add tests

* test: fix test

* refactor: upgrade standalone param

* fix: pre-commit and extract to method is_standalone_mode

* test: fix tests

* test: fix tests

* fix: fix standalone statement

* refactor: fix CR notes

* chore: pre-commit

* fix: fix sticky tabs + update CR notes

* lint: fix lint

* lint: fix lint

* fix: fix CR notes

* fix: fix CR notes

* lint: fix lint

* refactor: fix cr notes

Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2021-02-11 15:05:35 +02:00
Kamil Gabryjelski
2ce79823df feat: Save datapanel state in local storage (#12996)
* Save datapanel state in local storage

* Export string to a constant

* Move local storage helpers to separate file

* Use helper functions in ExploreViewContainer
2021-02-08 16:42:59 -08:00
Jesse Yang
57fa6d2cf9 fix: explore page style fix, remove unnecessary scroll bars (#12649)
* fix: various style touch on Explore page

* More style fixes

* Force 100% height for sidebars

* Fix linting
2021-01-22 09:18:13 -08:00
Duy Nguyen Hoang
862ddd9cb4 fix: chart disappears in standalone slice (#12606) 2021-01-19 11:56:24 -08:00
Kamil Gabryjelski
ed53b0090e feat: Resizable dataset and controls panels on Explore view (#12411)
* Implement resizable panels on explore view

* Optimize chart rendering while resizing

* Make dataset column narrower

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-01-12 10:39:56 -08:00
Grace Guo
9618f0786c [explore] Prevent duplicated query by data table (#12404) 2021-01-11 11:37:54 -08:00
Jesse Yang
9acf48fd1e chore: upgrade eslint, babel, and prettier (#12393) 2021-01-10 17:26:35 -08:00
Kamil Gabryjelski
5d04f7dbce fix: Data tables styling issues on Explore view (#12383)
* Fix sort icons wrapping

* Fix large table stretching chart section container

* Implement sticky paginattion

* Display "loading" when data is loading

* Lint fix
2021-01-09 18:04:53 +02:00
Kamil Gabryjelski
77b80c9431 fix: Fix chart resizing when using split view (#12362)
* Fix chart resizing when using split view

* Fix z-index issues
2021-01-08 15:20:51 -08:00
Victor Malai
553b440e4b fix: Show Data panel on resize (#12250)
* Show Data panel on resize

* Revert back tableSectionHeight

* FIx lint
2021-01-05 16:13:07 -08:00
Agata Stawarz
4ac00a0954 fix(chart): rendering standalone chart and errors (#12179) 2020-12-23 11:06:08 +00:00
Jesse Yang
8e625e0a64 fix: properly render booleans in FilterBox and explore page data preview (#12116) 2020-12-18 10:40:56 -08:00
simchaNielsen
49ec13c68c feat: Support multiple queries per request (#11880)
* refactor: add queriesData fields for multiple queries

* feat: support multi queries request

* lint: fix lint

* lint: fix lint

* lint: fix lint

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

* fix: fix error case for multi queries

* feat: change queryResponse to queriesResponse

* fix: revert webpack

* test: fix tests

* chore: lint

* chore: adjust asyncEvent to multiple results

* fix: lint

* fix: eslint

* fix: another eslint rule

Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2020-12-18 09:15:27 -08:00
Geido
1afe91579e refactor: Existing Antd Collapse to enhanced (#12013)
* Move ProgressBar to Antd

* Remove trailing space

* Fix linting issues

* Export enhanced Progress only

* Move existing antd Collapse to enhanced Collapse

* Move enhanced props up to Collapse only

* Add stories for enhanced Collapse

* Add 100% height for overflow

* Improve text light story
2020-12-13 22:57:08 -08:00
Kamil Gabryjelski
41738df77d feat: Results table on Explore view (#11854)
* Upgrade react-split

* Implement split on ExploreChartPanel

* Implement tabs with collapse

* Fix run query button

* Fix copy to clipboard button

* Move table controls to separate file

* Make component more generic to handle samples

* Remove samples from DisplayQueryButton

* Move data tables to separate file

* Make split dynamically controlled

* Fix unit test

* Fix arrow not centered

* fixup! Fix arrow not centered

* Change copy button paddings

* Use translations

* Fix grammar in a comment

* Fix imports

* Use grid units

* Convert new files to typescript

* Fix after rebase

* Remove forceRender

* Fix big_number test

* Delay making request until panel is opened

* White background in south panel

* fixup! White background in south panel

* Lint fix

* Lint fix

* Remove redundant prop types

* Remove console log

* Delay loading samples until user switches tab

* Add debounce to filter input

* Use gridUnit for gutter sizes

* Change types object to Record<string, any>
2020-12-04 19:49:24 -08:00
Kamil Gabryjelski
557a303cc5 ESLint: Enable rule no-named-as-default (#10879)
* Enable rule no-named-as-default

* Fix wrong import
2020-09-18 13:41:01 -07:00
Jesse Yang
9a59bdda48 refactor: merge/upgrade superset-ui packages (#10790)
* refactor: merge/upgrade superset-ui packages

* Fix flaky big number test

* Fix Flaky AdhocFilters test
2020-09-09 13:18:55 -07:00
Evan Rusackas
a3fd2b420e fix: More tweaks needed after adding Doctype tag (#10504)
* fixing last-of-type specificity

* Simplifying/consolidating styles

* fixing filterbox in explore

* linting

* adding some px to font sizes

* fixing in-dash overflow

* removing px for one special fontsize case

* simplifying, addressing comments
2020-08-13 11:50:14 -07:00
Jesse Yang
246add45a0 fix: explore panel missing padding (#10505) 2020-08-04 15:08:28 -07:00
Evan Rusackas
16459ad401 style: DOCTYPE tag, and related CSS cleanup/refactoring (#10302) 2020-07-29 18:49:32 -07:00
Erik Ritter
5fa4680447 feat: update timeout error UX (#10274) 2020-07-20 15:32:17 -07:00
Erik Ritter
6ae9f3af8e feat: add download as image button to explore (#10297) 2020-07-14 16:40:12 -07:00
Grace Guo
5ca6ed716f [explore view] inline edit slice name should not overwrite (#9817) 2020-05-18 22:53:29 -07:00
David Aaron Suddjian
cfa786850f upgrade to react-bootstrap v0.33.1 (#9372)
* upgrade to react-bootstrap v0.33.1

* fix test

* simplify proptypes

Co-Authored-By: Evan Rusackas <evan@preset.io>

* simplify more proptypes

Co-Authored-By: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-03-26 11:16:49 -07:00
David Aaron Suddjian
2913063924 SIP-32: Moving frontend code to the base of the repo (#9098)
* move assets out, get webpack dev working

* update docs to reference superset-frontend

* draw the rest of the owl

* fix docs

* fix webpack script

* rats

* correct docs

* fix tox dox
2020-02-09 17:53:56 -08:00