Commit Graph

12 Commits

Author SHA1 Message Date
David Aaron Suddjian
016f202423 Refactor Dashboard and Slice models (#8820)
* refactor dashboard and slice models

* appease various linters

* remove shortcuts & import indirection

* appease mypy

* fix bad imports

* lint

* address various issues

* ignore type issue

* remove unused imports

* lint
2019-12-18 11:40:45 -08:00
Will Barrett
60892ae45d Re-enable pylint for example-related files (#8771)
* re-enable pylint for superset/examples/energy.py

* re-enable pylint for superset/examples/world_bank.py

* re-enable pylint for superset/examples/tabbed_dashboard.py

* Re-enable pylint for superset/examples/helpers.py
2019-12-06 14:30:50 -08:00
Evan Rusackas
172b90ec50 Font styling consolidation (#8633)
* Font weights standardized

* now with more glob!

* Linting touchups

* caught a low-value color declaration

* first wave of font size alignment

* getting the CRUD styles caught up to speed.

* unneeded inline-block - float does that for ya.

* a few errant colors that snuck in.

* more font stylings.

* caught some more colors that needed variable alignment

* le typo

* whittle, whittle

* dead styles

* whittling

* whittling

* whittling away at font sizes

* since we appear to be adjusting icon sizes for optics, let's get this one too.

* Prettier 

* whittling at line height standardization.

* placing vars, take 1

* 2 more down...

* cleaning out some styles that had no real effect.

* seemingly no change if this is removed for consistency.

* allowing one 8px line height for proper icon placement - adding comment.

* last one, I reckon.

* linting fixes
2019-11-27 10:36:25 -08:00
John Bodley
7bfa24d0da [fix] Re-cleanup legacy filters (#8523) 2019-11-12 12:29:00 -08:00
Marcus
a8f1589dbf fixing typo. (#8487) 2019-10-30 22:30:06 -07:00
Will Barrett
e4ca44e95f Use config[] not config.get() (#8454)
* Typo fix in CONTRIBUTING.md

* Alter references to config.get('FOO') to use preferred config['FOO']

* Set missing configuration constants in superset/config.py

* Misc. CI fixes

* Add type annotation for FEATURE_FLATGS
2019-10-30 16:19:16 -07:00
John Bodley
9fc37ea9f1 [ci] Deprecate flake8 (#8409)
* [ci] Deprecate flake8

* Addressing @villebro's comments
2019-10-18 14:44:27 -07:00
Daniel Vaz Gaspar
83f7038374 [examples] Fix, sf population polygons div by zero error (#8209) 2019-09-10 09:53:27 -07:00
Maxime Beauchemin
4e7ea3f3e2 Improve birth example dashboard (#8042)
* Improve birth example dashboard

* Fix tests

* pylint
2019-08-18 22:36:27 -07:00
Ville Brofeldt
8773fdceb2 [bugfix] Fix deck_polygon metric bug and update examples chart (#8025)
* Fix deck_polygon bug and update examples chart

* Change js elevation to native ad-hoc metric

* Move scale from metric to native multiplier

* Remove redundant js_columns and change color scheme
2019-08-15 09:20:49 -07:00
Gianluca Ciccarelli
e23920b8ba 7620: Start removing dependencies on requests (#7643)
* 7620: Start removing dependencies on requests

* Patch urllib.request.urlopen instead of requests.get

* Try to fix flake8

* More work on flake8 import errors

* First attempt at using urllib with cookies

* Fix pylint/flake8

* Fix test_deliver_slice_csv_attachment

* Fix test_deliver_slice_csv_inline

* Import requests and pydruid conditionally, remove dependency on prison

* Fix flake errors

* Fix load_examples

* Please flake

* Skip tests depending on optional deps

* Try to please flake

* Address review comments

* Remove Druid-related UI

* Revert "Remove Druid-related UI"

This reverts commit d7e0f166cc3f3dd2496b4a666e177f0c191aeb0f.

* Skip a few tests more

* Put imports in right order

* Apply black patch

* Please flake

* Please black, silence flake

* Use flake8 silencing the right way

* Add deps for CI
2019-08-02 10:01:28 -07:00
Maxime Beauchemin
d65b039219 Improve examples & related tests (#7773)
* [WiP] improve load_examples

related to #7472, longer term we will generate the examples by exporting
them into tarball as in #7472. In the meantime, we need this subset of
the features:

* allowing specifying an alternate database connection for examples
* allowing a --only-metadata flag to `load_examples` to load only
  dashboard and chart definitions, no actual data is loaded

* Improve logging

* Rename data->examples

* Load only if not exist

* By default do not load, add a force flag

* fix build

* set published to true
2019-07-16 21:36:56 -07:00