Beto Dealmeida
77415685ce
fix: revert data endpoint name ( #16162 )
...
(cherry picked from commit 7b3fce7e81 )
2021-08-16 08:45:31 +03:00
Phillip Kelley-Dotson
cf922e1dcf
fix: ensure that users viewing chart does not automatically save edit data ( #16077 )
...
* add last_change_at migration
* add last_saved_by db migration
* finish rest of api migration
* run precommit
* fix name
* run precommitt
* remove unused mods
* merge migrations
* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset/migrations/versions/f6196627326f_update_chart_permissions.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* fix test
* precommit
* remove print
* fix test
* change test
* test commit
* test 2
* test 3
* third time the charm
* fix put req
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
(cherry picked from commit f0e3b68cc2 )
2021-08-16 08:45:31 +03:00
Maxime Beauchemin
3e98e9cd79
chore: add stats logging to thumbnail api ( #16133 )
...
(cherry picked from commit df50a47777 )
2021-08-10 07:53:23 +03:00
Beto Dealmeida
2d61f15153
feat: send post-processed data in reports ( #15953 )
...
* feat: send post-processed data in reports
* Fix tests and lint
* Use enums
* Limit Slack message to 4k chars
2021-07-30 09:37:16 -07:00
John Bodley
671b8f2544
chore: Mypy fix **kwargs type ( #15823 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-07-29 04:59:20 +12:00
Hugh A. Miles II
62550db385
fix: Update Query Context on Explore loading ( #15865 )
...
* create serialize json function
* saving for now
* saving for now
* lint
* cleanup
* fix network request
* update test
* Update tests/integration_tests/charts/api_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
2021-07-26 12:43:25 -07:00
Beto Dealmeida
2f95f81be7
feat: apply post processing to chart data ( #15843 )
...
* feat: apply post processing to chart data
* Fix tests and lint
* Fix lint
* trigger tests
2021-07-26 10:58:59 -07:00
Beto Dealmeida
f104fba61d
feat: add GET /api/v1/chart/{chart_id}/data/?format{format} API ( #15827 )
...
* feat: add `GET /api/v1/chart/{chart_id}/data/?format{format}` API
* Fix test
2021-07-21 17:03:22 -07:00
Ben Reinhart
ab153e66cc
feat: Synchronously return cached charts ( #15157 )
...
* feat: Synchronously return cached charts
* Fix lint issue
* Fix python lint error
* Change getChartDataRequest to return response
* Fix lint errors
* Add test
* explore_json: skip cached data check for forced refresh
Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com >
2021-06-22 10:00:57 -07:00
Beto Dealmeida
53df152362
feat: show spinner on exports ( #15107 )
...
* feat: show spinner on exports
* Set cookie only if token is passed
* Use iframe
* Small fixes
* Fix lint
* Remove stale test
* Add explicit type
2021-06-11 17:25:00 -07:00
Beto Dealmeida
2313e3ef4f
fix: show error on invalid import ( #14851 )
...
* fix: show error on invalid import
* Add unit test
* Remove unused imports
* Fix tests
2021-05-27 14:46:41 -07:00
Beto Dealmeida
f1ea1d74a7
fix: OpenAPI boolean type ( #14827 )
2021-05-25 14:46:41 -07:00
Ben Reinhart
b38596fd96
fix: Use g.user for getting the user_id for async queries ( #14702 )
...
* fix: Use g.user for getting the user_id
* Use id form for one user.id call
* Fix references to g.user
* Correct types
* Use if over try/catch
* Switch back to try/except
2021-05-21 14:30:13 -07:00
Ben Reinhart
6d9d362ca8
chore: use before_request hook for dynamic routes ( #14568 )
...
* chore: use before_request hook for dynamic routes
* Shorten hook names
* Introduce with_feature_flags and update thumbnail tests
* Disable test that fails in CI but not locally
* Add test for reports
2021-05-14 12:49:25 -07:00
Duy Nguyen Hoang
9a22fb00d9
fix: CSV Export permission is not consistent ( #13713 )
2021-05-04 10:19:58 +03:00
Sam Faber-Manning
11260b3117
chore: add stack trace to all calls of logger.error ( #14382 )
2021-04-30 09:22:05 -07:00
Rob DiCiuccio
6875a1a9e2
Make g.user attribute access safe for public users ( #14287 )
2021-04-26 08:50:50 -07:00
Erik Ritter
3d357c661c
feat: handle chart/data API errors ( #14040 )
2021-04-09 09:39:02 -07:00
Ben Reinhart
55ba47ec2e
fix( #13734 ): Properly escape special characters in CSV output ( #13735 )
...
* fix: Escape csv content during downloads
* Reuse CsvResponse object
* Use correct mimetype for csv responses
* Ensure that headers are also escaped
* Update escaping logic
2021-03-26 15:22:00 -07:00
Beto Dealmeida
9fc03f0424
fix: API to allow importing old exports (JSON/YAML) ( #13444 )
...
* fix: fix API to allow importing old exports (JSON/YAML)
* Fix test
* Fix lint
* Add description to API schema
2021-03-04 17:18:27 -08:00
Jesse Yang
e3db935c62
refactor: migrate table chart to new API ( #10270 )
...
* refactor: migrate table chart to new API
* chore: bump superset-ui to 0.17.0
* Fix Cypress tests
* Apply soft-conversion to numeric metrics
Fix time column formatting test
* Add translation to chart does not exist error
* Bump to 0.17.1
2021-01-29 13:12:09 +02:00
Duy Nguyen Hoang
862ddd9cb4
fix: chart disappears in standalone slice ( #12606 )
2021-01-19 11:56:24 -08:00
Duy Nguyen Hoang
77da4ada99
fix: error while parsing invalid json form_data ( #12586 )
...
* Fix error while parsing invalid json form_data
* Refine error returned
2021-01-19 16:15:16 +00:00
Beto Dealmeida
7bef5ab4d2
fix: ignore system files on import ( #12526 )
2021-01-15 15:53:55 -08:00
Beto Dealmeida
e47350ef96
fix: import ZIP files that have been modified ( #12425 )
...
* fix: import ZIP files that have been modified
* Add unit test
2021-01-12 12:56:26 -08:00
Daniel Vaz Gaspar
0f731f27e4
fix(api): prefix class names on events actions ( #12354 )
...
* fix(api): prefix class names on events actions
* fix bulk delete
2021-01-12 10:52:35 +00:00
Daniel Vaz Gaspar
f79e52f48e
feat(charts): security perm simplification ( #11981 )
...
* feat(charts): security perm simplification
* fix superset explore
* fix JS test
* fix cypress test
* fix split heads
* fix favorite permission
* fix permission
* update with new async permission
* fix new permission coming from master
* fix core permission assert
* black
* update alembic down revision
2020-12-15 11:27:06 +00:00
Rob DiCiuccio
4d329071a1
feat(SIP-39): Async query support for charts ( #11499 )
...
* Generate JWT in Flask app
* Refactor chart data API query logic, add JWT validation and async worker
* Add redis stream implementation, refactoring
* Add chart data cache endpoint, refactor QueryContext caching
* Typing, linting, refactoring
* pytest fixes and openapi schema update
* Enforce caching be configured for async query init
* Async query processing for explore_json endpoint
* Add /api/v1/async_event endpoint
* Async frontend for dashboards [WIP]
* Chart async error message support, refactoring
* Abstract asyncEvent middleware
* Async chart loading for Explore
* Pylint fixes
* asyncEvent middleware -> TypeScript, JS linting
* Chart data API: enforce forced_cache, add tests
* Add tests for explore_json endpoints
* Add test for chart data cache enpoint (no login)
* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag
* Add tests for tasks/async_queries and address PR comments
* Bypass non-JSON result formats for async queries
* Add tests for redux middleware
* Remove debug statement
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
* Skip force_cached if no queryObj
* SunburstViz: don't modify self.form_data
* Fix failing annotation test
* Resolve merge/lint issues
* Reduce polling delay
* Fix new getClientErrorObject reference
* Fix flakey unit tests
* /api/v1/async_event: increment redis stream ID, add tests
* PR feedback: refactoring, configuration
* Fixup: remove debugging
* Fix typescript errors due to redux upgrade
* Update UPDATING.md
* Fix failing py tests
* asyncEvent_spec.js -> asyncEvent_spec.ts
* Refactor flakey Python 3.7 mock assertions
* Fix another shared state issue in Py tests
* Use 'sub' claim in JWT for user_id
* Refactor async middleware config
* Fixup: restore FeatureFlag boolean type
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
2020-12-10 20:21:56 -08:00
Beto Dealmeida
475f59cb1c
feat: confirm overwrite when importing ( #11982 )
...
* feat: confirm overwrite when importing
* Skip flaky test
2020-12-10 14:50:10 -08:00
Beto Dealmeida
33325f9fa6
feat: add modal to import charts ( #11956 )
...
* WIP
* Splat props
2020-12-07 18:33:59 -08:00
Daniel Vaz Gaspar
14ea444e58
fix(charts): screenshot API declaring an unnecessary rison arg ( #11931 )
2020-12-05 08:57:44 +00:00
Beto Dealmeida
c354e7e0ab
fix: remove root dir from ZIP bundle ( #11805 )
...
* fix: remove root dir from ZIP bundle
* Fix lint
* Fix tests
* Improve tests
* Fix dashboard as well
2020-11-25 11:47:48 -08:00
Maxime Beauchemin
0504cf1a00
chore: improve analytics ( #11714 )
...
* chore: improve analytics
* lint
* log more events, add note in UPDATING.md
* handling base class
* more events\!
* get ref through
* right before @expose
* fix context
* touchups
2020-11-25 08:45:02 -08:00
Beto Dealmeida
a3a2a68f01
feat: API endpoint to import charts ( #11744 )
...
* ImportChartsCommand
* feat: API endpoint to import charts
* Add dispatcher
* Fix docstring
2020-11-20 14:40:27 -08:00
ʈᵃᵢ
1dc4c4746e
fix(dashboard): ordering for add chart widget ( #11672 )
2020-11-12 11:10:45 -10:00
ʈᵃᵢ
edb9619731
refactor: reduce number of api calls needed to fetch favorite status for charts and dashboards ( #11502 )
2020-11-02 21:26:14 -08:00
Beto Dealmeida
21f722c9bc
feat: add endpoint to export saved queries using new format ( #11447 )
...
* Add UUID to saved_query
* Reuse function from previous migration
* Point to new head
* feat: add backend to export saved queries using new format
2020-10-30 08:32:16 -07:00
Phillip Kelley-Dotson
f7051eaade
feat: home screen mvp ( #11206 )
...
* step 1: broken stuff!
* first steps
* more adding and slicing
* step 1: broken stuff!
* can now filter dashboards/charts for "Edited" tabs (filter by changed_by o_m)
* more updates
* update recent card
* add icon
* Adding Expand Icon to Collapse component
* more updates
* clean up code
* remove lock file
* remove consoles
* fixing subnav button height shift
* lil' ascii arrows
* update branch
* update test part 1
* remove consoles
* fix typescript
* add images and update emptystate
* add changes
* update chart card
* fix css issues from rebase
* add suggestions
* more changes
* update tests and clear typescript errors
* Update superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* update from comments
* more updates..
* fix rebase
* fix pesky type errors
* test fixes
* lint fix
* Update superset-frontend/spec/javascripts/views/CRUD/welcome/Welcome_spec.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/components/Menu/SubMenu.tsx
Co-authored-by: Evan Rusackas <evan@preset.io >
* Update superset-frontend/src/components/ListViewCard/index.tsx
Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com >
* Update superset-frontend/src/components/ListViewCard/index.tsx
Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com >
* add suggestions
* fix lint
* remove unused code
* toast getrecentActivityobjs
* add some suggestions
* remove types for now
* cypress fix
* remove unused type
Co-authored-by: Evan Rusackas <evan@preset.io >
Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com >
2020-10-29 21:59:31 -07:00
Beto Dealmeida
633355ab00
feat: export charts as ZIP files ( #11349 )
...
* Export datasets as ZIP files
* Add logging when failing to parse extra
* Export charts as Zip file
* Fix lint
2020-10-22 12:06:58 -07:00
Daniel Vaz Gaspar
4c85d33109
feat: custom favorite filter for dashboards, charts and saved queries ( #11083 )
...
* feat: custom favorite filter for dashboards
* lint and sort
* add favored for charts
* fix tests and lint
* more tests and saved query filter
* fix tests
* fix tests
* lint
* lint and fix conflict
* remove unnecessary prop
* separate tests
2020-10-01 15:08:40 -07:00
Lily Kuang
5b284e67eb
feat: add created by chart CRUD view ( #11067 )
2020-09-30 13:53:04 -07:00
ʈᵃᵢ
1dc05d4c12
feat(charts): modify custom api filter to include more fields ( #11054 )
2020-09-28 10:18:34 -07:00
Kasia Kucharczyk
d6be977d1b
fix: address all disabled pylint checks in charts/api.py ( #10932 )
...
* Refactored put in charts/api.py to have less return statement. Removed pylint rule too-many-return-statements
* Refactored data() in charts/api.py to have less return statement. Removed pylint rule too-many-return-statements
* Pylint disabled arguments-differ check is not necessary anymore in put method
* Pylint disabled arguments-differ check is not necessary anymore in delete method
* Pylint disabled arguments-differ check is not necessary anymore in bulk_delete method. Applied black
2020-09-17 17:31:44 +01:00
Will Barrett
52d7671204
Remove incorrect comment ( #10652 )
2020-08-24 10:40:36 -07:00
Lily Kuang
3f5d5cc0aa
fix: remove duplicated params and cache_timeout from list_columns; add viz_type to list_columns ( #10643 )
2020-08-19 11:59:16 -07:00
Daniel Vaz Gaspar
4dd1d1df5e
fix(thumbnails): missing field, logging and new config var ( #10562 )
...
* fix(thumbnails): missing field, logging and new config var
* deprecate EMAIL_REPORTS_WEBDRIVER
* fix after merge and conflicts
* fix tests
* black
2020-08-14 14:12:44 +01:00
ʈᵃᵢ
db88cec431
feat: SIP-34 card/grid views for dashboards and charts ( #10526 )
2020-08-13 14:46:56 -07:00
ʈᵃᵢ
78cad9a4a8
refactor(listviews): use correct filter endpoints for charts and datasets ( #10442 )
2020-07-29 11:00:19 -07:00
Daniel Vaz Gaspar
98a11e7cf2
fix(api): fixes openapi spec errors and adds a test to validate all spec ( #10393 )
2020-07-23 10:43:41 +01:00
Daniel Vaz Gaspar
2b061fc64b
fix: modified by column on charts and dashboards ( #10340 )
2020-07-16 23:15:47 +01:00