Commit Graph

317 Commits

Author SHA1 Message Date
Diego Medina
800ced5e25 fix(sql lab): when editing a saved query, the status is lost when switching tabs (#19448) 2022-04-22 15:23:30 -06:00
Diego Medina
dfba9ea596 fix: SQL Lab UI Error: Objects are not valid as a React child (#19783) 2022-04-20 09:18:46 +03:00
Phillip Kelley-Dotson
06ec88eb99 feat: add empty states to sqlab editor and select (#19598)
* feat: add empty states to sqlab editor and select

* add suggestions and test

* update type

* lint fix and add suggestions

* fix typo

* run lint

* remove unused code

* fix test

* remove redux for propagation and other suggestions

* add t

* lint

* fix text and remove code

* ts and fix t in p

* fix spelling

* remove unused prop

* add fn to prop change state

* remove unused code

* remove unused types

* update code and test

* fix lint

* fix ts

* update ts

* add type export and fix test

* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* remove handlerror and unused code

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-04-15 15:09:07 -07:00
Diego Medina
8d4a52c9d0 fix(sql lab): add quotes when autocompleting table names with spaces in the editor (#19311) 2022-04-15 12:55:04 -06:00
Diego Medina
bbe0af348b fix(sql lab): Selecting edit on a query from query history doesn't update the SQL Editor properly (#19290) 2022-04-15 12:49:32 -06:00
Luis Casillas
56381f4ee8 fix: sql lab ctrl t behaved differently from clicking (#19420)
* initial approach

To have consistent behaviour when creating a new tab with ctrl+t

* consistent behaviour when creating tabs

* fixed bug and added tests

* updates to pass checks
2022-04-15 12:28:40 -06:00
Diego Medina
d4e7c65f6a fix(sql lab): replace the output column in the query history table (#19370)
* fix(sql lab): replace the output column in the query history table

* improvements
2022-04-13 10:22:03 -06:00
Diego Medina
6d5d03e592 fix(sql lab): display the 'View Results' button consistently in the history tab on sync mode (#19362)
* fix(sql lab): display the 'View Results' button in the history tab when running sync queries

* pr comment
2022-04-13 10:20:32 -06:00
Diego Medina
26a0f05759 fix(sql lab): table selector should display all the selected tables (#19257)
* fix: table Selector should clear once selected

* Multi select

* Add tests

* refactor

* PR comments
2022-04-13 08:42:12 -06:00
Ville Brofeldt
87d47987b7 fix(sql-lab): do not replace undefined schema with empty object (#19664) 2022-04-12 15:13:03 +03:00
Yongjie Zhao
761d5c4208 chore: cleanup as unknown conversion (#19587) 2022-04-08 17:32:29 +08:00
Diego Medina
c6c9188a24 fix(sql lab): increase the size of the action icons in the history tab (#19313) 2022-04-06 08:21:07 -06:00
Ville Brofeldt
2d81c4c79f fix(sqllab): null database with backend persistence (#19548) 2022-04-06 12:32:41 +03:00
Geido
7914296d8a chore: Remove FilterbaleTableStyles.less (#19442)
* Remove FilterbaleTablesStyles less

* Add theme top level
2022-04-04 17:11:22 +03:00
Geido
b601db7809 chore: Remove StyledQueryButton.less (#19441)
* Remove StyledQueryButton less

* Remove unused className
2022-04-04 17:10:20 +03:00
smileydev
5db36ec81c fix(sqllab): make to hide the delete button of most recent query history (#19358) 2022-04-03 19:59:38 -06:00
Kamil Gabryjelski
60dcd651f4 feat(explore): SQL popover in datasource panel (#19308)
* feat(explore): SQL popover in datasource panel

* Fix acequire not defined

* Rebase and fix tests

* Disable highlighting gutter

* Use ace-build acequire instead of brace
2022-04-03 13:26:56 +02:00
Yongjie Zhao
d954c3df86 fix: can't sync temporal flag on virtual table (#19366) 2022-04-01 16:40:50 +08:00
Diego Medina
eab9388f7c feat(sql lab): enable ACE editor search in SQL editors (#19328) 2022-03-31 16:05:00 -07:00
Michael S. Molina
816a2c3e1e chore: Removes direct theme imports (#19368) 2022-03-29 10:15:07 -03:00
smileydev
446358642f fix(explore-sqllab): make that Timestamp column keep the Is temporal flagged when overwriting (#19010) 2022-03-24 18:20:39 -06:00
Smart-Codi
8947eb9680 fix: Remove gap from SQLLab results bottom (#19138)
* Remove gap from SQLLab results bottom

* resolve comment
2022-03-24 16:53:43 -06:00
Kamil Gabryjelski
a8a48af7fa chore: Make font-weights themable, fix font faces (#19236)
* fix(fonts): Import all necessary font packages

* Make html tags themable

* Set bold font weight to 600, add medium font weight to theme

* Replace hard coded font weights with theme variables

* Change some font weight light elements to normal

* Fix tests

* Fix bug in pivot table

* Address code review comments
2022-03-22 09:36:15 +01:00
Diego Medina
4669b6ce11 fix: most Recently Selected Table Should Appear at the Top of the List on the Left Panel (#19258) 2022-03-21 15:58:23 -06:00
David Aaron Suddjian
97abc28a1f chore!: remove ENABLE_REACT_CRUD_VIEWS feature flag (permanently enable) (#19231)
* remove ENABLE_REACT_CRUD_VIEWS feature flag

* docs

* deal with problematic tests

* empty test suite

* skip test

* test conditions changed

* removing the tests instead of skipping
2022-03-18 14:00:23 -07:00
Jesse Yang
f6291545fb chore: turn on SQLLAB_BACKEND_PERSISTENCE by default (#19107)
* chore: turn on SQLLAB_BACKEND_PERSISTENCE by default

* Rewrite SQL tabs test to make it more rerunnable
2022-03-17 21:51:47 -07:00
cccs-Dustin
02ef9ca4cd feat(sqllab): Add a configuration option to disable data preview (#19104) 2022-03-17 15:22:57 +02:00
Diego Medina
3b427b2029 fix: auto-complete of tables and names are not working in SQL lab (#19152) 2022-03-16 20:46:06 -06:00
Hugh A. Miles II
fc8721800b fix: Revert "refactor: converted QueryAutoRefresh to functional component … (#19226)
* Revert "refactor: converted QueryAutoRefresh to functional component (#18179)"

This reverts commit f497c1900e.

* lint
2022-03-16 15:57:35 -07:00
Lyndsi Kay Williams
bb618a47ff fix(sqllab): Updated blank states for query results and query history (#19111)
* Empty states updated on result tab and query history tab

* Testing on query history blank state

* Testing on result tab with empty state

* Forgot to remove a comment

* Corrected empty state image size and centered with drag bar

* Centered blank states vertically
2022-03-16 14:09:19 -05:00
Hugh A. Miles II
a21d8a0bf4 fix autocomplete (#19047) 2022-03-09 19:07:22 -08:00
Diego Medina
fd757c4aa4 fix: enable find text browser functionality inside SQL Lab editor (#19061) 2022-03-09 12:27:10 -07:00
Diego Medina
bd76648e4e fix: show the total row count in the SQL Lab Query History tab when limited by DISPLAY_MAX_ROW (#19054) 2022-03-09 12:19:18 -07:00
Diego Medina
aa0ec717a2 Add previous line hotkey to SQL editor for macOS (#19052) 2022-03-08 14:26:36 -07:00
Michael S. Molina
329855170e refactor: Deletes the common/components folder (#18999) 2022-03-04 14:19:14 -03:00
cccs-Dustin
5a5ff99c37 fix(SQL Editor): names new query tabs correctly (#18951)
* Added in code changes that now properly increment the Untitled Query SQL Lab tab names. All that is left is to add tests to make sure that the function works correctly

* Updated the code so that it adds to the untitled_query_numbers variable only if the character after the string 'Untitled Query ' is a number. This prevents any issues when trying to get the maximum value in the list.

* Refactored part of the mapping code, to make it shorter and easier to read/understand

* Fixed issues in the code that were causing some of the CI tests to fail

* Made code changes based on comments within the PR. Also added a unit test to make sure that the newQueryEditor function in the TabbedSqlEditors component works as intended

* Fixed the failing cypress test in tabs.test.js
2022-03-04 18:28:30 +02:00
Brian Nguyen
f497c1900e refactor: converted QueryAutoRefresh to functional component (#18179)
* converted file to functional component

* refactor: convert class component to functional component

* refactor: convert class component to functional"

* Working on converting the shouldCheckForQueries test to RTL

* Working on converting first test to RTL

* Working on first test for queryAutoRefresh

* Finished Tests, pushing for review

* Cleaned up comments and console logs

Co-authored-by: Josue Lugaro <josuelugaro15@gmail.com>
2022-03-01 08:59:31 -08:00
AAfghahi
147dc5af71 fix(sql Lab tabs): Empty SQL Lab tabs (#18817)
* Empty SQL table message on zero tabs

* sql editor no editor tab bug fix

* Revert Error message

* empty state tab state

* added a unit test

* addressed reviews

* kasia feedback

Co-authored-by: Yahya Kayani <yahyakiani1@gmail.com>
2022-02-25 10:48:15 -08:00
Smart-Codi
79633ce673 fix: null schema issue in saved queries (#18849) 2022-02-25 16:07:46 +01:00
Michael S. Molina
fd4bd1edbc chore: Moves components out of the commons folder (#18931)
* refactor: Moves components out of the commons folder

* Fixes tests
2022-02-25 10:17:32 -03:00
Smart-Codi
0db49b1a7c fix Metadata browser in SQL not render nicely in Safari (#18855) 2022-02-24 23:16:31 -07:00
Erik Ritter
420a63f343 fix(sqllab): Un-render deselected tabs (#18934) 2022-02-24 13:01:02 -08:00
smileydev
91236a5225 fix(sqllab): Removed the tooltip from CopyToClipboard button in sqllab (#18749)
* fix(15849): Removed the tooltip from CopyToClipboard button in sqllab

* chore(sqllab): added props for tooltip in CopyToClipboard component

* fix(sqllab): Added arg to storybook and refactor the component

* fix(sqllab): added a test case for hideTooltip
2022-02-18 16:22:21 -07:00
EugeneTorap
8dc2377680 refactor: migrate ExploreCtasResultsButton component to typescript (#18142)
* Move component to FC & tsx

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Fix type issue

* Fix type issue

* Fix ResultSet type issue

* Refactoring RootState
2022-02-17 12:54:36 -08:00
maltoze
57c4d0f9a4 fix: passing url params in sqllab (#15246)
* fix: passing url params in sqllab

* avoid undefined serach and add test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2022-02-15 13:18:04 +02:00
Meitong Qu
9f678e55b9 chore: migrate QueryTable component from jsx to tsx (#17944)
* chore: fix misspelling of button

* changed QuerySearch/index.jsx to index.tsx

* updated Query type at src/SqlLab/types.ts/Query and extended it into QueryTable

* updated defaultQueryLimit to be optional at ResultSetProps of superset-frontend/src/SqlLab/components/ResultSet/index.tsx

* moved statusAttributes into useMemo hook so that it will not make the dependencies of useMemo Hook change on every render and statusAttributes is only used within useMomo hook

* reset package-lock.json and package.json at frontend

* Acquired redux rootestate type for SqlLab, to be used at useSelector(state)

* updated query to be Query type and added a comment for q.status on line 178

* updated queryTable for typescript conversion

* updated actions type on QueryHistory and QuerySearch

* updated type for actions in SouthPane

* created type for SqlLab redux

Co-authored-by: David Woolner <davidwoolner@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-02-11 06:54:42 -06:00
Adam Dobrawy
7c69a1bc60 chore: improve React import reference consistency (#18608) 2022-02-10 21:03:16 -08:00
Christopher C Fleming
51f716f573 refactor(ExploreCtasResultsButton): convert to functional component (#17939)
* chore: fix misspelling of button

* Feat: Update ExploreCtasResultsButton to functional component

* Fix pull request

* Fix index.tsx

* Fix prettier issues and actions

* Streamline the onClick so it calls visualize directly

* Update MSP and MDP to arrow functions

* Test destructured props

* Fix props destructuring error

* Simplify with optional chaining on line 94 and clean up buildVizOptions

Co-authored-by: David Woolner <davidwoolner@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-02-08 13:23:45 -08:00
Phillip Kelley-Dotson
9c08bc0ffc fix: change database database selector (#18609)
* fix: change database selector

* fix lint
2022-02-08 12:22:20 -05:00
EugeneTorap
cdfcbbaf30 refactor: migrate ExploreResultsButton component to FC & tsx (#18143)
* Move ExploreResultsButton to FC & tsx

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Fix test
2022-02-08 10:57:08 -05:00