Commit Graph

136 Commits

Author SHA1 Message Date
vera-liu
89df2fcf76 Adjusted top margin of heatmap plot to get it working in V2 (#1361)
* Adjusted top margin of heatmap plot to get it working in V2

Problem:
The heatmap in V2 was shifted towards the top margin of slice
container, this was because in v2 slice name header was part of the
container body, while in v1 the header was separately defined in
explore.html template.

Solution:
To get heatmap properly shown in V2, we need to
take into account the height of the slice_name header. Adding to
margin_top will shift the plot in V1 too, but it won't make a big
difference to the look.

Ideally when we renovate slice container in future PR we would defined a
height for slice_name header and take it into account for all
visualization files.

* Added panel header height to margin_top for explore v2

* Use getBoundingClientRect to get header height

* Use slice-header for id of panel-title
2016-10-25 10:44:29 -07:00
Maxime Beauchemin
174a199c30 [hotfix] Query search is unreachable 2016-10-24 17:54:43 -07:00
vera-liu
6f1e7c3016 Added url shortner for sharing query link (#1314)
* Added url shortner for sharing query link

* Move shortener outside CopyToClipboard and move ajax call to common.js

* transfer dbId to int to avoid failed prop
2016-10-24 17:49:23 -07:00
vera-liu
9f81e23f8f Fixed css class not being used by slice container (#1359)
* Fixed css class not being used by slice container

* Delete require css line since it's not needed when className is specified
2016-10-24 16:26:30 -07:00
vera-liu
19fab6eea7 Get table viz work in explore v2: Added d3 format to mock slice (#1353)
* Added d3format() function to mock slice in explorev2

Problem:
table viz was not working in explorev2 due to d3format() not defined in
mock slice.

* Change column_formats to camel case
2016-10-24 16:01:06 -07:00
Maxime Beauchemin
63161b11c3 [sqllab] proper, quoted, select * on the server side (#1404)
* [sqllab] proper, quoted, select * on the server side

* fixing tests
2016-10-21 16:55:37 -07:00
Maxime Beauchemin
3dea6e0da5 [sqllab] adding more descriptive labels to left panel (#1407) 2016-10-21 12:51:50 -07:00
Maxime Beauchemin
6fb3b305ad [sqllab] add support for results backends (#1377)
* [sqllab] add support for results backends

Long running SQL queries (beyond the scope of a web request) can now use
a k/v store to hold their result sets.

* Addressing comments, fixed js tests

* Fixing mysql has gone away

* Adressing more comments

* Touchups
2016-10-20 23:40:24 -07:00
Maxime Beauchemin
c255e89219 [sqllab] show partition metadata for Presto (#1342) 2016-10-19 09:17:08 -07:00
Nick Barnwell
2edce5bf8a Enable "Run Query in New Tab" in SQL Lab (#1343)
* Enable "Clone to New Tab" btn in QueryHistoryTable

Method #1; doesn't feel very clean.

Going to attempt to reimplement using an action and changing state directly
through the reducer rather than creating a new QueryEditor object directly from
the QueryTable

* Move Clone Logic to Action

* Implement PR feedback

* Clean up reducer action; fix bug

Bug => Attempting to clone anything other than the most recent Query for a given
TabbedQueryEditor would throw an exception, because we depended on lastQueryId
to find the title of the QueryEditor to clone. Since you can only activate a
clone from the currently active tab, we can instead fetch the ID of the Editor
to copy the Title of from the tip of tabHistory.

* Tests for Reducer Action

* Fix CodeClimate feedback
2016-10-18 16:02:29 -07:00
Alanna Scott
b669a14081 [explore-v2] make chart container work with existing visualization files (#1333)
* make chart container work with nvd3_vis.js

* map vis to module, remove unneeded components

* fix linting

* use existing query and save btns, don't fork more things

* comment out chart and exploreviecontainer specs

* make a change because i think the js test is failing spuriously
2016-10-14 12:54:18 -07:00
Maxime Beauchemin
5bea3986b2 [hotfix] handling json errors in explore view 2016-10-12 19:42:03 -07:00
vera-liu
b785d27241 Taking out object spread operator (#1311)
* Changed eslint channel in codeclimate.yml for object spread

* Revert "Changed eslint channel in codeclimate.yml for object spread"

This reverts commit b9deb8ce84478f9c8f48ca7d41662e7222f40376.

* Took out the object spread operator
2016-10-12 15:54:51 -07:00
Alanna Scott
451860afca remove #app styling (#1312) 2016-10-12 14:04:38 -07:00
Maxime Beauchemin
bf1f5ea3de [sqllab] use encodeURIComponent for copy query URL (#1317)
had to bump babel-preset-airbnb for object-rest-spread to work in my
env.

Change the menu icon, text and tooltip to clarify the usage
2016-10-11 15:50:36 -07:00
Mihail Diordiev
79460abdd2 [SQLLab] Fix the usage of Redux DevTools Enhancer (#1278)
* Fix the usage of Redux DevTools Enhancer

* Fix ESLint error
2016-10-11 15:27:25 -07:00
Alanna Scott
fe66557bbb [explore-v2] hook up ExploreViewContainer to state and add specs (#1300)
* add getParams func to common

* get data from redux state

* specs for chart container and explore view container
2016-10-10 13:46:00 -07:00
vera-liu
f8e2ce6ff3 Change status color in tab to match with success (#1247) 2016-10-10 13:32:38 -07:00
vera-liu
b7d1f78f5e Put formData in store (#1281)
* Put formData in store

* Reform actions and reducers

* Maded modifications based on comments:
2016-10-07 14:53:36 -07:00
Maxime Beauchemin
3384e7598e Fixing explore actions & slice controller interactions (#1292)
* Fixing explore actions & slice controller interactions

* Addressing a comment
2016-10-07 14:06:26 -07:00
Alanna Scott
382b8e85da [explore v2] add scrollbar to control panel container (#1284)
* add scroll bars to control panel container

* make query and save-btns block elements

* don't use react component, use custom styles

* move style to stylesheet
2016-10-07 11:57:05 -07:00
Alanna Scott
8a5f050f6c [explore v2] fix explorev2 chart errors (#1277)
* fix prototypes and arrow function

* only show line chart if viz type is line

* split render lines function

* fix arrow-body linter
2016-10-06 13:07:27 -07:00
vera-liu
5c5b393f2f Change userId, dbId to username and dbname (#1274) 2016-10-06 09:53:33 -07:00
Alanna Scott
f837733d85 [explorev2] chart and controls (#1251)
* create structure for new forked explore view (#1099)

* create structure for new forked explore view

* update component name

* add bootstrap data pattern

* remove console.log

* Created store and reducers (#1108)

* Created store and reducers

* Added spec

* Modifications based on comments

* do use bootstrap data for now

* don't deal with bootstrap data for now

* use victory as a base

* import fake line data, add fake panels, make chart fixed

* add fetch support

* get slice data from json endpoint

* render chart with slicejson

* update chart and label demo

* remove fetch config

* remove dummy control panels

* should be a func

* make TimeSeriesLineChart

* add a comment

* inner height for height

* don't need fetch yet

* trailing comma breaks in package json

* pass in viz data from props

* add style sheet

* set height on explore container

* add legend

* make chart responsive to window resize

* can't use head_css in template bc overrides head_css in basic

* fix linting

* break labelItem into own SFC, make legend SFC

* add propTypes and fix linter
2016-10-05 19:41:16 -07:00
vera-liu
66b498de25 Added controls for Table Viz (#1253)
* Added controls for Table Viz

* Change control panel container to stateless

* Changed specs

* Resolved conflicts
2016-10-05 14:53:51 -07:00
vera-liu
659bf6d7e8 Moved time column and grains to models.py (#1255) 2016-10-05 13:02:35 -07:00
vera-liu
421a86ade5 Some polish on query search (#1222)
* Some polish
- Changed query search icon
- CopyToClipboard in action bar

* Added dbId as linked-button, made modifications based on comments

* Fix duplicated import (linting)
2016-10-05 11:43:05 -07:00
vera-liu
8ab5e5015a Added access check + Druid in endpoint (#1224)
* Explore control panel - Chart control, TimeFilter, GroupBy, Filters (#1205)

* create structure for new forked explore view (#1099)

* create structure for new forked explore view

* update component name

* add bootstrap data pattern

* remove console.log

* Associate version to entry files (#1060)

* Associate version to entry files

* Modified path joins for configs

* Made changes based on comments

* Created store and reducers (#1108)

* Created store and reducers

* Added spec

* Modifications based on comments

* Explore control panel components: Chart control, Time filter, SQL,
GroupBy and Filters

* Modifications based on comments

* Added access check + Druid in endpoint

* pull grains to constants

* Switch explore.html to old version
2016-10-04 13:44:45 -07:00
Alanna Scott
ae54ac9d58 [sql-lab] fix react warnings in dev (#1232)
* rename file to match class

* fix react warnings

* fix proptype typo

* add missing keys
2016-10-03 23:58:47 -07:00
Alanna Scott
e6e902e8df [explore-v2] setup, basic layout, control panels, v2 url (#1233)
* Explore control panel - Chart control, TimeFilter, GroupBy, Filters (#1205)

* create structure for new forked explore view (#1099)

* create structure for new forked explore view

* update component name

* add bootstrap data pattern

* remove console.log

* Associate version to entry files (#1060)

* Associate version to entry files

* Modified path joins for configs

* Made changes based on comments

* Created store and reducers (#1108)

* Created store and reducers

* Added spec

* Modifications based on comments

* Explore control panel components: Chart control, Time filter, SQL,
GroupBy and Filters

* Modifications based on comments

* accommodate old and new explore urls

* move bootstrap data up in scope

* fix code climate issues

* fix long lines

* fix syntax error
2016-10-03 22:47:39 -07:00
vera-liu
d8638dbcf3 revert devtool alert (#1238) 2016-10-03 16:21:33 -07:00
Bogdan
9795e4a532 [SQLLab] Fix updating the database state. (#1225) 2016-10-03 10:40:27 -07:00
Bogdan
e11ef994bb [SQLLab] user server for the query limit check. (#1230) 2016-10-03 09:59:08 -07:00
vera-liu
d066f8b726 Added alert to install redux devtool (#1228)
* Added alert to install redux devtool

* Change to warning
2016-09-30 15:02:52 -07:00
vera-liu
96844c5c12 Share query (#1154)
* In the tab's dropdown menu under SQL editors, copy query link option is
added. A url with copied query will pop up a new editor tab.

* Made changes based on comments

* Move copy query button to right bottom of sql editor box

* Added in Alanna's code for copy url under menu item

* Fixed linting issues
2016-09-27 22:48:01 -07:00
Maxime Beauchemin
b67906cfe1 [hotfix] dashboard doesn't have filter_immune_slices pre-save 2016-09-26 17:11:03 -07:00
vera-liu
5f6ef84c4e Vliu query search (#1187)
* Query search page under SQL Lab tab

* Modifications based on comments

* Hash

* Added spec and endpoint test with modifications
based on second round comments

* Changed permission menu in https://github.com/airbnb/caravel/pull/1095/files
2016-09-23 17:41:24 -07:00
vera-liu
551c97112c Revert "Query Search Page" (#1186) 2016-09-23 16:28:21 -07:00
vera-liu
d5c5c0d6ac Query Search Page (#1122)
* Query search page under SQL Lab tab

* Modifications based on comments

* Hash

* Added spec and endpoint test with modifications
based on second round comments

* Changed permission menu in https://github.com/airbnb/caravel/pull/1095/files
2016-09-23 16:13:18 -07:00
Maxime Beauchemin
6e5a93a6e1 [hotfix] result set always updates 2016-09-23 12:06:57 -07:00
Bogdan
df89bec712 Infer types. Smart defaults for the visualize window. Basic implementation. (#1134)
* Implement smart suggestions for the visualize flow.

* Address JS comments.

* Implement caravel dataframe wrapper.
2016-09-23 11:14:38 -07:00
Maxime Beauchemin
aed473d0d2 [filtering] define combo of slice/fields unafected by filtering (#1179)
* [FilterBox] dashboard date range filtering

* [filtering] define combo of slice/fields unafected by filtering

* adding an entry to the docs

* Addressed comments
2016-09-22 20:12:48 -07:00
Maxime Beauchemin
7115c5458d [FilterBox] dashboard date range filtering (#1165)
* [FilterBox] dashboard date range filtering

* Addressing comments
2016-09-22 14:30:39 -07:00
Alanna Scott
2f2ed229fb [redux] move some redux utils to shared file (#1164)
* move some redux utils to shared file so they can be used in the new export view too

* enhancer is a func now
2016-09-21 21:54:03 -07:00
Maxime Beauchemin
f1e80a8e1b Adding indexes to table metadata (#1160) 2016-09-21 14:40:33 -07:00
Alanna Scott
0e7af8d8a6 [explore] refactor slice action button group (#1074)
* pull explore actions button group into component

* use button component

* make sure we render all action buttons

* test that embed code is correct

* don't need before each

* generalize modal trigger for use with plain links or icons
2016-09-20 13:45:27 -07:00
Maxime Beauchemin
e8088d5c9a More improvements to SQL Lab (#1104)
* Handling timeouts

* Fixing timer on non-utc server

* Allowing async with results

* [bugfix] database is not selected

* Making sure the session is up and running

* Cleaning up query results and query objects

* Picking a groupby and metric field on visualize flow

* Showing local time in query history

* Using pull-left pull-right instead of grid layout for table metdata

Long column name were looking weird and icons were wrapping oddly

* Linting

* Eliminating east buttons under the sql editor

* Sort database dropdown by name

* Linting

* Allowing non-SELECT statements to run

* Adding a db config

* Making sqla checkout check cross-db
2016-09-19 15:28:10 -07:00
Maxime Beauchemin
3602d940eb [hotfix] lint 2016-09-16 09:47:21 -07:00
Maxime Beauchemin
9389f89889 [welcome] removing calendar heatmap from welcome page (#1119) 2016-09-16 08:32:59 -07:00
Maxime Beauchemin
2adc8a0274 [explore] clarifying force-refresh message 2016-09-16 08:20:06 -07:00