/review-code on the post-round-5 slice flagged two minor issues genuinely
introduced by 89919a1c96:
* `loads_request_json` already swallows `TypeError`/`JSONDecodeError` and
returns `{}`, so the explicit `try/except ValueError` wrapping it was
dead defensive code. Replace it with an `isinstance(..., dict)` guard
— that also closes the pre-existing `?form_data=42` edge case where a
non-dict top-level JSON value would `AttributeError` on `.get()`.
* The no-datasource fall-through path (the loop the fix unblocked) had
no targeted regression test. `test_slices` and
`test_slice_id_is_always_logged_correctly_on_web_request` exercised
it only indirectly via `Slice.slice_url`. Add a sibling to
`test_explore_redirect` that asserts `/explore/?form_data={"slice_id":1}`
returns 200 (SPA render), not 302.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
After Superset.route_base="" (c531185d0a) and the FAB-link migration
(28b845ead4), `url_for` for the core blueprint emits `/dashboard/...`,
`/explore/...`, `/explore_json/...`, `/welcome/...` etc. (no `/superset/`
segment). Likewise the Tag component renders `/all_entities/?id=<id>`,
and rewritePermalinkOrigin substitutes window.location.origin into
backend permalinks at the frontend boundary.
Update test expectations to match:
* Python unit: tests/unit_tests/commands/report/execute_test.py drops
`superset/` from the 12 `dashboard/p/...` expected paths and the
`superset/dashboard/` membership check (kept assertion meaningful
via the existing `dashboard/p/` negative check).
* Python integration: drop `/superset/` from URLs hit by tests and
from URLs asserted against API payloads in core_tests, dashboard_tests,
dashboards/api_tests, event_logger_tests, log_api_tests, security_tests,
strategy_tests, utils_tests, reports/commands_tests,
reports/commands/execute_dashboard_report_tests. Fixed the regex in
test_new_dashboard to match the new Location header shape.
* Jest: ChartList tag-link assertion drops `/superset/`, and
URLShortLinkButton tests assert the rewritten URL
(`${window.location.origin}/123`) the component renders after
rewritePermalinkOrigin, instead of the raw backend `http://fakeurl.com/123`.
These were called out in PROJECT.md as the queued "integration test sweep
for old `/superset/<endpoint>/` shapes" — this commit closes that item.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
