Commit Graph

4632 Commits

Author SHA1 Message Date
John Bodley
94b3d2f0f0 refactor: Deprecate ensure_user_is_set in favor of override_user (#20502)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-07-05 10:57:40 -07:00
John Bodley
ad308fbde2 chore(rls): Remove passing global username (#20344)
* chore(rls): Remove passing global username

* Update manager.py

* Update manager.py

* Update manager.py

* Update manager.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-07-05 10:51:24 -07:00
Daniel Vaz Gaspar
92bf1b8ef6 fix: welcome page user authentication check (#20605) 2022-07-05 17:04:47 +01:00
Rahul Raj
4137fe03a0 fix(schedule-query): getUISchema function called in SchemaForm component (#20256)
* Revert "Superset - Release and Improvements (12-05-2022)"

* merging conflic changes

* Revert "Revert "Superset - Release and Improvements (12-05-2022)""

This reverts commit 6d18661e03.

* fixed breaking changes

* sync with master

* fixed breaking flows

* fixed getUISchema function call

* added default placeholder and updated docs

* fixed format and comments

* changed flag to configuration

* fix: indentation of SCHEDULED_QUERIES dict

* fix: changed intendation for SCHEDULED_QUERIES

* fix: updated docs for SCHEDULED_QUERIES

* fix: replaced button to menu item for SCHEDULED_QUERIES

* fix: updated docs for SCHEDULED_QUERIES

* fix: trailing whitespace
2022-07-05 14:16:37 +02:00
Yongjie Zhao
b870a21eaa refactor: remove unused flatten function (#20582) 2022-07-01 19:17:55 +08:00
yourssvk
90d486a643 fix: SQL Lab cancel query in Redshift database connection does not wo… (#16326)
* fix: SQL Lab cancel query in Redshift database connection does not work #16325


Co-authored-by: Venkata Krishnan Somasundaram <venkata_cred@Venkatas-MacBook-Pro.local>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2022-06-29 11:12:59 -07:00
Jesse Yang
cadd259788 feat: save active tabs in dashboard permalink (#19983) 2022-06-29 09:43:52 -07:00
Michael S. Molina
cb3cd41dcd fix: Removes psycopg2 as a required dependency (#20543)
* fix: Removes psycopg2 as a required dependency

* Disables lint warning
2022-06-29 09:22:13 -03:00
Saint
364bb7c639 chore: added new translations to the spanish language (#20427)
* Added new translations for Spanish Language - Specifically on the visualizations of Time-Series

* Chore: Added more translations to the Time-Series visualizations
2022-06-28 20:34:14 +08:00
Susur
c4d2238a16 feat: add Spark Sql DB engine spec and support Spark 3.x (#20462)
* add apache spark3

* add Spark DB engine spec

* rebase secret key

* modify License error

* rebase databricks

* modify code style

* black code style

Co-authored-by: kai.he01 <kai.he01@idiaoyan.com>
2022-06-27 15:50:35 -07:00
John Bodley
f29cde2269 refactor: Minor optimization for updating DatasetDAO columns and metrics (#20473)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-25 14:31:04 -07:00
John Bodley
3483446c28 refactor: Cleanup user get_id/get_user_id (#20492)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-24 17:57:04 -07:00
Daniel Vaz Gaspar
c56e37cda2 fix: bump FAB to 4.1.2 (#20483) 2022-06-24 19:13:48 +01:00
Michael S. Molina
20163361b9 feat: Adds the /explore endpoint to the v1 API (#20399)
* feat: Adds the /explore endpoint to the v1 API

* Fixes pylint errors

* Fixes tests

* Changes the tests logic

* Removes ABC reference

* Improves indentation

* Addresses review comments

* Rebases code

* Improves dataset and slice assertions

* Fixes tests

* Removes schema and table name assertions

* Removes fixed IDs

* Fixes datasource ID
2022-06-24 08:23:30 -03:00
Elizabeth Thompson
44f0b511dd remove autoflush for queries during dual write (#20460) 2022-06-23 14:50:30 -07:00
Daniel Vaz Gaspar
b33c23ef25 fix: migration revision order (#20484) 2022-06-23 18:42:35 +01:00
John Bodley
f5cb23e0a3 fix(migration): Ensure key_value LargeBinary is encoded as a MEDIUMBLOB as opposed to BLOB for MySQL (#20385)
* fix(migration): Ensure key_value LargeBinary is encoded as a MEDIUMBLOB as opposed to BLOB for MySQL

* Update 2022-06-14_15-28_e09b4ae78457_resize_key_value_blob.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-23 08:38:33 -03:00
Michael S. Molina
a169b60712 fix: Changes the return type of get_permissions to be JSON friendly (#20472)
* fix: Changes the return type of get_permissions to be JSON friendly

* Removes dangling comma

* Removes unused import

* Fixes typing errors
2022-06-22 15:28:59 -06:00
AAfghahi
2c16be42e1 async queries limit bug (#20468) 2022-06-22 16:21:34 -04:00
cccs-Dustin
daded10992 feat(SQL Lab): Make SQL Lab explore use the default viz from the config file (#20056)
* Modified SQL Lab so it uses the default viz to explore a new dataset with

* Added a comment to the config file

* Remove trailing whitespace

* [CLDN-1312] Removed the 'viz_type' variable so that when it is undefinded in the back-end, it gets set to the default viz

* [CLDN-1312] Only sets the 'all_columns' variable if the default viz type is a 'table'

* Will only pop 'selectedColumns' out of 'form_data' if it is present

* [CLDN-1312] Updated files so that the default viz is now being used again in SQL Lab Explore
2022-06-22 11:33:44 -06:00
Cody Leff
44c5e2879b chore(newchart): update chart creation dataset selection help text, styles (#20369)
* Update dataset selection help text.

* Update 'Create a new chart' flow styles.

* Add support for linking directly to Create Dataset modal via URL hash.

* Add support for linking directly to Create Dataset modal via URL hash.

* Update dataset help text to not include spaces in translated strings and only include an 'Add dataset' link when user has permission to add dataset.

* Clean up test file

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-06-21 14:01:43 -03:00
Beto Dealmeida
f3b289d3c3 fix: ensure column name in description is string (#20340)
* fix: ensure column name in description is string

* Add unit test
2022-06-21 10:10:46 -03:00
Diego Medina
5afeba34bd fix(viz): BigQuery time grain 'minute'/'second' throws an error (#20350) 2022-06-21 10:06:52 -03:00
Yongjie Zhao
8bbbd6f03f fix: should raise exception when apply a categorical axis (#20451) 2022-06-21 20:37:51 +08:00
Daniel Vaz Gaspar
ba4ba0267e fix: RLS new db migration downgrade fails on SQLite (#20449) 2022-06-21 13:07:23 +01:00
Hugh A. Miles II
e3e37cb68f chore: switching out ConnectorRegistry references for DatasourceDAO (#20380)
* rename and move dao file

* Update dao.py

* add cachekey

* Update __init__.py

* change reference in query context test

* add utils ref

* more ref changes

* add helpers

* add todo in dashboard.py

* add cachekey

* circular import error in dar.py

* push rest of refs

* fix linting

* fix more linting

* update enum

* remove references for connector registry

* big reafctor

* take value

* fix

* test to see if removing value works

* delete connectregistry

* address concerns

* address comments

* fix merge conflicts

* address concern II

* address concern II

* fix test

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
2022-06-21 13:22:39 +02:00
Samira El Aabidi
68af5980ea feat(chart): Enable caching per user when user impersonation is enabled (#20114)
* add username to extra cache keys when impersonation is enabled.

* don't put effective_user in extra_cache_key

* get_impersonation_key method in engine_spec class  to construct an impersonation key

* pass datasource when creating query objects

* adding an impersonation key when construction cache key

* add feature flag to control caching per user

* revert changes

* make precommit and pylint happy

* pass a User instance

* remove unnecessary import
2022-06-20 18:14:08 -07:00
Sam Firke
b7eb235440 style(typo): occured -> occurred (#20116)
* Occured -> Occurred

* Occured -> Occurred

* Occured -> Occurred

* Occured - > Occurred

* Update FallbackComponent.tsx

* Update FallbackComponent.tsx

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
2022-06-20 08:49:45 -07:00
Daniel Vaz Gaspar
60eb1094a4 feat: add name, description and non null tables to RLS (#20432)
* feat: add name, description and non null tables to RLS

* add validation

* add and fix tests

* fix sqlite migration

* improve default value for name
2022-06-20 13:52:05 +01:00
John Bodley
8b0bee5e8b [fbprophet] Fix frequencies (#20326) 2022-06-19 21:53:09 -07:00
Simon Thelin
8b7262fa90 fix(20428): Address-Presto/Trino-Poll-Issue-Refactor (#20434)
* fix(20428)-Address-Presto/Trino-Poll-Issue-Refacto
r

Update linter

* Update to only use BaseEngineSpec handle_cursor

* Fix CI

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
2022-06-19 16:28:59 -07:00
Lily Kuang
ab9f72f1a1 fix(embedded): CSV download for chart (#20261)
* move postForm to superset client

* lint

* fix lint

* fix type

* update tests

* add tests

* add test for form submit

* add test for request form

* lint

* fix test

* fix tests

* more tests

* more tests

* test

* lint

* more test for postForm

* lint

* Update superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* update tests

* remove useless test

* make test cover happy

* make test cover happy

* make test cover happy

* make codecov happy

* make codecov happy

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2022-06-17 20:01:08 -07:00
Lily Kuang
f53018c7c5 feat(embedded): enforce allow domains (#20251)
* feat(embedded): enforce allow domains

* check referrer in view

* remove frontend check
2022-06-17 12:57:51 -07:00
mohittt8
41bbf62e58 fix(presto): use correct timespec for presto (#20333) 2022-06-16 16:43:17 -07:00
Beto Dealmeida
998624b1a5 feat: allow setting db UUID (#20412)
* WIP

* feat: allow passing UUID when creating a DB

* Test

* Fix field
2022-06-16 15:53:59 -07:00
Elizabeth Thompson
12436e47c9 fix key error on permalink fetch for old permalinks (#20414) 2022-06-16 15:51:17 -07:00
chuancy
11d94ce56c Chinese translation and English translation do not match (#20405) 2022-06-16 11:27:53 -03:00
Diego Medina
3fe53f735e fix: Unable to export multiple Dashboards with the same name (#20383) 2022-06-15 00:27:24 -06:00
Elizabeth Thompson
5a137820d0 fix: catch some potential errors on dual write (#20351)
* catch some potential errors on dual write

* fix test for sqlite
2022-06-13 17:30:13 -07:00
Smart-Codi
ee06d3d113 Fix typo issue in Error handling message (#20365) 2022-06-13 14:29:18 -06:00
Reese
11b33de61b feat(api): Added "kind" to dataset/<pk> endpoint (#20113) 2022-06-10 13:03:48 -07:00
Beto Dealmeida
ec331e683e feat: Databricks native driver (#20320) 2022-06-09 15:34:49 -07:00
Craig Rueda
d1c24f81f2 chore(migrations): Renaming migration files so that they're easier to keep track of (#20284)
* Renaming migration files so that they're easier to keep track of

* Fixing broken import

* Fixing broken import again

* Fixing broken tests
2022-06-07 10:30:09 -07:00
Rui Zhao
2a45be3996 fix(embedded): Referecing local variable response before initialization (#20263)
Co-authored-by: Rui Zhao <zhaorui@dropbox.com>
2022-06-06 14:05:47 -07:00
AAfghahi
c131f025f8 chore: add event logger to reports/alerts CRUD (#20249)
* add event logger to report CRUD

* added assert metric to tests

* added unique name to action

* testing

* with inline log context
2022-06-06 16:13:22 +02:00
John Bodley
b08e21efd9 [requirements] Resolve rebase conflicts (#20152)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-03 15:27:35 -07:00
Smart-Codi
80974033c0 fix database import with cancel_query.. extra field (#20187) 2022-06-03 12:51:06 -06:00
Elizabeth Thompson
f270e49c4b chore: use exc_info to pass errors to log warnings (#20252)
* use exc_info to pass errors to log warnings

* Update superset/views/base.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/views/base.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2022-06-03 11:41:24 -07:00
Stephen Liu
80b5578680 feat(superset-ui-core): add feature flag for the analogous colors (#19987)
* feat(superset-ui-core): add feature flag for the color analogous generator

* fix: test
2022-06-03 21:32:32 +08:00
Diego Medina
92057858c2 fix(sql lab): View result button is not showing consistently (#20164) 2022-06-02 22:53:59 -06:00