Commit Graph

125 Commits

Author SHA1 Message Date
Kamil Gabryjelski
f422f1ea49 perf(dashboard): decouple redux props from dashboard components (#16421)
* perf(dashboard): decouple redux props from dashboard components

* Lint fix

* Dont make copy of filters object

* Remove unnecessary exports
2021-08-26 21:54:11 +02:00
Michael S. Molina
e59f318ef9 chore: Changes the RefreshIntervalModal component to use the new select component (#16048) 2021-08-06 07:58:53 -03:00
Michael S. Molina
cc704dd53a fix: Cancel alert is not appearing to all native filters modal fields (#15925) 2021-07-30 11:59:36 -03:00
Michael S. Molina
5be0a89625 fix: Charts sort by in edit mode gets cut off (#15896) 2021-07-26 16:38:38 -03:00
Michael S. Molina
e6bbca3f61 chore: Preserve native filters selection after refresh (#15583) 2021-07-13 15:14:18 -03:00
Ville Brofeldt
f286647140 chore(native-filters): remove instant filtering option (#15365)
* chore(native-filters): remove instant filtering option

* fix test
2021-07-01 13:38:56 +03:00
Ville Brofeldt
4630abb5a8 feat(native-filters): add support for preselect filters (#15427)
* feat(native-filters): add support for sharing preselected filters

* abc

* add serialization
2021-06-29 18:57:49 +03:00
Kamil Gabryjelski
f109da479d perf(dashboard): Improve perf of highlighting charts in scope of active filter (#15424)
* perf(dashboard): Improve perf of highlighting charts in scope of active filter

* More optimizations

* fix tests

* Fix lint

* bug fix
2021-06-29 12:55:53 +02:00
Michael S. Molina
bdb9b0a9be chore: Rewrites dashboard IconButton component (#14174) 2021-06-25 15:15:20 -03:00
Kamil Gabryjelski
f0b64190b5 feat(native-filters): Set default scope by filters' and charts' datasets (#15302)
* feat(native-filters): Set default scope by filter's and charts datasets

* Fix undefined error

* Use JSON.stringify in dependency array

* Fix lint issue

* Lock scope after switching radio buttons

* Fix weird eslint issue

* Change prop names

* Implement useComponentDidUpdate

* Fix lint

* Refactor useComponentDidUpdate

* Remove screen.debug()
2021-06-24 09:23:35 +02:00
Michael S. Molina
0c22266041 chore: Improves the native filters bar layout (#15115) 2021-06-16 14:17:14 +03:00
Ajay M
045fa1bc7a feat(dashboard): Let users download full CSV of a table (#15046)
* - Convert SliceHeader to TSX in progress
- Add menu option to download full CSV. Probably will change it

* Add Download Full CSV feature, and tests

* Added more tests, more TS fixes

* Added feature flag

* Update @superset-ui package versions

* Update @superset-ui packages versions

* use backend config instead of hardcoding number of rows

* Update tests

* front end test fix

* Lint fixes and test fixes
2021-06-14 14:26:18 -07:00
Kamil Gabryjelski
51f0d4fd98 feat(native-filters): Hide filters which don't affect any visible charts (#15063)
* feat(native-filters): Hide filters which don't affect any visible charts

* Fix lint errors

* Add comments

* Code review fix

* Fix tests

* Refactor logic in FilterControls
2021-06-11 13:41:08 +02:00
Kamil Gabryjelski
405f95b6af feat(dashboard/native-filters): Hide filters out of scope of current tab (#14933)
* Optimize finding charts and tabs in scope

* Put filters out of scope in Collapse

* Use lastFocusedTabId instead of directPathToChild

* Fix tests

* Fix cypress test

* Uncomment e2e test
2021-06-02 20:38:18 +02:00
Michael S. Molina
0c0eccb81a chore: Improves the native filters UI/UX - iteration 3 (#14824) 2021-05-26 10:49:00 +03:00
Kamil Gabryjelski
c831655913 feat(native-filters): Highlight charts affected by focused native filter (#14693)
* Highlight charts affected by focused native filter

* Remove tabs animation on dashboard

* Remove a test that checks for "animated={true}" prop on tabs

* Move hooks types to a separate interface
2021-05-21 15:54:33 +02:00
Michael S. Molina
be8c176df2 chore: Removes less from SliceAdder (#14448) 2021-05-19 00:16:44 -07:00
Phillip Kelley-Dotson
e4e23ea487 fix: fix adhocpopovers tab animate. (#14478)
* fix popover

* addd tabs default css

* fix lint

* fix tests

* address comments

* lint fix

* fix test

* lint
2021-05-13 20:30:27 -07:00
Michael S. Molina
e7a4734742 chore: Removes tabs animation by default (#14496) 2021-05-08 14:22:16 -07:00
simcha90
582900c170 perf(native-filters): Load native filters after charts (#14443)
* fix:fix get permission function

* refactor: filter default value

* refactor: update default value loading

* refactor: apply defaultValues

* lint: fix lint

* lint: fix lint

* test: fix test

* refactor: use extraFormData for reload charts

* feat: load native filters after after charts

* feat: load filters after charts

* fix: revert changes

* test: fix timers

* test: fix tests
2021-05-04 16:07:40 +03:00
simcha90
bbb1f2d757 perf(native-filters): avoid unnecessary reloading of charts (#14408)
* fix:fix get permission function

* refactor: filter default value

* refactor: update default value loading

* refactor: apply defaultValues

* lint: fix lint

* lint: fix lint

* test: fix test

* refactor: use extraFormData for reload charts

* test: fix tests

* test: fix tests

* test: fix tests
2021-05-03 14:56:41 +03:00
Geido
545e257537 feat: Dynamic imports for the Icons component (#14318)
* Add aria-label and twotone

* Enhance LazyIcon

* Fix tests and solve ject warnings

* Add new line

* Revert package-lock to master

* Fix failing test

* Implement icon overrides

* Fix failing storybook

* Clean up

* Improve var name
2021-04-29 11:49:39 -07:00
Michael S. Molina
1d6a746a09 refactor: Boostrap to AntD - Tabs (#14048) 2021-04-28 23:49:50 -07:00
Michael S. Molina
d0be1ff79e chore: Moves Tabs to the components folder (#14136) 2021-04-27 00:15:21 -07:00
simcha90
7ff35dfdfb fix(native-filters): Fix indicators (#14334)
* fix:fix get permission function

* fix: hide featured filters

* test: fix FF in tests

* test: fix FF in tests

* fix: fix unset cross filters
2021-04-26 13:22:11 +03:00
simcha90
3e8bf96642 fix(native-filters): Fix first loading of charts (#14332)
* fix:fix get permission function

* fix: fix unnecessary loading for native filters

* test: fix mocks
2021-04-25 13:58:53 +03:00
simcha90
d386e66f59 test(native-filters): add integration tests for filter bar (#14098)
* test: add tests for filter bar

* test: merge filter bar tests with master

* test: add test for filter set

* test: filter set tests

* test: merge with master

* test: fix tests for filter bar

* fix: fix CR notes

* fix: fix CR notes
2021-04-20 12:24:12 +03:00
Michael S. Molina
b83ee46d0f chore: Moves Modal to the components folder (#14130) 2021-04-16 15:49:53 -07:00
simcha90
8ef572a412 refactor(native-filters): update dataMask and ExtraFormData schema (#13983)
* refactor: updates usage of `ownFilters` to `ownState`

* refactor: update dataMask (final)

* lint: fix lint

* refactor: revert feat

* fix: fix missed chart configuration

* add filter set migration

* apply new changes

* fix migration revision

* update migration

* fix jest mock

* js lint

* fix test types

* update tests and types

* remove append_form_data from tests

* fix findExistingFilterSet tests

* add migration test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-04-15 17:43:29 +03:00
Geido
474f1e2044 test: Add tests for Dashboard Header and HeaderActionsDropdown components (#13973)
* Add tests for HeaderActionsDropdown - WIP

* Fix trigger node

* Add types

* Clean up

* Add tests for Header

* Delete obsolete tests

* Add factory and clean up

* Add opposite case

* Fix file name

* Include latest changes
2021-04-14 06:54:24 -07:00
Michael S. Molina
c8a794368d refactor: Bootstrap to AntD - ListGroup (#13996)
* refactor: Bootstrap to AntD - ListGroup

* Improves theme handling on touched files
2021-04-13 15:26:02 -07:00
Amit Miran
9c5264af0d feat(can_share): can share chart and dashboard (#14076)
* feat: share chart  - can_share_chart
share dashboard can_share_dashboard

* fix: pre-commit

* fix: userCanShare tests

* fix: after hugh CR

* fix: adjust after spa refactor
2021-04-13 13:54:14 +03:00
Michael S. Molina
b394733ff3 test: Adds tests to the UndoRedoKeyListeners component (#13919) 2021-04-12 23:51:57 -07:00
Geido
11869dc076 test: Tests audit for the Dashboard FilterBar (#13916)
* Add FilterBar tests

* Finalize FilterBar tests

* Add tests for FilterBar Header

* Add tests for FilterBar FilterConfigurationLink

* Add tests for FilterBar FilterSets EditSection

* Add tests for FilterBar FilterSets

* Clean up

* Add tests for FilterBar FilterSetUnit

* Add tests for FilterBar FilterSets FiltersHeader

* Add tests for FilterBar FilterSets Footer

* Fix linting

* Fix import

* Fix minor changes

* Fix import

* Add factory and clean up
2021-04-12 23:28:19 -07:00
Michael S. Molina
b5c95c537c test: Adds tests to the CssEditor component (#13933) 2021-04-07 14:40:24 -07:00
simcha90
e06290663a fix(colors): fix color schemes (#13945)
* fix: fix color schemes

* fix: tests case
2021-04-04 15:53:21 +03:00
Michael S. Molina
a1442497d4 test: Fixes PropertiesModal_spec (#13548) 2021-04-01 11:42:14 -07:00
simcha90
aa92c1e7eb refactor(native-filters): refactor filter bar (#13723)
* fix: fix removeing native filter

* fix: fix native-cross filters

* fix: fix native-cross filters

* fix: fix native-cross filters

* fix: fix function declaration

* refactor: before pull

* refactor: refactor filter bar

* chore: add lic

* lint: fix lint
2021-03-22 17:03:44 +02:00
Grace Guo
fa072cd74e fix: dashboard filter scope bug (#13695)
* fix: dashboard filter scope bug

* fix comments

* fix function/variables name
2021-03-19 10:39:09 -07:00
simcha90
0e0c99b2fb feat(cross-filters): Add scoping for cross filters (#13625)
* feat: cross filter modal

* refactor: add charts metadata

* refactor: add charts metadata

* feat: cross filters scoping

* fix: fix CR notes

* test: fix test

* lint: fix lint
2021-03-17 14:00:32 +02:00
simcha90
3970d7316b feat(native-filters): Update filter bar buttons (#13506)
* refactor(native-filters): move data mask to root reducer

* refactor: update rest stuff for dataMask

* refactor: add ownCrrentState to explore

* fix: fix immer reducer

* fix: merge with master

* refactor: support explore dataMask

* refactor: support explore dataMask

* docs: add comment

* refactor: remove json stringify

* fix: fix failed cases

* feat: filter bat buttons start

* fix: fix CR notes

* fix: fix cascade filters

* fix: fix CR notes

* refactor: add clear all

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

* feat: buttons in filter bar

* lint: update imports

* test: fix tests
2021-03-07 11:27:22 +02:00
simcha90
45972e9945 refactor(native-filters): Move filtersState to dataMask redux root (#13437) 2021-03-07 09:34:12 +02:00
simcha90
dc170397c5 feat(dashboard_rbac): manage roles for dashboard (#13145)
* feat(dashboard_rbac): manage roles for dashboard

* test: fix tests

* fix: fix empty roles

Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
2021-03-03 12:31:41 +02:00
simcha90
f19a830d9b refactor(self-trigger): Split native filters state (#13137)
* feat: add cross filters

* refactor: fix CR notes

* lint: fix lint

* lint: fix lint

* feat: POC adding filters set feature

* chore: pre-commit

* refactor: under chage

* lint: fix TS

* fix: fix FF name

* refactor: move to behaviors

* lint: fix lint

* refactor: update state of native filters

* refactor: finish refactor nativeFilter state

* feat: split native filters state

* refactor: refactor Time filter to use new API

* refactor: refactor Time filter to use new API

* refactor: fix CR notes

* fix: fix update values in filter bar

* refactor: save filter sets in meta

* feat(filter-sets): save filters sets in metadata

* refactor: partially fix ts

* refactor: merge conflicts

* refactor: add behaviors property

* refactor: add behaviors property

* fix: undo py changes

* fix: under some changes

* refactor: synx with master

* fix: undo FF

* fix: undo FF

* lint: ts-ignore

* chore: update lock file

* refactor: update enum

* refactor: naming of enum

* test: fix test

* test: update mocks

Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2021-03-02 09:03:26 +02:00
Michael S. Molina
72721845e1 test: Adds tests to URLShortLinkButton component (#13319) 2021-02-25 10:59:36 -08:00
simcha90
9b5e66b728 refactor(native-filters): Refactor filters config modal module (#13268)
* refactor(native-filters): Refactor filters config modal module

* fix: fix import

* lint: fix import
2021-02-22 09:23:38 +02:00
Michael S. Molina
42ab57850d Migrate Bootstrap Alert to AntD (#12101) (#12122) 2021-02-21 20:50:18 -08:00
Geido
409fc83ca9 chore: Tab title to be empty when creating a new tab (#12773)
* Remove unwanted package lock

* Edit on new and autofocus

* Update test

* Remove autofocus
2021-02-18 10:14:59 -08:00
simcha90
2ff8741248 feat(filter-sets): Saving filter sets in metadata (#13205)
* feat: POC adding filters set feature

* lint: fix TS

* fix: fix FF name

* refactor: fix CR notes

* fix: fix update values in filter bar

* refactor: save filter sets in meta

* feat(filter-sets): save filters sets in metadata
2021-02-18 15:43:10 +02:00
Michael S. Molina
ad4ca2223e feat: one-click copy chart and dashboard URL (#13037)
Closes #10328
2021-02-17 14:14:08 -08:00