QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 07:35:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
7,999 Commits 448 Branches 542 Tags
a3f54a6c7bde41669413c2df6ff7213210a2e2b9
Commit Graph

80 Commits

Author SHA1 Message Date
John Bodley
ab4e3b9bf9 chore: Enforce Mypy for non-tests (#15757) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-07-22 06:46:43 +12:00
Beto Dealmeida
c9dad05f2b chore: remove retry dependency in favor of backoff (#15788) 
* chore: remove retry dep in favor of backoff

* Fix lint
 2021-07-20 10:33:37 -07:00
Daniel Vaz Gaspar
727847d2e5 fix: remove unnecessary app context on celery (#15422) 
* fix: remove unnecessary app context on celery

* fix lint

* fix lint
 2021-06-29 12:16:16 +01:00
Ben Reinhart
a06a2f30af fix: Set g.user to anon user in Celery (#14742) 
* Set g.user to anon user in Celery

* Add test

* Fix bug in logic
 2021-05-21 14:33:08 -07:00
Sam Faber-Manning
11260b3117 chore: add stack trace to all calls of logger.error (#14382) 2021-04-30 09:22:05 -07:00
Ben Reinhart
e7f5100833 fix: Fix unintended cache misses with async queries (#14291) 
* bug: Fix unintended cache misses with async queries

* Ensure sort order

* Ensure columns are sorted

* Update failing tests
 2021-04-28 12:14:55 -07:00
Lily Kuang
7980b767c0 feat: Implement Celery SoftTimeLimit handling (#13740) 
* log soft time limit error

* lint

* update test
 2021-04-12 13:18:17 -07:00
Daniel Vaz Gaspar
89817d4cee fix(alerts/reports): working timeout with celery kill and logic fix (#13911) 
* fix: working timeout with celery kill and logic fix

* add config flags

* fix typo

* fix python lint

* log query time for alerts

* add tests

* fix lint
 2021-04-08 11:23:31 +01:00
Ben Reinhart
ca506e9396 fix(#13378): Ensure g.user is set for impersonation (#13878) 2021-03-31 11:22:56 -07:00
Jack Fragassi
304e3b36eb feat(alerts & reports): Easier to read execution logs (#13752) 
* Prep for migration

* Migration for execution id column

* Generate execution ids for alerts and reports

* Change execution id range

* Add execution id to API endpoint

* Add execution id to execution log view

* Change execution id range

* Change execution id to a uuid

* Fix execution id type

* Switch state and exec. id columns

* Change db column to UUIDType

* Python lint

* Fix failing frontend tests

* execution_id -> uuid

* Fix migration head

* lint

* Use celery task id as the execution id

* lint

* lint for real

* Fix tests
 2021-03-30 08:46:16 -07:00
ʈᵃᵢ
3078c84d40 feat(reports): SLACK_API_TOKEN as callable or str (#13634) 2021-03-16 10:06:29 -06:00
Daniel Vaz Gaspar
94fc5d586e docs: deprecate old alerts and dash/charts reports (#13440) 
* docs: deprecated old alerts and dash/charts reports

* revert celery default config

* fix lint
 2021-03-05 09:40:08 +00:00
Rob DiCiuccio
b4ca39ceeb fix(celery): Reset DB connection pools for forked worker processes (#13350) 
* Reset sqlalchemy connection pool on celery process fork

* Fix race condition with async chart loading state

* pylint: ignore

* prettier
 2021-02-26 08:05:40 -08:00
Daniel Vaz Gaspar
a0e05a5eff fix(reports): handle exceptions properly in scope (#12811) 
* fix(reports): handle exceptions properly in scope

* list and test commit removal

* revert removing commits from tests

* lint
 2021-01-28 19:06:19 +00:00
İbrahim Ercan
49e6e420da fix: session error fixed related to thumbnails. (#12760) 
* fix: session error fixed related to thumbnails.

* compute_and_cache moved to session scope

* lint fix done
 2021-01-27 11:04:14 +00:00
Rob DiCiuccio
e4ae17def5 fix: Stabilize and deprecate legacy alerts module (#12627) 
* Add deprecation notice to superset.tasks.schedules

* Reduce retries and schedule window for alerts
 2021-01-21 09:51:53 -08:00
Yongjie Zhao
9b0e6d0cc0 refactor: from superset.utils.core break down date_parser (#12408) 2021-01-11 14:16:42 -08:00
Amit Miran
b221417e19 chore: remove harmless incubator refs (#12289) 
* chore: migrate all harmless incubator refs like comments and documentation files

* chore: migrate all superset.incubator.apache.org to superset.apache.org to

* chore: migrate dist.apache.org refs

* chore: removing incubating and Disclaimer

* fix: linting issues
 2021-01-06 13:45:19 +02:00
Daniel Vaz Gaspar
0171a6bee4 fix(reports): don't log user errors and state change has errors (#12277) 2021-01-06 08:57:10 +00:00
Daniel Vaz Gaspar
1a20552c2b fix(reports): increase crontab size and alert fixes (#12056) 
* fix(reports): increase crontab size

* update to current alembic revision

* Merge branch 'master' into feat/security-converge-datasets

# Conflicts:
#	tests/security_tests.py

* Merge branch 'master' into feat/security-converge-datasets

# Conflicts:
#	tests/security_tests.py

* Merge branch 'master' into feat/security-converge-datasets

# Conflicts:
#	tests/security_tests.py

* lint

* update alembic revision

* fix related fields

* fix test
 2020-12-17 18:03:05 +00:00
Rob DiCiuccio
4d329071a1 feat(SIP-39): Async query support for charts (#11499) 
* Generate JWT in Flask app

* Refactor chart data API query logic, add JWT validation and async worker

* Add redis stream implementation, refactoring

* Add chart data cache endpoint, refactor QueryContext caching

* Typing, linting, refactoring

* pytest fixes and openapi schema update

* Enforce caching be configured for async query init

* Async query processing for explore_json endpoint

* Add /api/v1/async_event endpoint

* Async frontend for dashboards [WIP]

* Chart async error message support, refactoring

* Abstract asyncEvent middleware

* Async chart loading for Explore

* Pylint fixes

* asyncEvent middleware -> TypeScript, JS linting

* Chart data API: enforce forced_cache, add tests

* Add tests for explore_json endpoints

* Add test for chart data cache enpoint (no login)

* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag

* Add tests for tasks/async_queries and address PR comments

* Bypass non-JSON result formats for async queries

* Add tests for redux middleware

* Remove debug statement

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Skip force_cached if no queryObj

* SunburstViz: don't modify self.form_data

* Fix failing annotation test

* Resolve merge/lint issues

* Reduce polling delay

* Fix new getClientErrorObject reference

* Fix flakey unit tests

* /api/v1/async_event: increment redis stream ID, add tests

* PR feedback: refactoring, configuration

* Fixup: remove debugging

* Fix typescript errors due to redux upgrade

* Update UPDATING.md

* Fix failing py tests

* asyncEvent_spec.js -> asyncEvent_spec.ts

* Refactor flakey Python 3.7 mock assertions

* Fix another shared state issue in Py tests

* Use 'sub' claim in JWT for user_id

* Refactor async middleware config

* Fixup: restore FeatureFlag boolean type

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
 2020-12-10 20:21:56 -08:00
Daniel Vaz Gaspar
1e3aaab590 fix(reports): validator_config, report state machine, working_timeout (#11890) 
* fix(reports): expect more exceptions and fix validator config

* use a state pattern on command reports

* use a state pattern on command reports continue

* fix multiple heads

* fix unittests

* add more tests

* fix api tests after enum rename

* fix alembic multiple heads

* fix tests

* fix fixture cleanup

* fix mysql tests

* fix initial and not found state

* fix schema, and private public methods, addressing comments

* add new col to the API
 2020-12-09 18:19:07 +00:00
Daniel Vaz Gaspar
7e6f04fce4 fix(alerts, thumbnails): celery tasks using flask-sqlalchemy sessions (#11950) 
* fix(alerts, thumbnails): celery tasks using flask-sqlalchemy sessions

* selenium user is case sensitive
 2020-12-08 13:03:32 +00:00
Daniel Vaz Gaspar
f27ebc4be5 feat: new reports scheduler (#11711) 
* feat(reports): scheduler and delivery system

* working version

* improvements and fix grace_period

* add tests and fix bugs

* fix report API test

* test MySQL test fail

* delete-orphans

* fix MySQL tests

* address comments

* lint
 2020-11-25 08:50:30 +00:00
Grace Guo
014fe9fd8c fix: [email report] add multiple schedules per hour (#11414) 2020-10-27 09:37:42 -07:00
Bogdan
cb3f649a7f chore: simplify alerting data model to leverage a single class (#11179) 
* Collapse alerting models into a single one

Fixing upgrade migration & tests

* Address feedback

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-10-09 19:20:12 -07:00
Kasia Kucharczyk
89bf76553e Updated lint in schedules.py in tasks: unused_import, ungrouped_import and changed argument name to remove unused-argument (#11045) 2020-09-29 08:10:46 -07:00
Bogdan
b2fdf12f62 Support jinja templates (#11008) 
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-09-24 10:29:44 -07:00
Bogdan
56d001835e fix: use nullpool even for user lookup in the celery (#10938) 
* Use nullpool even for user lookup in the celery

* Address feedback

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-09-21 10:34:03 -07:00
Bogdan
801fb4063c Allow empty observations in alerting (#10939) 
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-09-21 08:48:02 -07:00
Bogdan
c3f1720456 fix: superset alerting misc fixes (#10891) 
* Superset alerting misc fixes

* Test 0 threshold

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-09-16 11:09:11 -07:00
Bogdan
ac2937a6c5 fix: use nullpool in the celery workers (#10819) 
* Use nullpool in the celery workers

* Address comments

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
 2020-09-10 13:29:57 -07:00
Lily Kuang
8a3ac70c06 feat(databases): test connection api (#10723) 
* test connection api on databases

* update test connection tests

* update database api test and open api description

* moved test connection to commands

* update error message

* fix isort

* fix mypy

* fix black

* fix mypy pre commit
 2020-09-09 13:37:48 -07:00
Jason Davis
54ae3b044f fix: add validator information to email/slack alerts (#10762) 
* added validator info to alerts

* adjusted format of messages

* added nits

Co-authored-by: Jason Davis <@dropbox.com>
 2020-09-03 08:15:05 -07:00
Jason Davis
b59f6b1833 feat: refractored SQL-based alerting framework (#10605) 
* added new tables for alerting refractor

* reformatted inheritance structure

* added workflow for updated framework

* added suggested changes

* cleaned up changes

* added obervations to alert table to enable view

* added comments

* added requested changes

* fix tests

* added styling changes

* mypy

* added requested changes

* updated operator logic

* requested changes, 1 validator, styling changes

* refactored tests

* fix test alert workflow

* fixed create_alert in test

Co-authored-by: Jason Davis <@dropbox.com>
 2020-09-01 13:36:02 -07:00
John Bodley
8581bda2f1 chore: Fix indentation issue (#10690) 2020-08-26 20:09:09 -07:00
Maxime Beauchemin
82dda473b1 fix: dedup groupby in viz.py while preserving order (#10633) 2020-08-21 08:02:02 +03:00
Grace Guo
ca9ca99510 refactor: [migration] convert iframe chart into dashboard markdown component (#10590) 
* refactor: [migration] convert iframe chart into dashboard markdown component

* remove 3 viz_types

* fix comments
 2020-08-16 14:43:30 -07:00
Daniel Vaz Gaspar
4dd1d1df5e fix(thumbnails): missing field, logging and new config var (#10562) 
* fix(thumbnails): missing field, logging and new config var

* deprecate EMAIL_REPORTS_WEBDRIVER

* fix after merge and conflicts

* fix tests

* black
 2020-08-14 14:12:44 +01:00
Daniel Vaz Gaspar
11da6ee812 fix: dataset delete and perm delete (#10578) 2020-08-13 10:18:13 +01:00
Erik Ritter
bd88e12b8b feat: add extra column to tables and sql_metrics (#10592) 2020-08-12 15:27:29 -07:00
Craig Rueda
2aaa4d92d9 chore: Migrating reports to AuthWebdriverProxy (#10567) 
* Migrating reports to AuthWebdriverProxy

* Extracting out webdriver proxy / Adding thumbnail tests to CI

* Adding license

* Adding license again

* Empty commit

* Adding thumbnail tests to CI

* Switching thumbnail test to Postgres

* Linting

* Adding mypy:ignore / removing thumbnail tests from CI

* Putting ignore statement back

* Updating docs

* First cut at authprovider

* First cut at authprovider mostly working - still needs more tests

* Auth provider tests added

* Linting

* Linting again...

* Linting again...

* Busting CI cache

* Reverting workflow change

* Fixing dataclasses

* Reverting back to master

* linting?

* Reverting installation.rst

* Reverting package-lock.json

* Addressing feedback

* Blacking

* Lazy logging strings

* UPDATING.md note
 2020-08-12 13:28:41 -07:00
Jason Davis
c0bb86d0d6 feat: slack integration for SQL-based alerts (#10566) 
* add slack functionality

* deleted unused variable

* updated test

* black

* fix rebase

* added nits

* added slack no screenshot integration

* isort

* added namedtuple for screenshot

* added test

* fix precommit

Co-authored-by: Jason Davis <@dropbox.com>
 2020-08-11 11:15:31 -07:00
Bogdan
101e5b670b chore: clean up csv tests (#10556) 
* Clean up csv tests

* Update tests/base_tests.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update tests/base_tests.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* import optional

* Fix mypy error

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
 2020-08-10 11:22:38 -07:00
Jason Davis
8b9292ed05 fix: add retry to SQL-based alerting celery task (#10542) 
* added retry and minimized sqlalchemy object lives

* pylint

* added try catch

* adjusted naming

* added scoped session

* update tests for dbsession

* added requested changes

* nit todo

Co-authored-by: Jason Davis <@dropbox.com>
 2020-08-10 10:20:43 -07:00
Erik Ritter
fd2d1c58c5 Revert "chore: Cleanup database sessions (#10427)" (#10537) 
This reverts commit 7645fc85c3.
 2020-08-06 15:33:48 -07:00
Jason Davis
0d91b3ee6e fix: make SQL-based alert email links user friendly (#10519) 
* make urls user friendly

* formatting

Co-authored-by: Jason Davis <@dropbox.com>
 2020-08-04 15:45:38 -07:00
Jason Davis
aa479fb002 feat: updated email format for SQL-based email alerts (#10512) 
* added sql statement and link to chart in alert email

* pylint

* updated email to include link to alert

* style changes

* pylint

* added todo and fixed formatting of email

Co-authored-by: Jason Davis <@dropbox.com>
 2020-08-04 13:20:02 -07:00
Jason Davis
9c5b0e1c86 fix: refactored SQL-based alerts to not pass sqlalchemy objects as args (#10506) 
* refractored alerting to not pass sqlalchemy obj as args

* updated to pass only alert id as arg

* used object id instead of argument

* updated alerts_tests.py to reflect change

Co-authored-by: Jason Davis <@dropbox.com>
 2020-08-04 09:52:32 -07:00
John Bodley
7645fc85c3 chore: Cleanup database sessions (#10427) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2020-07-30 23:07:56 -07:00