Commit Graph

395 Commits

Author SHA1 Message Date
Lyndsi Kay Williams
6b20e74442 fix: Create dataset polish/bug fix (#22262) 2022-12-20 11:05:40 -05:00
Antonio Rivero Martinez
96de314c0c fix(sqllab): Fix autocomplete for SQL Lab (#22329) 2022-12-05 13:15:27 -07:00
AAfghahi
5e1b8170ca fix: add columns back into SQL Lab to Explore Flow (#22320) 2022-12-05 12:17:31 -07:00
EugeneTorap
f3bf3ec2ed chore: Remove actions prop and refactor code in SQL Lab (#22231) 2022-12-05 12:12:52 +01:00
Corbin Robb
83d990db4f test(sqllab): Convert tests to RTL for SqlEditor (#22093) 2022-11-17 13:10:13 -05:00
EugeneTorap
d76f305343 chore: Use queryEditorId in SqlEditor child components (#21650) 2022-11-16 08:06:20 -05:00
JUST.in DO IT
4f2e264b3f chore(sqllab): Change icon color for running sql (#22050) 2022-11-15 12:33:53 -08:00
JUST.in DO IT
c3f1873c43 fix(sqllab): Add templateParams on kv store (#22013) 2022-11-14 10:46:21 -08:00
Daniel Vaz Gaspar
7c6fabb033 chore: deprecate /superset/fetch_datasource_metadata mig to API v1 (#22102) 2022-11-14 08:51:26 +00:00
Phillip Kelley-Dotson
d3f930a557 fix: add form data for empty state control to save dataset (#21944) 2022-10-28 11:43:42 -07:00
JUST.in DO IT
fb8231b50c fix(sqllab): wiped out unsaved changes by delayed actions (#21877) 2022-10-27 13:20:34 -07:00
JUST.in DO IT
40024064ae fix: BIGINT rendering regression in chartAction (#21937) 2022-10-26 15:04:20 -07:00
JUST.in DO IT
792820ef48 fix(sqllab): remove set state on component update lifecycle (#21771) 2022-10-24 10:50:30 -07:00
Phillip Kelley-Dotson
88e98d576c fix(sqllab): fix control x to stop query (#21899) 2022-10-24 12:51:22 -04:00
Lyndsi Kay Williams
fcb98003a3 fix(sqllab): Fix spacing on Schedule option in SqlEditor dropdown (#21832) 2022-10-17 14:54:45 -05:00
Lyndsi Kay Williams
d21e1d799d fix(sqllab): Async queries are now fetched properly (#21698)
Co-authored-by: hughhhh <hughmil3s@gmail.com>
2022-10-11 12:21:37 -05:00
JUST.in DO IT
0c461497ff chore(sqllab): refactor addQueryEditor for new tab (#21711) 2022-10-07 17:57:39 -03:00
Mayur
61319fd759 feat(sqllab): save query parameters in database (#21682) 2022-10-07 12:49:14 +05:30
Geido
de444d4de6 fix: Race conditions with setupExtensions (#21647) 2022-10-05 12:38:51 +03:00
JUST.in DO IT
50cb396bf2 fix(sqllab): async query broken due to #21320 (#21667) 2022-10-05 15:23:40 +08:00
Evan Rusackas
4245bc3f38 chore(style): Enforce optional chaining (#21614) 2022-10-03 09:17:20 -06:00
JUST.in DO IT
8d1b7ecfde fix(sqllab): perf regression on #21532 refactor (#21632) 2022-10-03 11:00:53 +08:00
Antonio Rivero Martinez
71bf267307 fix(sqllab): SqlEditorLeftBar listening to database changes (#21628) 2022-09-28 19:22:09 -04:00
EugeneTorap
15c3c34268 chore: refactor AceEditorWrapper to functional component (#21532) 2022-09-27 18:04:34 -06:00
EugeneTorap
cbadb8773f fix: Reset dataset name after saving a new dataset in SQL Lab (#21529) 2022-09-21 22:56:45 +02:00
EugeneTorap
2224ebecfe chore: refactor SqlEditor to functional component (#21320) 2022-09-20 08:41:14 -05:00
Michael S. Molina
7c3fc67315 refactor: Moves the DeprecatedSelect to its own folder (#21445) 2022-09-16 08:23:28 -03:00
MichaelHintz
3098e657e5 fix(sqllab): Fix cursor alignment in SQL lab editor by avoiding Lucida Console font on Windows (#21380) 2022-09-13 13:03:21 -07:00
John Bodley
eac6fdcd29 chore(sqllab): Cleanup /tables/... endpoint (#21284) 2022-09-13 08:22:12 -07:00
Lyndsi Kay Williams
0601b2db99 test: Fix act errors in SqlEditorLeftBar test (#21363) 2022-09-08 07:49:47 -03:00
Lyndsi Kay Williams
3fd0ba7b04 test: Fix act errors in SaveDatasetActionButton test (#21362) 2022-09-08 07:43:16 -03:00
JUST.in DO IT
acd9515353 fix(sqllab): Copy link doesn't apply the unsaved changes (#21311) 2022-09-06 10:44:36 -07:00
EugeneTorap
f603295678 chore: refactor ResultSet to functional component (#21186) 2022-09-06 16:55:07 +02:00
JUST.in DO IT
2d70ef670e feat(sqllab): Make LeftBar width resizable (#21300) 2022-09-01 21:26:20 -07:00
JUST.in DO IT
222f1e7ea8 fix(sqllab): invalid table metadata request (#21304) 2022-09-01 16:35:19 -07:00
JUST.in DO IT
65a11b6f45 refactor: introduce react-query on api resource hook (#21240) 2022-09-01 13:39:34 -07:00
JUST.in DO IT
5233a9027f chore(sqllab): Remove max-width on side panel (#21280) 2022-08-31 17:23:47 -07:00
AAfghahi
a7fe4850ed fix: dataset exists error in save Dataset modal (#21244)
* dataset exists error

* fixed flashing modal
2022-08-31 16:47:39 -04:00
JUST.in DO IT
034ee1c3c1 fix(sqllab): unable to create new tabs (#21260) 2022-08-30 13:54:42 -07:00
JUST.in DO IT
ad6b98c2b7 fix(sqllab): update persistent queryEditor keys (#21246) 2022-08-30 09:46:31 -07:00
JUST.in DO IT
f77b910e2c perf(sqllab): Rendering perf improvement using immutable state (#20877)
* perf(sqllab): Rendering perf improvement using immutable state

- keep queryEditors immutable during active state
- add unsavedQueryEditor to store all active changes
- refactor each component to subscribe the related unsaved editor state only

* revert ISaveableDatasource type cast

* missing trigger prop

* a default of an empty object and optional operator
2022-08-23 12:17:19 -03:00
Diego Medina
15b9f83150 chore: support trailing slashes in database api (#21123) 2022-08-22 15:15:04 +08:00
Lyndsi Kay Williams
1ffa5670b3 test: Fix async tests in SaveDatasetModal and complete overwrite screen test (#21020)
* initial push

* SaveDatasetModal test fix

* Remove arbitrary async declarations

Co-authored-by: AAfghahi <arash.afghahi@gmail.com>
2022-08-17 22:35:28 -05:00
Eric Briscoe
ab6ec89f68 fix: [sc-54864] Adds safety check to provide near term fix to save query (#21034)
* [sc-54864] Adds safety check to provide near term fix for Queries not saving

There is an error when casting the columns array to String() for saving queries where the objects in the array are missing the toString method.   This is a near term rapid patch to fix workflow in production which will have a follow up to identify root cause.

* fix typo

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Adjusted chekc to be explicit for undefined instead of truthy

This fixes issue caught by unit test where the if statement was using a truthy check where it should be explicitly checking for value of undefined

* Adds new unit test to get 100% coverage for callApi

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2022-08-10 10:33:47 -07:00
Jesse Yang
58245dd7f7 fix(sqllab): result set min-height (#21016) 2022-08-08 20:52:52 -07:00
AAfghahi
846529a500 easy fix (#20999) 2022-08-08 12:31:08 -04:00
Lyndsi Kay Williams
d42cf4e4c9 fix: Columns not passing properly from SQL Lab to Explore (#20975)
* debugging columns

* Clean up code

* Fix test
2022-08-04 14:59:50 -04:00
AAfghahi
eb5369f2a6 fix: No back button in save dataset modal (#20964)
* back button fix

* fixed test
2022-08-03 21:29:11 -04:00
Jesse Yang
ac585821d8 fix(sqllab): tracking url and error alert padding (#20937) 2022-08-02 14:55:41 -07:00
Lyndsi Kay Williams
8a04536f9d feat(SqlLab): Change Save Dataset Button to Split Save Query Button IV (#20852)
* Moving entire split save btn PR

* Addressed review comments

* Remove arbitrary div from ErrorBoundary in Chart

* Added accidentally removed comment

* Fix act errors in SaveQuery tests

* Fix SaveDatasetActionButton test

* SaveDatasetModal test almost working

* SaveDatasetModal tests all passing

* Clean SaveDatasetModal test

* Fix create chart button and SaveDatasetModal text in SQL Lab

* Fix untitled dataset name on SaveDatasetModal in explore

* Fix styling on split save button
2022-08-01 14:36:34 -05:00