Commit Graph

49 Commits

Author SHA1 Message Date
Mehmet Salih Yavuz
bcc61bd933 refactor(Dropdown): Migrate Dropdown to Ant Design 5 (#31972) 2025-02-07 18:38:04 +01:00
Maxime Beauchemin
6eb87e04c0 chore: refactor Alert-related components (#31858) 2025-01-24 08:39:09 -08:00
Ville Brofeldt
7482b20f7b chore: replace selenium user with fixed user (#31844) 2025-01-22 12:46:06 -08:00
Đỗ Trọng Hải
b74da7963b chore(fe): migrate 6 Enzyme-based unit tests to RTL (#31819)
Signed-off-by: hainenber <dotronghai96@gmail.com>
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
2025-01-22 15:13:49 +01:00
Evan Rusackas
4d50d4944f chore(AntD5): touchup on component imports/exports, theming ListViewCard (#29545)
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
2024-11-11 12:35:51 -07:00
Đỗ Trọng Hải
0ca42a8e4d chore: remove React 16.4's obsolete React imports (#28571)
Signed-off-by: hainenber <dotronghai96@gmail.com>
2024-06-05 08:13:24 -03:00
Evan Rusackas
753ef69529 feat(storybook): Co-habitating/Upgrading Storybooks to v7 (dependency madness ensues) (#26907) 2024-02-15 07:40:17 -07:00
Anthony Gainor
7f563cf92d chore: Remove several React app console warnings and errors v2 (#21725)
Co-authored-by: Herbert Gainor <herbert.gainor@preset.io>
2022-10-28 19:08:10 +08:00
Eric Briscoe
6a0b7e5598 feat: Add Chromatic publishing to superset-frontend storybook (#21095)
* Work in progress to add Chromatic publishing to superset-fronted storybook

Adds new Github action to publish storybook builds to chromatic
Adjusts configuration to support MDX story format
Updates Alert stories to take advantage of MDX format for example in storybook that will publish to Chromatic
Fixes issue in ListViewCard stories that make the story build fail

* Adjust Chromatic Github action

* Adjust action so Gtihub Secret is read into env

Github secrets are not accessible in conditional blocks so this change moves the access of the github secret into an env variable which is accessible in conditional logic

* Removes unneccesary projectToken from package json

* Using a temp key to debug no access to value from github secret

* Refining skipping if no changes to superset-frontend

* Remove typos from Action component story, consolidate on folder check in Chromatic action

* Fix error in Chromatic action event

* Testing action with pul_request_target

* adjustments to Chromatic action triggers

* lint fix

* Testing if pull_request_target is disabled

* More adjustments to Chromatic action

* UI Change to trigger action

* Change to story text to test action

* update package-lock after merge conflicts from master

* Changes to test chromatic action

* Finalize Chromatic actions, fix lint errors

* Backs out addition of @storybook/addon-docs which is included in addon-essentials

* Lint error in package.json
2022-08-23 16:16:28 -04:00
Moriah Kreeger
83dd85166f feat: add extension point for workspace home page (#21033)
* updates to allow insertion of workspace home sidescroll/table UI

* fix types

* fix User type import

* add welcome message to ui registry

* add extra fields to individual chart/query GET results (for workspace home required info)

* update list view card to support a subtitle

* add id to individual chart fetch

* update chart api test

* another test fix

* fix saved query test

* update extension types + insert point

* fix typing

* fix type name
2022-08-15 12:16:40 -07:00
Michael S. Molina
8bb8b7f612 chore: Removes hard-coded colors - iteration 3 (#20016) 2022-05-11 15:02:13 -03:00
dudasaron
b8891acf4a fix(dashboard list): do not show favorite star for anonymous users #18210 (#19409)
* fix: Only show favorite star on dashboard list if user is logged in #18210

* Fix linter errors
2022-04-04 10:38:44 +03:00
Michael S. Molina
329855170e refactor: Deletes the common/components folder (#18999) 2022-03-04 14:19:14 -03:00
Michael S. Molina
fd4bd1edbc chore: Moves components out of the commons folder (#18931)
* refactor: Moves components out of the commons folder

* Fixes tests
2022-02-25 10:17:32 -03:00
Adam Dobrawy
7c69a1bc60 chore: improve React import reference consistency (#18608) 2022-02-10 21:03:16 -08:00
Geido
4b969710e4 Rename CertifiedIcon to CertifiedBadge (#17715) 2021-12-10 11:45:53 -07:00
Geido
83e49fc9ee feat: Certify Charts and Dashboards (#17335)
* Certify charts

* Format

* Certify dashboards

* Format

* Refactor card certification

* Clear details when certified by empty

* Show certification in detail page

* Add RTL tests

* Test charts api

* Enhance integration tests

* Lint

* Fix dashboards count

* Format

* Handle empty value

* Handle empty slice

* Downgrade migration

* Indent

* Use alter

* Fix revision

* Fix revision
2021-11-24 13:42:52 +02:00
Michael S. Molina
99d15b25b0 chore: Moves the images folder to the assets folder (#14429)
* chore: Moves the images folder to the assets folder

* Rebases
2021-09-22 10:28:51 -03:00
Phillip Kelley-Dotson
5fd798afb7 chore: change dropdown icons from horizontal to vertical (#15958)
* change icons

* add size

* fix storybook

* fix favstar, add new icons, and others

* fix lint
2021-07-30 17:02:40 -06:00
Phillip Kelley-Dotson
02f9749d18 feat(homepage): add more cards and new layout (#15853)
* testing out

* use %

* test

* more changes for testing

* add styles

* initial test commit

* remove ff

* default to false

* fix bug

* fix lint

* fix test

* ensure thumbnails if ff is true

* add back examples and fix layout

* fixes

* new layout

* add suggestions

* changes descriptions

* add changes

* Update superset-frontend/src/components/ListViewCard/index.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* add const for req

* Update superset-frontend/src/views/CRUD/utils.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* fix grid-gap

* fix padding

* fix cards in listviews

* address comments

* removing fractional pixel

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-07-29 11:57:00 -07:00
Geido
625468c56a Fix style (#15662) 2021-07-15 15:26:00 -07:00
Phillip Kelley-Dotson
79d3d06c8a refactor: icon to icons for homepage and card compompents (#15624)
* initial commit

* add listviewcard

* remove plural
2021-07-12 10:23:45 -07:00
gordern
b20293d1b1 fix: click card view link to 404 page when card rendering(#15526) 2021-07-05 13:55:41 +08:00
Jesse Yang
23014e9233 chore: upgrade @emotion (#14454) 2021-05-04 15:26:16 -07:00
David Aaron Suddjian
21cf12a480 chore(dashboard): Integrate dashboard app into the SPA bundle (#14356)
* chore(dashboard): Integrate dashboard app into the SPA bundle

* fix url params

* change variable name

* change title correctly

* custom css

* lint

* remove unused file

* remove content assertions from dashboard tests

* fix case with missing bootstrap data

* fix: respect crud views flag

* crud views -> spa

* remove unused dashboard templates

* fix: remove unused variable

* fix: missed a spot with the crudViews -> spa

* router link to dashboard from dashboard list page

* link using the router when in card mode

* lint

* fix tests, add memory router

* remove  dashboard app files

* split up the bundle a little more

* use webpack preload
2021-05-04 08:51:17 -07:00
Michael S. Molina
8441590812 chore: Moves Tooltip to the components folder (#14137) 2021-04-20 08:47:47 -07:00
Bruno Motta
95ed8735f1 chore: well component to card component(Updating PR #12200) (#14033)
* replace Well componenet with Card component

* Fix lint errors

* Fix lint

* Addressing comments

* Addressing comments

* Fix lint errors

* Exporting Card from index.tsx and adding storybook variants

* Fix some refactoring

* Fix errors

* solving conflicts and lint errors

* Update superset-frontend/src/common/components/Card.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/Card.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Nikola Gigic <nik.gigic@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 15:06:44 -07:00
Geido
8ab45c90cc refactor: New Icon system with Enhanced Antd Custom Icon (#12229)
* Enhance custom icon

* Minor fix

* Move DashboardList icon trash icon to enhanced

* Enhance trash icon on lists

* Enhance actions icons card view

* Add storybook entry for custom icons

* Test delete button

* Remove commented line

* Fix linting issue

* Enhance Antd icons

* Enhance existing icons up to BoltSmallRunIcon

* Remove unused import

* Import/Exports all icons from index

* Export all existing icons

* Implement more enhanced icons

* Add data-id on edit buttons

* Fix lint issue

* Inherit color

* Apply original color to actions

* Fix linting issue

* Fix typo

* Change ModeHoriz to MoreHoriz
2021-02-24 19:36:40 -08:00
Daniel Vaz Gaspar
3e0681b438 fix: UI toast typo (#13026)
* fix: UI toast typo

* translate

* fix error msg
2021-02-10 08:17:54 +00:00
Jesse Yang
9acf48fd1e chore: upgrade eslint, babel, and prettier (#12393) 2021-01-10 17:26:35 -08:00
Phillip Kelley-Dotson
0e9898cb96 feat(welcome): add SQL snippets to saved queries card (#11678)
* update savedqueries card to new layout

* update card

* update card to latest mock

* update empty state

* remove fallback

* fix query statement

* update card styles

* remove double import

* use fallbackurl prop for emptystate

* update line lenth

* Update superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* update styles and svg

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-11-30 11:53:12 -08:00
Erik Ritter
e4d02881d2 chore: unbreak frontend ci (#11806) 2020-11-24 21:43:02 -08:00
Phillip Kelley-Dotson
d364d0354c add tool tip to cards (#11791) 2020-11-24 10:20:27 -08:00
Evan Rusackas
86651cd451 fix: default dashboard/chart cards are vector with perfect corners (#11684)
* fix: default dashboard/chart cards are vector with perfect corners

* fix: adding licenses
2020-11-16 09:26:07 -08:00
Evan Rusackas
73cc938358 style: various little tweaks to home screen stylin' (#11650)
* adding bottom padding

* making light gray backgrounds match

* vertical centering of empty state content.

* linting 

* fixing card radii

* fixing corner radius... thumb was covering corner border.
2020-11-10 17:20:31 -08:00
Evan Rusackas
3b89d2307a fix: card thumbnails now always show border. (#11638)
Co-Authored-By: Evan Rusackas <evan@preset.io>
2020-11-10 08:58:39 -08:00
Phillip Kelley-Dotson
d8373f2bb9 chore(home-screen): fixes for loading states, flicker issue, and reduction of api calls (#11557)
* fixes for loading states, flicker issue, api calls

* fix filter bug

* add high res images

* bug fixes for cards and face pile, change imgs to svgs, and address comments

* update from comments

* add stopprop

* fix tests

* add liscenses

* remove unused type

* fix types

* add license

* fix lint
2020-11-06 19:35:13 -08:00
ʈᵃᵢ
edb9619731 refactor: reduce number of api calls needed to fetch favorite status for charts and dashboards (#11502) 2020-11-02 21:26:14 -08:00
Phillip Kelley-Dotson
f7051eaade feat: home screen mvp (#11206)
* step 1: broken stuff!

* first steps

* more adding and slicing

* step 1: broken stuff!

* can now filter dashboards/charts for "Edited" tabs (filter by changed_by o_m)

* more updates

* update recent card

* add icon

* Adding Expand Icon to Collapse component

* more updates

* clean up code

* remove lock file

* remove consoles

* fixing subnav button height shift

* lil' ascii arrows

* update branch

* update test part 1

* remove consoles

* fix typescript

* add images and update emptystate

* add changes

* update chart card

* fix css issues from rebase

* add suggestions

* more changes

* update tests and clear typescript errors

* Update superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* update from comments

* more updates..

* fix rebase

* fix pesky type errors

* test fixes

* lint fix

* Update superset-frontend/spec/javascripts/views/CRUD/welcome/Welcome_spec.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/views/CRUD/welcome/EmptyState.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/components/Menu/SubMenu.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/components/ListViewCard/index.tsx

Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>

* Update superset-frontend/src/components/ListViewCard/index.tsx

Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>

* add suggestions

* fix lint

* remove unused code

* toast getrecentActivityobjs

* add some suggestions

* remove types for now

* cypress fix

* remove unused type

Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>
2020-10-29 21:59:31 -07:00
adam-stasiak-polidea
fc03549299 chore: Added data-test attributes for testing (#11254)
* Added data-test attributes for testing

* fixed incorrect naming change

* review changes
2020-10-14 16:12:01 -07:00
ʈᵃᵢ
7b0dabd7aa style(listview): various changes to get closer to SIP-34 designs (#11101) 2020-10-09 13:06:26 -07:00
ʈᵃᵢ
017e5acd14 style(listview): dynamic card size and grid spacing (#11111) 2020-10-01 15:44:42 -07:00
Evan Rusackas
eeeb21077d feat: adding all icons from the design system to the codebase (#11033)
* error -> error-solid

* warning -> warning-solid

* all the new icons mixed in!

* card-view -> card_view

* circle-check-solid -> circle_check_solid

* corrected circle-check to new name and correct (stroke) icon

* sort-asc/desc -> sort_asc/desc

* databases -> database

* compass -> nav_explore

* pencil -> edit-alt

* more pencil migrations

* easy list view rename

* star -> favorite (changed in Figma)

* removing deprecated icon

* renaming icon to mach figma

* More -> More Horiz

* forgot to change this when ranming the file

* updating some icon names in use

* adding hella icons

* fixing errant viewboxes

* removing dropdown-arrow in favor of triangle-down

* adding key to storybook map.

* fixing icon component reference

* tweaks to fave star styling to support revised icon

* fixing a bad icon inclusion

* missed a license

* touchup to virtual dataset... will tweak later.

* e2e fix

* linting
2020-09-25 14:49:30 -07:00
Kamil Gabryjelski
7f1012360a Re-enable no-useless-path-segments rule (#10860) 2020-09-14 10:38:18 -07:00
Jesse Yang
9a59bdda48 refactor: merge/upgrade superset-ui packages (#10790)
* refactor: merge/upgrade superset-ui packages

* Fix flaky big number test

* Fix Flaky AdhocFilters test
2020-09-09 13:18:55 -07:00
Evan Rusackas
fdfb7cdfd2 Eslint error cleanup (#10657)
* moving two console errors to logger errors

* nixing unused map index

* nixing unused param

* linting

* changing an alert to a toast

* fixing tests

* lint fix

* one letter change, just to see if iti gets CI to pass this test.
2020-08-24 14:04:27 -07:00
ʈᵃᵢ
b86c0e5727 feat(listview): skeleton loading states for table and card collections (#10606) 2020-08-21 10:32:37 -07:00
Lily Kuang
a3ac5061fe feat: card view bulk select (#10607) 2020-08-18 18:04:36 -07:00
ʈᵃᵢ
db88cec431 feat: SIP-34 card/grid views for dashboards and charts (#10526) 2020-08-13 14:46:56 -07:00