* remove ENABLE_REACT_CRUD_VIEWS feature flag
* docs
* deal with problematic tests
* empty test suite
* skip test
* test conditions changed
* removing the tests instead of skipping
* Empty states updated on result tab and query history tab
* Testing on query history blank state
* Testing on result tab with empty state
* Forgot to remove a comment
* Corrected empty state image size and centered with drag bar
* Centered blank states vertically
* Added in code changes that now properly increment the Untitled Query SQL Lab tab names. All that is left is to add tests to make sure that the function works correctly
* Updated the code so that it adds to the untitled_query_numbers variable only if the character after the string 'Untitled Query ' is a number. This prevents any issues when trying to get the maximum value in the list.
* Refactored part of the mapping code, to make it shorter and easier to read/understand
* Fixed issues in the code that were causing some of the CI tests to fail
* Made code changes based on comments within the PR. Also added a unit test to make sure that the newQueryEditor function in the TabbedSqlEditors component works as intended
* Fixed the failing cypress test in tabs.test.js
* converted file to functional component
* refactor: convert class component to functional component
* refactor: convert class component to functional"
* Working on converting the shouldCheckForQueries test to RTL
* Working on converting first test to RTL
* Working on first test for queryAutoRefresh
* Finished Tests, pushing for review
* Cleaned up comments and console logs
Co-authored-by: Josue Lugaro <josuelugaro15@gmail.com>
* Empty SQL table message on zero tabs
* sql editor no editor tab bug fix
* Revert Error message
* empty state tab state
* added a unit test
* addressed reviews
* kasia feedback
Co-authored-by: Yahya Kayani <yahyakiani1@gmail.com>
* fix(15849): Removed the tooltip from CopyToClipboard button in sqllab
* chore(sqllab): added props for tooltip in CopyToClipboard component
* fix(sqllab): Added arg to storybook and refactor the component
* fix(sqllab): added a test case for hideTooltip
* chore: fix misspelling of button
* changed QuerySearch/index.jsx to index.tsx
* updated Query type at src/SqlLab/types.ts/Query and extended it into QueryTable
* updated defaultQueryLimit to be optional at ResultSetProps of superset-frontend/src/SqlLab/components/ResultSet/index.tsx
* moved statusAttributes into useMemo hook so that it will not make the dependencies of useMemo Hook change on every render and statusAttributes is only used within useMomo hook
* reset package-lock.json and package.json at frontend
* Acquired redux rootestate type for SqlLab, to be used at useSelector(state)
* updated query to be Query type and added a comment for q.status on line 178
* updated queryTable for typescript conversion
* updated actions type on QueryHistory and QuerySearch
* updated type for actions in SouthPane
* created type for SqlLab redux
Co-authored-by: David Woolner <davidwoolner@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* chore: fix misspelling of button
* Feat: Update ExploreCtasResultsButton to functional component
* Fix pull request
* Fix index.tsx
* Fix prettier issues and actions
* Streamline the onClick so it calls visualize directly
* Update MSP and MDP to arrow functions
* Test destructured props
* Fix props destructuring error
* Simplify with optional chaining on line 94 and clean up buildVizOptions
Co-authored-by: David Woolner <davidwoolner@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* Creating draft PR to address bug
* Still working on solving re rendering bug
* Cleaning up in preparation for push
* Starting conversion to TypeScript
* Working on conversion
* Continued working on typescript conversion, referenced other files for different types, still a rough version of final product
* Added type assertion to actions in props, and added types to some component functions
* Progress on typescript conversion
* Fixed typing issue on collapseStyles
* Fixed styling on div, child of StyledScrollbarContainer
* Attempting to address issues with the actions passed into the TableElement
* Resolved typescript warning on actions of the TableElement component
* Made changes suggested by Arash
* Tested the component without dbId, cleaned up lingering comments
* Made more changes suggested by Arash, removed offline from the SqlEditorLeftBarProps interface
* Made change suggested by Hugh
* Changed the expanded type from any to boolean
* Working on converting sqleditorleftbar to functional component
* Creating draft PR to address bug
* Still working on solving re rendering bug
* infinite rerender fix
* Creating draft PR to address bug
* Cleaning up in preparation for push
* Made changes suggested by Elizabeth
* Fixed issues as per Lindsey's comment
Co-authored-by: Arash <arash.afghahi@gmail.com>
* migrate EstimateQueryCostButton component from jsx to tsx
* re-format spaces using prettier
* Update superset-frontend/src/SqlLab/components/EstimateQueryCostButton/index.tsx
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
* remove extra onClick and make disabled prop optional
* restore & rename event handler onClick to onClickHandler
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
* Add conditional to table name tooltip to only show when overflowing
* Remove uneccessary state and useEffect, a little clean up and slight refactoring
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
* fix: feature flags typing
* fix tests
* add note in UPDATING.md
* fix frontend
* also move SCHEDULED_QUERIES to top level
* fix test
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
* add database id back
* add condition to verify dataset is being changed
* Update superset/datasets/dao.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor
* putting the background back in, but using the theme.
* should be no need for this import anymore.
