QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 07:35:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
12,685 Commits 448 Branches 542 Tags
b55ef5b514b4db93e2e275e67de2fed270436e84
Commit Graph

69 Commits

Author SHA1 Message Date
EugeneTorap
394fb2f2d0 fix: slug is empty if filename is non-ASCII (#22118) 2022-11-16 10:53:30 -08:00
Hugh A. Miles II
e23efefc46 feat: refactor all get_sqla_engine to use contextmanager in codebase (#21943) 2022-11-15 13:45:14 -05:00
Antonio Rivero Martinez
203b289021 feat(bigquery): Custom message when Service Account doesnt have the correct Roles and Permissions (#21838) 2022-10-26 19:44:09 -04:00
Elizabeth Thompson
e98943e580 refactor: pass all properties to validate_parameters (#21487) 2022-10-03 17:48:54 -07:00
Beto Dealmeida
34a79add04 feat: filter parameters from DB API (#21248) 2022-09-02 11:50:04 -07:00
Daniel Vaz Gaspar
3f2e894af3 fix: dataset name change and permission change (#21161) 
* fix: dataset name change and permission change
 2022-08-31 18:11:03 +01:00
Beto Dealmeida
8772e2cdb3 fix: improve get_db_engine_spec_for_backend (#21171) 
* fix: improve get_db_engine_spec_for_backend

* Fix tests

* Fix docs

* fix lint

* fix fallback

* Fix engine validation

* Fix test
 2022-08-29 11:42:42 -07:00
Daniel Vaz Gaspar
bfd2a3d79f fix: database permissions on update and delete (avoid orphaned perms) (#20081) 
* fix: database permissions on update and delete (avoid orphaned perms)

* fix event transaction

* fix test

* fix lint

* update datasource access permissions

* add tests

* fix import

* fix tests

* update slice and dataset perms also

* fix lint

* fix tests

* fix lint

* fix lint

* add test for edge case, small refactor

* add test for edge case, small refactor

* improve code

* fix lint
 2022-08-02 18:28:46 +01:00
John Bodley
f0ca158989 fix: Refactor ownership checks and ensure consistency (#20499) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2022-07-07 11:04:27 -07:00
Phillip Kelley-Dotson
5111011de9 fix: dbmodal test connection error timeout (#20068) 
* fix: check for connect on ping

* clean up merge

* fix merge

* precommit
 2022-05-17 10:04:52 -07:00
John Bodley
449d08b25e fix: Refactor SQL username logic (#19914) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2022-05-12 21:03:05 -07:00
Daniel Vaz Gaspar
87a4379d0a feat: deprecate /superset/validate_sql_json migrate to api v1 (#19935) 
* feat: deprecate /superset/validate_sql_json migrate to api v1

* use new error handling

* migrate SQLLAb frontend and add tests

* debug test

* debug test

* fix frontend test on sqllab

* fix tests

* fix frontend test on sqllab

* fix tests

* fix tests

* fix tests

* fix tests
 2022-05-10 21:25:39 +01:00
Craig Rueda
f64d654de3 chore(database): Creating helper make_url_safe to wrap potential errors (#19526) 
* Creating helper make_url_safe to wrap potential errors

* Fixing imports

* Fixing imports again

* Adding comment

* Linting

* Fixing test

* Fixing test again...

* Fixing import
 2022-04-05 11:17:30 -07:00
Ville Brofeldt
a619cb4ea9 chore: upgrade black (#19410) 2022-03-29 20:03:09 +03:00
Richard Whaling
202e34a259 feat: add duckdb as DataSource - Fixes #14563 (#19317) 
* + duckdb support

needs the forked version of [duckdb-engine](https://github.com/alitrack/duckdb_engine)

* Update duckdb.py

update  _time_grain_expressions

* removed superfluous get_all_datasource_names def in duckdb engine spec

* added exception handling for duckdb single-threaded RuntimeError

* fixed linter blips and other stylistic cleanup in duckdb.py

* one last round of linter tweaks in test_connection.py for duckdb support

Co-authored-by: Steven Lee <admin@alitrack.com>
Co-authored-by: Richard Whaling <richardwhaling@Richards-MacBook-Pro.local>
 2022-03-24 15:07:57 +08:00
Beto Dealmeida
d01fdad1d8 feat: add export_related flag (#19215) 
* feat: add export_related flag

* Fix lint
 2022-03-16 16:03:06 -07:00
Elizabeth Thompson
c143b37128 chore: log multiple errors (#14064) 
* log all errors from db create

* return unique set of errors

* sort set for exceptions list

* run black
 2022-03-08 17:31:19 -08:00
Beto Dealmeida
51090c3f1b feat: shorter timeout on test_connection (#18001) 
* feat: shorter timeout on test_connection

* pip-compile-multi --no-upgrade

* Fix for SQLite

* Return 408

* Add test
 2022-01-12 13:01:34 -08:00
Ville Brofeldt
5d1c9078ad chore(translations): fix translation literals (#17501) 
* chore(translations): fix translation literals

* fix table name types and translations

* fix lint

* join concat'd messages
 2021-11-23 10:06:09 +02:00
Beto Dealmeida
cb34a22684 fix: import should accept old keys (#17330) 
* fix: import should accept old keys

* Fix lint

* Preserve V1 schema
 2021-11-03 11:25:30 -07:00
Shiva Raisinghani
ef3afbde82 refactor: Repeated boilerplate code between upload to database forms (#16756) 
* abstract boilerplate code into class and rename csv to file

* add db migration

* fix some stuff

* more renaming of csv to file

* rename in translations

* update down revision

* update down revision

* bump chart version

* switch to alter column name approach in db migration

* fix db migration for MySQL

* db migration conflict
 2021-10-25 13:53:06 +03:00
AAfghahi
376c685838 feat: adding logging to validation (#16527) 
* adding logging to validation

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-09-13 16:09:40 -07:00
Ville Brofeldt
ac1d779a30 chore(ci): bump pylint to 2.10.2 (#16463) 2021-08-26 20:30:41 +03:00
John Bodley
7e4c940314 chore(pylint): Enable useless-suppression check (#16388) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-08-24 03:58:41 +12:00
John Bodley
be7065faf8 chore(pylint): Reenable raise-missing-from check (#16266) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-08-17 10:26:10 +12:00
Beto Dealmeida
7b15b7690d fix: DB exported with incorrect type (#16037) 
* fix: DB exported with incorrect type

* Fix export as well
 2021-08-03 08:35:48 -07:00
Hugh A. Miles II
bfe7eb9a7b feat(dbc ui): Adding Google Sheets Dynamic Form (#15801) 
* feat: Make Google Sheets Dyanmic (#15576)

* first draft

* second draft

* added tests

* first draft

* added table_catalog

* remove console.log

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* revisions

* save this for now

* working form

* save disable on public sheets

* refactor somethings

* saving this for now

* working edit

* add back query to schema

* working add

* fix styling

* fixing x

* fix linting

* prettier

* fix some type issues

* more lint fixes

* remove unused dependency

* fix linint

* fix validation

* pylint bypass

* pylint bypass

* fix this

* fix mypy

* yerp

* fix test

* fix test

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* wrap add sheets

* fix linting issues

* fix unit test

* ignore typing

* fix editting and paste issues

* remove query

* fix this

* fix test

* add test back

* fix error messaging

* update url messaging on error

* change error type

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* add errors for sheets with no name

* fix

* fix messaging for gsheets

* stop pylint

* update line

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: Arash <arash.afghahi@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-07-28 15:00:27 -04:00
John Bodley
ab4e3b9bf9 chore: Enforce Mypy for non-tests (#15757) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-07-22 06:46:43 +12:00
Hugh A. Miles II
d4480f5c9a feat: Database Connection UI (#14881) 2021-07-01 14:40:27 -07:00
Hugh A. Miles II
143a1b0650 fix: Test connection before starting on create transaction (#15100) 
* test connection before starting on create transaction

* Update create.py
 2021-06-14 12:44:27 -04:00
Maxime Beauchemin
7d5bc2438a chore: rename 'tables' to 'datasets' in error message (#15078) 2021-06-10 17:56:26 -06:00
Elizabeth Thompson
8cc97e4790 feat: validation db modal (#14832) 
* split db modal file

* hook up available databases

* use new validation component
 2021-06-01 18:18:17 -04:00
Hugh A. Miles II
6d33432b58 feat: Create BigQuery Parameters for DatabaseModal (#14721) 2021-05-23 12:45:48 -04:00
AAfghahi
4f5c537250 feat: Configuration Method and expanded parameters for Database Model (#14451) 
* db migration for dbs

* first draft at logic

* added unit tests

* revisions

* use strings for db values

* lint and revisions to tests

* changed test back

* added revisions for testing

* Update superset/databases/commands/update.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/databases/schemas.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/models/core.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/databases/commands/update.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* got rid of extra imports added new test

* Update superset/databases/schemas.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-05-14 18:19:17 -07:00
Hugh A. Miles II
3a81e6aee8 change name to Basic instead of Base (#14625) 2021-05-13 15:05:37 -04:00
Beto Dealmeida
31f406a526 feat: API endpoint to validate databases using separate parameters (#14420) 
* feat: new endpoint for validating database parameters

* Rebase

* Remove broken tests
 2021-05-12 18:32:10 -07:00
Beto Dealmeida
5d3191bb61 feat: catch errors on do_ping (#14250) 2021-04-21 18:43:40 -04:00
Beto Dealmeida
c7112d1c48 feat: error messages for Presto connections (#14172) 
* chore: rename connection errors

* feat: error messages for Presto connections

* Add unit tests

* Update docs/src/pages/docs/Miscellaneous/issue_codes.mdx

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
 2021-04-16 15:49:47 -04:00
AAfghahi
df04c3af21 feat: error messages when connecting to mssql (#14171) 
* database errors for mssql

* revisions
 2021-04-16 09:43:42 -07:00
Beto Dealmeida
21f973f0bd feat: error messages when connecting to MSSQL (#14093) 
* feat: error messages when connecting to MSSQL

* Address comments
 2021-04-14 10:57:58 -07:00
Beto Dealmeida
c60a93db9c feat: add extract_errors to Postgres (#13997) 
* feat: add extract_errors to Postgres

* Add unit tests

* Fix lint

* Fix unit tests
 2021-04-08 13:24:54 -07:00
Beto Dealmeida
a82d72fef6 feat: initial work to make v1 API compatible with SIP-40 and SIP-41 (#13960) 
* WIP

* Use errorhandler

* Add response schema

* Fix status on HTTPException

* s/found/encountered/g

* Fix test

* Fix lint

* Fix lint and test
 2021-04-06 22:06:32 -07:00
Hugh A. Miles II
9f53c6c5bc chore: add success log whenever a connection is working (#13811) 2021-03-29 13:22:09 -04:00
Beto Dealmeida
db57f90a34 feat: better error message when adding DBs (#13601) 
* WIP

* Adding tests

* Add unit tests

* Show error message

* Fix lint

* Fix after rebase
 2021-03-17 20:29:26 -07:00
Daniel Vaz Gaspar
1e88408418 fix: better handle datasource exceptions (#13578) 
* fix: handle datasource injected security exception

* add tests

* fix error text on create update dbs

* fix lint

* revert create update message

* fix test

* add sqlalchemy exceptions
 2021-03-15 22:46:51 +00:00
Hugh A. Miles II
c91c45574b feat: add event_logger to test_connection and create_database commands (#13468) 
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-03-09 08:17:13 -05:00
Beto Dealmeida
3d23adec5e chore: use shillelagh instead of gsheetsdb (#13185) 
* chore: use shillelagh instead of gsheetsdb

* Fix tests

* Clean up code and remove duplication

* Fix test

* Tighten dep
 2021-02-18 09:48:18 -08:00
Daniel Vaz Gaspar
c685c9ea8f refactor: test connection raises only command exceptions (#12307) 
* refactor: test connection raises only command exceptions

* fix tests

* fix tests

* fix tests

* lint fix
 2021-01-08 13:10:11 +00:00
Beto Dealmeida
e0079bb5ae fix: small fixes to the new import/export (#12064) 2020-12-15 12:24:24 -08:00
Beto Dealmeida
475f59cb1c feat: confirm overwrite when importing (#11982) 
* feat: confirm overwrite when importing

* Skip flaky test
 2020-12-10 14:50:10 -08:00