Since https://github.com/apache/incubator-superset/pull/6287 and
effectively moving to a new version of d3, d3-format and d3-time-format
raises when receiving invalid input strings.
This code wraps the potential issues inside `try` blocks that will
effectively return an `ERROR` string as output to the formatting
function.
* [refactor] Migrate from Mocha+Chai to Jest
This change migrates all the existing unit tests
- to Jest's global expect and matchers from chai's imported expect, asserts and matchers.
- to Jest's describe/test from mocha's describe/it
The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks:
1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank.
2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :)
This change also removes dependencies to Mocha and Chai.
* Remove the test:one command as it now does the same thing as test.
* Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix`
The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest.
* Adding eslint-plugin-jest and further modify tests.
- One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing.
- Deletion of a duplicated test caught by eslint-plugin-jest.
* - Make istanbul coverage work with Jest.
- Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes!
* Attempt to fix dynamic imports in tests.
* run sequentially and log heap usage
* - tweaking maxworkers for travis and specifying coverageDirectory for codecov
- remove dynamic import in shim.js now that it is set in babelrc for tests only.
* remove lodash.throttle from dependency
* add babel-plugin-lodash'
* use lodash instead of underscore for isFunction
* switch underscore to lodash
* switch from underscore to lodash flatten
* Remove slugify and use kebabCase from lodash instead
* move into folder and scaffold adaptor
* extract width and height
* remove jquery
* extract showBrush
* extract lineInterpolation
* extract xAxisFormat and yAxisFormat
* extract annotationData
* extract xTicksLayout and colorScheme
* extract showXXX
* extract x and y axis labels
* extract showminmax
* extract pie chart props
* extract area chart props
* extract logscale and yAxisBounds
* extract margin
* extract bubble props x,y,size
* extract contribution, comparisonType and color_picker
* remove the last fd.xxx
* remove unnecessary variables
* remove slice.container
* fix unit test reference
* Rewrite logic to compute max label lengths to use only d3, not jquery.
* extract annotationLayers and no more slice.xxx in nvd3vis
* rename x, y, size to xField, yField, sizeField
* use arrow function
* move tooltip function
* extract helper functions into utils
* remove unused argument
* fix height calculation and show bar labels
* rename function
* update unit test
* organize tooltip generator
* update line_multi
* Add proptypes for data
* list proptypes for data
* extract tooltip function for bubble chart
* rename variables
* remove console.log
* enumerate vizTypes and pieLabelType
* parse maxBubble
* use new color scale
* fix import"
* remove line
* [formats] add better defaults for time + number formatting
* [formatDate] add tests for concise formatDate
* [nvd3] use verbose time format in tooltips
* [number format] improve number format description
* [formats] revert to .3s defaults, tweak number format preview
* [formats] default number vis to .3s
* Use 'count' as the default metric when available
Count is a much better default than the current behavior which is to use
whatever the first metric in the list happens to be.
* Addressing nits
