Commit Graph

8 Commits

Author SHA1 Message Date
Claude
be1dbac02e test(SaveModal,CopyToClipboard): drop placeholder asserts; add string/number copyNode guard
Two changes in response to review feedback on the FC conversion:

1. Drop three `expect(true).toBe(true)` placeholder tests in
   `SaveModal.test.tsx` (`dispatches removeChartState ... - placeholder`,
   `onDashboardChange triggers tabs load ... - placeholder`,
   `onTabChange correctly updates selectedTab - placeholder`). They were
   left behind from the class-component version and assert nothing —
   net-negative as regression guards. They'll be re-added in a follow-up
   once the FC-shaped versions are wired up.

2. Add a regression test in `CopyToClipboard.test.tsx` that renders the
   component with a string `copyNode` and with a number `copyNode`,
   covering the `cloneElement`-on-non-element crash that prompted the
   `isValidElement` guard in `src/components/CopyToClipboard/index.tsx`.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-12 14:21:27 -07:00
Evan Rusackas
82b224395a chore(lint): convert explore controls, SqlLab, and misc components to function components
Converts explore control components (AnnotationLayer, CheckboxControl,
CollectionControl, DatasourceControl, AdhocFilter*, FixedOrMetricControl,
AdhocMetric*, SelectControl, SpatialControl, TextAreaControl, TextControl,
TimeSeriesColumnControl, ViewportControl, SaveModal), SqlLab (App,
TabbedSqlEditors), Datasource (CollectionTable, DatasourceEditor),
and misc (CopyToClipboard, ErrorBoundary, RightMenu, ChartCreation)
from class to function components.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-12 14:21:24 -07:00
yeaight
7445105735 fix(explore): explain disabled chart overwrite option (#39796) 2026-05-12 12:53:59 -07:00
Richard Fogaca Nienkotter
8c80caefa3 fix(explore): preserve preview chart name on save (#39908) 2026-05-07 13:08:28 -03:00
Kamil Gabryjelski
fc705d94e3 fix(explore): migrate from window.history to React Router history API (#38887) 2026-03-27 16:49:54 +01:00
Enzo Martellucci
bbafae5f62 fix(save-chart): fix info icon alignment in save chart modal (#37708)
Co-authored-by: Diego Pucci <diegopucci.me@gmail.com>
2026-02-26 18:11:07 +01:00
Đỗ Trọng Hải
563d9f1a3f chore(lint): migrate Jest lint rules from eslint to oxlint (#37787)
Signed-off-by: hainenber <dotronghai96@gmail.com>
2026-02-08 16:44:42 +07:00
Evan Rusackas
fc5506e466 chore(frontend): comprehensive TypeScript quality improvements (#37625)
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-06 13:16:57 -08:00