Daniel Vaz Gaspar
bfd2a3d79f
fix: database permissions on update and delete (avoid orphaned perms) ( #20081 )
...
* fix: database permissions on update and delete (avoid orphaned perms)
* fix event transaction
* fix test
* fix lint
* update datasource access permissions
* add tests
* fix import
* fix tests
* update slice and dataset perms also
* fix lint
* fix tests
* fix lint
* fix lint
* add test for edge case, small refactor
* add test for edge case, small refactor
* improve code
* fix lint
2022-08-02 18:28:46 +01:00
John Bodley
f0ca158989
fix: Refactor ownership checks and ensure consistency ( #20499 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2022-07-07 11:04:27 -07:00
Beto Dealmeida
998624b1a5
feat: allow setting db UUID ( #20412 )
...
* WIP
* feat: allow passing UUID when creating a DB
* Test
* Fix field
2022-06-16 15:53:59 -07:00
Smart-Codi
80974033c0
fix database import with cancel_query.. extra field ( #20187 )
2022-06-03 12:51:06 -06:00
Elizabeth Thompson
32bb1ce3ff
feat!: pass datasource_type and datasource_id to form_data ( #19981 )
...
* pass datasource_type and datasource_id to form_data
* add datasource_type to delete command
* add datasource_type to delete command
* fix old keys implementation
* add more tests
2022-06-02 16:48:16 -07:00
Phillip Kelley-Dotson
5111011de9
fix: dbmodal test connection error timeout ( #20068 )
...
* fix: check for connect on ping
* clean up merge
* fix merge
* precommit
2022-05-17 10:04:52 -07:00
John Bodley
449d08b25e
fix: Refactor SQL username logic ( #19914 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2022-05-12 21:03:05 -07:00
Daniel Vaz Gaspar
87a4379d0a
feat: deprecate /superset/validate_sql_json migrate to api v1 ( #19935 )
...
* feat: deprecate /superset/validate_sql_json migrate to api v1
* use new error handling
* migrate SQLLAb frontend and add tests
* debug test
* debug test
* fix frontend test on sqllab
* fix tests
* fix frontend test on sqllab
* fix tests
* fix tests
* fix tests
* fix tests
2022-05-10 21:25:39 +01:00
Daniel Vaz Gaspar
4fdf230a56
feat: deprecate /superset/extra_table_metadata migrate to api v1 ( #19921 )
...
* feat: deprecate /superset/extra_table_metadata migrate to api v1
* use can_read to table_extra_metadata
* troubleshoot sqlite
* fix test
* fix test
* fix test
* fix frontend test on sqllab
2022-05-04 14:55:52 +01:00
Daniel Vaz Gaspar
5dd3ea154b
fix: OpenAPI docs small fixes ( #19936 )
2022-05-04 09:59:16 +01:00
AAfghahi
57157c8b15
fix: remove expose ( #19700 )
...
* bumping shillelagh
* remove expose
2022-04-16 22:02:23 -07:00
Ville Brofeldt
3a231f6b87
fix(database-api): allow search for all columns ( #19662 )
2022-04-12 13:50:57 +03:00
AAfghahi
4bf4d58423
fix: update Permissions for right nav ( #19051 )
...
* draft pr
* finished styling
* add filter
* added testing
* added tests
* added permissions tests
* Empty-Commit
* new test
* Update superset-frontend/src/views/components/MenuRight.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
* revisions
* added to CRUD view
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com >
2022-04-11 16:50:59 -04:00
Elizabeth Thompson
aa419b8119
fix: check type of url before performing string actions ( #19569 )
...
* ensure url is a string
* return url if param is a url
2022-04-06 17:32:10 -07:00
Beto Dealmeida
1b4d8ddf71
chore: blacklist unsafe functions ( #19537 )
2022-04-05 14:55:30 -07:00
Craig Rueda
f64d654de3
chore(database): Creating helper make_url_safe to wrap potential errors ( #19526 )
...
* Creating helper make_url_safe to wrap potential errors
* Fixing imports
* Fixing imports again
* Adding comment
* Linting
* Fixing test
* Fixing test again...
* Fixing import
2022-04-05 11:17:30 -07:00
David Aaron Suddjian
8e29ec5a66
feat: Embedded dashboard configuration ( #19364 )
...
* embedded dashboard model
* embedded dashboard endpoints
* DRY up using the with_dashboard decorator elsewhere
* wip
* check feature flags and permissions
* wip
* sdk
* urls
* dao option for id column
* got it working
* Update superset/embedded/view.py
* use the curator check
* put back old endpoint, for now
* allow access by either embedded.uuid or dashboard.id
* keep the old endpoint around, for the time being
* openapi
* lint
* lint
* lint
* test stuff
* lint, test
* typo
* Update superset-frontend/src/embedded/index.tsx
* Update superset-frontend/src/embedded/index.tsx
* fix tests
* bump sdk
2022-03-30 12:34:05 -07:00
Ville Brofeldt
a619cb4ea9
chore: upgrade black ( #19410 )
2022-03-29 20:03:09 +03:00
Beto Dealmeida
d304849b46
feat: disable edits on external assets ( #19344 )
...
* feat: disable edits on external assets
* Update tests
2022-03-28 16:32:57 -07:00
Beto Dealmeida
c7f9060a2f
feat: import external management columns ( #19315 )
...
* feat: import flags
* Add tests
2022-03-24 10:41:22 -07:00
Richard Whaling
202e34a259
feat: add duckdb as DataSource - Fixes #14563 ( #19317 )
...
* + duckdb support
needs the forked version of [duckdb-engine](https://github.com/alitrack/duckdb_engine )
* Update duckdb.py
update _time_grain_expressions
* removed superfluous get_all_datasource_names def in duckdb engine spec
* added exception handling for duckdb single-threaded RuntimeError
* fixed linter blips and other stylistic cleanup in duckdb.py
* one last round of linter tweaks in test_connection.py for duckdb support
Co-authored-by: Steven Lee <admin@alitrack.com >
Co-authored-by: Richard Whaling <richardwhaling@Richards-MacBook-Pro.local >
2022-03-24 15:07:57 +08:00
Beto Dealmeida
9766726b26
feat: external management flags in CRUD ( #19318 )
2022-03-23 15:38:33 -07:00
Craig Rueda
4b34817b19
feat(ui): Adding manifest prefix config ( #19141 )
...
* Adding manifest prefix config
* Fixing broken tests
* Fixing import
* Adding prefix for remaining assets
* Changing static prefix strategy
* Fixing DST test
* Fixing up formatting
* Fixing up async_query_manager.py types
2022-03-17 08:58:48 -07:00
cccs-Dustin
02ef9ca4cd
feat(sqllab): Add a configuration option to disable data preview ( #19104 )
2022-03-17 15:22:57 +02:00
Beto Dealmeida
d01fdad1d8
feat: add export_related flag ( #19215 )
...
* feat: add export_related flag
* Fix lint
2022-03-16 16:03:06 -07:00
Smart-Codi
e97cdba092
fix database import error ( #19037 )
2022-03-09 21:23:13 -07:00
Elizabeth Thompson
c143b37128
chore: log multiple errors ( #14064 )
...
* log all errors from db create
* return unique set of errors
* sort set for exceptions list
* run black
2022-03-08 17:31:19 -08:00
Victor Arbues
5ee070c402
feat: datasource access to allow more granular access to tables on SQL Lab ( #18064 )
2022-02-09 22:05:25 +08:00
Ville Brofeldt
299635c580
docs: add password example to dataset import API ( #18580 )
2022-02-07 09:38:55 +02:00
Adam Dobrawy
dad6f78419
refactor: extract json_required view decorator ( #18170 )
...
* refactor: extract json_required view decorator
* chore: rename json_required to requires_json
* refactor: add requires_form_data decorator and use it
* fix: fix lint issue, raise InvalidPayloadFormatError for invalid payload
2022-01-31 08:53:48 -03:00
Beto Dealmeida
51090c3f1b
feat: shorter timeout on test_connection ( #18001 )
...
* feat: shorter timeout on test_connection
* pip-compile-multi --no-upgrade
* Fix for SQLite
* Return 408
* Add test
2022-01-12 13:01:34 -08:00
Beto Dealmeida
73ae892066
feat: don't ask for password when DB exists ( #17776 )
2021-12-16 09:17:15 -08:00
Ville Brofeldt
5d1c9078ad
chore(translations): fix translation literals ( #17501 )
...
* chore(translations): fix translation literals
* fix table name types and translations
* fix lint
* join concat'd messages
2021-11-23 10:06:09 +02:00
Hugh A. Miles II
e5fe18660c
fix: Show sqllab state when deleting databases ( #17331 )
...
* saving
* fix ts
* update test
* update test
* log unit
* updated test
2021-11-04 20:17:08 -04:00
Beto Dealmeida
cb34a22684
fix: import should accept old keys ( #17330 )
...
* fix: import should accept old keys
* Fix lint
* Preserve V1 schema
2021-11-03 11:25:30 -07:00
Shiva Raisinghani
ef3afbde82
refactor: Repeated boilerplate code between upload to database forms ( #16756 )
...
* abstract boilerplate code into class and rename csv to file
* add db migration
* fix some stuff
* more renaming of csv to file
* rename in translations
* update down revision
* update down revision
* bump chart version
* switch to alter column name approach in db migration
* fix db migration for MySQL
* db migration conflict
2021-10-25 13:53:06 +03:00
AAfghahi
904c506591
fixing db connection ( #16899 )
2021-09-29 10:02:34 -07:00
AAfghahi
aa747219ad
feat: Add Private Google Sheets to dynamic form ( #16628 )
...
* first pass private gsheets
* made encrypted extra into string, refactored onParametersChanged
* private sheets working, credential_info errors
* all but test connection working
* first pass private gsheets
* made encrypted extra into string, refactored onParametersChanged
* private sheets working, credential_info errors
* all but test connection working
* Regenerate package-lock.json
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
2021-09-28 17:08:50 -07:00
AAfghahi
376c685838
feat: adding logging to validation ( #16527 )
...
* adding logging to validation
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
2021-09-13 16:09:40 -07:00
John Bodley
1669947bcd
chore(pylint): Reenable too-many-lines check ( #16287 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-09-13 13:22:19 -07:00
Ville Brofeldt
ac1d779a30
chore(ci): bump pylint to 2.10.2 ( #16463 )
2021-08-26 20:30:41 +03:00
John Bodley
7e4c940314
chore(pylint): Enable useless-suppression check ( #16388 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-08-24 03:58:41 +12:00
John Bodley
be7065faf8
chore(pylint): Reenable raise-missing-from check ( #16266 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-08-17 10:26:10 +12:00
John Bodley
36bc7b0b80
chore(pylint): Reenable too-few-public-methods check ( #16264 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-08-17 05:20:44 +12:00
Beto Dealmeida
7b15b7690d
fix: DB exported with incorrect type ( #16037 )
...
* fix: DB exported with incorrect type
* Fix export as well
2021-08-03 08:35:48 -07:00
Hugh A. Miles II
bfe7eb9a7b
feat(dbc ui): Adding Google Sheets Dynamic Form ( #15801 )
...
* feat: Make Google Sheets Dyanmic (#15576 )
* first draft
* second draft
* added tests
* first draft
* added table_catalog
* remove console.log
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* revisions
* save this for now
* working form
* save disable on public sheets
* refactor somethings
* saving this for now
* working edit
* add back query to schema
* working add
* fix styling
* fixing x
* fix linting
* prettier
* fix some type issues
* more lint fixes
* remove unused dependency
* fix linint
* fix validation
* pylint bypass
* pylint bypass
* fix this
* fix mypy
* yerp
* fix test
* fix test
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* wrap add sheets
* fix linting issues
* fix unit test
* ignore typing
* fix editting and paste issues
* remove query
* fix this
* fix test
* add test back
* fix error messaging
* update url messaging on error
* change error type
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* add errors for sheets with no name
* fix
* fix messaging for gsheets
* stop pylint
* update line
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com >
Co-authored-by: Arash <arash.afghahi@gmail.com >
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
2021-07-28 15:00:27 -04:00
John Bodley
ab4e3b9bf9
chore: Enforce Mypy for non-tests ( #15757 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-07-22 06:46:43 +12:00
Peter Kosztolanyi
02032ee8a4
feat: cancel db query on stop ( #15403 )
...
* feat: cancel db query on stop
* fix pylint
* Add unit tests
* Do not bind multiple times
* Stop only running queries
* Postgres to cancel only the required query
* Remove extra log
* Add docstring
* Better types, docstring and naming
* Use python3 format strings
* Update superset/sql_lab.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Add cancel_query_on_windows_unload option to database
* Return cancel_query as bool
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
2021-07-13 12:09:22 -04:00
Hugh A. Miles II
f67e40236d
update db for expose in sqllab param ( #15609 )
2021-07-09 10:08:17 -07:00
Beto Dealmeida
301b94f49a
fix: available endpoint showing specs without drivers ( #15587 )
2021-07-08 09:20:52 -07:00
