Commit Graph

232 Commits

Author SHA1 Message Date
serenajiang
c37c56c2e4 Revert "fix: Select a query from History and Run (#15891)" (#15992)
This reverts commit 8c7e09e500.
2021-07-30 15:24:07 -07:00
Grace Guo
8c7e09e500 fix: Select a query from History and Run (#15891)
* fix: Run query picked from History

* remove sql from component local state
2021-07-27 13:24:48 -07:00
Beto Dealmeida
d908dd6689 chore: better copy for SQL dialog (#15714) 2021-07-15 12:20:47 -07:00
Beto Dealmeida
b489cffb57 fix: no lazy translation on SupersetError (#15669)
* fix: no lazy translation on SupersetError

* Small fixes
2021-07-14 16:54:11 -07:00
Phillip Kelley-Dotson
1483e04381 refactor: icon to icons for Querytable, datasource test, and copyclipboard story (#15665)
* initial commit

* fix theme

* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-07-13 14:24:59 -07:00
Peter Kosztolanyi
02032ee8a4 feat: cancel db query on stop (#15403)
* feat: cancel db query on stop

* fix pylint

* Add unit tests

* Do not bind multiple times

* Stop only running queries

* Postgres to cancel only the required query

* Remove extra log

* Add docstring

* Better types, docstring and naming

* Use python3 format strings

* Update superset/sql_lab.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Add cancel_query_on_windows_unload option to database

* Return cancel_query as bool

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-07-13 12:09:22 -04:00
Phillip Kelley-Dotson
d8a15e60b9 refactor: icon to icons for sqllab (#15593)
* initial commit

* rid of theme

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-07-12 10:24:16 -07:00
Beto Dealmeida
cbc4aa8dc1 feat: extra table metadata for Google Sheets (#14775)
* feat: GSheets extra table metadata

* Bump version
2021-07-01 19:27:26 -07:00
Grace Guo
5b2eb8d933 Revert "fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)" (#15301)
This reverts commit 408d58f937.
2021-06-22 11:08:29 -07:00
Grace Guo
408d58f937 fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)
* fix: SQL Lab show "Refetch Results" button while fetching new query results

* fix comments
2021-06-16 16:57:31 -07:00
Phillip Kelley-Dotson
ca89292faa refactor: refactor Icon to Icons in sqlEditor component (#14463)
* add triangle-down

* lint fix

* add suggestions
2021-06-16 14:14:36 -06:00
Beto Dealmeida
d625f5f111 feat: show rich error messages on past failed queries (#15158)
* feat: store SIP-40 error payload with queries

* Set errors in query on load
2021-06-16 12:58:14 -07:00
Corbin Robb
b179863e25 refactor: Convert TableElement to TypeScript (#14978)
* Convert TableElement to typescript

* Change type names to better match naming conventions in other files

* Fix import order and update tests on TableElement

* Remove defaultProps

* Destructure the props

* Use Rest and Spread syntax to condense props destructuring

* Fix TypeScript errors and add comment to explain antd props and types weirdness

* Remove comment, add consistency with other files, and use method chaining to make more concise

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-06-15 13:29:45 -07:00
AAfghahi
2d3f552b51 adding fetching to query status (#15064) 2021-06-09 16:11:49 -07:00
AAfghahi
7f4e036433 fix: adding additional configs and colors for queryHistory (#14995)
* added additional configs and colors for queryHistory

* added condition to status icon

* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx

* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx
2021-06-07 14:10:28 -04:00
Corbin Robb
004a6d9e54 refactor: Convert TableElement.jsx component from class to functional with hooks (#14830)
* Change TableElement from a class component to a functional component

* Replace class state checks in TableElement_spec.jsx with checks testing elements they change

* Refactor small bit of logic to use optional chaining

* Add optional chaining to some logic

* Fix IconTooltip and add IconTooltip to the collapse button

* Fix custom icon using IconToolTip so it better matches the original

* Update collapse/expand icon to use Icons component instead of importing from antdesign directly

* Fix eslint errors

* Clean up some code for readability

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-06-03 16:04:56 -07:00
cccs-jc
f652908a70 fix: renamed sqllab filters to _filters (#14971) 2021-06-03 21:22:50 +03:00
AAfghahi
53505c2acb additional safeguard (#14953) 2021-06-02 12:02:22 -07:00
AAfghahi
eced510708 fix: Query History cosmetic issues (#14885)
* easiest fix

* Query History Cosmetic Issues

* added revisions

* beto revisions
2021-06-01 14:53:12 -04:00
cccs-jc
eef489c667 feat: add support for filters in sqlLab (#14765) 2021-06-01 21:23:51 +03:00
Einat Bertenthal
add35f9fe4 fix: set table name width to not hide icons when name is too long (#14489)
* fix: set table name width to now hide icons when name is too long

* fix: table style

Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
2021-05-25 16:44:28 +03:00
AAfghahi
252c64b397 fix: Additional ResultSet tests (#14741)
* fixing tests

* added testing

* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* removed decribe

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-05-24 17:42:09 -04:00
Beto Dealmeida
65f90096fd fix: use encodeURIComponent when getting table metadata (#14790) 2021-05-24 12:20:31 -07:00
David Aaron Suddjian
0e86a6b81c fix(sqllab): don't store user in localstorage (#14722)
* fix(sqllab): remove user info from localstorage

* filter out user data when loading localstorage
2021-05-20 16:35:56 -07:00
Elizabeth Thompson
a9d888ad40 check limiting factor on query results (#14719) 2021-05-19 14:38:57 -07:00
AAfghahi
a7a011cce5 feat: Better return messages in SQL Editor (#14381)
* Sqllab limit

* Add migration script

* Set default values

* initial push

* revisions

* moving migration to separate PR

* revisions

* Fix apply_limit_to_sql

* all but tests

* added unit tests

* result set

* first draft

* revisions

* made user required prop, added it to all places ResultSet is imported

* changed QueryTable test to allow for useSelector

* Query Table working

* working with heights

* fixed scrolling

* got rid of animated

* fixed tests, revisions

* revisions

* revisions

* heights

* fun with heights

* alert state

* aaron helped me fix this

* better alert messages

* fixed result set test

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-05-18 11:02:06 -07:00
Geido
b5e9854ddc Fix tooltip position (#14656) 2021-05-17 15:49:06 -07:00
Hugh A. Miles II
0d240c3841 fix: properly keep state on queryEditorSetSql on tabstateview PUT (#14579)
* send queryid up with setSQL

* pass latest query id

* update

* cleanup
2021-05-12 15:20:26 -04:00
Michael S. Molina
79ff96269b refactor: Bootstrap to AntD - Form - iteration 3 (#14502) 2021-05-08 12:34:52 -07:00
Michael S. Molina
331310db9b refactor: Bootstrap to AntD - Form - iteration 2 (#14379) 2021-05-05 22:00:37 -07:00
AAfghahi
12baba03cc fix: Query History (#14498)
* fix for QUery History

* fixed
2021-05-05 17:00:32 -04:00
Jesse Yang
23014e9233 chore: upgrade @emotion (#14454) 2021-05-04 15:26:16 -07:00
AAfghahi
e507508b48 feat: Logic added to limiting factor column in Query model (#13521)
* Sqllab limit

* Add migration script

* Set default values

* initial push

* revisions

* Update superset/views/core.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* moving migration to separate PR

* with migration

* revisions

* Fix apply_limit_to_sql

* all but tests

* added unit tests

* revisions

* Update superset/sql_lab.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/sql_parse.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* fixed black issue

* Update superset/views/core.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* updated logic

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-04-30 15:15:18 -07:00
Michael S. Molina
a52ff13b5d chore: Moves Card to the components folder (#14139) 2021-04-29 11:51:41 -07:00
eriendeng
2dc3fa3f21 fix error getting partitionQuery from table.partition (#14369)
Co-authored-by: eriendeng <eriendeng@tencent.com>
2021-04-29 10:42:11 +03:00
Michael S. Molina
d0be1ff79e chore: Moves Tabs to the components folder (#14136) 2021-04-27 00:15:21 -07:00
Michael S. Molina
4fbb572568 refactor: Bootstrap to AntD - Form - iteration 1 (#14106) 2021-04-26 15:03:53 -07:00
Michael S. Molina
b963624e12 refactor: Boostrap to AntD - Row/Col (#14100) 2021-04-22 20:57:17 -07:00
zuzana-vej
86233d1676 chore: SQLLab row limit warning using Alert component (#14298) 2021-04-22 10:12:46 -07:00
Michael S. Molina
42fb2286ad chore: Moves Dropdown to the components folder (#14126) 2021-04-20 08:48:28 -07:00
Michael S. Molina
d1b458c4c5 chore: Moves Radio to the components folder (#14133) 2021-04-20 08:48:10 -07:00
Michael S. Molina
8441590812 chore: Moves Tooltip to the components folder (#14137) 2021-04-20 08:47:47 -07:00
Michael S. Molina
77a9cc7088 chore: Moves Collapse to the components folder (#14124) 2021-04-16 15:55:04 -07:00
Michael S. Molina
b83ee46d0f chore: Moves Modal to the components folder (#14130) 2021-04-16 15:49:53 -07:00
Erik Ritter
01f13c5678 chore: type some SQL Lab components (#14178)
* chore: type some SQL Lab components

* Update superset-frontend/src/SqlLab/components/QueryHistory.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-16 09:16:16 -07:00
Michael S. Molina
e4c8084285 chore: Moves DropdownButton to the components folder (#14127) 2021-04-15 22:46:18 -07:00
AAfghahi
f1acb2f974 horizontal scroll (#14140) 2021-04-14 16:31:13 -07:00
Michael S. Molina
c8a794368d refactor: Bootstrap to AntD - ListGroup (#13996)
* refactor: Bootstrap to AntD - ListGroup

* Improves theme handling on touched files
2021-04-13 15:26:02 -07:00
Bruno Motta
95ed8735f1 chore: well component to card component(Updating PR #12200) (#14033)
* replace Well componenet with Card component

* Fix lint errors

* Fix lint

* Addressing comments

* Addressing comments

* Fix lint errors

* Exporting Card from index.tsx and adding storybook variants

* Fix some refactoring

* Fix errors

* solving conflicts and lint errors

* Update superset-frontend/src/common/components/Card.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/Card.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Nikola Gigic <nik.gigic@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 15:06:44 -07:00
Michael S. Molina
784d29b57c chore: Moves Fade component into TableElement (#13458) 2021-04-08 12:56:21 -07:00