Commit Graph

482 Commits

Author SHA1 Message Date
Ville Brofeldt
f1fa1a733d chore(key-value): use json serialization for main resources (#23888) 2023-05-04 08:04:05 +03:00
Michael S. Molina
10d640e940 feat: Considers GENERIC_CHART_AXES in viz migrations (#23905)
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2023-05-03 18:57:07 -03:00
Hugh A. Miles II
c441a7050d chore: add check constraint to restrict Slice models datasource_type != "table" (#23614) 2023-04-20 12:43:59 -07:00
Jack Fragassi
61ddfe6972 fix(migration): Only attempt to drop types if they exist (#23650) 2023-04-11 15:04:22 -04:00
RekhaZemoso
8f0328006b fix(#23176): adding URL decoding to SQLAlchemy URI (#23421)
Co-authored-by: Evan Rusackas <evan@preset.io>
2023-04-06 16:41:17 -06:00
ʈᵃᵢ
068163e2a1 fix(tags): convert postgres enum type to varchar (#23526) 2023-03-30 17:21:18 -07:00
Kamil Gabryjelski
b0d83e8c50 feat(echarts): Implement stream graph for Echarts Timeseries (#23410) 2023-03-20 12:56:15 +01:00
Hugh A. Miles II
b820eb8235 chore: Update pre-commit packages (#23173) 2023-03-13 17:05:13 -06:00
John Bodley
f7e7652270 fix(migration): Address issue in #23228 (#23276) 2023-03-07 20:04:31 +13:00
Ville Brofeldt
71a9d0d403 fix(plugin-chart-echarts): render horizontal categories from top (#23273) 2023-03-06 11:25:52 +02:00
John Bodley
5f0c320415 chore: Deprecate show_native_filters (#23228) 2023-03-02 07:29:51 +13:00
Daniel Vaz Gaspar
79274eb5bc fix: memoized decorator memory leak (#23139) 2023-02-27 15:59:11 +00:00
Josh Soref
dec6ac49f6 chore(backend): Spelling (#19677)
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2023-02-17 10:48:24 -07:00
Trey Gilliland
a2c3ef8130 fix(migrations): Flask-Migrate output is not logged during alembic migrations #17991 (#22991) 2023-02-06 15:29:06 -08:00
Josh Soref
78ede590ee chore(frontend): Spelling (#19676)
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2023-02-02 11:23:11 -07:00
Evan Rusackas
6998f65e1d chore: removing unnecessary double spaces, a.k.a. "shotgun holes" (#22852) 2023-01-26 11:48:41 -07:00
Hugh A. Miles II
ebaad10d6c feat(ssh-tunnelling): Setup SSH Tunneling Commands for Database Connections (#21912)
Co-authored-by: Antonio Rivero Martinez <38889534+Antonio-RiveroMartnez@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2023-01-03 17:22:42 -05:00
Kamil Gabryjelski
79e7980791 chore: Add a migration that removes filter_bar_orientation from dashboard's json_metadata (#22248) 2022-11-29 15:09:56 +01:00
micsbot
2e5270cdb0 fix(db-migration): new_dataset_models_take_2 error on postgres (#21417)
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
2022-11-21 14:51:57 +02:00
John Bodley
88a89c9fd6 fix(migration): Ensure the paginated update is deterministic (#21778) 2022-10-12 17:11:59 -07:00
Mayur
61319fd759 feat(sqllab): save query parameters in database (#21682) 2022-10-07 12:49:14 +05:30
QLands
5da20f449d fix(migration): Catch DatabaseError to avoid migration crash with MySQL 8.0 (#21679) 2022-10-04 10:07:51 +03:00
cccs-Dustin
2e564897f8 feat: Add dataset tagging to the back-end (#20892)
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-09-23 11:01:17 +03:00
John Bodley
eac6fdcd29 chore(sqllab): Cleanup /tables/... endpoint (#21284) 2022-09-13 08:22:12 -07:00
Kamil Gabryjelski
8005b7f8c7 fix(plugin-chart-table): Upgrade old color formats (#21101)
* fix(plugin-chart-table): Upgrade old color formats

* Bug fix

* add comments
2022-08-16 22:05:53 +02:00
Jesse Yang
2c8867e4e4 chore(db-migration): ensure query_context is MediumText before viz migration (#20936) 2022-08-08 13:30:46 -07:00
Elizabeth Thompson
fb5f8cacaf skip row if created_at_fk is null (#20939) 2022-08-02 15:49:32 -07:00
Jesse Yang
4d192e6e4d feat(report): capture dashboard reports in specific states (#20552) 2022-07-26 17:01:56 -07:00
John Bodley
e1094e2198 fix: Add migration to add created_by_fk as explicit owner for charts and datasets (#20617)
* fix: Add migration to add created_by_fk as owner

* Update 2022-07-05_15-48_409c7b420ab0_add_created_by_fk_as_owner.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-07-26 10:22:19 -07:00
Jesse Yang
a64cdec8c2 fix(db): set slices.query_context to MEDIUMTEXT for mysql (#20779) 2022-07-19 18:12:44 -07:00
Jesse Yang
e2d3ea831a fix(db): use paginated_update for area chart migration (#20761) 2022-07-19 07:20:46 -07:00
Beto Dealmeida
e60083b45b chore: upgrade SQLAlchemy to 1.4 (#19890)
* chore: upgrade SQLAlchemy

* Convert integration test to unit test

* Fix SQLite

* Update method names/docstrings

* Skip test

* Fix SQLite
2022-07-18 15:21:38 -07:00
Yongjie Zhao
4e6e87f62e feat: Area viz migration (#20359) 2022-07-08 19:56:03 +08:00
Daniel Vaz Gaspar
4bfa622d02 fix: migration revisions from #19532 (#20641) 2022-07-07 15:33:11 +01:00
Yongjie Zhao
7626c31372 feat: TreeMap migration (#20346) 2022-07-07 19:37:18 +08:00
Eugene Bikkinin
d16f274991 feat(database): Add user_id and dttm composite index to Log model. (#19532)
* feat: Added user_id and dttm composite index to Log model.

* fix: Refactored migration to a general view.

* fix: Changed down revision.

* fix: Formatted with black.

* fix: Removed odd Index import.
2022-07-06 22:24:44 -06:00
Jesse Yang
cadd259788 feat: save active tabs in dashboard permalink (#19983) 2022-06-29 09:43:52 -07:00
John Bodley
3483446c28 refactor: Cleanup user get_id/get_user_id (#20492)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-24 17:57:04 -07:00
Daniel Vaz Gaspar
b33c23ef25 fix: migration revision order (#20484) 2022-06-23 18:42:35 +01:00
John Bodley
f5cb23e0a3 fix(migration): Ensure key_value LargeBinary is encoded as a MEDIUMBLOB as opposed to BLOB for MySQL (#20385)
* fix(migration): Ensure key_value LargeBinary is encoded as a MEDIUMBLOB as opposed to BLOB for MySQL

* Update 2022-06-14_15-28_e09b4ae78457_resize_key_value_blob.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-23 08:38:33 -03:00
Daniel Vaz Gaspar
ba4ba0267e fix: RLS new db migration downgrade fails on SQLite (#20449) 2022-06-21 13:07:23 +01:00
Daniel Vaz Gaspar
60eb1094a4 feat: add name, description and non null tables to RLS (#20432)
* feat: add name, description and non null tables to RLS

* add validation

* add and fix tests

* fix sqlite migration

* improve default value for name
2022-06-20 13:52:05 +01:00
Craig Rueda
d1c24f81f2 chore(migrations): Renaming migration files so that they're easier to keep track of (#20284)
* Renaming migration files so that they're easier to keep track of

* Fixing broken import

* Fixing broken import again

* Fixing broken tests
2022-06-07 10:30:09 -07:00
Daniel Vaz Gaspar
b9a98aae79 fix: None dataset and schema permissions (#20108)
* fix: None dataset and schema permissions

* fix pylint

* add migration and test

* fix migration
2022-05-20 09:40:10 +01:00
cccs-RyanS
ddc01ea781 feat(business-types): initial implementation of SIP-78 (#18794)
* add BUSINESS_TYPE_ADDONS to config with example callback

* Removing uneeded whitespace

* [Work in progress] Modifying cidr function to allow for  single ip and adding port outline

* Added test REST endpoint, added some more ports

I've thrown in a test.py script as well that will try to connect to the
business_type endpoint.

* Moving code from config.py into the business api

Very simple api is exposed that will allow someone to call a checkport
endpoint and get back a response.

* Removing commented out bits.

* Adding fucntion dict back to the config

* Moving business_type endpoint to charts

* Adding schema for get endpoint

* Removing imports, updating docstring, fixing typo

Just some small changes as described in the title.  I've updated the
test.py as well so it functions with the endpoint changes.

* Adding translation dict

* Fixing ops

* Adding check for list

* Modifying changes to add quotes where needed

Also changed BusinessTypeResponse to resp.

* Adding in some code to call the filter config

If a column starts with "cidr_" it will call the code in config.py to
try to translate the filter.  Nothing is changed in the JSON being
executed, just some information is dumped to console.

* Porting Ryan's changes

* Adding migration script (as per Ryan's PR)

* Fixing typo

* Prettier fixes

* [CLDN-1043] Adding rough version of filter changes for business types

* fix down migration

* Fixing bugs after merge

* adding functionality to appy filters in back end

* Fixing linting issues

* fix down revision

* Changing conversion callback to handle multiple values at once

* Adding string representation of values

* Code cleanup plus fixing debouce to only be called once for each entry

* Removing non needed logginh

* Changing operator list to use sting values

* Using text value operators

* Removing clear operator call

* Moving business type endpoints

* fix down revision

* Adding port functions

* update migration

* fix bad rebase and add ff

* implement validator

* dont add invalid values to response

* [CLDN-1205] Added a new exception type for a business type translation error. Added the error message in the display_value field within the business type response. Modified the IP and Port business types to populate the error message field in the response if an error occurs

* [CLDN-1205] Added meaningful error message for port translation errors

* Removing status field from businesstype Response and adding in error message

* [CLDN-1205] Added check to make sure the port business type is within the valid range of ports, if it is not, it will populate the error message

* [CLDN-1205] Fixed the if statement that checks to see if the string_value is in the valid range of port numbers. It did not corrently verify this before now.

* [CLDN-1205] Fixed an error where it was trying to use string_value in <= statements. I just casted string_value to an integer if it is numeric, which allows <= operators to be used on it

* [CLDN-1207] Added unit tests for the cidr_func and port_translation_func functions which are located in /superset/config.py

* [CLDN-1207] removed the assertRaises line as it does not work with the cidr_func and port_translation_func functions

* [CLDN-1207] Added the skeleton of the test_cidr_translate_filter_func unit test, still need to update what the expected response from the function will be.

* [CLDN-1207] Added the remainder of the back-end unit tests for the business types

* [CLDN-1207] Fixed the syntax error which caused the test_cidr_translate_filter_func_NOT_IN_double unit test to fail

* [CLDN-1207] Removed the logging that was added for debugging purposes

* [CLDN-1207] Formatted the commands_tests.py file to make it nicer to look at/read through

* [CLDN-1207] Fixed the code so that it conformed to the pylint requirements (i.e., pylint no longer complains about the code in commands_tests.py)

* [CLDN-1207] Modified some of the docstrings so they made better use of the 100 character per line, line limit

* [CLDN-1207] Added the beginnings of the unit tests for the
business types API

* [CLDN-1207] Added a comment to the top of the commands_tests.py file explaining how to run the unit tests. This prevents the next person who tries to run them from having to waste time trying the different forms of testing that Superset supports (e.g., pytest, tox, etc.)

* [CLDN-1207] Added a grammar fix to the comments describing how to run the unit tests

* [CLDN-1207] Modified the description of the business_type API endpoints as they did not represent what the API was actually doing

* [CLDN-1207] Added further instructions on how to run the unit tests that are within the business_type/api_tests.py file

* add request validation

* disable request if business type missing

* [CLDN-1207] Unit tests for the business type API are now working, however, they need to be modified to make use of @mock as we don't want to have to run the server to be able to run the unit tests

* Removing businesss types deffinitons from config

* Adding select to only show valid business types

* Fixed Enzyme tests

* Added scalfolding for selecting filter dropdown

* Adding intigration tests

* fix revision

* fix typos and unnecessary requests

* break out useBusinessTypes

* Added front-end RTL unit tests for the business type API endpoint

* Fixed error from unit tests

* Added a unit test to ensure the operator list is updated after a business type API response is received

* Removing elect compoenet for business types

* Adding feature flag and allowing saving when no business type present

* fixing useEffect hooks

* Adding feature flag to model

* Changing behavior such that an empty string returns a default response

* add form validation

* Modified comments in unit test as command to run test has changed

* Modified comments in unit test as filename to run test has changed

* Modified the api_tests.py file to conform to the linting requirements

* Changed the name of one of the tests to reflect what the test is actually testing

* Added cypress back to the package.json

* Added informative comments

* Updated comments in files as well as removed imports which were not being used

* Changes made by npm run prettier

* Fixed spelling mistakes

* Updated models.py to remove placeholder comments used in development

* Added feature flag mocking in unit test

* Fixing open api failure

* Fixing business types to pass unit tests

* Reverting unsafe connections back to false

* Removing print statement

* Adding business tpye to export test

* setting default feature flag to false for business type

* Reverting pre commit

* Reverting pre commit and running pre commit

* Reverting pre commit and running pre commit

* Fixing formatting

* Adding license

* Fixing Linting

* Protecting api enpoints

* updating model

* Fixing code path when business type exists

* Linting

* Linting

* Fixing linting

* Fixing spelling

* Fixing schemas

* Fixing app import

* fixing item render

* Added RTL test to make sure business type operator list is updated after API response

* Fixing linting

* fix migration

* Changing unit tests

* Fixing import and DB migration after rebase

* Renaming to advanced types

* Fixing Linting

* More renaming

* Removing uneeded change

* Fixing linting and test errors

* Removing unused imports

* linting

* Adding more detailed name for migration

* Moving files to plugins

* more renaming

* Fixing schema name

* Disabling feature flag that should not be enabled by default

* Adding extra cehck

* NameChange

* formatting

* Fixing equals check

* Moveing all advanced type classes and types to one file, and converting tests to functional

* Adding advanced type to test and fix linitng

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Dan Parent <daniel.parent@cse-cst.gc.ca>
Co-authored-by: GITHUB_USERNAME <EMAIL>
Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com>
2022-05-16 17:58:21 +03:00
Ville Brofeldt
4435e53901 fix(dataset): handle missing sqla uri in migration (#20073) 2022-05-16 10:17:28 +03:00
John Bodley
89a844a40f fix(reports): Clear last value when state is WORKING (#19941)
* fix(reports): Clear last value when state is WORKING

* Update cbe71abde154_fix_report_schedule_and_log.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-05-12 21:54:23 -07:00
Josh Soref
c32c505742 chore(docs): Spelling (#19675)
* spelling: adding

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: aggregate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: avoid

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: blacklist

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: cached

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: discontinue

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: exhaustive

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: from

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: github

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: hybrid

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: implicit

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: interim

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: introduced

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: javascript

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: logstash

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: metadata

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: password

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: recommended

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: redshift

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: refactored

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: referencing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: sqlite

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: the

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: thumbnails

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: undoes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: very

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2022-04-26 13:17:15 -03:00
Ville Brofeldt
a1bd5b283c fix(key_value): use longblob on mysql (#19805)
* fix(key_value): use longblob on mysql

* set length
2022-04-22 13:12:29 +03:00
Jesse Yang
fa680369ea fix(SIP-68): handle empty table name during migration (#19793) 2022-04-21 10:49:25 -07:00