Commit Graph

51 Commits

Author SHA1 Message Date
Beto Dealmeida
cf315388f2 feat(sqllab): use sqlglot instead of sqlparse (#33542) 2025-05-30 17:08:19 -04:00
Evan Rusackas
90651dfe3e fix(dev/ci): pre-commit fixes galore (#32352) 2025-02-24 11:26:45 -07:00
Maxime Beauchemin
e51b95ffa8 chore: enforce more ruff rules (#31447)
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2024-12-18 17:41:34 -08:00
JUST.in DO IT
48864ce8c7 fix(sqllab): Remove update_saved_query_exec_info to reduce lag (#31294) 2024-12-06 10:09:02 -08:00
Maxime Beauchemin
a849c29288 chore: enable lint PT009 'use regular assert over self.assert.*' (#30521) 2024-10-07 13:17:27 -07:00
Beto Dealmeida
cc9fd88c0d chore: improve DML check (#30417) 2024-09-27 15:26:36 -04:00
John Bodley
8fb8199a55 chore(dao/command): Add transaction decorator to try to enforce "unit of work" (#24969) 2024-06-28 12:33:56 -07:00
John Bodley
d69363ef11 fix(tests): Ensure fixture is invoked (#29352) 2024-06-25 10:17:58 -07:00
John Bodley
b50e3af07c fix(sqllab): Do not strip comments when executing SQL statements (#29248) 2024-06-14 13:38:36 -03:00
Eyal Ezer
07b2449bd7 refactor: Unify all json.(loads|dumps) usage to utils.json (#28702)
Co-authored-by: Eyal Ezer <eyal.ezer@ge.com>
2024-05-28 14:17:41 -07:00
Eyal Ezer
56f0fc4ec2 refactor: Migration of json utilities from core (#28522)
Co-authored-by: Eyal Ezer <eyal.ezer@ge.com>
2024-05-20 10:27:22 -07:00
Michael S. Molina
c9aa4a1f84 fix: Revert "fix: don't strip SQL comments in Explore (#28363)" (#28567) 2024-05-17 15:01:23 -03:00
Maxime Beauchemin
c618767c6b fix: don't strip SQL comments in Explore (#28363) 2024-05-07 14:49:46 -07:00
Beto Dealmeida
e90246fd1f feat(SIP-95): permissions for catalogs (#28317) 2024-05-06 11:41:58 -04:00
Maxime Beauchemin
2d63722150 chore: set up ruff as a new linter/formatter (#28158) 2024-04-24 17:19:53 -07:00
Beto Dealmeida
99a1601aea refactor: rename get_sqla_engine_with_context (#28012) 2024-04-12 13:31:05 -04:00
John Bodley
481a63da55 chore(tests): Remove ineffectual login (#27149) 2024-04-09 09:52:02 -07:00
John Bodley
5ed48760fb chore(sqllab): Do not strip comments when executing SQL statements (#27725) 2024-04-03 19:24:39 -07:00
JUST.in DO IT
f4bdcb5743 perf(sqllab): reduce bootstrap data delay by queries (#27488) 2024-03-18 12:52:23 -07:00
John Bodley
847ed3f5b0 refactor: Ensure Flask framework leverages the Flask-SQLAlchemy session (Phase II) (#26909) 2024-02-14 06:20:15 +13:00
John Bodley
7af82ae87d refactor: Ensure Celery leverages the Flask-SQLAlchemy session (#26186) 2024-01-17 17:06:22 +13:00
JUST.in DO IT
b370c66308 fix(sqllab): template validation error within comments (#25626) 2023-10-13 11:07:54 -06:00
JUST.in DO IT
5ab1e7eae4 feat(sqllab): SPA migration (#25151) 2023-10-04 15:21:41 -04:00
Daniel Vaz Gaspar
c69634df27 chore: remove deprecated apis on superset, get_or_create_table, sqllab_viz (#24375) 2023-06-14 08:48:29 +01:00
Daniel Vaz Gaspar
c8e958fb7e chore: remove deprecated apis stop_query, queries, search_queries (#24360) 2023-06-13 15:56:06 +01:00
John Bodley
a4d5d7c6b9 chore(pre-commit): Add pyupgrade and pycln hooks (#24197) 2023-06-01 12:01:10 -07:00
Geido
66fb4867dc chore: Remove unnecessary information from response (#24056) 2023-05-17 20:07:47 +03:00
Hugh A. Miles II
d581d698b6 chore: Refactor ExploreMixin to power both Datasets (SqlaTable) and Query models (#22853) 2023-04-10 16:32:52 -04:00
Daniel Vaz Gaspar
8f8fba2056 fix: gamma sql_json test (#23135) 2023-02-21 15:34:25 +00:00
Geido
c7823e32ff fix: Validate jinja rendered query (#22851) 2023-02-21 11:01:12 +01:00
Josh Soref
02e5dcbbf2 chore(misc): Spelling (#19678)
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2023-01-25 16:35:08 -07:00
Ville Brofeldt
5b2ca97341 fix(sqllab): remove link to sqllab if missing perms (#22566) 2023-01-09 14:02:36 +02:00
Hugh A. Miles II
9c0d6c51f1 chore(ssh-tunnel): Refactor establishing raw connection with contextmanger (#22366) 2022-12-29 14:20:45 -05:00
Hugh A. Miles II
e23efefc46 feat: refactor all get_sqla_engine to use contextmanager in codebase (#21943) 2022-11-15 13:45:14 -05:00
Hugh A. Miles II
7600da8041 feat: create function for get_sqla_engine with context (#21790) 2022-10-25 14:12:48 -04:00
Jesse Yang
77db0651d8 feat(sql lab): display presto and trino tracking url (#20799) 2022-07-26 20:20:08 -07:00
Jesse Yang
2cb4fd31f1 refactor(test): add login_as_admin in global conftest (#20703) 2022-07-14 18:10:31 -07:00
John Bodley
449d08b25e fix: Refactor SQL username logic (#19914)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-05-12 21:03:05 -07:00
Yongjie Zhao
d954c3df86 fix: can't sync temporal flag on virtual table (#19366) 2022-04-01 16:40:50 +08:00
Ville Brofeldt
a619cb4ea9 chore: upgrade black (#19410) 2022-03-29 20:03:09 +03:00
Daniel Vaz Gaspar
f37fc1a7f0 chore: bump majors on celery and Flask (#19168)
* chore: bump celery, Flask, flask-jwt-extended, pyJWT

* fix pyJWT breaking change

* fix pyJWT breaking change 2

* test

* fixed test

* fixed test

* fixed test

* revert since mypy won't pick the correct signature

* lint 1

* fix test

* fix test

* docs and celery config migration

* bump FAB to 4.0.0rc3, remove AUTH_STRICT_RESPONSE_CODES

* update docs for new celery config keys

* downgrade celery to 5.2.2

* ref FAB to final 4.0.0 release

* remove conflict left over
2022-03-24 09:16:53 +00:00
ofekisr
e53a50a155 chore(supeset.utils.core): move all database utils to database utils module (#18058) 2022-01-16 08:32:50 +02:00
Amit Miran
4954d52329 ci: make presto hive tests to cover only chartData and sqljson (#17782)
* chore: make presto hive tests to cover only chartData and sqljson

* fix: single quote

* fix: add eval for arguments

* fix: add double quotes on args

* chore: add @pytest.mark.sql_json_flow

* fix: pre-commit
2021-12-31 07:17:54 +02:00
Bogdan
afd2e9f2ca chore: update fixtures scope that are loading data into the analytical db (#17780)
* Update db setup fixture scope

* Load data into db only once

* Update fixture scopes for data loading

* cleanup imports

* try import

* Update scope

* fix cleanup

* Import all fixtures

* Separate data log and metadata creation

* Retain table description

* fix dtype

Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
2021-12-16 16:11:47 -08:00
Amit Miran
029ed90afb fix: preventing sql lab None limit value (#17155)
* fix: preventing sql lab None limit value

* test: create a test for the fix

* pylint (#17172)

* add test (#17173)

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
2021-10-20 23:43:14 +03:00
ofekisr
0d0c759cfe refactor: sql lab command: separate concerns into different modules (#16917)
* chore move sql_execution_context to sqllab package

* add new helper methods into base Dao

* refactor separate get existing query concern from command

* refactor separate query access validation concern

* refactor separate get query's database concern from command

* refactor separate get query rendering concern from command

* refactor sqllab_execution_context

* refactor separate creating payload for view

* chore decouple command from superset app

* fix pylint issues

* fix failed tests

* fix pylint issues

* fix failed test

* fix failed black

* fix failed black

* fix failed test
2021-10-03 11:15:46 +03:00
ofekisr
c520eb79b0 refactor: sqllab: move sqllab ralated enumns and utils to more logical place (#16843)
* refactor move QueryStatus to common

* refactor move apply_display_max_row_limit to sqllab package

* refactor move limiting_factor to sqllab package

* fix pylint issues
2021-09-26 21:15:57 +03:00
ofekisr
e60b489867 refactor sql_json view endpoint: separate concern into ad hod method (#16595) 2021-09-05 23:18:17 +03:00
ofekisr
be77ad2288 refactor: sql_json view endpoint: encapsulate ctas parameters (#16548)
* refactor sql_json view endpoint: encapsulate ctas parameters

* fix failed tests

* fix failed tests and ci issues
2021-09-05 16:34:26 +03:00
John Bodley
6d3e19d857 fix(15403): Re-enable canceling query for Hive and Presto (#15878)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-26 08:04:56 -07:00